mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Rientjes <rientjes@google.com>
To: Nicholas Krause <xerofoify@gmail.com>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
	x86@kernel.org, gleb@kernel.org, pbonzini@redhat.com,
	linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH] x86: Remove Fix me in main.c and add include statement for kvm_para.h
Date: Tue, 22 Jul 2014 15:06:56 -0700 (PDT)	[thread overview]
Message-ID: <alpine.DEB.2.02.1407221506240.5814@chino.kir.corp.google.com> (raw)
In-Reply-To: <1406065658-3866-1-git-send-email-xerofoify@gmail.com>

On Tue, 22 Jul 2014, Nicholas Krause wrote:

> This patch removes a fix me by including linux/types.h in kvm_para.h
> as stated by the  fix me in main.c and also removes the comment from
> main.c too.
> 
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
>  arch/x86/kernel/cpu/mtrr/main.c | 2 +-
>  include/linux/kvm_para.h        | 3 +--
>  2 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/x86/kernel/cpu/mtrr/main.c b/arch/x86/kernel/cpu/mtrr/main.c
> index f961de9..7ba314b 100644
> --- a/arch/x86/kernel/cpu/mtrr/main.c
> +++ b/arch/x86/kernel/cpu/mtrr/main.c
> @@ -33,7 +33,7 @@
>  
>  #define DEBUG
>  
> -#include <linux/types.h> /* FIXME: kvm_para.h needs this */
> +#include <linux/types.h>
>  
>  #include <linux/stop_machine.h>
>  #include <linux/kvm_para.h>
> diff --git a/include/linux/kvm_para.h b/include/linux/kvm_para.h
> index 00a97bb..21d1be2 100644
> --- a/include/linux/kvm_para.h
> +++ b/include/linux/kvm_para.h
> @@ -2,8 +2,7 @@
>  #define __LINUX_KVM_PARA_H
>  
>  #include <uapi/linux/kvm_para.h>
> -
> -
> +#include <linux/types.h>
>  static inline int kvm_para_has_feature(unsigned int feature)
>  {
>  	if (kvm_arch_para_features() & (1UL << feature))

There's no build error reported that would indicate that this is needed, 
so this patch isn't justifiable.

  reply	other threads:[~2014-07-22 22:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-22 21:47 Nicholas Krause
2014-07-22 22:06 ` David Rientjes [this message]
2014-07-22 22:08   ` Nick Krause
2014-07-22 22:13     ` David Rientjes
2014-07-22 22:18       ` Nick Krause

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.02.1407221506240.5814@chino.kir.corp.google.com \
    --to=rientjes@google.com \
    --cc=gleb@kernel.org \
    --cc=hpa@zytor.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=xerofoify@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®