From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759464AbaHHWDq (ORCPT ); Fri, 8 Aug 2014 18:03:46 -0400 Received: from mail-pd0-f169.google.com ([209.85.192.169]:57897 "EHLO mail-pd0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758419AbaHHWDm (ORCPT ); Fri, 8 Aug 2014 18:03:42 -0400 Date: Fri, 8 Aug 2014 15:03:40 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Jeremiah Mahler cc: Dave Hansen , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Rik van Riel , Mel Gorman , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH linux-next] arch/x86/mm: sparse 'tlb_single_page_flush_ceiling' warning In-Reply-To: <1407482671-23856-1-git-send-email-jmmahler@gmail.com> Message-ID: References: <1407482671-23856-1-git-send-email-jmmahler@gmail.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 8 Aug 2014, Jeremiah Mahler wrote: > A sparse warning is generated about 'tlb_single_page_flush_ceiling' > not being declared. > > arch/x86/mm/tlb.c:177:15: warning: symbol > 'tlb_single_page_flush_ceiling' was not declared. Should it be static? > > Since it isn't used anywhere outside this file, fix the warning by > making it static. > > Signed-off-by: Jeremiah Mahler Seems like __read_mostly would also be in order?