From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751575AbaHIVev (ORCPT ); Sat, 9 Aug 2014 17:34:51 -0400 Received: from mail-pa0-f47.google.com ([209.85.220.47]:53785 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751187AbaHIVes (ORCPT ); Sat, 9 Aug 2014 17:34:48 -0400 Date: Sat, 9 Aug 2014 14:34:46 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: "Aneesh Kumar K.V" cc: Andrew Morton , Tejun Heo , Li Zefan , Michal Hocko , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [patch v2] mm, hugetlb_cgroup: align hugetlb cgroup limit to hugepage size In-Reply-To: <87mwbem0zo.fsf@linux.vnet.ibm.com> Message-ID: References: <87mwbem0zo.fsf@linux.vnet.ibm.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 9 Aug 2014, Aneesh Kumar K.V wrote: > > diff --git a/mm/hugetlb_cgroup.c b/mm/hugetlb_cgroup.c > > --- a/mm/hugetlb_cgroup.c > > +++ b/mm/hugetlb_cgroup.c > > @@ -275,6 +275,7 @@ static ssize_t hugetlb_cgroup_write(struct kernfs_open_file *of, > > ret = res_counter_memparse_write_strategy(buf, &val); > > if (ret) > > break; > > + val = ALIGN(val, 1ULL << huge_page_shift(&hstates[idx])); > > Do we really need ULL ? max value should fit in unsigned long right ? > I usually just go for type agreement. > > ret = res_counter_set_limit(&h_cg->hugepage[idx], val); > > break; > > default: > >