From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934997AbaH0QUt (ORCPT ); Wed, 27 Aug 2014 12:20:49 -0400 Received: from mail-bn1blp0189.outbound.protection.outlook.com ([207.46.163.189]:27792 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751082AbaH0QUr (ORCPT ); Wed, 27 Aug 2014 12:20:47 -0400 Date: Wed, 27 Aug 2014 11:15:04 -0500 From: atull X-X-Sender: atull@atx-linux-37 To: Weike Chen CC: Linus Walleij , Alexandre Courbot , Grant Likely , Rob Herring , , , , Boon Leong Ong , Andriy Shevchenko , Mika Westerberg , Hock Leong Kweh , Darren Hart , , Subject: Re: [PATCH 3/3] GPIO: gpio-dwapb: Suspend & Resume PM enabling In-Reply-To: <1409161588-19417-4-git-send-email-alvin.chen@intel.com> Message-ID: References: <1409161588-19417-1-git-send-email-alvin.chen@intel.com> <1409161588-19417-4-git-send-email-alvin.chen@intel.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [64.129.157.38] X-ClientProxiedBy: BN1PR02CA0051.namprd02.prod.outlook.com (10.141.56.51) To BY2PR03MB313.namprd03.prod.outlook.com (10.141.139.13) X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:;UriScan:; X-Forefront-PRVS: 0316567485 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(6009001)(199003)(189002)(51704005)(24454002)(99396002)(4396001)(23726002)(83322001)(42186005)(76482001)(92726001)(31966008)(86152002)(85852003)(74502001)(19580405001)(74662001)(46102001)(92566001)(83072002)(66066001)(19580395003)(69596002)(83506001)(46406003)(53416004)(86362001)(80022001)(47776003)(20776003)(50986999)(106356001)(50466002)(54356999)(95666004)(105586002)(81542001)(77096002)(21056001)(77982001)(107046002)(90102001)(76176999)(101416001)(33716001)(87976001)(81342001)(102836001)(64706001)(79102001)(85306004)(81156004)(110136001);DIR:OUT;SFP:;SCL:1;SRVR:BY2PR03MB313;H:atx-linux-37.altera.com;FPR:;MLV:sfv;PTR:InfoNoRecords;A:0;MX:1;LANG:en; X-OriginatorOrg: opensource.altera.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 27 Aug 2014, Weike Chen wrote: > This patch enables suspend and resume mode for the power management, and > it is based on Josef Ahmad's previous work. > > Reviewed-by: Hock Leong Kweh > Reviewed-by: Shevchenko, Andriy > Signed-off-by: Weike Chen > --- > drivers/gpio/gpio-dwapb.c | 67 +++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 67 insertions(+) > Hi Weike, I tried out these patches on the current master branch (v3.17-rc2-9-g68e3702) with a socfpga cyclone5 board. If I apply all 3 patches, the kernel doesn't boot. If I rebuild with only the first patch, I get only one gpio block showing up (should have 3 for this board) and these messages: ------------[ cut here ]------------ WARNING: CPU: 0 PID: 1 at /home/atull/repos/linux-socfpga/fs/sysfs/dir.c:31 sysfs_warn_dup+0x58/0x74() sysfs: cannot create duplicate filename '/class/gpio/gpiochip0' Modules linked in: CPU: 0 PID: 1 Comm: swapper/0 Not tainted 3.17.0-rc2-00012-g7ad6a41 #1 [] (unwind_backtrace) from [] (show_stack+0x10/0x14) [] (show_stack) from [] (dump_stack+0x74/0x90) [] (dump_stack) from [] (warn_slowpath_common+0x68/0x8c) [] (warn_slowpath_common) from [] (warn_slowpath_fmt+0x30/0x40) [] (warn_slowpath_fmt) from [] (sysfs_warn_dup+0x58/0x74) [] (sysfs_warn_dup) from [] (sysfs_do_create_link_sd+0xbc/0xc4) [] (sysfs_do_create_link_sd) from [] (device_add+0x304/0x4ec) [] (device_add) from [] (device_create_groups_vargs+0x9c/0xcc) [] (device_create_groups_vargs) from [] (device_create_vargs+0x20/0x28) [] (device_create_vargs) from [] (device_create+0x20/0x28) [] (device_create) from [] (gpiochip_export+0x4c/0x98) [] (gpiochip_export) from [] (gpiochip_add+0x114/0x29c) [] (gpiochip_add) from [] (dwapb_gpio_probe+0x16c/0x634) [] (dwapb_gpio_probe) from [] (platform_drv_probe+0x2c/0x5c) [] (platform_drv_probe) from [] (driver_probe_device+0x78/0x208) [] (driver_probe_device) from [] (__driver_attach+0x8c/0x90) [] (__driver_attach) from [] (bus_for_each_dev+0x54/0x88) [] (bus_for_each_dev) from [] (bus_add_driver+0xd8/0x1d4) [] (bus_add_driver) from [] (driver_register+0x78/0xf4) [] (driver_register) from [] (do_one_initcall+0x80/0x1b8) [] (do_one_initcall) from [] (kernel_init_freeable+0x170/0x240) [] (kernel_init_freeable) from [] (kernel_init+0x8/0xec) [] (kernel_init) from [] (ret_from_fork+0x14/0x3c) ---[ end trace 209e273f37ff62dd ]--- gpiochip_add: GPIOs 0..28 (ff709000.gpio) failed to register gpio-dwapb ff709000.gpio: failed to register gpiochip for /soc/gpio@ff709000/gpio-controller@0 gpio-dwapb: probe of ff709000.gpio failed with error -17 ------------[ cut here ]------------ WARNING: CPU: 0 PID: 1 at /home/atull/repos/linux-socfpga/fs/sysfs/dir.c:31 sysfs_warn_dup+0x58/0x74() sysfs: cannot create duplicate filename '/class/gpio/gpiochip0' Modules linked in: CPU: 0 PID: 1 Comm: swapper/0 Tainted: G W 3.17.0-rc2-00012-g7ad6a41 #1 [] (unwind_backtrace) from [] (show_stack+0x10/0x14) [] (show_stack) from [] (dump_stack+0x74/0x90) [] (dump_stack) from [] (warn_slowpath_common+0x68/0x8c) [] (warn_slowpath_common) from [] (warn_slowpath_fmt+0x30/0x40) [] (warn_slowpath_fmt) from [] (sysfs_warn_dup+0x58/0x74) [] (sysfs_warn_dup) from [] (sysfs_do_create_link_sd+0xbc/0xc4) [] (sysfs_do_create_link_sd) from [] (device_add+0x304/0x4ec) [] (device_add) from [] (device_create_groups_vargs+0x9c/0xcc) [] (device_create_groups_vargs) from [] (device_create_vargs+0x20/0x28) [] (device_create_vargs) from [] (device_create+0x20/0x28) [] (device_create) from [] (gpiochip_export+0x4c/0x98) [] (gpiochip_export) from [] (gpiochip_add+0x114/0x29c) [] (gpiochip_add) from [] (dwapb_gpio_probe+0x16c/0x634) [] (dwapb_gpio_probe) from [] (platform_drv_probe+0x2c/0x5c) [] (platform_drv_probe) from [] (driver_probe_device+0x78/0x208) [] (driver_probe_device) from [] (__driver_attach+0x8c/0x90) [] (__driver_attach) from [] (bus_for_each_dev+0x54/0x88) [] (bus_for_each_dev) from [] (bus_add_driver+0xd8/0x1d4) [] (bus_add_driver) from [] (driver_register+0x78/0xf4) [] (driver_register) from [] (do_one_initcall+0x80/0x1b8) [] (do_one_initcall) from [] (kernel_init_freeable+0x170/0x240) [] (kernel_init_freeable) from [] (kernel_init+0x8/0xec) [] (kernel_init) from [] (ret_from_fork+0x14/0x3c) ---[ end trace 209e273f37ff62de ]--- gpiochip_add: GPIOs 0..26 (ff70a000.gpio) failed to register gpio-dwapb ff70a000.gpio: failed to register gpiochip for /soc/gpio@ff70a000/gpio-controller@0 gpio-dwapb: probe of ff70a000.gpio failed with error -17 How are you testing this? Alan