From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: David Vrabel <david.vrabel@citrix.com>
Cc: <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
<x86@kernel.org>, <xen-devel@lists.xenproject.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 2/3] x86: allow dma_get_required_mask() to be overridden
Date: Fri, 14 Nov 2014 15:19:39 +0000 [thread overview]
Message-ID: <alpine.DEB.2.02.1411141519100.26318@kaball.uk.xensource.com> (raw)
In-Reply-To: <1415805906-27316-3-git-send-email-david.vrabel@citrix.com>
On Wed, 12 Nov 2014, David Vrabel wrote:
> Use dma_ops->get_required_mask() if provided, defaulting to
> dma_get_requried_mask_from_max_pfn().
>
> This is needed on systems (such as Xen PV guests) where the DMA
> address and the physical address are not equal.
>
> Signed-off-by: David Vrabel <david.vrabel@citrix.com>
Reviewed-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> arch/x86/include/asm/device.h | 2 ++
> arch/x86/kernel/pci-dma.c | 8 ++++++++
> 2 files changed, 10 insertions(+)
>
> diff --git a/arch/x86/include/asm/device.h b/arch/x86/include/asm/device.h
> index 03dd729..10bc628 100644
> --- a/arch/x86/include/asm/device.h
> +++ b/arch/x86/include/asm/device.h
> @@ -13,4 +13,6 @@ struct dev_archdata {
> struct pdev_archdata {
> };
>
> +#define ARCH_HAS_DMA_GET_REQUIRED_MASK
> +
> #endif /* _ASM_X86_DEVICE_H */
> diff --git a/arch/x86/kernel/pci-dma.c b/arch/x86/kernel/pci-dma.c
> index a25e202..5154400 100644
> --- a/arch/x86/kernel/pci-dma.c
> +++ b/arch/x86/kernel/pci-dma.c
> @@ -140,6 +140,14 @@ void dma_generic_free_coherent(struct device *dev, size_t size, void *vaddr,
> free_pages((unsigned long)vaddr, get_order(size));
> }
>
> +u64 dma_get_required_mask(struct device *dev)
> +{
> + if (dma_ops->get_required_mask)
> + return dma_ops->get_required_mask(dev);
> + return dma_get_required_mask_from_max_pfn(dev);
> +}
> +EXPORT_SYMBOL_GPL(dma_get_required_mask);
> +
> /*
> * See <Documentation/x86/x86_64/boot-options.txt> for the iommu kernel
> * parameter documentation.
> --
> 1.7.10.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://secure-web.cisco.com/1ixXdBDpz1KdvMlO1aynlM5N1jrQ7I1zdB_g1CPo0rimcVM76xTOPAvm484tRhqPosYwwpXnvHtyzSn_CZ4-EcYzELZhn5abgWc7e5fB0Ki0nE024_U4cvFTVoR2qflul0tkkVvivUWBl8v3vMWMTT6wuEYW3UcP3Bt3ttSORXPc/http%3A%2F%2Fwww.tux.org%2Flkml%2F
>
next prev parent reply other threads:[~2014-11-14 15:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 15:25 [PATCHv2 0/3]: dma,x86,xen: reduce SWIOTLB usage in Xen guests David Vrabel
2014-11-12 15:25 ` [PATCH 1/3] dma,ia64: add dma_get_required_mask_from_max_pfn() David Vrabel
2014-11-14 15:11 ` [Xen-devel] [PATCH 1/3] dma, ia64: " Stefano Stabellini
2014-11-12 15:25 ` [PATCH 2/3] x86: allow dma_get_required_mask() to be overridden David Vrabel
2014-11-13 10:25 ` [Xen-devel] " Jan Beulich
2014-11-13 10:30 ` David Vrabel
2014-11-13 10:32 ` Jan Beulich
2014-11-14 15:19 ` Stefano Stabellini [this message]
2014-11-12 15:25 ` [PATCH 3/3] x86/xen: use the maximum MFN to calculate the required DMA mask David Vrabel
2014-11-12 15:55 ` [Xen-devel] " Jan Beulich
2014-11-12 16:59 ` David Vrabel
2014-11-12 17:18 ` Jan Beulich
2014-11-13 9:57 ` Jan Beulich
2014-11-13 10:38 ` Andrew Cooper
2014-11-13 10:53 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1411141519100.26318@kaball.uk.xensource.com \
--to=stefano.stabellini@eu.citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®