From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
<david.vrabel@citrix.com>, <konrad.wilk@oracle.com>,
<jun.nakajima@intel.com>, <linux-kernel@vger.kernel.org>,
<xen-devel@lists.xen.org>
Subject: Re: [PATCH v3 1/2] xen/pci: Defer initialization of MSI ops on HVM guests until after x2APIC has been set up
Date: Tue, 25 Nov 2014 15:12:14 +0000 [thread overview]
Message-ID: <alpine.DEB.2.02.1411251511580.2675@kaball.uk.xensource.com> (raw)
In-Reply-To: <54749C2B.4090303@oracle.com>
On Tue, 25 Nov 2014, Boris Ostrovsky wrote:
> On 11/25/2014 07:06 AM, Stefano Stabellini wrote:
> > On Mon, 24 Nov 2014, Boris Ostrovsky wrote:
> > > If the hardware supports APIC virtualization we may decide not to use
> > > pirqs
> > > and instead use APIC/x2APIC directly, meaning that we don't want to set
> > > x86_msi.setup_msi_irqs and x86_msi.teardown_msi_irq to Xen-specific
> > > routines.
> > > However, x2APIC is not set up by the time pci_xen_hvm_init() is called so
> > > we
> > > need to postpone setting these ops until later, when we know which APIC
> > > mode
> > > is used.
> > >
> > > (Note that currently x2APIC is never initialized on HVM guests. This may
> > > change in the future)
> > I take that this is safe because no MSIs can be received at this point
> > (apic_post_init), right?
>
>
> Yes. At the time apic_post_init() is called PCI has not been probed yet.
Please add that to the commit message.
Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
next prev parent reply other threads:[~2014-11-25 15:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-24 23:06 [PATCH v3 0/2] xen/pci: Use APIC for MSIs when APIC virtualization is supported Boris Ostrovsky
2014-11-24 23:06 ` [PATCH v3 1/2] xen/pci: Defer initialization of MSI ops on HVM guests until after x2APIC has been set up Boris Ostrovsky
2014-11-25 12:06 ` Stefano Stabellini
2014-11-25 15:11 ` Boris Ostrovsky
2014-11-25 15:12 ` Stefano Stabellini [this message]
2014-11-24 23:06 ` [PATCH v3 2/2] xen/pci: Use APIC directly when APIC virtualization is supported by hardware Boris Ostrovsky
2014-11-25 12:05 ` Stefano Stabellini
2014-11-25 16:17 ` [PATCH v3 0/2] xen/pci: Use APIC for MSIs when APIC virtualization is supported Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1411251511580.2675@kaball.uk.xensource.com \
--to=stefano.stabellini@eu.citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=jun.nakajima@intel.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®