From: atull <atull@opensource.altera.com>
To: Steffen Trumtrar <s.trumtrar@pengutronix.de>
Cc: <gregkh@linuxfoundation.org>, <jgunthorpe@obsidianresearch.com>,
<hpa@zytor.com>, <monstr@monstr.eu>, <michal.simek@xilinx.com>,
<rdunlap@infradead.org>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>, <pantelis.antoniou@konsulko.com>,
<robh+dt@kernel.org>, <grant.likely@linaro.org>,
<iws@ovro.caltech.edu>, <linux-doc@vger.kernel.org>,
<pavel@denx.de>, <broonie@kernel.org>, <philip@balister.org>,
<rubini@gnudd.com>, <jason@lakedaemon.net>, <kyle.teske@ni.com>,
<nico@linaro.org>, <balbi@ti.com>, <m.chehab@samsung.com>,
<davidb@codeaurora.org>, <rob@landley.net>, <davem@davemloft.net>,
<cesarb@cesarb.net>, <sameo@linux.intel.com>,
<akpm@linux-foundation.org>, <linus.walleij@linaro.org>,
<pawel.moll@arm.com>, <mark.rutland@arm.com>,
<ijc+devicetree@hellion.org.uk>, <galak@codeaurora.org>,
<delicious.quinoa@gmail.com>, <dinguyen@opensource.altera.com>,
<yvanderv@opensource.altera.com>
Subject: Re: [PATCH v4 6/6] staging: fpga manager: add driver for altera socfpga manager
Date: Thu, 11 Dec 2014 17:14:24 -0600 [thread overview]
Message-ID: <alpine.DEB.2.02.1412111710470.11739@linuxheads99> (raw)
In-Reply-To: <20141210150548.GB23358@pengutronix.de>
On Wed, 10 Dec 2014, Steffen Trumtrar wrote:
> > +static inline void altera_fpga_reg_set_bitsl(struct altera_fpga_priv *priv,
> > + u32 offset, u32 bits)
> > +{
> > + u32 val;
> > +
> > + val = altera_fpga_reg_readl(priv, offset);
> > + val |= bits;
> > + altera_fpga_reg_writel(priv, offset, val);
> > +}
> > +
> > +static inline void altera_fpga_reg_clr_bitsl(struct altera_fpga_priv *priv,
> > + u32 offset, u32 bits)
> > +{
> > + u32 val;
> > +
> > + val = altera_fpga_reg_readl(priv, offset);
> > + val &= ~bits;
> > + altera_fpga_reg_writel(priv, offset, val);
> > +}
> > +
>
> Why do you need these? Can't you just use regmap_mmio?
I would like to do that as an improvement as time allows, not now.
> > + ret = request_irq(priv->irq, altera_fpga_isr, 0, "altera-fpga-mgr",
> > + priv);
> > + if (ret < 0)
> > + goto err_dispose_irq;
>
> devm_request_irq
Will do, thanks.
Alan
next prev parent reply other threads:[~2014-12-11 23:14 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-09 20:14 [PATCH v4 0/6] FPGA Manager Framework atull
2014-12-09 20:14 ` [PATCH v4 1/6] doc: add bindings document for altera fpga manager atull
2014-12-09 20:14 ` [PATCH v4 2/6] arm: dts: socfpga: add " atull
2014-12-10 15:01 ` Steffen Trumtrar
2014-12-10 17:25 ` atull
2014-12-10 17:49 ` Steffen Trumtrar
2014-12-11 8:56 ` Michal Simek
2014-12-11 15:50 ` atull
2014-12-09 20:14 ` [PATCH v4 3/6] ARM: socfpga: defconfig: enable " atull
2014-12-10 9:41 ` Michal Simek
2014-12-10 17:17 ` atull
2014-12-09 20:14 ` [PATCH v4 4/6] fpga manager: add sysfs interface document atull
2014-12-10 9:42 ` Michal Simek
2014-12-10 14:47 ` Greg KH
2014-12-10 15:24 ` Michal Simek
2014-12-10 17:23 ` atull
2014-12-10 14:50 ` One Thousand Gnomes
2014-12-09 20:14 ` [PATCH v4 5/6] staging: fpga manager: framework core atull
2014-12-10 12:41 ` Michal Simek
2014-12-12 17:14 ` atull
2014-12-17 11:54 ` SPDX for kernel (was Re: [PATCH v4 5/6] staging: fpga manager: framework core) Pavel Machek
2014-12-09 20:14 ` [PATCH v4 6/6] staging: fpga manager: add driver for altera socfpga manager atull
2014-12-10 12:04 ` Michal Simek
2014-12-17 16:52 ` atull
2014-12-10 15:05 ` Steffen Trumtrar
2014-12-11 23:14 ` atull [this message]
2014-12-10 14:52 ` [PATCH v4 0/6] FPGA Manager Framework Greg KH
2014-12-10 20:49 ` atull
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1412111710470.11739@linuxheads99 \
--to=atull@opensource.altera.com \
--cc=akpm@linux-foundation.org \
--cc=balbi@ti.com \
--cc=broonie@kernel.org \
--cc=cesarb@cesarb.net \
--cc=davem@davemloft.net \
--cc=davidb@codeaurora.org \
--cc=delicious.quinoa@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@opensource.altera.com \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=iws@ovro.caltech.edu \
--cc=jason@lakedaemon.net \
--cc=jgunthorpe@obsidianresearch.com \
--cc=kyle.teske@ni.com \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=mark.rutland@arm.com \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=nico@linaro.org \
--cc=pantelis.antoniou@konsulko.com \
--cc=pavel@denx.de \
--cc=pawel.moll@arm.com \
--cc=philip@balister.org \
--cc=rdunlap@infradead.org \
--cc=rob@landley.net \
--cc=robh+dt@kernel.org \
--cc=rubini@gnudd.com \
--cc=s.trumtrar@pengutronix.de \
--cc=sameo@linux.intel.com \
--cc=yvanderv@opensource.altera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®