From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753321AbbAMR1u (ORCPT ); Tue, 13 Jan 2015 12:27:50 -0500 Received: from mail-bl2on0097.outbound.protection.outlook.com ([65.55.169.97]:51072 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752495AbbAMR1s (ORCPT ); Tue, 13 Jan 2015 12:27:48 -0500 Date: Tue, 13 Jan 2015 11:27:05 -0600 From: atull X-X-Sender: atull@linuxheads99 To: Pavel Machek CC: Pantelis Antoniou , Michal Simek , Greg Kroah-Hartman , , , Michal Simek , , Linux Kernel Mailing List , , , Grant Likely , , , Mark Brown , , , Steffen Trumtrar , , , , Felipe Balbi , , , Rob Landley , , , , , Linus Walleij , , , , , , Alan Tull , , Subject: Re: [PATCH v8 2/4] fpga manager: add sysfs interface document In-Reply-To: <20150113075651.GB11760@amd> Message-ID: References: <20150107084819.GA1887@amd> <20150109205643.GA5761@amd> <4D4EA2D5-68DD-49F7-9E2D-3A0A8F6AF9CA@konsulko.com> <20150110151118.GA16036@amd> <20150112084530.GA28681@amd> <20150113072857.GA11760@amd> <20150113075651.GB11760@amd> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-132828085-1421170041=:27340" X-Originating-IP: [64.129.157.38] X-ClientProxiedBy: BY2PR06CA060.namprd06.prod.outlook.com (10.141.250.178) To BY1PR0301MB1240.namprd03.prod.outlook.com (25.161.203.24) Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=atull@opensource.altera.com; X-DmarcAction-Test: None X-Microsoft-Antispam: UriScan:; X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(3005003);SRVR:BY1PR0301MB1240; X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004);SRVR:BY1PR0301MB1240; X-Forefront-PRVS: 045584D28C X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(52044002)(51704005)(24454002)(377424004)(199003)(50944004)(189002)(84326002)(60046008)(97736003)(83506001)(46102003)(50986999)(54356999)(76176999)(53416004)(64706001)(101416001)(77156002)(62966003)(68736005)(66066001)(122386002)(40100003)(42186005)(69596002)(15975445007)(81156004)(86152002)(2950100001)(41446005)(105586002)(33716001)(86362001)(106356001)(512874002)(19580395003)(93886004)(92566002)(110136001)(19580405001)(7059030);DIR:OUT;SFP:1101;SCL:1;SRVR:BY1PR0301MB1240;H:linuxheads99.altera.com;FPR:;SPF:None;MLV:sfv;PTR:InfoNoRecords;A:0;MX:1;LANG:en; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:;SRVR:BY1PR0301MB1240; X-OriginatorOrg: opensource.altera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2015 17:27:42.5608 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0301MB1240 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --8323329-132828085-1421170041=:27340 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8BIT On Tue, 13 Jan 2015, Pavel Machek wrote: > On Tue 2015-01-13 09:40:18, Pantelis Antoniou wrote: > > Hi Pavel, > > > > > On Jan 13, 2015, at 09:28 , Pavel Machek wrote: > > > > > > Hi! > > > > > >>>>>>>>>> +What: /sys/class/fpga_manager//firmware > > >>>>>>>>>> +Date: October 2014 > > >>>>>>>>>> +KernelVersion: 3.18 > > >>>>>>>>>> +Contact: Alan Tull > > >>>>>>>>>> +Description: Name of the FPGA image file to load using firmware > > >>>>>>>>>> class. > > >>>>>>>>> > > >>>>>>>>> This one is ugly: it unneccessarily passes firmware name through the > > >>>>>>>>> kernel. Just make interface and code simpler by always passing > > >>>>>>>>> "socfpga-fpga-image" or something like that. > > > ... > > > > > >>> What is cumbersome about symlink? Why is "fake" symlink in sysfs better? > > >>> > > >>>> Previous uses of the firmware layer has been to use it to load once after > > >>>> bootup; this is different since some use cases will want to switch out > > >>>> the FPGA image. If someone wants there to be only one FPGA image on > > >>>> the FGPA forever, they will probably not be using this framework; their > > >>>> FPGA will probably be loaded before Linux boots up. > > >>> > > >>> Why? I have just one image on the fpga, and would prefer to load it > > >>> from Linux. > > >> > > >> Pavel: These patches target staging and sysfs interface doesn't need to be stable > > >> at this time. I would prefer to add these patches to staging for 3.20 > > >> and feel free to send the patch which fix this. > > > > > > Interesting way to address patch review. "We'll merge it, and you can > > > fix it up later". > > > > > >> With your code will be exactly clear how you want to use it and we can > > >> talk about it. > > > > > > I'm pretty sure Alan knows what I want at this point, he just does not > > > want to do it. > > > > > > For the record, I want to drop "firmware" file, use fixed firmware > > > name, and deal with multiple firmwares in userspace (using symlink or > > > udev magic). > > > > That’s completely bogus. Using a fixed firmware file does not respond to > > real world usage, and there are no words to describe the hacks using > > symlinks and udev in an embedded product. > > > > I believe this is simplest solution, should be adequate, and is > > > certainly less ugly than implementing fake symlink in > > > /sys/.../firmware. And I have yet to hear what is wrong with that > > > suggestion. > > > > Everything. > > Can you be more specific? Current solution already has a fake symlink, > implemented badly. > > Just remove it, and use real symlink (and then you can optionally > think of something better...) > Hi Pavel, I still don't get what you are saying. It's not a symlink. I'm not changing it. Alan > > Pavel > -- > (english) http://www.livejournal.com/~pavelmachek > (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html > --8323329-132828085-1421170041=:27340--