From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754478AbbCRWqN (ORCPT <rfc822;w@1wt.eu>);
	Wed, 18 Mar 2015 18:46:13 -0400
Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:29663 "EHLO
	mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1751475AbbCRWqJ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 18 Mar 2015 18:46:09 -0400
X-IronPort-AV: E=Sophos;i="5.11,425,1422918000"; 
   d="scan'208";a="126644318"
Date: Wed, 18 Mar 2015 23:46:07 +0100 (CET)
From: Julia Lawall <julia.lawall@lip6.fr>
X-X-Sender: jll@localhost6.localdomain6
To: Patrick Farrell <paf@cray.com>
cc: py@amd48-systeme.lip6.fr, devel@driverdev.osuosl.org,
        gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
        Julia.Lawall@lip6.fr,
        =?ISO-8859-15?Q?Pierre-Yves_P=E9neau?= <pierre-yves.peneau@gmx.com>,
        viro@zeniv.linux.org.uk, aybuke.147@gmail.com,
        HPDD-discuss@ml01.01.org
Subject: Re: [HPDD-discuss] [PATCH] Staging: lustre: file.c: fix coding
 style
In-Reply-To: <5509D590.30207@cray.com>
Message-ID: <alpine.DEB.2.02.1503182345290.2193@localhost6.localdomain6>
References: <1426705728-2001-1-git-send-email-pierre-yves.peneau@gmx.com> <5509D291.1060005@cray.com> <5509D590.30207@cray.com>
User-Agent: Alpine 2.02 (DEB 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 18 Mar 2015, Patrick Farrell wrote:

> Uck, my reply made the formatting even worse.  I'm trying to say it should
> look like this:
> +            rc = ll_intent_file_open(file->f_path.dentry,
> +                                                    NULL, 0, it);
> Not like this:
> +            rc = ll_intent_file_open(file->f_path.dentry,
> +                                                   NULL, 0, it);

Both look wrong to me.  Are your tabs equivalent to 8 spaces?

julia

> 
> On 03/18/2015 02:31 PM, Patrick Farrell wrote:
> > Perhaps this is just a formatting error in my email client, but shouldn't
> > NULL be one more space over to line up with the '(' above?
> > 
> > On 03/18/2015 02:08 PM, py@amd48-systeme.lip6.fr wrote:
> > > +            rc = ll_intent_file_open(file->f_path.dentry,
> > > +                        NULL, 0, it);
> > 
> > _______________________________________________
> > HPDD-discuss mailing list
> > HPDD-discuss@lists.01.org
> > https://lists.01.org/mailman/listinfo/hpdd-discuss
> 
>