From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752331AbbCYGX6 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 25 Mar 2015 02:23:58 -0400
Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:23165 "EHLO
	mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1750815AbbCYGXz (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 25 Mar 2015 02:23:55 -0400
X-IronPort-AV: E=Sophos;i="5.11,463,1422918000"; 
   d="scan'208";a="129985853"
Date: Wed, 25 Mar 2015 07:23:52 +0100 (CET)
From: Julia Lawall <julia.lawall@lip6.fr>
X-X-Sender: jll@localhost6.localdomain6
To: kbuild test robot <fengguang.wu@intel.com>, peter.chen@freescale.com
cc: kbuild@01.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        gregkh@linuxfoundation.org, Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: [PATCH] usb: chipidea: usbmisc_imx: fix returnvar.cocci
 warnings
In-Reply-To: <20150324234408.GA120171@athens>
Message-ID: <alpine.DEB.2.02.1503250723070.2205@localhost6.localdomain6>
References: <201503250705.ZLF1deME%fengguang.wu@intel.com> <20150324234408.GA120171@athens>
User-Agent: Alpine 2.02 (DEB 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Please take a look.

thanks,
julia

On Wed, 25 Mar 2015, kbuild test robot wrote:

> TO: Peter Chen <peter.chen@freescale.com>
> CC: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
> CC: linux-usb@vger.kernel.org
> CC: linux-kernel@vger.kernel.org
> 
> drivers/usb/chipidea/usbmisc_imx.c:277:5-8: Unneeded variable: "ret". Return "0" on line 297
> 
> 
>  Removes unneeded variable used to store return value.
> 
> Generated by: scripts/coccinelle/misc/returnvar.cocci
> 
> CC: Peter Chen <peter.chen@freescale.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
> 
> Please take the patch only if it's a positive warning. Thanks!
> 
>  usbmisc_imx.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> --- a/drivers/usb/chipidea/usbmisc_imx.c
> +++ b/drivers/usb/chipidea/usbmisc_imx.c
> @@ -274,7 +274,6 @@ static int usbmisc_imx6sx_init(struct im
>  	unsigned long flags;
>  	struct imx_usbmisc *usbmisc = dev_get_drvdata(data->dev);
>  	u32 val;
> -	int ret = 0;
>  
>  	usbmisc_imx6q_init(data);
>  
> @@ -294,7 +293,7 @@ static int usbmisc_imx6sx_init(struct im
>  		spin_unlock_irqrestore(&usbmisc->lock, flags);
>  	}
>  
> -	return ret;
> +	return 0;
>  }
>  
>  static int usbmisc_vf610_init(struct imx_usbmisc_data *data)
>