From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932111AbbCYPlV (ORCPT <rfc822;w@1wt.eu>);
	Wed, 25 Mar 2015 11:41:21 -0400
Received: from smtp.citrix.com ([66.165.176.89]:35049 "EHLO SMTP.CITRIX.COM"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754494AbbCYPlJ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 25 Mar 2015 11:41:09 -0400
X-IronPort-AV: E=Sophos;i="5.11,465,1422921600"; 
   d="scan'208";a="246604045"
Date: Wed, 25 Mar 2015 15:38:57 +0000
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
X-X-Sender: sstabellini@kaball.uk.xensource.com
To: Will Deacon <will.deacon@arm.com>
CC: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        "hanjun.guo@linaro.org" <hanjun.guo@linaro.org>,
        Catalin Marinas <Catalin.Marinas@arm.com>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Olof Johansson <olof@lixom.net>,
        "grant.likely@linaro.org" <grant.likely@linaro.org>,
        Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>,
        Arnd Bergmann <arnd@arndb.de>, Mark Rutland <Mark.Rutland@arm.com>,
        "graeme.gregory@linaro.org" <graeme.gregory@linaro.org>,
        Sudeep Holla <Sudeep.Holla@arm.com>, "jcm@redhat.com" <jcm@redhat.com>,
        Marc Zyngier <Marc.Zyngier@arm.com>, "Mark Brown" <broonie@kernel.org>,
        Robert Richter <rric@kernel.org>, Timur Tabi <timur@codeaurora.org>,
        Ashwin Chaugule <ashwinc@codeaurora.org>,
        "suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
        "msalter@redhat.com" <msalter@redhat.com>,
        "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linaro-acpi@lists.linaro.org" <linaro-acpi@lists.linaro.org>,
        Julien Grall <julien.grall@linaro.org>,
        Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
        David Vrabel <david.vrabel@citrix.com>
Subject: Re: [patch v11 19/23] XEN / ACPI: Make XEN ACPI depend on X86
In-Reply-To: <20150325115113.GF24636@arm.com>
Message-ID: <alpine.DEB.2.02.1503251538380.7982@kaball.uk.xensource.com>
References: <1427205776-5060-1-git-send-email-hanjun.guo@linaro.org>
 <1427205776-5060-20-git-send-email-hanjun.guo@linaro.org>
 <55118303.8060003@oracle.com>
 <alpine.DEB.2.02.1503241723520.7982@kaball.uk.xensource.com>
 <20150325115113.GF24636@arm.com>
User-Agent: Alpine 2.02 (DEB 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
X-DLP: MIA1
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 25 Mar 2015, Will Deacon wrote:
> Hi Stefano,
> 
> On Tue, Mar 24, 2015 at 05:24:53PM +0000, Stefano Stabellini wrote:
> > On Tue, 24 Mar 2015, Boris Ostrovsky wrote:
> > > On 03/24/2015 10:02 AM, Hanjun Guo wrote:
> > > > When ACPI is enabled on ARM64, XEN ACPI will also compiled
> > > > into the kernel, but XEN ACPI is x86 dependent, so introduce
> > > > CONFIG_XEN_ACPI to make it depend on x86 before XEN ACPI is
> > > > functional on ARM64.
> > > > 
> > > > CC: 'Stefano Stabellini' <stefano.stabellini@eu.citrix.com>
> > > > CC: Julien Grall <julien.grall@linaro.org>
> > > > CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> > > > CC: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> > > > CC: David Vrabel <david.vrabel@citrix.com>
> > > > Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
> > > > ---
> > > >   drivers/xen/Kconfig  | 4 ++++
> > > >   drivers/xen/Makefile | 2 +-
> > > >   2 files changed, 5 insertions(+), 1 deletion(-)
> > > > 
> > > > diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig
> > > > index b812462..a31cd29 100644
> > > > --- a/drivers/xen/Kconfig
> > > > +++ b/drivers/xen/Kconfig
> > > > @@ -253,4 +253,8 @@ config XEN_EFI
> > > >   	def_bool y
> > > >   	depends on X86_64 && EFI
> > > >   +config XEN_ACPI
> > > > +	def_bool y
> > > > +	depends on X86 && ACPI
> > > > +
> > > 
> > > 
> > > I think XEN_DOM0 (in arch/x86/xen/Kconfig) should select this option.
> > > Otherwise, if it is set to 'n', we won't be able to build enlighten.c
> > > (xen_start_kernel() -> xen_acpi_sleep_register() refers to
> > > xen_acpi_notify_hypervisor_sleep()).
> > > 
> > 
> > I don't think that it is necessary: XEN_ACPI gets automatically enabled
> > anyway.
> 
> In which case, can I have your Ack on this please?

Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>