From: Julia Lawall <julia.lawall@lip6.fr>
To: "DHANAPAL, GNANACHANDRAN (G.)" <gdhanapa@visteon.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"lambert.quentin@gmail.com" <lambert.quentin@gmail.com>,
"mdcasey@chabloom.com" <mdcasey@chabloom.com>,
"julia.lawall@lip6.fr" <julia.lawall@lip6.fr>,
"kolbeinnkarls@gmail.com" <kolbeinnkarls@gmail.com>,
"himangi774@gmail.com" <himangi774@gmail.com>,
"joe@perches.com" <joe@perches.com>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Babu, Viswanathan (V.)" <vbabu3@visteon.com>
Subject: Re: [PATCH] Staging: rtl8192e: Timer setup using macro rather assignment
Date: Mon, 18 May 2015 19:49:30 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.02.1505181948310.2065@localhost6.localdomain6> (raw)
In-Reply-To: <20150518144539.GA10481@visteon-gnana>
> void _setup_timer(struct timer_list *ptimer, void *fun, unsigned long data)
> {
> - ptimer->function = fun;
> - ptimer->data = data;
> init_timer(ptimer);
> + setup_timer(ptimer, fun, data);
> }
setup_timer also subsumes init_timer. Check the definition. Probably you
can delete this function completely.
julia
prev parent reply other threads:[~2015-05-18 17:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-18 14:44 DHANAPAL, GNANACHANDRAN (G.)
2015-05-18 16:05 ` Sudip Mukherjee
2015-05-18 16:26 ` Joe Perches
2015-05-18 16:42 ` Sudip Mukherjee
2015-05-31 0:26 ` gregkh
2015-05-18 17:49 ` Julia Lawall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1505181948310.2065@localhost6.localdomain6 \
--to=julia.lawall@lip6.fr \
--cc=devel@driverdev.osuosl.org \
--cc=gdhanapa@visteon.com \
--cc=gregkh@linuxfoundation.org \
--cc=himangi774@gmail.com \
--cc=joe@perches.com \
--cc=kolbeinnkarls@gmail.com \
--cc=lambert.quentin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mdcasey@chabloom.com \
--cc=vbabu3@visteon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®