From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754639AbbE1UZu (ORCPT ); Thu, 28 May 2015 16:25:50 -0400 Received: from mail-bn1on0074.outbound.protection.outlook.com ([157.56.110.74]:56224 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754006AbbE1UZk (ORCPT ); Thu, 28 May 2015 16:25:40 -0400 Authentication-Results: spf=fail (sender IP is 66.35.236.227) smtp.mailfrom=opensource.altera.com; vger.kernel.org; dkim=none (message not signed) header.d=none; Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=atull@opensource.altera.com; Date: Thu, 28 May 2015 15:21:43 -0500 From: atull X-X-Sender: atull@linuxheads99 To: Pavel Machek CC: Dinh Nguyen , Rob Herring , Arnd Bergmann , Steffen Trumtrar , Pawel Moll , Mark Rutland , Ian Campbell , "Kumar Gala" , , , Russell King , , Delicious Quinoq Subject: Re: [PATCH v4 1/2] ARM: socfpga: support suspend to ram In-Reply-To: <20150526215617.GA3137@amd> Message-ID: References: <1432317735-29413-1-git-send-email-atull@opensource.altera.com> <1432317735-29413-2-git-send-email-atull@opensource.altera.com> <20150525124133.GF9943@amd> <20150526215617.GA3137@amd> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [64.129.157.38] X-ClientProxiedBy: BY1PR0501CA0001.namprd05.prod.outlook.com (25.162.139.11) To BLUPR03MB1507.namprd03.prod.outlook.com (25.163.81.25) X-Microsoft-Exchange-Diagnostics-untrusted: 1;BLUPR03MB1507;2:2FEuWh7XS6amasFrzddc9Hw1NrLSEEauIQsGfvY7oX7Yv7jvq3yEnXI4v30l+AzP;2:zWtISyaACyv/Lm/USSUTzBiJGSQdP94PJOrN+u5c9klG35ygST1aRqz1gqfZPu3UTc9od0b16tn674NS0Z5IW6a6V9J9K0F+SUDHj+LyaEU6l/nSbm/aI24m2hq0CnCYugL81OA3l3ipHW8+K5b9Iw==;6:nJ25LCTEM6V2qQpntEqYAjMy4xfaI/ndwKUswYqtWbqBFaiCgL3JkPDlVr18OAEWNhUdCMvmlsXH0RLV/u19fG/6tSpNZur6i44uu5qXlUi0NUTwJIo2YbcXT0UVtvDYDR4Rux0YTCfh2JF/H8TvKg==;3:/NzQw6J4wxxOIeSpZ9kJllYmlnXWD1ThwHglhcxIO7mo0KpSUQLSspw5hq4sRY3hiQU5kfx+cVohxfUYsP3ogb/f3Tki1qVxNj0QTUz7y/GbsIqEu/N8/xu8xv7JLtbJYRrrIBAMn6gDYOX6AF2+B2TIoZPZMTXWat/wnGpBChHwX/WBfh7M6vLcZY/I+/PVccKvGseGTudtgl4mA8Upp1vPgTGZsnkXJz69lGUjtf2zbtkN7QYmwo0a+2vf+eZA0Q9G+zN+vkmgJWFKipAd9UdeEIPYuMksx9goOqqKiJ4+HUA9bvkGGaajVQ/x946M X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB1507;UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB216;UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM2PR03MB318; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:;UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(520003)(5005006)(3002001);SRVR:BLUPR03MB1507;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB1507;BCL:0;PCL:0;RULEID:(601004)(520003)(5005006)(3002001);SRVR:DM2PR03MB318;BCL:0;PCL:0;RULEID:;SRVR:DM2PR03MB318; X-Forefront-PRVS: 0590BBCCBC X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(6009001)(51704005)(189002)(199003)(24454002)(51914003)(106356001)(64706001)(76176999)(54356999)(50986999)(42186005)(83506001)(86362001)(69596002)(101416001)(23726002)(77156002)(62966003)(4001350100001)(97736004)(4001540100001)(81156007)(5001860100001)(189998001)(40100003)(93886004)(87976001)(5001830100001)(53416004)(66066001)(5001960100002)(86152002)(105586002)(47776003)(110136002)(46406003)(50466002)(46102003)(77096005)(33716001)(92566002)(122386002)(2950100001)(68736005);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR03MB1507;H:linuxheads99.altera.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:0;LANG:en; X-Microsoft-Exchange-Diagnostics-untrusted: =?us-ascii?Q?1;BLUPR03MB1507;9:/BfD8ss9/+/N1LLlsCXzIInjC5I/ZoxVS0MIGePM9V?= =?us-ascii?Q?t4McPXnGl8wruokEjZm/AMH3N8wdMiaAfC5Br6+bwt4hhWDts4jF+OiG3cPo?= =?us-ascii?Q?T+zsPMZCRR31dXG1fObVb/lfI8cdpRs3JokkqJyCRUDibvjv42QDtGMHQY7s?= =?us-ascii?Q?peV8cHP+vVRBPKPSzYAw38/YV5hPrSv/oAnQtPNRq1NNvCBLpU79hwxHLSEZ?= =?us-ascii?Q?czlxgUzn8om3FMphF4OhF95BgAz/owOZSTTe5LJaqcQkdXK89Ve2Rk3n9aDn?= =?us-ascii?Q?jBvTbS46QpkLB3OCg0SofJNCSKdtXqNLwj7DpZNfGydlV3tdnoDc1XIzLW6x?= =?us-ascii?Q?aMid4ItOEQIffAt2lfvn1CBEnbUKPL+iAGfbRWVNMHTg3JqjY0y3SqCkDBXq?= =?us-ascii?Q?k1GJNoETLWumAGYYS71Z1Qw9ZNhdN5BlbpFmbt16r1b/YdecXY7qyhawXmM4?= =?us-ascii?Q?onBODsUnB2sTQpEfrFOAaoqsXM6W+IMW5eLDMfdKD24KuDuZwNj333qOKIcM?= =?us-ascii?Q?TuXy9dm+5DAXTG8GP6GO1TUm0mhNzihKjeJdTIhZvOQzwkEahjOa1XxuMHBR?= =?us-ascii?Q?b7lMjZ1GF413Q88bvQb6P6QZqYRHmhbOu3hVyHwzxhX+UacrcH3Nq4amxBBB?= =?us-ascii?Q?cZ8csMoEaMl7RReBGuRAqs+eJwr1h332DHWGIOrM/e72cASaksDTX/MfPdGe?= =?us-ascii?Q?eh6+QrO0b2VMgmSz1gEIbgFQ/CoZ/fwaMVHUIDZepbZXh7zOZMfSeUA/tUIz?= =?us-ascii?Q?ch10rv68VIiMT4HjVn4wPDKlkBnUvmXgcB52VJAuzEu2PQQcMWuRRd/oKqIJ?= =?us-ascii?Q?yx613G+hWLVpafk+Ovf7JGog+KnuZAmua/rQOKsw10TuSTukZojPfhTXqo87?= =?us-ascii?Q?6HaskPxsV6SfJSD4+udbNvcDBwnnLmUzM40197oMCWEpV2LjOlGCapaEQpq7?= =?us-ascii?Q?1ajwm5JslfoNRoEvsmU45uDdkZmbyx6b71/FnkkKVX34hge/S9NLURFgvw8O?= =?us-ascii?Q?hnIzAxBR0NBl9s1l+Hc56zOGDI1TMqnb7vo9MN2kIZKBK7PLvQNRBXkv24PC?= =?us-ascii?Q?ENj8d+lsx48QzKk9Pb7zgigy1R/vpkNu0AG7KM5ODPIrjmYWCVQRByQ8jAu5?= =?us-ascii?Q?vhB0j22EFQdWzdgMAfi+a3wSrLAr+JkafBrgQsaIoW5qVXUEvxUg=3D=3D?= X-Microsoft-Exchange-Diagnostics-untrusted: 1;BLUPR03MB1507;3:jzPOIOXXYB65MnjTyn2DUSNM0GwC8+yrBv4p77bkZ+nq25NUKHCzvr7cQhKtj+RWI/Hb7cE6DDSgRFZMKh9Ws/yo/zE+9J+fJQhfoYiNgmJchELP/x1P0+a2siTDd03et7Kl8SFa0XfreTc2phn8gQ==;10:Ks2bX69pzzc1URGW3y1uT6gIhym1g1og6X8labh4fBF0vsFxJh7yETZ/Y29fNV6MN+XJiRYvboymNMU/oD6bTn9vudtnMDsVPOR8jUX79dw=;6:Gx48YkmlcAAutP9JxP+TOe4umcGLiY8Kn/O1Usowyd7miXQtfu7QVeji+mChnfXydT548YAHNdEKvHQT59glfjJtksKx0V+tWvw9iCsAWE0TGy1fHi41jYf4Mee5blsQA8UGN6dWRQxoTjHmSDbqzg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB1507 X-Microsoft-Exchange-Diagnostics-untrusted: 1;BLUPR03MB216;2:8fPIhi2e0Ygji6XOk1Nsn3ekfv7ouE9+zYzD2WwyPZDJbadGIOVPGWn04Bks0EqX;2:23dEm0Kmu4PgzZ8+zycfcdnRHrw1eLG5g9u2lS50fJRlJg7FEj3sRTwoTvrlYTHABAWFZRJitvmOYzrFIZ38rUXZMzeCfMk3YRA1Apz3hK7sDU+0qDfLOjFnPgCTFXfeH+3K/csNaYHdTcfxc8AIzQ==;9:rNOIWBnizdkzAqKCzUT4mLui9IzXyvqv0F7XMrejQlEG0ljGI0QTJuAqQi0wVgzDPIh/63VY1X8BLVN5L8VlOZhFMLMH2yAZe3FhD02Uh9cUUav0KqefjG3PlrzKdI7I9YQYuVdwvU3ai8O0L/ApaQ== X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: BY2FFO11FD029.protection.gbl X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11FD029;1:Jk4zNRCgKwxfvzV5+eAZbrVNKoqnPCLGRizCTfAgnMgsyGIOcuoxR3em+KJApjbhNqe0qYi0cmyWrioabYiSea9h9CRN5gtKA/RNL/ZBI0aOSBUZJ9ph4CbhH9jbbT1vC8x1H7w4HDNtfKLvNmxOwkBKum/A4BZusZGPav7yIb4/IjjPcc9uF80vKUrbri/KPitH9mkkjM0e7fBEhDZqQtxN/KKLYgq+Hh+McsjQ6zUCo/5EVsOB+6soLK1PTOi+sBnmxJzkChcr6PPBVmXAlahj79GzrlVbyIIwmMu0XfXQaWwYHqnV1xY/ugTfH0Sj X-Forefront-Antispam-Report: CIP:66.35.236.227;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(339900001)(199003)(51704005)(189002)(24454002)(51914003)(2950100001)(110136002)(5001960100002)(46406003)(97736004)(66066001)(106466001)(53416004)(6070500001)(4001350100001)(105606002)(93886004)(83506001)(76176999)(6806004)(77096005)(92566002)(54356999)(86152002)(50986999)(86362001)(40100003)(47776003)(4001540100001)(81156007)(68736005)(46102003)(50466002)(23726002)(64706001)(122386002)(85426001)(5001860100001)(33716001)(77156002)(62966003)(87936001)(189998001)(5001830100001)(7099028);DIR:OUT;SFP:1101;SCL:1;SRVR:DM2PR03MB318;H:sj-itexedge03.altera.priv.altera.com;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;A:0;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;DM2PR03MB318;2:NX0H3RyUZUnSOCHzPEk9pAv30W22xGn+pNt5l58vOsR+dUuasXzRZWGhGHHIcULl;2:c6nt++H5XWRoAC7s+LVClDNuZK15y9ideVbR8642fu+86H3bbPTbZG/WbD1YvT1MeqYVaUVpA90J8NzkPm7yGlas+AvGcF42ypQgUrvE0Aks3aHm7awir7TrqiwgiLwrueG1CXQsldxYntSZLM1q7/b39RCcWnpNoEVcdYLZbAqVa47hz7rOK6VDdAm5LMiZJ2gdMIjR+jGbBDCV3d7o8tEAyMxwieGd6vOdpWTuo+A=;6:miaKTw+orTz4ghL2tAId/jUccV3Hjx3x2C9Qma0JJaxZgsAzTaEC56OiFabiJyVzUzBwsmt5Jq0J0plcSjC/NcmcaGTsuShAGItP6HlAxBzchxHG57O2RMn5XXgX82dfjOE5SFwNbQKySTHoPUvlJw==;3:Gz4tGLjE1um236OfsNKIwSI9dbt+GH862BueUEs0FhcTX9LAG3Id6E3pckdTJItGTAgnsOWTsKjDFt7wQ6bDJ9Zt9HpLjDDQ/Wi6+9bSgGZf70OPaPGFVabPY8OMIiyZbZeJQa34q8fteZB7zhsq2jzalV2Q7vxwoIRrRg4/PYa95o7R/KVeV01MI3xtoUzMeMTFKqsPwDWOnjzWapctgusCipdeaT/ECQMnjg2f6fM8JBLKAXwU0UwxQJs94IWzVBrI/RsMxRoP80j653JKc1FM68rFQt0CA+91EvgHmJJnEnW+RYV6m+Z8HfY4SfZ/ X-Forefront-PRVS: 0590BBCCBC X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DM2PR03MB318;9:7FvR9kA605qBp6i0gO3Vt8ORp5NGBGTZW9RRN5UZfaY?= =?us-ascii?Q?0qhFwCLLQzslH8QnJc5Al8vCsFxqP5dnIKfzqPbKbrTRQaqEqPjUDE2mqDPs?= =?us-ascii?Q?ETOupoGT9LnpYehN/L+XU/8FVnuBFEpFR4y97tBSzXWXWE30rIz7qdqVJ3p/?= =?us-ascii?Q?NV3arC49So4l9+6YtFEbztczgmyLuiNAMIzF70LxNtPsl6WP/zxHA2Idz/KQ?= =?us-ascii?Q?r0+h68VOCQsSjuJrMzFcEAcMXpF1e0JFLXNAycnltw5WZvfGSZqp+xNJj+ri?= =?us-ascii?Q?J6UaqXItEtXKmS87QR5aka+lM7t5ek+Tr2NQOrxtd0QmDE10ViiB9Ykq7sLT?= =?us-ascii?Q?BEPs74iP8I0c9UhxhPA+0JmXhxgTDlAAKyS2gsEpWjBAbZxVYuAZG1Nwqign?= =?us-ascii?Q?7hIXqhvAYMV4U0Oq19VbWzIL6+cmVm+U0MVdtaSPZMXRKmIWDLSSOQ/2+66b?= =?us-ascii?Q?c/nZ2Vo5/qL3qkDNg3d2JBF9SemyaeZ58ZAipS2VLdUP+pOJQhcla1nENftr?= =?us-ascii?Q?I5/K+ug3KcOljN38sq0Q6hbGYtZVL37asiGwsgNLt0N6wL9E1/mA/iC/7Mbf?= =?us-ascii?Q?NM7sibzxwf4mCwCZ9VIRayC5XhrLz3d4RFmRrC9P2OEjAnw9bkOEih5B5W/V?= =?us-ascii?Q?wCO+eG2P6DqTUSGpByEeJRAuXDvwNGhIz0kQQ7gyTNMBdMd4wAlHZ6uMew9b?= =?us-ascii?Q?HAqfXNFm6aWahwoy7fgfP+cG9bCdklZaU18eN+IUp6Yy+5xniyStaEl9TDUh?= =?us-ascii?Q?ukh/nw0QMuqeRZGOvNXIlUvikqDC1mNvilnGhpcC5v+RlJJbCLgzzOXs1lTi?= =?us-ascii?Q?QE2kd0rpeG6d/GSqHm6XOs8V/SbscDZAbX6Ymc/nhFRxQ+o8lDKObU0Gk8Pd?= =?us-ascii?Q?AetFRLohy1/muRxtabkO+XKeIjMJ9G7C80Z/VCuIjbEFdoYKpq2K56RxnGxf?= =?us-ascii?Q?Vtxv42JyXDU5ixKQsZH+JCtRQ71v08VXolkduWvncKRTrV3Ieg9SobEvbQ+t?= =?us-ascii?Q?kvJZPO2yE7PyS6BRaQ/AnCqXfyCvzyefOslRrvK5SvaTlFi/qqj4bEtoQq3N?= =?us-ascii?Q?GaP7nLUj0thmV58YFTJv7m5MUcwDKfh7zS/Gz3lq7AKC/tFLDJV80inXKPhW?= =?us-ascii?Q?sGUKjPCwMm6FT6VSBAueIVFb9qjGYuC1amNBFoFaZzCUaIEH5ga5leQ/mWZM?= =?us-ascii?Q?7jjFvIsVgkrTwl+veCOeI2vSLHP1N6RDA?= X-Microsoft-Exchange-Diagnostics: 1;DM2PR03MB318;3:N/jAv5kvkkjouWvDcNI053zR9wEv2W8Y8in36ZHnpujlcw0jiFXyn4HLZwGZ+Oh+fHRgWNishGLdpnYKZissll2f3BGwPkCDXjSkRMcJdcdJh2OHos6OzjM1WxfSnZTMKpeBuCd51hBrspShArEkYQ==;10:nNRQRaxjTf/ZHZpVaIcGzQ+Tc8cyGam3McdRFxv3ouBI+M72fa/xdOLTyRhf9RTMxvYNXWjrawCHHcEILSIGRya5bdaXWEmxivG3y8sSSeI=;6:riIaKsJs+5fP4OT6fXMquHAqFpw8QwoB+c4bEo0KZd7R7CCT+ZmvY0rewzqQv825q2a0rIfHFa+bO6oX/rJ3cM66qkQjpiSnGVAeV11HI0staw39AsoPVcKe6sFZHyQcnE3fMjEi+fJ5I/a6eZQgnA== X-OriginatorOrg: opensource.altera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 May 2015 20:25:31.0136 (UTC) X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a;Ip=[66.35.236.227];Helo=[sj-itexedge03.altera.priv.altera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR03MB318 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 26 May 2015, Pavel Machek wrote: > Hi! > > > Thanks for the feedback. > > > > Yes I agree. > > > > One possibility is that I could add a suspend function to EDAC that > > always fails with a helpful message like "Suspend with EDAC not > > supported." If someone wants to suspend, they'll have to take the > > EDAC out of the device tree so its probe will bomb out. I'm not > > sure how normal it is to have suspend functions in the kernel > > that always fail, though. > > "Interesting" solution, but better than config exclusion, I'd say. > > > > > + /* > > > > + * This code assumes that the bootloader has already > > > > + * properly configured the sdram controller: > > > > > > Which bootloaders can do that? > > > > Whatever bootloader is configuring the sdram controller for the > > board. > > Ok, so direct question: will mainline u-boot 2015.04 configure the > controller correctly? Should be in 2015.07 Alan Tull