From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754774AbbE1U1I (ORCPT ); Thu, 28 May 2015 16:27:08 -0400 Received: from mail-bn1on0094.outbound.protection.outlook.com ([157.56.110.94]:59296 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754634AbbE1U07 (ORCPT ); Thu, 28 May 2015 16:26:59 -0400 Authentication-Results: spf=fail (sender IP is 66.35.236.227) smtp.mailfrom=opensource.altera.com; kernel.org; dkim=none (message not signed) header.d=none; Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=atull@opensource.altera.com; Date: Thu, 28 May 2015 15:23:16 -0500 From: atull X-X-Sender: atull@linuxheads99 To: Dinh Nguyen CC: Rob Herring , Pavel Machek , "Arnd Bergmann" , Steffen Trumtrar , Pawel Moll , Mark Rutland , "Ian Campbell" , Kumar Gala , , , Russell King , , "Delicious Quinoq" Subject: Re: [PATCH v4 1/2] ARM: socfpga: support suspend to ram In-Reply-To: <55672F32.3050506@opensource.altera.com> Message-ID: References: <1432317735-29413-1-git-send-email-atull@opensource.altera.com> <1432317735-29413-2-git-send-email-atull@opensource.altera.com> <556479C9.5070208@opensource.altera.com> <55672F32.3050506@opensource.altera.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [64.129.157.38] X-ClientProxiedBy: BLUPR08CA0069.namprd08.prod.outlook.com (10.141.200.49) To BY1PR03MB1514.namprd03.prod.outlook.com (25.162.210.148) X-Microsoft-Exchange-Diagnostics-untrusted: 1;BY1PR03MB1514;2:1KPoOO5qK6BgCVh1/WM2KuvR5Ff3eahlaJ0l5sA/XXSsFjEtqRlV3BHiZaeWXo6s;2:lgYOwwRnotn2y2kzrXZAmElxjy0dxuk4fQUYjmFBzIkfjHWap/8HZGCFD5fZ1jVjwADWiIjAKQg8oPgmvKHTZjdKMS+aQD0L3hvem9HtHdLnvs93usJ2ttyLt/lLE94Z+pI5jzc7qD2zFan0jddVRA==;6:yoR4CLu4quVYBsxftETpIdAT7dOwIjky+f5ABe0ZSI8S33gFd8D0m5OFZFpION/fONmPkgfFV/L0aE3fGOUoMYhP/f1mfKkwHCv5Sx/8F+0AHS+oDU7HdD84LUZj3zqVvnywyeqCzTRPbIvBByPfQQ==;3:gvXpthD4TUCCKnGW05QvdPp+od2MQipc+em8y/KpaB14c0jDYU0Gt8PC1hUKfNsggdx1dLj0njZVl0VFWosItdTS+aJXm5G4xK7Jo1/4MSWPwT9uXo4ganDVgDbT6++6RVeLmwnM+f2FiLvP90fqtXw7ibt95hnAvqS2M2ftRSC2Bz2f2zZ4Rqnkm45VrwoBgEmDLk2NN7x9YEK9FbRJr9aX8PVaBBIOZQkhgqUXeXS56RojppPfw1zyF1WfngUKewgrsXY3Y1WXGuTqmWbV9fuVQclv5ztD5H5+xE8Czw9k5Ud9gpUpT4W8c3+NFXU7 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1514;UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1503;UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1440; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:;UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(520003)(3002001);SRVR:BY1PR03MB1514;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1514;BCL:0;PCL:0;RULEID:(601004)(520003)(5005006)(3002001);SRVR:CY1PR03MB1503;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1503; X-Forefront-PRVS: 0590BBCCBC X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(6009001)(51704005)(479174004)(377454003)(24454002)(189002)(199003)(23726002)(86152002)(106356001)(87976001)(76176999)(50986999)(105586002)(101416001)(46406003)(5001860100001)(42186005)(50466002)(83506001)(33716001)(54356999)(86362001)(69596002)(77096005)(5001830100001)(92566002)(66066001)(110136002)(46102003)(4001540100001)(40100003)(53416004)(47776003)(93886004)(189998001)(122386002)(77156002)(64706001)(19580395003)(19580405001)(68736005)(81156007)(4001350100001)(62966003)(5001960100002)(2950100001)(97736004)(4001450100001);DIR:OUT;SFP:1101;SCL:1;SRVR:BY1PR03MB1514;H:linuxheads99.altera.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:0;LANG:en; X-Microsoft-Exchange-Diagnostics-untrusted: =?us-ascii?Q?1;BY1PR03MB1514;9:pxNC5jNN5vZYMMDbpH30D2c78Kt1BmihwwyRiB4+29?= =?us-ascii?Q?aHN6tttMTVCQOhZKJqirI7a5tqK17TJxFbznYm1lcyYzl7gnKjFdAup4sqZB?= =?us-ascii?Q?UMhzmRzbBCfNLggw4HcbeEVw0RQ81wdC2xj4aEwd9cAJgSkn43xFz+uJX3qv?= =?us-ascii?Q?eqR+muPyvaOntG0gXZG454LWw/bCeTnMDxTTJkAItfkleSvOFNbZsBd1Y3k0?= =?us-ascii?Q?vbaMnS0+WG+WxQd/W5sMM7CHDXr7OcVlMzKBjwSNX2qISD8iUCKKZSvtGjm9?= =?us-ascii?Q?7jyNUUzwC0wPIIG4/pFa6DaNmMGNxUdO6q/XsQIoD5jXxBKkpeZDYu/4a7t0?= =?us-ascii?Q?a/aVQ52iaYZnbvkFJwp+5wxJkuW8+/pMnNyndk3WGOfQFBFJlA5aL591fQ19?= =?us-ascii?Q?rX0LpNtmepXeNWfVqlZgw0JrVv+XHT3v0eIhG2lDfSG/PGEaBEhHcyFHa1R1?= =?us-ascii?Q?rOQX6CDrTlUHYDFRi8sxLhPXVUEu9bYFcNE7oxWGQQdoJmkJ1VPfzSwL/3LW?= =?us-ascii?Q?CqLP2tW7O5yfH42qDS5CnLaGgGw+eZbekOfJo9vefwHxBrVM4y70ebgqvPwG?= =?us-ascii?Q?8pUHrF9rLmLkqtBXiQTNgeWl3oFWj4rYOeACdstnog3/n77aJ3C41VnZHuzb?= =?us-ascii?Q?jzwdrzCOvwLPdeZOe4KqeYU9YVcYO1QC03ddkaoaf8GGXbiDu1zBdskhz0Gl?= =?us-ascii?Q?acSTKncIISfavqZncV9kbghbLoJVQ7A8fV+2MtJAH+DdBpt2Ok4OL6Q/HRXM?= =?us-ascii?Q?xjOU/0cQQvL6RNE78tI73RThVfiAfQ+gPp3CY0mP1nluIc/WdyFo/4IzqEXp?= =?us-ascii?Q?XMPhkRiGxYW7NNeJg2HAQYOyVbVCFlgWZbeKInzIwzWkKInJWkUE/1w6s6OD?= =?us-ascii?Q?thnG2C2JLiAwrOc2Ih8g17ViYhLNa8/dNcIgssgoy2TgbyrREVtuhe1tOEHf?= =?us-ascii?Q?lvydAMG38i/WxXpPn+tZujoLqZxzLXOk6I0WFu+h/EKWcMUquf5y5p+VWACy?= =?us-ascii?Q?ZytBJoYjSUT42xL3hY67k1RKCtnVEULchli2e3diusumn4x8WTXEVFZqGn0c?= =?us-ascii?Q?OrBvoSmFHxx3zNGaMrXWq1B3j2V+PXLVdXqq4FbJoYiveuVs+lKXsUAVmAtD?= =?us-ascii?Q?r3aLFwxB3KGf041oVY9kUaWYn/yrYAMJWXx1eVaD7T/AHfwmiy92/xtnG7lm?= =?us-ascii?Q?pPusNKdRycOlnk8pWECcTqDlyaz7bqoTkp0vCbLt7xcFKvUs42/xxLqc9JxQ?= =?us-ascii?Q?eXfxYYErMYXn2CQPbYrxOR09B0H/z/6rDOCOnoLPXmTWzOYBLcyvlsWThs6A?= =?us-ascii?Q?=3D=3D?= X-Microsoft-Exchange-Diagnostics-untrusted: 1;BY1PR03MB1514;3:iyZDDHDB60LpYdnleot1NSsXvo9Ho/EwYG9zP+0lrXquvZlRGMeOuRbBCL9Dv/LbWl2Zs4Gl8EtArBo0Pg0YTOh7E1LeDJbyWD9WXVhWUHpqxK4wsSYMI21BVaKhqgo3qM0Z31rX7ZmIBRAFpc3ATg==;10:9KBdyb8K6dtgRh47eey/MW4EWjhAXT4eCJlnSjAUPq9m+lWE4uVuh/DSnOVPXatGFM9YZvwkcDSA5C2MrOydtGOOWmiAjFCXGqLxo0O6Hlg=;6:KpgupCwNenU7s8zuu0KpoY8SvxXCs4nAlvvXLq2jxzmgN7sbvm06NbLAKVbxgulkvMrMZb/Du8JH5/nzseWqtYU2yT18RgmuiMxbaCv7j/uw6ZPI6TTYD6YKRQzfIdbxwNRUOegoSxj0v3jH3HStdg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB1514 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: BY2FFO11OLC002.protection.gbl X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11OLC002;1:qrgyLi98XuyNVsaXKNba2gL/btarIIfTdfi+fEKXt1F2c+O8KONkdsRVgs/8hFo4Ozcr8MkzVmWkFfTdsBTFGRNHjyiOAwexh6eU5rUGvEkzkVSX8TxD5XBZyI/jpWWbSxiRNMii+NZlHa9STNohL2RSLkxRpMeYPrsBoClya0AwjaQYHGpFhhCHUzZo4o9hg39KeE/Uo5f8wzK9xebXURL8l4J2ZW+S5G1CjumJJ+eOAUY0C0SqA7LxipdPhPjhfi//X2bQy2eIwKs0r8NS+wITxE/jW55/tMJz9qxdI9EMOL/afZq/qyQE1zIGrswf X-Forefront-Antispam-Report: CIP:66.35.236.227;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(339900001)(479174004)(377454003)(24454002)(189002)(51704005)(199003)(106466001)(62966003)(16796002)(77096005)(122386002)(105606002)(2950100001)(53416004)(68736005)(40100003)(97736004)(33716001)(4001540100001)(81156007)(4001350100001)(86152002)(6070500001)(77156002)(92566002)(93886004)(19580395003)(46102003)(5001860100001)(83506001)(189998001)(5001830100001)(5001960100002)(110136002)(5001920100001)(50466002)(64706001)(66066001)(87936001)(76176999)(6806004)(19580405001)(86362001)(50986999)(54356999)(47776003)(46406003)(85426001)(23726002)(7099028)(4001450100001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR03MB1503;H:sj-itexedge03.altera.priv.altera.com;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;MX:1;A:0;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1503;2:zBYtQXfdbVZ00LjQRXcQoySmovW4AWyV25QAnnPlL1yilYEsx9Q6nvoxVEHKwQC2;2:oVbSs7H3vt2RCkRKnRVxtMTpnKfvBLKdaRV11RLJ9l/MRlMgO2kwA6cKqgRqj9vH1Zc0pOHQ0yRR70AxLR5r/Aaps+W7uVPMejf/YZA/p/0G9RDaNNBGOqmIEL1ecku2P7brX8uaOAUSe57CLN5esKxLp/JAfQ1DU4WOBz9CzHZUG2URq/9N7rFoL8o+cc3ffexUeYnoDpluhckrGw70ui9e7ynMJkQDxPtQBXPQa2M=;6:ac45eMrsottzkcogS5c5Ol5Ha7EPNfTqt/7PESoXP0KSYlc6saTV/yzKZfOhLG5dawF1h8z4nHnjmDoZ6NVMr3guM54ZVrW5grBllM+8fq9No3GYj5jYyfTMYFPIrZ3fqaAfUIU63wXpFSPg8s3eGg==;3:cuLBtO0XFk8B6RQ9pUuGyL9X2tFGPZkXtGBzPNlkmGnvVBXLaDbqClarJETZqKbIPLQvPk1RrYWwygfgt9ym72L5IZF9KRQa9P2wwCJeyKQtNu1HsPqv/9or+2XaONndmkLY3wpvES4iW467uQFhh65vDkzFCQkv+hDxiAaL5XRuJBxO9Pfm/hbcEYuTqz7CgDSueGsHkUmbjcKT7g8bA63tsL9HJzPzpR8U1KeZ1lg2P/1vEncwiR26kSg19MnBbuMmH1N1irbcTq2U1F+Cbvn/6iKiYjITlsb256JeWgadYHn6t4zyCePaYlI3GteY X-Forefront-PRVS: 0590BBCCBC X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CY1PR03MB1503;9:eUBqiDKNiXrhvRwmtcRbsls1Zl2w4hJXd4GhQytlSU?= =?us-ascii?Q?1QhY09e0C35BIbBIsJzl0vMG94dZbHa66euQWNz7dc3yzj0DTRXLl9YEpcb+?= =?us-ascii?Q?rqRVsSkuuR/6FjTaCrGg+jY1fd4b95cjjxKrN0TgYzgLvwVN8k9OeaOu8raO?= =?us-ascii?Q?pfipm4rl04AF3CkYDRWrRZuPiRIZm4wSnvcJ4JTcvqoDfn7uYk+DScsFXOkm?= =?us-ascii?Q?hZlYVS2JefE/PsMZ2/zf7dyZchOl2s/7YLLNHB6XJU5V5XSz1r+ChH/uYgkl?= =?us-ascii?Q?i4n9CjCDSJ8/TP1uco9YhgWz8/U64SUz7z7ACtBsgZ+58/NzlSJnnN14bBLS?= =?us-ascii?Q?IFX6OxVyGNsBNGzPHq56W47zClaybR/ZotHKUwoCt9wpwJehRmMZZd6rWfIU?= =?us-ascii?Q?mQnT02iR1K5gnDCXc3DgWHU8D9fxFk10qPcBE746AOAppNnf073sXddHxYLP?= =?us-ascii?Q?KKq8EbvwMaGy+dazi0/wdf1xKzgz8Vt5IFzKJc+CNIC8bqHRLsZqQFpMM/nM?= =?us-ascii?Q?VVZ8YwNQRokMkcP+ghsOqIgACBc0ao70Huc8txvNUBz5utOvEZForZXX9fma?= =?us-ascii?Q?XXLfYQiGUYO5LeBZFEgejke46xbHjOrp5yjQ+oVaEvecQl2xVehUGNKc+g7w?= =?us-ascii?Q?ubv2Fi1Lmqqhjt+q6iihX5lJxsFDxioSWHG2x3t7WFbwOMSlT4LP9JbLeEiB?= =?us-ascii?Q?/k5fzwJrnzI3W1J4TolgdTvr8uw3qUpJBhHzGjsNjER2xK62E/Tvn9zlW10U?= =?us-ascii?Q?HFj12UWnLjK/4pDU8JQIkjZXIfSlkJcNPNRL4MLMf/p6FJA/qKiDL67ztLR6?= =?us-ascii?Q?p4MY0Dpep/yxfHZUynDGzHGhBrqlbZamsswfyQv/02fFfnqao86cncD4udkI?= =?us-ascii?Q?l7oWB7ChtZZUF7I4QfYARXqXpjKyOkhhKmskygtnlaFbiYvfc+cb9uTj5UfP?= =?us-ascii?Q?yxCpeX+m/d4Tt88Cb/A5ZgFzEXAlcgqN+bp1ajoAiaJxP4bO9KlGWLN089mE?= =?us-ascii?Q?0mu78TnK6+txTblmmrvCpTM74JXhrCyuFUbtlP5MVEMikUJ7W+9PjnlVjTTD?= =?us-ascii?Q?ZT//JEPuUgF4GLoAVjUTUlB4QoLvT7VCejlnkNsSyAKr4dTIgBAfPmIQvFKt?= =?us-ascii?Q?76cPmOLyT6j1TQ19xY7B+d/nLUMCSU5MLNyU4h0mU69cw6kxZ513MLHEeL1d?= =?us-ascii?Q?axAILqcKd8tL5lH+VsUvJ0QDtH2eBvpsTyVu2aPLocrbpv90d8ZmJa0ig7xg?= =?us-ascii?Q?B7D8FcVS1UuFjk4LVLPv8EGs1cfg09EGNlc3OHqYWjP2K4Y8pmwOfBESWYkC?= =?us-ascii?Q?zi/xBcTC+yI0av7em99B4+y8a0XVh+VlYxKuWEqiUMeD6XT5pPclRmOW92SP?= =?us-ascii?Q?Se5upcqa7unk1yhXHHzssiqBs=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1503;3:Mu8l2A3xOWAW3JWwCG4zEMoqAaX57EbDifaTOn3+3CIFWi7CM8SQG9F6QOJS978MQFkbtSBj+X2MojPB+S153ihZHmIakY56EngW3A+JYKPGLhRkR8taHB5aZJtpQHjs8re1qNGfTWkHGgJcYe4CVQ==;10:6gXQb3BbAI0u5ryGWt+6wlVreGrWHmXsViftyV+X76J1PrpjdWsdcCt/p1RyIlG7Ra8nGeFUoHMkubO0v5RZzTEpq4DR/UNmt63IkqtQXto=;6:1yphfnt19Yr0mg8k/foaB12Rmuof+VlJpjo9zSm9XSqHkEbcY7pr9i0X8q/htbeRr/WvVgSMBU191SrEQBEKTXSLVSnowvhATGA013j3FqTdqDPbnUXYKSUzYSyvjl9M6ldAhhN11SZZeyuSTBtW7g== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 May 2015 20:26:53.0048 (UTC) X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a;Ip=[66.35.236.227];Helo=[sj-itexedge03.altera.priv.altera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB1503 X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1440;2:epoo32zwOwO3sLV8y3XXeS8mA52uR7BHJ72onlCWAoc/nPV+zFvtavq+PFcGBx9B;2:IhnNxTHoT4D8kcJ2vkO+t6PAO7CfmTfQnvUZ8CQ5Cyo4DYFLBesCtaXWYQ4JzU7IEbIcLClGCPHHlnlgdWgf01OZlrzm0NXw8PslS2xSfjkI8KrWIuT8ol/fEvMBOOG3UlRCgiP/lY3jGQK2DH/qB6UnwiB2zZdlZ/cylAknkgaVl/yRLRIN7ArwgEd/LPjo3muydK6Co9JwUfj7ZbNyaqQeTeqrUbifu9HWiuW26dE=;9:3aUNWKbKcL7d1J+2pfiIjSkE44IVUq4p+MfOmLuyjakYEqkiNNqIp/RKxcTAxi3clnWI4tkWIh6kAQIvKEBIQfsiCnXBm0snSeaswzOlQ5XJ9HdkNYHvPkVLskIr6ERU3cMBzm7sl2yNt9TZFiFcoA== X-OriginatorOrg: opensource.altera.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 28 May 2015, Dinh Nguyen wrote: > On 05/27/2015 03:25 PM, atull wrote: > > On Tue, 26 May 2015, Dinh Nguyen wrote: > > > >> Hi Alan, > >> > >> On 5/22/15 1:02 PM, Alan Tull wrote: > >>> Add code that requests that the sdr controller go into > >>> self-refresh mode. This code is run from ocram. > >>> > >>> This patch assumes that u-boot has already configured sdr: > >>> sdr.ctrlcfg.lowpwreq.selfrfshmask = 3 > >>> sdr.ctrlcfg.lowpwrtiming.clkdisablecycles = 8 > >>> sdr.ctrlcfg.dramtiming4.selfrfshexit = 512 > >>> > >>> Suspend-to-RAM and EDAC support are mutually exclusive on SOCFPGA > >>> platforms. CONFIG_SOCFPGA_SUSPEND enables suspend-to-RAM and > >>> prevents selecting CONFIG_EDAC_ALTERA_MC. > >>> > >>> How to suspend to ram: > >>> $ echo enabled > \ > >>> /sys/devices/soc/ffc02000.serial0/tty/ttyS0/power/wakeup > >>> > >>> $ echo -n mem > /sys/power/state > >>> > >>> Signed-off-by: Alan Tull > >>> Cc: Pavel Machek > >>> Cc: Arnd Bergmann > >>> Cc: Dinh Nguyen > >>> Cc: Steffen Trumtrar > >>> --- > >>> v2: use Generic on-chip SRAM driver to allocate ocram > >>> rm fncpy_align since generic allocator handles alignment > >>> check __arm_ioremap_exec return code > >>> check for NULL pointers > >>> add a comment regarding sdram controller configuration > >>> v3: fix renamed #define > >>> propagate socfpga_setup_ocram_self_refresh error code > >>> v4: Kconfig: don't need to select GENERIC_ALLOCATER > >>> add CONFIG_SOCFPGA_SUSPEND > >>> make s2r and EDAC support mutually exclusive > >>> socfpga.c: add sdr_ctl_base_addr > >>> return error if ocram not available in device tree > >>> update copyright years > >>> --- > >> > >> > >> > >>> + > >>> +static int socfpga_pm_suspend(unsigned long arg) > >>> +{ > >>> + u32 ret; > >>> + > >>> + if (!sdr_ctl_base_addr || !socfpga_scu_base_addr) > >>> + return -EFAULT; > >>> + > >>> + ret = socfpga_sdram_self_refresh_in_ocram( > >>> + (u32)sdr_ctl_base_addr, (u32)socfpga_scu_base_addr); > >>> + > >> > >> I had a patch that removed socfpga_scu_base_addr from being a global and > >> just a local variable in: > >> > >> f6e14376fb20 ARM: socfpga: use of_iomap to map the SCU > >> > >> This patch will be in v4.2 and is currently in arm-soc/next or > >> at my fork: kernel/git/dinguyen/linux.git socfpga_for_next_arria10 > >> > >> So you will either need to make socfpga_scu_base_addr global again, or > >> you can use the asm instruction to get the SCU base addr. > >> > >> Sorry about that.. > >> > >> Dinh > >> > > > > I can't make socfpga_scu_base_addr a global from platsmp.c since that file > > may or may not be compiled in. > > Ah, okay.. > > > > That leaves me with the option of adding the code that was removed from > > socfpga.c back where it was or taking that same code moving it to pm.c > > > > I think you only need the scu base address in > socfpga_sdram_self_refresh(), so you can probably just use the single > line assembly code to get it there. > > Dinh > I realized that I don't need to touch the scu self refresh bit at all here. It's handled in scu_enable(). Alan