From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751319AbbFHBEh (ORCPT ); Sun, 7 Jun 2015 21:04:37 -0400 Received: from mail-bn1bon0068.outbound.protection.outlook.com ([157.56.111.68]:57152 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751253AbbFHBE3 (ORCPT ); Sun, 7 Jun 2015 21:04:29 -0400 X-Greylist: delayed 852 seconds by postgrey-1.27 at vger.kernel.org; Sun, 07 Jun 2015 21:04:29 EDT Authentication-Results: spf=fail (sender IP is 66.35.236.227) smtp.mailfrom=opensource.altera.com; alien8.de; dkim=none (message not signed) header.d=none; Authentication-Results: alien8.de; dkim=none (message not signed) header.d=none; Date: Sun, 7 Jun 2015 19:46:20 -0500 From: atull X-X-Sender: atull@linuxheads99 To: Borislav Petkov CC: Thor Thayer , , , , , , Subject: Re: [PATCH] EDAC, altera: wrap edac pm with a CONFIG_PM In-Reply-To: <20150606080126.GB545@pd.tnic> Message-ID: References: <1433512155-9906-1-git-send-email-dinguyen@opensource.altera.com> <20150605151559.GK3679@pd.tnic> <5572174D.60804@opensource.altera.com> <20150606080126.GB545@pd.tnic> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [64.129.157.38] X-ClientProxiedBy: DM2PR10CA0066.namprd10.prod.outlook.com (10.141.241.34) To BN3PR03MB1509.namprd03.prod.outlook.com (25.163.35.148) X-Microsoft-Exchange-Diagnostics-untrusted: 1;BN3PR03MB1509;2:uUDzs6XegXKbrn4pB1EA0N+f91uyz3y+V4pJQlFXoWtWO8LPFHYnWdG0VBTTxdTY;2:CJAymjh2xCpV9ZJ33wSo9QiRrUqM8QWHgh06twjoUtt6PQiwYTyh0t5Yk9Ie/+rPWyqsRYULp69Za9X+7xeywpb1N2RLLJ6KKJ1QcmLJGyLDKT7Ssh+MZQN+9Lr1yBiRHVq857WVGE48XRDR8yZL9Q==;6:pNMK/UT8qk+4nAGqd2ofeWpQBeAmHvFYpl/0P85zvc9zJGjSrskRC8AzKfkQCeUybK64qHiIcvY3d6TcZHwQERTJAmQkkQIBKo36MYh2AM3WUfISXRZMkaT2DVBiHmWfDSyFHfhPa3CkfloSAB4oRA==;3:ZjrVUYsEc9B67DARJzD9VmlFmV23jzPfLo8FOhF0lTAOx3MzgQfN+n+0+tPSHd/yVcfeSr0WsKHdV/Q3Wpn+ZgqtG4pSVyRhkrW9pVj3ighgbYDK9pkCU12UuCzm5+CsgHRUhqCBqQx9pzBOZuLo6JvJAVIY4JQj6P++vrxeMdfU4gclmoEVduu3cRHs9R28TQJBy8DW5bmaIZNihsb3DC8xPP5uUM0SJPOzyRlcFdz/kARZWp7Ow3jPPcPF7yoPyU0wouQXIf6FZ5G3haMIZKaoUiFEeGcJ2T7jlFvEzUENVcbVDZjq8XauVwtrCnv8 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1509;UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB119; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:;UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(520003)(5005006)(3002001);SRVR:BN3PR03MB1509;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1509;BCL:0;PCL:0;RULEID:(601004)(520003)(5005006)(3002001);SRVR:BLUPR03MB119;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB119; X-Forefront-PRVS: 060166847D X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(6009001)(51704005)(52314003)(24454002)(4001350100001)(87976001)(122386002)(5001960100002)(50466002)(33716001)(47776003)(189998001)(86362001)(66066001)(92566002)(86152002)(110136002)(83506001)(50986999)(62966003)(46102003)(46406003)(2950100001)(15975445007)(19580405001)(42186005)(93886004)(54356999)(77156002)(19580395003)(77096005)(76176999)(53416004);DIR:OUT;SFP:1101;SCL:1;SRVR:BN3PR03MB1509;H:linuxheads99.altera.com;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics-untrusted: 1;BN3PR03MB1509;9:1QAjewa9vwkHbDAJiLAkPp5Wz3BLCPjibr8jOFh5PXlxGgW6S+g/BUXwZF6qXweZjeATIBfFHYdwWYOHzQo5l89wMk5jRsQd3z0bRrh5i9o7wyovuDyW4tHNjnvVwkYK9+Sz/n6Y+awqLHyfdsD/ayq2xQyQM9H2bZW1eXDryzMzUVHnPQRI0B2Fb61ZI7afYVAnC/HYqghe/ezJjUI7shTnbxBPq8K0w560TImbzFD0CF711QeCI+PZKtNdmHK7RDi6af7dVX+v6KIN8z+lbusZTzYnS5RSOnYs8rKXpcBQdUn3MGLrRTbtv/qQDhjf8Guv5DmChbSZDlGFiJrPJpxLUFCzJG08mjhOl7R6A9r9ZrDPmv42pKCb9CVazHBZ9iSE6eD3h8S/PgMcb56jmq9MuRuF6TsvkdqUOBi6OAGTAd4FDoBtQEn9TQjhSILACFHlPm+SDUihWnO5DfIQUyNVu0ua3uVFkdR1uxt2WNf/aN0JUJwHcNkrYGLJeIgFURD1FLBS13SeNhJQt1YmKiqsUWulflz707hejkWaOqrJ6Wt6sSTZvODl5C6iBV1GTOe048JlI6mB8deQJw9SJ2IinE+C1M98NJDAHtw1wmPsZVYw8gNL4Q1A8c/QVTnCpmg7kOSbPhY01vq7w1OtOaS819Ns7M/nkW9uqIa0L8WLB9JUq1FNZ5iOHQEVnc/dvqSVmzgp6qyxvRM2Y52wkrbxmPn9R8UCfyP8fDa/KOBmWNhmmEzJAp8uLMcT+88WfmpGHUOEOwq6Rnhm+PUNCrpu3gpUhtUei2j9tVMKmmg2hxXAH3yMbfsQSL8wKY95Y47b2zFzQNA6AuKOREyOSdP95dnRl7LTJfjmsVAnDJLFbEtgIoY5Dw9Tk6ev2IWn2SIEkUPPeJcExeum/dOg3g== X-Microsoft-Exchange-Diagnostics-untrusted: 1;BN3PR03MB1509;3:VHCKvzcQiIE0HfCwNvqctJSGj9jwwUB0QyMcWLIr7pK2rojWS81+uiO01VI0DoEv4woUCk6p4gbRke7ueqiXd6G1A1lp2klSb7Aro+4MMtNNEYw/JuqmlPKlVQG7x1y9J6ENNcEEMMGXPoK8QGd8bw==;10:CUNv+VIHqtPAQq48AHib3Zw/cOhqbXWxcEBxeGlEmVKDgWYdrmeseJC4IuX1IIYLjIRVqZQwcKBIsUvRNNgFURGMqTAlj63Pus6QrSl4l+E=;6:I1u0BjOjSoDAmio2onks7dZ8H5dkqOYTEBDDYaoaCPkI24NDfOZpLe4qJKv/kH2WZKMaNoA9VlE5HJant+mmPn7knJFOYQStvNfOvaJvsMq8hFmb3TQLZ6tPPpx4Btad5MxNBzT26lTdn67U8sYxeA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB1509 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: BN1AFFO11FD026.protection.gbl X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11FD026;1:64H560tB1/tcc9C5lVz1oGw3EiPOVsL1KC6VQSs6OULh8kUw4nveGEOLlpIb5U0qrCJiP2zXkYoRp8Bshk+xmggqaxASaZEXgaivazwq3asD1614W3rPn2l61aj/DDyaCKTjZ4YoolEwU+V6HRHMBknAKCfCuFQ/059bV+Dpr89O+1lzWfRNazzAzEvKQspLk1OYIhk0uZQFFaRGY/TGBpXamxRDmwNfdothPGAItLBy0PvQvL4ujUgARYTfgJTObXyfn4BuNYQWwrey78ofMw== X-Forefront-Antispam-Report: CIP:66.35.236.227;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(339900001)(24454002)(189002)(51704005)(199003)(52314003)(110136002)(23726002)(4001540100001)(4001350100001)(46406003)(5001860100001)(53416004)(50466002)(106466001)(46102003)(5001830100001)(5001960100002)(16796002)(105606002)(189998001)(122386002)(50986999)(76176999)(54356999)(40100003)(15975445007)(86362001)(83506001)(77096005)(19580395003)(47776003)(86152002)(66066001)(92566002)(2950100001)(19580405001)(62966003)(6806004)(77156002)(93886004)(33716001)(85426001)(87936001)(7099028);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR03MB119;H:sj-itexedge03.altera.priv.altera.com;FPR:;SPF:Fail;MLV:ovrnspm;MX:1;A:0;PTR:InfoDomainNonexistent;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB119;2:r//uBKMnHokegPP0G6TbXX+Z7OL2A6YZbc8iwOpDIza5tNcMqaki1skUXMG8Ujmp;2:jXn7SHPnqNbFcRuY+3Duf9MRLc8I0aNxv5zYLS0GP/5sN001b2m3gjQzAUG/Iug0nuxZtahqmJigs70jf/ENuF2FwofTXodx06Oni4tQ592fpfWAeTR6f1xPvsd2YgD1ii30F2omfKIX70Rv2oT7HumPpAOzNcDBx6NRoTD1U5ebfLd2eXm/IwqHpEWfBZCdkLRa1B7fma9rZKQEYxU7ZufSyIYLN2nktHovoz6WxEo=;6:2xHWXJ6tA8hx5Q25DwIRZqd9dtxU8zMCjbP4i/oGyML1CtBB3Hz2osUyuTriqfo4ygzJyY0c3GnBbK5Vx0/xT4fNhg3kBpjarZkapIq03nVjqeKS7qguy7hEgi/dAQ2DrpcQEN75iaO5hJR52m57hA==;3:+CGtP+jA+NMcnC1BNzief70S+sr+ZTxEEnTfyMuLM2AaYtEpeMtktOxruSJUKv0vFVVq3uyibG6kTFXRiAefbGK6dcPJPbq7Lcii4zrwCKWMqx7cwG6R9JPPdEMtSe0ElxGJfUf5Lyp3OslkU9qTv63HMXAgiU7LZY8oNwiKUiKxOxidapoTYNqtDE29Q5OpOFnT0gYrvB9lR73WkMYuZFqSxJ060K3ZGSL6EQ0s6Y5adrP3qfdN4V4xDfNNEKuYiBdo4UwiXn/rb+lBkw9XpEE7geQfHVa/96WfMUeJCU07kMtUWO77iOqA8pP2Sc7i X-Forefront-PRVS: 060166847D X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BLUPR03MB119;9:PRuDQ7Huzl/Fgn2+4Q6SUXo39srDDbYEdEADm7P2tKp?= =?us-ascii?Q?YCWQLxbm9VUQStIBWmF4TIz/4W3pHGwDtFECqpMX9yiZF6omjB1+mq4kVuQA?= =?us-ascii?Q?zG1ZFy901zaMRuH26wUvIJ76kkodtohi4jhWDlbyMGyRXPLvLgkpFY1Oh7Kz?= =?us-ascii?Q?DgCXjuV4bqVow1a+6VWT1id7a6dFHss8NZ7CjpXbLRfBc9jEK2iZb2vqez48?= =?us-ascii?Q?hqHXlXz+PbwUDn8eU+oXc/6kv9TkmB0RTc3Ny9sbDpZ/P3PQegA2Ii7zpV9H?= =?us-ascii?Q?LmG/WKGr2xUy5rRfsAU6LeLgcFmvxUWpeO+ycHGXj8/EP+AcUMZ6awOZA9Km?= =?us-ascii?Q?nnjGc9jA/qHDfWzSCrd3iSh/IqMy80BuWJe5zNOoh8kddYUy2JXr/EAGbpFE?= =?us-ascii?Q?bVxtVS7qOR7aNyNAP+S/pIxvo5zL6S95BKVSAvuAgUBVietv4FB83XDA/nIh?= =?us-ascii?Q?tZOOfr4+I2rzcTfeO2cC/vkl5tqIp4OLaQ5Yfr7Ggv+5UpRIUjcKZDok58I6?= =?us-ascii?Q?CpMrAH1wi76kcrMjina27anyAGF17Imwap6vBibOUY6wExFGO7CctXbGjyVt?= =?us-ascii?Q?IC+KbQ7XzKNXFK2npNYsAcE6EO5ktg98Mqi2fpqZ1c4/AGWsougULR3Mxgj+?= =?us-ascii?Q?PbvciGrPhygBxIf9wJ8S2GhsuvAJ9k/HLvNDtwETpk16G7L/gS1sS/XhbTbJ?= =?us-ascii?Q?yGnz9VTGOfDSWIjPrenOJ7b33Tt0l93c1KauaU/X0bXh3ieI8kwNlAkvOXyd?= =?us-ascii?Q?ChKSQBXr4dR5Y9DaJTY8wgDCatIz2hbrga5Sfq9LfBH0feoORmaTaEj6llca?= =?us-ascii?Q?o3pQLsULuTpi2tEg1yilmc/SDy2HYpqoYawdfrKUP7vWiaMpJeW9paqiv2pz?= =?us-ascii?Q?y8kFJAH9n/uUmA1vuuY69m+FCUTcxu+jsOq382Eh2RO6tIiYOxf9+p2IJHWL?= =?us-ascii?Q?y1lSJf462KvT5pEgDtGLEVFKHKt2n4upJqUCmsqiatDTKT8r6xql0LoAxGPV?= =?us-ascii?Q?z1ysguZ8B8mVb3AyCYs5UM1d4/ZPG1JqqdW5Avu2qJAEXRpVKNPytcXjvBwh?= =?us-ascii?Q?LHjDX6Twro7eIAIe4hcyT6t04znVh3iZAMHdVfC6f7aagWlLv9u2B/hAFO8Y?= =?us-ascii?Q?yGorVYdqwqXlYbJ7G/XoZ9fdwLpy/tj7z3tSfKxNkpqly1UeJOgpiTtVTkuO?= =?us-ascii?Q?MnNt8UCviApYUPD5yYNtTJiFpqFcRv4t+?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB119;3:OwqpFZsuAAE8Yi/xkP16MHM/y9DbvoA4zZl/u6TPYShUDH3ZLTG5DsHrWWChE7I3SvSqkv+vLzh4WXog7fO/bzxpZXnJX52qUFalKO8Yo26I7Pm0qxAzovwLtKU2egVtxkS3rGFIYbAzkP2O9++K6w==;10:dcJZZ8+oL6yxT3SfXiKlLWKKYHEXv9ych3+lHRJAROyX/UTh0/pE9Bih5zxKmyX01Ol9+EWqDw1lU2+T/up1WDHjljnAYWxvvXXtrrf35zw=;6:0b5qaYM5Si9ds5YEgtm/BPqJCiNnqALsihcIebDMOyXJO8/NDA//OynVFOgZrlVu5mSm8cTM6TTTfN3K1T1d1I3HH9XfwdzopIlmbw7MRq8hi4RAjogJ3nueLYGXBo3rAsGMVgh4KoADteoKiuMziQ== X-OriginatorOrg: opensource.altera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jun 2015 00:50:09.3983 (UTC) X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a;Ip=[66.35.236.227];Helo=[sj-itexedge03.altera.priv.altera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB119 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 6 Jun 2015, Borislav Petkov wrote: > On Fri, Jun 05, 2015 at 04:40:29PM -0500, Thor Thayer wrote: > > Yes, in our case, it is a hardware issue but I'm still gathering > > information. > > > > The IRQ vectors for OCRAM reside on DDR and in Suspend-to-RAM mode we're > > executing out of OCRAM. If an ECC error occurs, we can't handle it so it was > > decided to make them mutually exclusive. > > Thanks Thor, > > that's actually a good-enough explanation for me - I was just making > sure that it is not some silly EDAC core limitation preventing you guys > from doing suspend. > > Anyway, I've committed the version below, if you still feel you want to > improve the explanation, no problem - it is the topmost patch on the > branch and I can amend it easily. > Thanks Boris. That looks good. Regards, Alan > --- > From: Alan Tull > Date: Fri, 5 Jun 2015 08:49:15 -0500 > Subject: [PATCH] EDAC, altera: Do not allow suspend when EDAC is enabled > > Suspend-to-RAM and EDAC support are mutually exclusive on SOCFPGA. If > EDAC is enabled, it will prevent the platform from going into suspend. > > The reason is that the IRQ vectors for OCRAM reside on DDR and in > Suspend-to-RAM mode we're executing out of OCRAM. If an ECC error > occurs, we can't handle it so it was decided to make them mutually > exclusive. > > Signed-off-by: Alan Tull > Signed-off-by: Dinh Nguyen > Cc: dinh.linux@gmail.com > Cc: dougthompson@xmission.com > Cc: linux-edac > Cc: mchehab@osg.samsung.com > Cc: tthayer@opensource.altera.com > Link: http://lkml.kernel.org/r/1433512155-9906-1-git-send-email-dinguyen@opensource.altera.com > Signed-off-by: Borislav Petkov > --- > drivers/edac/altera_edac.c | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c > index 182c741adf3e..23ef0917483c 100644 > --- a/drivers/edac/altera_edac.c > +++ b/drivers/edac/altera_edac.c > @@ -477,11 +477,31 @@ static int altr_sdram_remove(struct platform_device *pdev) > return 0; > } > > +/* > + * If you want to suspend, need to disable EDAC by removing it > + * from the device tree or defconfig. > + */ > +#ifdef CONFIG_PM > +static int altr_sdram_prepare(struct device *dev) > +{ > + pr_err("Suspend not allowed when EDAC is enabled.\n"); > + > + return -EPERM; > +} > + > +static const struct dev_pm_ops altr_sdram_pm_ops = { > + .prepare = altr_sdram_prepare, > +}; > +#endif > + > static struct platform_driver altr_sdram_edac_driver = { > .probe = altr_sdram_probe, > .remove = altr_sdram_remove, > .driver = { > .name = "altr_sdram_edac", > +#ifdef CONFIG_PM > + .pm = &altr_sdram_pm_ops, > +#endif > .of_match_table = altr_sdram_ctrl_of_match, > }, > }; > -- > 2.3.5 > > -- > Regards/Gruss, > Boris. > > ECO tip #101: Trim your mails when you reply. > -- >