From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752500AbbF3LjS (ORCPT ); Tue, 30 Jun 2015 07:39:18 -0400 Received: from ns.pmeerw.net ([84.19.176.92]:57137 "EHLO pmeerw.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752043AbbF3LjN (ORCPT ); Tue, 30 Jun 2015 07:39:13 -0400 Date: Tue, 30 Jun 2015 13:39:10 +0200 (CEST) From: Peter Meerwald To: Martin Kepplinger cc: jic23@kernel.org, christoph.muellner@theobroma-systems.com, martin.kepplinger@theobroma-systems.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org Subject: Re: [PATCH 0/2] iio: mma8452: add support for 3 more devices In-Reply-To: <1435663602-29868-1-git-send-email-martink@posteo.de> Message-ID: References: <1435663602-29868-1-git-send-email-martink@posteo.de> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Martin, > The first patch doesn't change anything for existing users of mma8452. Please > test this if you can! nice to see the driver improved! the first patch does quite I bit more than it claims; it's not only adding more device, I'd prefer the patch split up for review > The second patch corrects how interrupts are described as IIO events. It exists > seperately because it changes the driver's behaviour for existing users of > mma8452. what is the difference? thanks, p. -- Peter Meerwald +43-664-2444418 (mobile)