From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753509AbbGXFvc (ORCPT ); Fri, 24 Jul 2015 01:51:32 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:46810 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752656AbbGXFvb (ORCPT ); Fri, 24 Jul 2015 01:51:31 -0400 X-IronPort-AV: E=Sophos;i="5.15,536,1432591200"; d="scan'208";a="141046228" Date: Fri, 24 Jul 2015 07:51:28 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@localhost6.localdomain6 To: Vinod Koul cc: Alex Smith , Zubair.Kakakhel@imgtec.com, dmaengine@vger.kernel.org, Vaishali Thakkar , linux-kernel@vger.kernel.org Subject: Re: question about drivers/dma/dma-jz4780.c In-Reply-To: <20150724054226.GO29916@localhost> Message-ID: References: <55ACAEC5.7090000@imgtec.com> <20150721041558.GE23525@localhost> <55AFA7F9.20600@imgtec.com> <20150723172110.GB29916@localhost> <20150724054226.GO29916@localhost> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Yes for dmaengine drivers I do ask this question which typically ends up in > driver invoking devm_irq_free() in driver's remove callback > > IMHO don't think devm irq calls are very useful, they do make stuff > complicate Would it be better then to just go back to request_irq (or whatever is appropriate in this case). It would seem that the devm property can never be relied on, so there is no point to use it. julia