From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752323AbbIEHXR (ORCPT ); Sat, 5 Sep 2015 03:23:17 -0400 Received: from ns.pmeerw.net ([84.19.176.92]:37487 "EHLO pmeerw.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751155AbbIEHXI (ORCPT ); Sat, 5 Sep 2015 03:23:08 -0400 Date: Sat, 5 Sep 2015 09:23:05 +0200 (CEST) From: Peter Meerwald To: Matt Ranostay cc: jic23@kernel.org, lars@metafoo.de, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC v1 1/4] iio: chemical: Add IIO_CONCENTRATION channel type In-Reply-To: <1441432406-4761-2-git-send-email-mranostay@gmail.com> Message-ID: References: <1441432406-4761-1-git-send-email-mranostay@gmail.com> <1441432406-4761-2-git-send-email-mranostay@gmail.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > There are air quality sensors that report data back in parts per million > of VOC (Volatile Organic Compounds) which are usually indexed from CO2 > or another common pollutant. > > This patchset adds an IIO_CONCENTRATION type and IIO_MOD_PPM/PPB modifiers > because no other channels types fit this use case. comments below can you add these to tools/iio/iio_event_monitor.c as well? > Signed-off-by: Matt Ranostay > --- > Documentation/ABI/testing/sysfs-bus-iio | 10 ++++++++++ > drivers/iio/industrialio-core.c | 3 +++ > include/uapi/linux/iio/types.h | 3 +++ > 3 files changed, 16 insertions(+) > > diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio > index 42d360f..a3803a1 100644 > --- a/Documentation/ABI/testing/sysfs-bus-iio > +++ b/Documentation/ABI/testing/sysfs-bus-iio > @@ -1459,3 +1459,13 @@ Description: > measurements and return the average value as output data. Each > value resulted from [_name]_oversampling_ratio measurements > is considered as one sample for [_name]_sampling_frequency. > + > +What: /sys/bus/iio/devices/iio:deviceX/in_concentrationX_raw > +What: /sys/bus/iio/devices/iio:deviceX/in_concentrationX_ppm_raw > +What: /sys/bus/iio/devices/iio:deviceX/in_concentrationX_ppb_raw > +KernelVersion: 4.3 > +Contact: linux-iio@vger.kernel.org > +Description: > + Raw (unscaled no offset etc.) concentration reading of data like > + CO2 or VOC (Volatile Organic Compounds) substances with or without > + ppm (Part Per Million) or ppb (Parts Per Billion) channel modifiers. Part_s_ Per Million > diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c > index b3fcc2c..ea9e31a 100644 > --- a/drivers/iio/industrialio-core.c > +++ b/drivers/iio/industrialio-core.c > @@ -75,6 +75,7 @@ static const char * const iio_chan_type_name_spec[] = { > [IIO_ENERGY] = "energy", > [IIO_DISTANCE] = "distance", > [IIO_VELOCITY] = "velocity", > + [IIO_CONCENTRATION] = "concentration", > }; > > static const char * const iio_modifier_names[] = { > @@ -111,6 +112,8 @@ static const char * const iio_modifier_names[] = { > [IIO_MOD_ROOT_SUM_SQUARED_X_Y_Z] = "sqrt(x^2+y^2+z^2)", > [IIO_MOD_I] = "i", > [IIO_MOD_Q] = "q", > + [IIO_MOD_PPM] = "ppm", > + [IIO_MOD_PPB] = "ppb", > }; > > /* relies on pairs of these shared then separate */ > diff --git a/include/uapi/linux/iio/types.h b/include/uapi/linux/iio/types.h > index 2f8b117..dfb8b8c 100644 > --- a/include/uapi/linux/iio/types.h > +++ b/include/uapi/linux/iio/types.h > @@ -35,6 +35,7 @@ enum iio_chan_type { > IIO_ENERGY, > IIO_DISTANCE, > IIO_VELOCITY, > + IIO_CONCENTRATION, > }; > > enum iio_modifier { > @@ -72,6 +73,8 @@ enum iio_modifier { > IIO_MOD_ROOT_SUM_SQUARED_X_Y_Z, > IIO_MOD_I, > IIO_MOD_Q, > + IIO_MOD_PPM, > + IIO_MOD_PPB, > }; > > enum iio_event_type { > -- Peter Meerwald +43-664-2444418 (mobile)