From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932145AbbIWQVi (ORCPT ); Wed, 23 Sep 2015 12:21:38 -0400 Received: from mail-bn1bon0057.outbound.protection.outlook.com ([157.56.111.57]:35594 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755962AbbIWQVc (ORCPT ); Wed, 23 Sep 2015 12:21:32 -0400 X-Greylist: delayed 88729 seconds by postgrey-1.27 at vger.kernel.org; Wed, 23 Sep 2015 12:21:31 EDT Authentication-Results: spf=fail (sender IP is 66.35.236.236) smtp.mailfrom=opensource.altera.com; konsulko.com; dkim=none (message not signed) header.d=none;konsulko.com; dmarc=none action=none header.from=opensource.altera.com; Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=atull@opensource.altera.com; Date: Wed, 23 Sep 2015 11:15:16 -0500 From: atull X-X-Sender: atull@linuxheads99 To: Dan Carpenter CC: Pavel Machek , Josh Cartwright , , , , , , , , , , , , , , , , , , , , , , , , "Petr Cvek" , , , , , , , , , , , , Subject: Re: [PATCH v11 3/4] add FPGA manager core In-Reply-To: <20150923141106.GH4953@mwanda> Message-ID: References: <1442935271-10375-1-git-send-email-atull@opensource.altera.com> <1442935271-10375-4-git-send-email-atull@opensource.altera.com> <20150922222929.GA26335@jcartwri.amer.corp.natinst.com> <20150923132354.GB31253@amd> <20150923141106.GH4953@mwanda> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [64.129.157.38] X-ClientProxiedBy: CO2PR18CA0037.namprd18.prod.outlook.com (25.161.80.47) To BLUPR03MB1506.namprd03.prod.outlook.com (25.163.81.24) X-Microsoft-Exchange-Diagnostics-untrusted: 1;BLUPR03MB1506;2:2sSYA+xmDTDwDo2326kbpls4wtRTtXTYrquqki+NaKOBHR97RimL2hYjkpnHcBz93nVMiiug3LfmjmlXZbqRresV5I2HyjzcKlbZOsNIaiaMAX4MmIosiGDmnYrE+nX7uRljkBL9BZOp1H0kRYEgZJ7shtgBah1ehlQ+V5VpLyg=;3:MmUBRCySHARi8g8QcJhuRK2MWiT8b0YXJUD9sKLYeRCQDLOVLU8UcIqn6R/jtL401Ud18JJWnlMpZNXkySV/cciWYPnVL+qJ0eB+1/QzHGwpy2s/xyaN6dDAvc6OsoE86COURDpT2Hv3/Q4uF2nR8w==;25:cqaj1/B48n6oFc2IAiHXl63kMpLYtRF8caGlFXBaTz9vH8s+WG40sFsYuhdUksd2VZ/Mrlm5jlbru0jDR+Alcf+5n5bjtM1diqJzi8iqHvxUeL374jvrUjpWki2wHeSOvqPyI46U3e/JPgIYW8F1DlWyWSKBPP2Ohh3oMhaa5w9ZH9yB/jenaAM0nfPBRPlyEq2uhPXljToo5Tm/BS/WLSi01sx8AM+kzV+ll6H1gzgffI8208XPb00OHYz82oY+;20:3HUZ2jduLL87o+bK0ylyTjlcNUQeJMTZJB0KyfXF3WvQFON/GIjGBP0C/03ES5dsHTfrLROBvK32PRdv47aIb6XFrlX3OxjG5+NVO0G1CUOa0csrcbx5j6VegWu0eiIUzrW1aVP/hMGA//LeuZwALnxXt0O0+E+ImlETKJ6Uo0g= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB1506;UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1503; X-LD-Processed: fbd72e03-d4a5-4110-adce-614d51f2077a,ExtAddr,ExtAddr X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:;UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(520078)(5005006)(3002001);SRVR:BLUPR03MB1506;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB1506;BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(520078)(5005006)(3002001);SRVR:CY1PR03MB1503;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1503; X-Microsoft-Exchange-Diagnostics-untrusted: 1;BLUPR03MB1506;4:YB5L+8kF8GcdTZ/VOxJvZ5KQ3oBCazxgpUMyd6bhLmrgHbqUIlBPJaGodwOEaVAaZQyWuLR0+j9aGi3MZ+DyOL/L1N2jUjBPFJZ8ScyxzXzCO+58x4wEeTOk4awGIXr9h0JjSYDeSRJK40x0tQ1er2CewUGfD9dqT8qhwqzl5T+XNDneqKEoB+OVnS//QDM/mm7rrLtILpnfAHXCwjrCjYHX9nYEGS9FGHBTLwNJO8cagFr+tTsZVqYAoXFzCpKoaPRd3T0Jz7TkAaxHFxiFaPoaTxlDQJlKr+E3KDKAD3jg7SrdlYtpiJj4mecJz6QkeccnEX7DytmtImZWKyQNoKMJpjzVdmLp0KsPcAxWz9M= X-Forefront-PRVS: 07083FF734 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(6009001)(189002)(24454002)(199003)(46102003)(76176999)(50466002)(4001540100001)(101416001)(40100003)(93886004)(97736004)(33716001)(47776003)(5001830100001)(2950100001)(83506001)(92566002)(23726002)(54356999)(69596002)(4001350100001)(86152002)(5007970100001)(87976001)(189998001)(77156002)(5001860100001)(64706001)(68736005)(110136002)(66066001)(46406003)(53416004)(62966003)(5001960100002)(81156007)(86362001)(77096005)(105586002)(106356001)(50986999)(122386002)(5004730100002)(42186005)(7059030);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR03MB1506;H:linuxheads99.altera.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:0;LANG:en; X-Microsoft-Exchange-Diagnostics-untrusted: =?us-ascii?Q?1;BLUPR03MB1506;23:EGvc1hBv17PgTYLYCokEkX9aYttGWokeaS3mMoMyp?= =?us-ascii?Q?/d//t08T2oRgNIUQjl8KnXGQ9rTduCSMcY4Mctb9fkXxQGKSz5tO90h647yG?= =?us-ascii?Q?XlGfZaI90TibN2KQqQ9df0dgx7eBXoBleBN3k0uxAIJVTc0pNyogNrNROu0v?= =?us-ascii?Q?8IuhNM36kQWCFMUeOEo2QvZ4by7MfEjHwHmcJ32JuO++acwbjMaZzD3XTkoi?= =?us-ascii?Q?+6CpkoGz3Azkw04/Ljb7HFXau4kjWeoR0EmT71d3ZR2ONOMKnDIH0G0THiOw?= =?us-ascii?Q?/+PWhL1biP3WFZjfqQzZYszmATHmYK8667exZrYem4iUWRXqrMauUhitRYpL?= =?us-ascii?Q?CjVcCUAhlpWetf7yUlHtwNZvngZJgPsjEmuBhAHP6TjiP3Ggu0PM4thorLCH?= =?us-ascii?Q?uL1ZRKGEzvGSLep0+ax7ghpZOT2892SXkzD0e5jcgBBZmeMGbZ93xyIU5Pt+?= =?us-ascii?Q?+ShZ5G/9eHFmVveVwSre8gc9CY4oQBvgoopDkQcAzG6zkPimNUZwOYTszzUE?= =?us-ascii?Q?ITJLnbLmcTUHSOzFJeVZMJHsXzWJy4uwYkBIVYKp2ObW/y/2oqBrfre0F3tX?= =?us-ascii?Q?IW/cFh3FqffD9djykIvjqVaoZpgJzr2OUKQDebMDc1gqSRUPJFjkp2Ly6BCN?= =?us-ascii?Q?EGXaEdlAhdNzgWa3uFgzNeYe4X5SaPNrcJqj+Rpk+TO6lHX5QUJ4zo05r30i?= =?us-ascii?Q?KEBX7HVBc70Af2gZgnVBFp8zg+jBzhVBKQM6g5jsNO4nNMJp7Ldy/MPOH0Y5?= =?us-ascii?Q?33uGyOy44OO6zwSpcFl0DN+R+2dzJ+aZkTHYHvnV8dQHCis401al13QKAOfG?= =?us-ascii?Q?Id/Qkm7+9AL93M27a5c7snPDcsfBAjhGCYY6geThBuea5ld0Q2sKrQ4bhDo+?= =?us-ascii?Q?sWnwv0XWLJgfHTjGwdz/idCwImuOD8xDpcK7K0HA/nhSAqdhRFOFE6QNup8n?= =?us-ascii?Q?X8+RqviKxs+VAre6MZhWU102kxZlfhjBA+l0rZt6emhWVQjXhC+uNyEsKA0x?= =?us-ascii?Q?5LgycnE2rxyNc7mWoCBYN1lbU6ubCAkqmTVWv36cmhY5eKkpM2k8bOmXy/Fx?= =?us-ascii?Q?T9m4ciS9CM7CNKfSHDj6wX+hWHCdyfrmJPIZPdN9yqGwYOIPWzgi8mLrEKcu?= =?us-ascii?Q?+LQqKWbXta+Rbf4CVmCXk0e+iRxc21EfqGFMROTlyngDbT7/GazHpFFCYYxj?= =?us-ascii?Q?36lFnJfOtSI8ERgTIEv/1nlmLUA/h8tGetvDRS7btCPK7Oz1hC864D5Ig=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics-untrusted: 1;BLUPR03MB1506;5:8zJ3qPWMvy20W8TfWpIh0kage+EO2lk4/FeY9/J0SXwZlHGi/7Lg5hY2iVNK2ttgnBgR8Q9zbtpMfPmLcF4TUm/qTFK6uDkvHNoaegSoIrp1voOrlttlSZ33pTLIm6DLofQ1PF1+RAKbGEINHqaFZQ==;24:K/PCJkVI4Glj6GxTqrWSg7wOLCFUEmbpmKZKf81rSO5lbWxc+28BCUcjrqrnrLtcb4ADNx7qbYKlaPn9jESsCFEXhVXxJu7Gec8qe0tZgR4=;20:xtdEpVsVqIHvfij7Q56o/QlkSh5QJHeF9gH2zJd2YpQiz8Del9ipoqWDcLba0IYwvPVh3W8XpKtja4wGaDxhJswnpsxs29fKn47yGomZgiR1Jt/1d1IJ5YXUFNrWFeFb8mdjvSeaMRuLDDB43Dwth0xl6Elmjve8ygBWRHcg5ec= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB1506 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: BN1AFFO11FD011.protection.gbl X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11FD011;1:KiW/RpzhX5tjBhLoYMRFbBOLhshP+I3MeNrBFNcXqjT2D+jxeAmr8HqJ3AC9ePTHFp5BQw/UpPMtP1MVIk5jncvPpfdV67Iom2nrXP7PpCi45+zbyOivmvSZiwME6hj3Gge2wI7WDyv6zbE6Ee4ZGdNcvgKQqvg6ut5bVaX+6qiDG5jimPGZ8hQ4U/+uvexDrE4Y6ROcZdmic9eOA/pTw30E+HykIMA8r2gXER2e/Os13mlPT+BFiIzklyjnd4IeHJ129JY6TG/w2g9+PvKlHqK30vsxKkY6A68ZnsZfUXBM/ZFSlzYX+VtpCvR9uUG0CjTTJZ+iUn4PPx8zAf+CJ9OOOKU6G0EsBNdkfSMba0hYeEQ2HnY3RhYGDj4WdmS3y56WwPMeQ2dcb8eOg1phKA== X-Forefront-Antispam-Report: CIP:66.35.236.236;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(1109001)(1110001)(339900001)(24454002)(199003)(189002)(23726002)(6070500001)(47776003)(122386002)(4001350100001)(68736005)(62966003)(46102003)(77096005)(16796002)(64706001)(5001830100001)(87936001)(83506001)(106466001)(5001960100002)(189998001)(77156002)(81156007)(4001540100001)(6806005)(66066001)(86362001)(97736004)(93886004)(110136002)(50986999)(2950100001)(53416004)(11100500001)(92566002)(5007970100001)(46406003)(76176999)(5004730100002)(85426001)(54356999)(105606002)(33716001)(86152002)(40100003)(5001860100001)(50466002)(7099028)(7059030);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR03MB1503;H:sj-itexedge04.altera.priv.altera.com;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;A:0;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1503;2:0cQsjXzJUhkBS4ZOfXwZEDX37usNTE8ftpDSOZYg8xM3tiQ061RAxPnPiY1MwW6O9IvS6SwWOK3+0247aA+CgsHxpy53AOOFPlMEruz5km+ydmHDYCP86Yuhncx90/Zmj9sA6DgPQ717HkiI7kJ5wnNNc8aQSxuJSWaaSWGhdzk=;3:aWTczzw/pqZQNzo9PorXMPBZRA+TBEfzYGtuVvni+OtZEi4UZqkO0IMbL5ZUWvcDmJ+ePVEFvXGFJUt6p5u9HtiDkn77PfxTeVhIweSo01FwcG1kMoh9Jbu9ukvAOVBEvUi5l7cJAJbPtLn9Sf+H805iaRU5Ta/nmfy3/hkZ8yZMFcljLNl0Ut34/gGY8XbwaC/vzJcdva1DQKnTOasmQOgjbisHiXk+Sq+9B9pYMSU=;25:BQrjpodABJmAD/fynncRY8AmnJl868YgKRIZaFt7czNFpBLet9uknx+P88rhIg3IgEwtdwliIFwHe0mWREjMVrSFKDRF4OdjZs48xRTyCgMahy1QeZKxweObT4OhzaeTu02ar+UFV+bqmGXHtWsolgcvvMqlP3TI0wrId0xDLBO10nc/0P6SXr9l05etjIWGqRfQio5cwx43wkhDHaQ9G4hMj5WkLltVcmYI3gbsFZH7K38SqmCwwGYN3YJxtfZM;20:6zIOi7hUP5nEfNBTjkO5THIToh7E+1yLT3aqMxUKll+wWdhjXm5Ca+EXC4tCVyJ42ZP3xEr93M3fKBA46/ioyw7+bD6KcMp90ATgr7hsVCYlqrwLMXu5ZIaM5a3z55nm15Wp2SgxFgZ1MQoOL3VKVNQrKzQZtbkK/Zd2DsZqIqo= X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1503;4:U4eLtfBsfhddWsVm5KsfGndIJfbk3+srkBafLFE83MApSB4E5z+ll6p+5AqNW2owg5iNyOVURCX5e2PhzVr8nSmEDiV49deFO9gr5lH53Jp6AogKjh339FetIIbRF91LkHRnSrT+KLz2WajWbD16SjXSlwwNZdHr1HWNwuOKWbk8cPc426i+VtcpFgiRAqbih0cOonPUD8jjhrDLQLAA1n/mzH5PdbSjKGUisydWoZhMS+Kbc/yZMSd6MxKWDzI3kYp0A7I04sG+Ja/lGn9Ckp6TgaS2yYIu5UpbzhR4QkN0slI+gDftum+xPiTqKQIc1rXykw6rNSgqVDIzIgO0Na7B8CWHWzhA3BcsbUssoic= X-Forefront-PRVS: 07083FF734 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CY1PR03MB1503;23:jbPBjxbmOZf4li3jNoCAU8ic2Odad2VU6IKEdqPve?= =?us-ascii?Q?NFfSqUmW1pualTu1REwS6k2Z5DkIk9N7+K4XiMyga2hI91RL3eczbt6jxvMN?= =?us-ascii?Q?hUcy6OyQK8aI4aoUvfAAxU8Del8RKBGvR9SUdx+VKBNMNPa+/cJpbYl2+hn+?= =?us-ascii?Q?7Wddz7OTBwwqKGSOjS5hrOfGGicb2sVSY5FMNjOZ8BV68aa+nAKJspvqO2JE?= =?us-ascii?Q?qU0vcOLGJcTwjMtHuQLsCXcuRXmJhp96jAb+O5W2L5kLlLwm1QdUpdGVi4WG?= =?us-ascii?Q?gNTYwHrjTIJ7KSN9O2Tlx7C5flVYMzTqOo3jt8DuZnZ47GKjYWa7Ex6CgSO0?= =?us-ascii?Q?33e8k16qE8rKzhQ6ilTC/G66a9WNhQN6x2oLHnp4gHyEQ1LaTXEtRYGwRCtE?= =?us-ascii?Q?YZjOkrBb1e4A2aYBFFsvxGAYFXCivPBPFoqKrRsmDcopkqwpozYnvJlTagLy?= =?us-ascii?Q?ZTAwXowmDgHY3Fc2h0Bvd5/0nm+WhSQ9IHgmTk3aZlMKqZWGApzI0NixFM73?= =?us-ascii?Q?dAgT18pMUfMGYEx5ag4eugWDJEZg4JTA9aDfVImJs7jc412VTebHq1hsqvNf?= =?us-ascii?Q?J/fZmGld30+jd62u7uVfcLIknru9c6Jj7FXqPzYj5c7Jg3tUKwNVJhO/zRCr?= =?us-ascii?Q?w9XsXiqjMw3kXmbnp6Gnmrum2VJu+F1UHitPbRS4NwhmfYmvk3fvCdG7hacc?= =?us-ascii?Q?1Zug6voIh+6nIc3kRMv+xNgKimVW5G0gG505Rd6SA7O18SGONoBWbmiB6p66?= =?us-ascii?Q?zP+hpv0IC1wpSG4LOCw7PdbMP/+rucmtI0lhEuiIYmUyo/1TEFB5kK+3181b?= =?us-ascii?Q?CCYvbcoF6SMi0cM2/ClRjaR5DCFPX5DPFhLWE1GxmklgN0R1Mt4zlb+Dgdsk?= =?us-ascii?Q?VkO7+RcAwv43n71Io4G/31Xq3+axGNDsWsQZ1R1zeGlTxy4N8IfwPY5Y2KNd?= =?us-ascii?Q?V5KxuaXorxMDMSkq2DNm87iIKsy+fe3ihsRt1g2hwDTQhPshlOlEAXhhKnaG?= =?us-ascii?Q?QFeAG+/CNNhJlCknMHDeRMVN57lemmpGpWUxX0BsU4/mNuzOFICXJqYDMPtK?= =?us-ascii?Q?NKZ1dMkjGtmeKaVzRK/o4S2AM2uGaebDHTcsbzkZSw/GJnvvMLIhJxqXxuQ1?= =?us-ascii?Q?id9jBgcvPpNyp7XsKRmEUDesjVIbTSJYR1OJ5ABDlM4G1fcyBDBoLebJfge3?= =?us-ascii?Q?2WKsH+aG/drUsmyxlomBlD/U5tb8SYiKnRUE+j4AE/cfZorWJZB4UNNH24Ad?= =?us-ascii?Q?x3354atQXJAbjUaViNEcpCJdj+2quie+NTTHU0KUPCv3f6Y5iKmXAyzAdAWz?= =?us-ascii?Q?g5IHu5hyDx6bWgFxxLwgdc5W/mG5aDDw6QASmfVdjWTKzE7Rx+y7amw39u74?= =?us-ascii?Q?EilQbKQKPiNYPzCV5VezjfYxck=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1503;5:8nie0fXcvTcKZpRMV+1wrI7To+PzBZMe/YdQgOnrgWoebBUTdna0tcSPMDT9BF59wgMrI6+/7TT6nWN0yYpD0lZq8JNFdoBf9YB52H8P2bWI55+Ycbt1ta8m340c+W6FQ+1c+Kpajbxblf7F6ZNvcw==;24:UO0ONALZhvRSZhmZa61KqF0djFk8RPO3U6ZPQWttjbugD0tvAbZaITI3RmmQU6mCmGGeUd7Y991lAMEW3uZ56tlqTfEAUEhAWdrFW+FDq8o=;20:oHrxELPrkBBByhBywhUgl1sgMbh+bN/EwVgGP3qKsNhFW84sEE5QG9+y6XZpFXTXVtbi37xFo7pLSldcxhf8xZpzMiKSmmWXk4VPuWqGJGnwzVzVkBU6zNkoBlDaR14OZTO+3zHZU563wZQywHFyJKl+A80zcGK+i1zR8dcrXs4= X-OriginatorOrg: opensource.altera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Sep 2015 16:21:27.9336 (UTC) X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a;Ip=[66.35.236.236];Helo=[sj-itexedge04.altera.priv.altera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB1503 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 23 Sep 2015, Dan Carpenter wrote: > On Wed, Sep 23, 2015 at 03:23:54PM +0200, Pavel Machek wrote: > > > > +int fpga_mgr_firmware_load(struct fpga_manager *mgr, u32 flags, > > > > + const char *image_name) > > > > +{ > > > > + struct device *dev = &mgr->dev; > > > > + const struct firmware *fw; > > > > + int ret; > > > > + > > > > + if (!mgr) > > > > + return -ENODEV; > > > > > > Again; I'm of the opinion this is needlessly defensive. > > > > Not only that, it can never happen. mgr is already dereferenced above. > > > > It's not dereferenced. We're taking the address of mgr->dev but we > don't dereference mgr. > > regards, > dan carpenter > > That's correct, it's not dereferenced. Is there some community agreement on whether we want to check a pointer that has been passed for NULL or not? This is C code after all. Checking a passed pointer for NULL is a very common reason to return -ENODEV. Alan