From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933938AbbI1Nub (ORCPT <rfc822;w@1wt.eu>);
	Mon, 28 Sep 2015 09:50:31 -0400
Received: from smtp02.citrix.com ([66.165.176.63]:19870 "EHLO
	SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S933846AbbI1Nu2 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 28 Sep 2015 09:50:28 -0400
X-IronPort-AV: E=Sophos;i="5.17,602,1437436800"; 
   d="scan'208";a="306546753"
Date: Mon, 28 Sep 2015 14:48:08 +0100
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
X-X-Sender: sstabellini@kaball.uk.xensource.com
To: Julien Grall <julien.grall@citrix.com>
CC: <xen-devel@lists.xenproject.org>, <linux-arm-kernel@lists.infradead.org>,
        <ian.campbell@citrix.com>, <stefano.stabellini@eu.citrix.com>,
        <linux-kernel@vger.kernel.org>,
        Robert Richter <robert.richter@caviumnetworks.com>,
        Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        "David Vrabel" <david.vrabel@citrix.com>
Subject: Re: [PATCH] xen/pci: Don't build Xen pci code for ARM and ARM64
In-Reply-To: <1443447044-24985-1-git-send-email-julien.grall@citrix.com>
Message-ID: <alpine.DEB.2.02.1509281447010.2672@kaball.uk.xensource.com>
References: <1443447044-24985-1-git-send-email-julien.grall@citrix.com>
User-Agent: Alpine 2.02 (DEB 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
X-DLP: MIA2
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 28 Sep 2015, Julien Grall wrote:
> The PCI support for Xen doesn't compile on ARM/ARM64 when
> CONFIG_PCI_MMCONFIG=y:
> 
> drivers/xen/pci.c:31:25: fatal error: asm/pci_x86.h: No such file or
> directory
>  #include <asm/pci_x86.h>
> 
> Although, Xen is not currently involved in PCI management for ARM/ARM64.
> There is plan to support it, but it would require some changes in Linux
> side.
> 
> For now, introduce a new config options XEN_PCI which will be turned off
> for ARM platform.
> 
> Reported-by: Robert Richter <robert.richter@caviumnetworks.com>
> Signed-off-by: Julien Grall <julien.grall@citrix.com>
> 
> ---
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Cc: David Vrabel <david.vrabel@citrix.com>
> ---
>  drivers/xen/Kconfig  | 6 +++++-
>  drivers/xen/Makefile | 2 +-
>  2 files changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig
> index 73708ac..6bcc8b0 100644
> --- a/drivers/xen/Kconfig
> +++ b/drivers/xen/Kconfig
> @@ -168,7 +168,7 @@ config XEN_TMEM
>  
>  config XEN_PCIDEV_BACKEND
>  	tristate "Xen PCI-device backend driver"
> -	depends on PCI && X86 && XEN
> +	depends on XEN_PCI
>  	depends on XEN_BACKEND
>  	default m
>  	help
> @@ -189,6 +189,10 @@ config XEN_PCIDEV_BACKEND
>  
>  	  If in doubt, say m.
>  
> +config XEN_PCI
> +	def_bool y
> +	depends on PCI && !ARM && !ARM64

This is confusing because x86 already has PCI_XEN, see arch/x86/Kconfig.
Just move PCI_XEN from arch/x86/Kconfig to here and disable it for ARM?


>  config XEN_SCSI_BACKEND
>  	tristate "XEN SCSI backend driver"
>  	depends on XEN && XEN_BACKEND && TARGET_CORE
> diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile
> index e293bc5..c9f23b7 100644
> --- a/drivers/xen/Makefile
> +++ b/drivers/xen/Makefile
> @@ -11,7 +11,7 @@ CFLAGS_features.o			:= $(nostackp)
>  
>  CFLAGS_efi.o				+= -fshort-wchar
>  
> -dom0-$(CONFIG_PCI) += pci.o
> +dom0-$(CONFIG_XEN_PCI) += pci.o
>  dom0-$(CONFIG_USB_SUPPORT) += dbgp.o
>  dom0-$(CONFIG_XEN_ACPI) += acpi.o $(xen-pad-y)
>  xen-pad-$(CONFIG_X86) += xen-acpi-pad.o
> -- 
> 2.1.4
>