From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752581AbbJJVNU (ORCPT ); Sat, 10 Oct 2015 17:13:20 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:48175 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751394AbbJJVNS (ORCPT ); Sat, 10 Oct 2015 17:13:18 -0400 X-IronPort-AV: E=Sophos;i="5.17,664,1437429600"; d="scan'208";a="182114872" Date: Sat, 10 Oct 2015 23:12:55 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@localhost6.localdomain6 To: Thomas Petazzoni cc: Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Julia Lawall , Russell King , Andrew Lunn , Jason Cooper , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas Subject: Re: [PATCH 5/5] arm: add missing of_node_put In-Reply-To: <20151010230802.71d1c421@free-electrons.com> Message-ID: References: <1444480254-14399-1-git-send-email-Julia.Lawall@lip6.fr> <1444480254-14399-6-git-send-email-Julia.Lawall@lip6.fr> <8655275.vMqHQfLN9g@wuerfel> <20151010230802.71d1c421@free-electrons.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 10 Oct 2015, Thomas Petazzoni wrote: > Arnd, > > On Sat, 10 Oct 2015 23:02:15 +0200, Arnd Bergmann wrote: > > > The same for_each_child_of_node() loop has three 'return' statements' > > aside from the 'break' statement here. I think you should change your > > semantic patch to cover both cases. > > I think Julia's semantic patch covers both cases, but only the cases > where there is one break or return (though I have essentially zero > Coccinelle knowledge, this is all based on guessing looking at the > semantic patch in the cover letter). Normally, it should be OK with lots of returns. And contrary to my previous email, even with return;. Will check on it. julia