From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751348AbbJKGIl (ORCPT ); Sun, 11 Oct 2015 02:08:41 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:27184 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751141AbbJKGIk (ORCPT ); Sun, 11 Oct 2015 02:08:40 -0400 X-IronPort-AV: E=Sophos;i="5.17,666,1437429600"; d="scan'208";a="182141674" Date: Sun, 11 Oct 2015 08:08:37 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@localhost6.localdomain6 To: Takashi Sakamoto cc: kernel-janitors@vger.kernel.org, alsa-devel@alsa-project.org, Clemens Ladisch , linux-kernel@vger.kernel.org, Takashi Iwai Subject: Re: [PATCH v2] ALSA: bebob: constify snd_bebob_rate_spec structures In-Reply-To: <5619DA57.6010705@sakamocchi.jp> Message-ID: References: <1444484390-22158-1-git-send-email-Julia.Lawall@lip6.fr> <5619308C.7000601@sakamocchi.jp> <5619DA57.6010705@sakamocchi.jp> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 11 Oct 2015, Takashi Sakamoto wrote: > Hi, > > On Oct 11 2015 06:24, Julia Lawall wrote: > > The structures of type snd_bebob_clock_spec, snd_bebob_rate_spec, > > snd_bebob_meter_spec, and snd_bebob_spec are never modified after they are > > initialized. Make them all const. > > > > Done with the help of Coccinelle. > > > > Signed-off-by: Julia Lawall > > > > --- > > > > v2: extend to snd_bebob_clock_spec, snd_bebob_meter_spec, and > > snd_bebob_spec structures. > > > > sound/firewire/bebob/bebob.c | 2 +- > > sound/firewire/bebob/bebob.h | 32 ++++++++++++++++---------------- > > sound/firewire/bebob/bebob_focusrite.c | 26 +++++++++++++------------- > > sound/firewire/bebob/bebob_maudio.c | 32 ++++++++++++++++---------------- > > sound/firewire/bebob/bebob_pcm.c | 2 +- > > sound/firewire/bebob/bebob_proc.c | 6 +++--- > > sound/firewire/bebob/bebob_stream.c | 6 +++--- > > sound/firewire/bebob/bebob_terratec.c | 10 +++++----- > > sound/firewire/bebob/bebob_yamaha.c | 6 +++--- > > 9 files changed, 61 insertions(+), 61 deletions(-) > > Tested-by: Takashi Sakamoto > Reviewed-by: Takashi Sakamoto > > Thank you to include my extra request and spend more time for this patch ;) > > But I prefer to change the title of this patch to 'ALSA: bebob: constify > some structures because they are never modified' or something like it > because this patch is not only for 'struct snd_bebob_rate_spec'. Sorry not to have paid attention to that. I will send it again. julia