From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752583AbbJMTZs (ORCPT ); Tue, 13 Oct 2015 15:25:48 -0400 Received: from mail-bl2on0083.outbound.protection.outlook.com ([65.55.169.83]:8849 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752456AbbJMTZV (ORCPT ); Tue, 13 Oct 2015 15:25:21 -0400 Authentication-Results: spf=fail (sender IP is 66.35.236.227) smtp.mailfrom=opensource.altera.com; kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=opensource.altera.com; Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=dinguyen@opensource.altera.com; Date: Tue, 13 Oct 2015 14:18:22 -0500 From: Dinh Nguyen X-X-Sender: dinguyen@linux-builds1 To: Steffen Trumtrar CC: , Mark Rutland , , Pawel Moll , Ian Campbell , , Rob Herring , Kumar Gala , , Subject: Re: [PATCH] ARM: socfpga: dts: add fpga manager In-Reply-To: <20151013185750.GB17155@pengutronix.de> Message-ID: References: <1444760900-1373-1-git-send-email-atull@opensource.altera.com> <20151013185750.GB17155@pengutronix.de> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [64.129.157.38] X-ClientProxiedBy: BY2PR1001CA0022.namprd10.prod.outlook.com (25.164.163.160) To CY1PR03MB1374.namprd03.prod.outlook.com (25.163.16.28) X-Microsoft-Exchange-Diagnostics-untrusted: 1;CY1PR03MB1374;2:emwvFHmQuWvwJnAgYCqT9E1iV+ciRwyMZjGx4YZ/TSqC7n2XDyiwv9yf8on5lqhX2x7dbnCVNyo6y7TTa35Cl9lETxf/GHS4hyk1kx/rX7rjSIL3BcTrJHk42e6JwxSOTR3dHicYmh6tSPhXve5epAEYJp8J7U1tjNkmQjW5PhM=;3:uCGruTVpxe3Uv1j7vHFeKnAIwlIhHSSx4G+cPL03ibfR9l+dFgJDdpgsDdrzSnEObNb2YFEZAWHTrpDq99UNGqshtkjTPpcmmx3iagIsEfE+/LSaAd7H1MKZ8Mq7r+XT0pzlIuMxbV8vQf5osCfyyA==;25:9x82gASYyYciVlrD/0gZkLelhXSkXRcXLX2bt8pBriaQ2ZjQwact7X3hUwCXuJ21wgSYO0KFAW/azsSsYvrn68/QOQnYA90O18vq6Z9hl7SbHlvm78SW3IZUALACcTMOjshx5kbdOLAe2/1COJLN3d+rPWPF5PJiArGRdp9pkvazYh3E1hcSKUfcb0sx/1zDd+S6Z1akrmhnsHqi+uI5miQetPp0dYg/VHV3C+4/QCLNQj2/qDmpT5eRWATUJC8JDezuazj+TPW0VvgaXLVvQw==;20:4XH5ldohzzzBWa9Yl7hJtWbWwp6qfQqIVl1dG0DRigN8rJS12ju/wd0YFc5VlAX+xwfGB4jc8e2hq20i6sZOM3k6KYtUJW1MUqMQTf5CAVIWcPU4Hw/WyDRGJZ6LNm3Fbyg1KEuBot/h6jnhmz960llnkKMYzValQ/EalATE8aE= X-Microsoft-Antispam-Untrusted: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1374; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(80048183373757);UriScan:(80048183373757); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(520078)(3002001);SRVR:CY1PR03MB1374;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1374;BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(520078)(3002001);SRVR:CY1PR03MB1501;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1501; X-Microsoft-Exchange-Diagnostics-untrusted: 1;CY1PR03MB1374;4:JWiMtoen5SXbXTYlJR0DvFDqYoWsqZxDB7//pttlUQ9maEcxzjvjziWh+id8TCessBPednZRlVqh0kL6Do1pGz7orgmkiNuCa7BhOKHRlHIFsF7dvn+3VvVLe6lSMDAuMVCzZVzrH7jlkOa5S20gHyyR6RRgkgZcxN48MVLM0X1gCVuJcGyQk8769EpxO89kGdKfTqSveM+rGuTdzR2lL20NmHSrlwZ2OvtZF1RBm8CSU6zholstXhlJhYoFxEPCUKlOfMpmET+UN6iQZ59RXFkppo/YbXsxjmvx2E5r7TRbXbW4In8i15ogwHwda/OdhFvmrD6lZu+vYQL4Yu0BRTHKb8CAr3C9WiOy8H68hto= X-Forefront-PRVS: 07283408BE X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(6009001)(24454002)(199003)(164054003)(189002)(50986999)(64706001)(5007970100001)(66066001)(5004730100002)(189998001)(5008740100001)(97736004)(101416001)(92566002)(47776003)(46406003)(5001960100002)(110136002)(50466002)(76176999)(83506001)(106356001)(42186005)(87976001)(86362001)(77096005)(19580405001)(54356999)(46102003)(122386002)(19580395003)(81156007)(40100003)(2950100001)(23726002)(33716001)(53416004)(69596002)(4001350100001)(105586002)(15975445007);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR03MB1374;H:linux-builds1.altera.com;FPR:;SPF:None;PTR:InfoNoRecords;A:0;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics-untrusted: =?us-ascii?Q?1;CY1PR03MB1374;23:E+xI4tUNP8bC6gpk/HGLKFMH32CEfryPog2swb6ts?= =?us-ascii?Q?uPq+YkJ2SEUlGoW6q3tzo0fpU9YC2LJ+8imq9Rxcggl25zDX0rbW6q7Dzm4a?= =?us-ascii?Q?DCoEWhvVLg4ZOQaGCxclmUJqbwL7yiZe/76EvzP3npSyioGuStPAkF14gBgQ?= =?us-ascii?Q?aB+fyCxbGrjDJXubkrvxNtpZZ1TNzLXnqsvnHgQk5/FNjAHOJ3Y+RzXSdd5g?= =?us-ascii?Q?RGkntLWXc4pCHo+yoNbnYUVWkm4AWw4MeL3TakJtCpvmpYD2VOnTgyu4e2ls?= =?us-ascii?Q?WplK5pmYraV3CYm15vn+6fPp5A6TzFqvLnFx55HStMOX6+viubda/qeBYrAg?= =?us-ascii?Q?iiIZnRBBfNC+p7xSF5KrRkMATsaUMXv++S1MhAu9r5o3wXkkpOXBzXPvVHcy?= =?us-ascii?Q?QkQQnO8VlY/Fe13qyG/Mg1v6KD2ghn6rsMsP5LuMUSjxmwsewGatjq+B6lBU?= =?us-ascii?Q?MsKvf+KObsIcgDsD1x3VRjjucGVky0twkCAetxxrJAC/r4lv8kzeZMBhhg9o?= =?us-ascii?Q?vT6clnmfyc2gWTVg5ptZHYqMGQLPqZ7DjVRo5Kq8UJLBPAXgOZykyIDUZiOh?= =?us-ascii?Q?6u0jouQ/WEIgj5+w4BXE7UAhI4833uNsKonkv4zbU6xyklzkEx5Lr4bw5y9X?= =?us-ascii?Q?y5N5oWwxiZ2AM38QE+l6B+KhbYt4tStyrsRepe6gMndBen8dxblxoFug6pOm?= =?us-ascii?Q?cVqs2vSve4sWZsYlXbwG3LwSQy1mbAyp2rD7mlB0FV0ubRFr1ohKstk9puHV?= =?us-ascii?Q?HrRA1biSfejQivBUiOC7RTwkBamKpdCepUFvkB6UzY09nQpyLSTLlKo/3i+u?= =?us-ascii?Q?tg3WeRynXb2Jney1K1ea3A4dAXt/+ClOa/e9M29pEltxQqMSkKBuCtO0sg72?= =?us-ascii?Q?kbP1/bBxuZAewqLLSCNmktV/zr7YwpObO3t5hzchEX+GTCBlRitEIF08Cg+d?= =?us-ascii?Q?v6c/F33jgSsnMTd1f/4L2tmx+D5BcX/yFhspIJM74Cvv4FSSCF7Y1qgdAx4G?= =?us-ascii?Q?I6FRIYE9lttGlpPOiYwYCoiYG2ScS/cXAyIl3ULdUfM/qII1BKj9byfQK7QD?= =?us-ascii?Q?+zzatBtgGIZHj6L2BH3inRobDut2qnO1ym6YM8nZO7jv9sd8a5dwFC2ZxpYa?= =?us-ascii?Q?GrMy8YZ8LXP7/En2PLqdxWr0dNGt6Pa?= X-Microsoft-Exchange-Diagnostics-untrusted: 1;CY1PR03MB1374;5:DXLE0FC4qJoGLa44Ei6wzzULEMGV6hbei8cVqIwheIxMjhrsupvDLYTKSg7lRnl6A3ot/UFcBuCDA8MH6Zp5/kY9PRqqFu0g8y3U2TECfNW/wEQ1XiXnr/gjPhMhT/ZhUkMfS0EctWb0Hz23OLhWYQ==;24:S54wPp32jumIJiFMmwxcOjyWRWG4c4o43tl6bozXMa61qHkfcMoinmsab5CDX2I9/0V5xbHsT33Jdjb8igk4E3KMmw09lMdoxm96bxvoCmM=;20:mJFzWq5ULqXS81Hd6xxZ/pOOX/iHhyonArOHE/ckWBrDsk2pDtGTUU9YCL0c11ahJxNn/o3HskBxhYk8ZZ2q+JvGTHind1JskR8o7M+sVcttFYTydq+BaO1yzB0i3uH13QaTL/+Vc8/F2PSKcay0Bhg2SvI5NoqUcBCe1V/sPuM= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB1374 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: BY2FFO11FD053.protection.gbl X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11FD053;1:dH6raSsZVJXOgo09dpyH5W/eLiUEo9bTm5ua1UIMuuuN1Us1v8S3+KVdCw/WzSzb4xGuoIErV8gDQMNOdBfIL/vQ29QpWoTdUE/IzAk2MMFRJZLe7P/b0WyKjJeelADv2hD8hEhcCkETgvcNOqw+KqBDZPyyqxpf0QwXasDUlfYkvLIU3SaE1LOD+wbowYsuzoQlVjbxCa81o/1VwMwQVI3e0dwtMDYOWG+B1hUN//BPUCbym8xow81CdoIuA6z6WNcp4i5Lem7rbvyanQQKpA1bUnk1RRjLvVFTVNF7N1V0uNMX6bmj/FUwxiscxmihsGfeeNozGARyVtDCW5XmOMLgnxWfIxeMoIT1dz9SB25Fj7BL41smDhUFYXy5Vm3W X-Forefront-Antispam-Report: CIP:66.35.236.227;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(1110001)(1109001)(339900001)(24454002)(164054003)(189002)(199003)(97736004)(122386002)(5004730100002)(46102003)(5008740100001)(6070500001)(53416004)(105606002)(11100500001)(4001350100001)(54356999)(81156007)(16796002)(189998001)(6806005)(5001960100002)(19580395003)(110136002)(77096005)(2950100001)(21840400001)(47776003)(19580405001)(87936001)(64706001)(85426001)(23726002)(76176999)(50986999)(15975445007)(5001920100001)(106466001)(5007970100001)(33716001)(46406003)(66066001)(86362001)(92566002)(50466002)(40100003)(83506001)(7099028);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR03MB1501;H:sj-itexedge03.altera.priv.altera.com;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;MX:1;A:0;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1501;2:4FWRZ3bgIYfiTkt8iIZgJ3ss243753mNQc+9R+aFMU7ZUBhaTsA5J343d3CT08k6ZJzOXgMtrsdmb8bAbge/sTii0xQBYlzHQhnOw5UTfSIWiuPIEVglmm2501lAR84LTvSAjjo/RCHS58m2sctNM1F7laXjUmlHwXnqUd5xsr8=;3:4mm4GCjqdktBETunCSOKo+JEjV6VyqNZUo/Uj/0wmwF4Gn+uPTId/2Kd6tz95Y/1ECTlDmIbj2J8/AS1aAwnLfwVwLhu11Lt1wCrKe3jQyaK1eNkQilD41oGG54nnCTulKcvpDu7JUDVYAx/GqVdjRtOO8GXQ8pTorGy1GyfTwIgmStzn7BF/wOZW3aez8a68/pI9f6wkWVg3iY2CF8AnKXKxkq8EfOSdBt1kliR2T4=;25:EMyVOyMGlh10aVhJmMUJT09ajc/wOcfoJGFmq2TKwgVkRNzgZG1tN4TXD4+Xvjbn1frY5SEWYN5f7D9c7j0NmvVPspBBzvjJFhcFuONriXfUWVfEQsW/SE6CR8GM3PiymciKZg4qHlpMlm6sqyLpXlji7r5nM1Y0zBj9faTfBvukbNGl5kp0EPGSp3kjhL1mD5jGNVxX2rJQM9SiZQI+XuK1te88MBE9gsi26CFnQmHXs6hMczFUildh4l+QSx6Rzs1e/c1SgwtVQAmaIyImOQ==;20:Pe2XT2WfOKywTElIg+JPzYKNu/FTJP8W3RLLLikS7f5z4vH9UyXsIlQ5LLhgRNOMGdqRJ9LwAKfO/r6uOoX0rp/IaYJJdfjbWAJnK+mQEzh34EmoMj2exBP46DO6NO462BWRD9eHHxdmEoV6HDv8p94uKJEkfdndTXgpKdiA7zc= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1501; X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1501;4:18deLduQCl9YiJmYWYItqqdbgdCkZwn2jHADTi8/bCE8Av8f0qf7DoIGYlLySL41OvR2lFGL8kzb/S1wWqNznEsFDkNG5MN1t1WKSd9dFWZ8zqdaqFx4C4wUDcXlZbd2momO/g5AqTCiT4jGsZwgfhiwjg5gAb83QmXSkg5FIp0EpmzAn5Ve/Bpk1g2OePZZ96xDFacREFVTLIYh3OcFRK8YfV+cqIpEqyrcWSwsSeUpqxal1Lxr88xfOW3qyywtLkbPVLY9oN4OfQO7/yYE3fSxQhZWZQowC8nN6AmHuEuBMmnIWJesA3hsfaPt7rLusGXKh7NaNS+QNL9AiaSZNcLuquxtUyQ3jzouwzmqr10= X-Forefront-PRVS: 07283408BE X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CY1PR03MB1501;23:2ncH9s6xOMxu+LG68F7hqgiCBODt1NLpPjruvVvw1?= =?us-ascii?Q?RlCs7ajPQaoGKz3/Bx9GiEFYi0z8e7Z/dq1jK+LY8qnt9I9qBHT1LFkUMwsZ?= =?us-ascii?Q?iVWIsRuobdgEZp6qVkntU24E8HyHen4w1/6glNxIjYFj1YY7pVio5ksZymr3?= =?us-ascii?Q?nhOLjinlYGxtkr9qttBGQnhLXlGXjYM80xhCKYL4ha6ABiW7PJL08/ZVguVT?= =?us-ascii?Q?e//HVA4eEhhc+gfQbdkED3Li4D9LJBIX7235+x2LIJ4ERNSYE5ZEdMX4W5UX?= =?us-ascii?Q?hU9uF0ZkFSPZ+EZQo0xr1SkQpH5Ot5UY6sCpYAJ4q27r5OE7ERdK0TN9DE4z?= =?us-ascii?Q?lN4J9RWahh6cojeX4GjQiaXSuP5PeyOY6rcbo4FngJz5iqQLkXUF6fWmI2wq?= =?us-ascii?Q?BFjf0jLffwUhNkZgRRNEZclz0mVWt4oOU3bNm9xck8E0m0pR32UocyXRoNKw?= =?us-ascii?Q?TLy8okRBr9aIEQ6PPXnELQ832vH1ocCjE3920iPhrKQeA64d/trwyJmdTxG2?= =?us-ascii?Q?+WOQdVI93TgLayef07D/xC5GKrqea+UzbIG34QIwckQujAlQdeh54TMwqjmE?= =?us-ascii?Q?3Ri0RzhfllT1POpil1nl8z+t1kpCkE5Odj5G6FKxAyD1lI2p0msZfrIGfQUP?= =?us-ascii?Q?8Lh4vZHCdHOwtfTVbjqX5eg6uVSdepBdlk5mj1VFtdAqpDY7w4zOVM6iLOHv?= =?us-ascii?Q?ou0viDc13eyAw3lhdtakGNai/6xB7yG2TOigQGVfEizofZ7S8a4vo9IDg8uS?= =?us-ascii?Q?9oCuHzRPqWJ+YPV26OhTrXnil3cNQqLz3J8bWJV0zI9zgYnONQx4TciNGeed?= =?us-ascii?Q?IXM2ldpEeMuxyYXyvOS0JgHQod1XiXINU9VbzgoqkPgSkECaBCoHWJiDdqOZ?= =?us-ascii?Q?PyiXtGpybC7fXt9pA43LzxmCKpH+yYFXIl3iIR+pePNV2Bw39R13VMuC6S2w?= =?us-ascii?Q?UEBdwe9Wf9hHAcO1ZP8onglgj5An7tTcjgdDbvhZCT4ue/s07SLLvFbNr+Go?= =?us-ascii?Q?SbFrWry8wXXyZLFYvCT/RLPTzD4uQIeYgt86OpgiXTvtnhipHg9oovIfBD5Z?= =?us-ascii?Q?DvylI8445awyQ8Jc/+HtC30pTGsK8FHgSw/h1w/AmLnS5B5/mjyWs6LLnwt5?= =?us-ascii?Q?O3lTCwli+rdy11qzQYeNjSe4wTu2LSpmiKYcgLQp0IUWkc23IEw/fMCVaQzj?= =?us-ascii?Q?WN5IOjgx4khXCkXVPF1++304+XRMvUIjqvsTeVRwmAm5mn/GdD6Rq4dB7JtP?= =?us-ascii?Q?4W/UXcIVhL7Ib8ew09Ehp/oef4pWssY1Bf/CInBX8Pi01YwLk1Kd0uRtIKa0?= =?us-ascii?Q?2bXocimsU5V2WOoKCtWE71bABVynUR+pFqUCTvktVRK1y2ZHvR+6UNzxGTEE?= =?us-ascii?Q?Jctcg=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1501;5:rc9Hpade8BGMbTwoprNfdNCMGMxXc7RnuT/sK8jHArkEysAhX/rkTd34WhcIcZjC8s0PCcopouKlTKcGA3WFvXQdkTqa8/5JJUoFfJCR1FIfEDqcOyj2uaJFl2Rg0yIfIUYGqg2dTrXRMy6dqV2prw==;24:uifVpoNvM2FKmXT+c6BXQopr6WxmDUWPPul1NSb59THa9spvKUw+ZZqjtPaMGwQIUeHml+NtiHwJFTqhiPwuEM8pC9AJMhNxbvv0A8xMm7Y=;20:HugV50RdtqIZhODKKGmXF9gjpocswQpcnOAKyRmKzzyFfUexIX8qI9JDrx7SP5fr4oPSNIPnslWnnLDjymjHK9H/WtfX1AvdR3CdLG5zEmVc0uGeRQrd42IO1HwMqc1M9JxQFrstaZsKZSCowh6T4Jc3siuBc1LuD6ZKj4qoSBA= X-OriginatorOrg: opensource.altera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2015 19:25:17.8446 (UTC) X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a;Ip=[66.35.236.227];Helo=[sj-itexedge03.altera.priv.altera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB1501 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 13 Oct 2015, Steffen Trumtrar wrote: > Hi Alan! > > On Tue, Oct 13, 2015 at 01:28:20PM -0500, atull@opensource.altera.com wrote: > > From: Alan Tull > > > > Add FPGA manager to device tree for SoCFPGA. > > > > Signed-off-by: Alan Tull > > --- > > arch/arm/boot/dts/socfpga.dtsi | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi > > index 314e589..e37ba11 100644 > > --- a/arch/arm/boot/dts/socfpga.dtsi > > +++ b/arch/arm/boot/dts/socfpga.dtsi > > @@ -834,5 +834,12 @@ > > compatible = "altr,sys-mgr", "syscon"; > > reg = <0xffd08000 0x4000>; > > }; > > + > > + hps_0_fpgamgr: fpgamgr@0xff706000 { > > + compatible = "altr,socfpga-fpga-mgr"; > > + reg = <0xFF706000 0x1000 > > + 0xFFB90000 0x1000>; > > + interrupts = <0 175 4>; > > + }; > > }; > > }; > > Please keep the format in line with the rest of the file: > Hexvalues are lowercase and no 0x after the "fpgamgr@". > I'd say "And please put the node in its proper position > according to its address", but I see just now, that the > dtsi is all messed up right now anyway :-( > How so? Patches are welcomed! Please fix the "fpgamgr@" and lower case the hex values. But I would prefer the nodes to be in alphabetical order. Also, you need to document the "altr,socfpga-fpga-mgr". Thanks, Dinh > Regards, > Steffen > > -- > Pengutronix e.K. | | > Industrial Linux Solutions | http://www.pengutronix.de/ | > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | > BR, Dinh