From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752668AbbJPCjR (ORCPT ); Thu, 15 Oct 2015 22:39:17 -0400 Received: from mail-bn1on0075.outbound.protection.outlook.com ([157.56.110.75]:21123 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752172AbbJPCjO (ORCPT ); Thu, 15 Oct 2015 22:39:14 -0400 X-Greylist: delayed 25618 seconds by postgrey-1.27 at vger.kernel.org; Thu, 15 Oct 2015 22:39:14 EDT Authentication-Results: spf=fail (sender IP is 66.35.236.236) smtp.mailfrom=opensource.altera.com; cavium.com; dkim=none (message not signed) header.d=none;cavium.com; dmarc=none action=none header.from=opensource.altera.com; Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=dinguyen@opensource.altera.com; Date: Thu, 15 Oct 2015 21:32:18 -0500 From: Dinh Nguyen X-X-Sender: dinguyen@linux-builds1 To: Florian Fainelli CC: David Daney , "David S. Miller" , , , "linux-kernel@vger.kernel.org" Subject: Re: SoCFPGA ethernet broken In-Reply-To: <56201AE7.2020103@gmail.com> Message-ID: References: <561FF9E2.30102@opensource.altera.com> <56200687.9040903@gmail.com> <562005AD.8020903@opensource.altera.com> <56200BD7.8020505@gmail.com> <56200E15.9080603@caviumnetworks.com> <56201158.8040806@opensource.altera.com> <56201AE7.2020103@gmail.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [64.129.157.38] X-ClientProxiedBy: BY2PR02CA0038.namprd02.prod.outlook.com (10.141.216.28) To BY1PR03MB1370.namprd03.prod.outlook.com (25.162.109.28) X-Microsoft-Exchange-Diagnostics-untrusted: 1;BY1PR03MB1370;2:IKNzx0SpKy02evJhCw80O+IaETTABZYbTooF/lb94+6qvpTvCST6ujdFw+BsnTG1Vhb8dKVKYLlnnWrdN2yY8LxP2rnJG+UT+W5zpGslFO5wJJ9vOJD5ZELNNuXum+6wZGSiNsi/6te7U1KkPHGK/+7aL7rHQ4xhBkjkvFI0vyw=;3:tZJavNdhfVYhxJL00GmVug0erO4eXFH9PQDnrmqZDwruge6GIisS4Fa4cdPyjIlowcCOOrhm7VJeD0+ftiI7Zsyxf2G/syZnZ8qumxTk5bBdgqh8/o/H2osdcbdY49AqQH/KW+JrGFSaKEmlL2Vf3Q==;25:d3DK7bm8lJt2Fl4TGxFXKLBNdt7mInmyko8hveDh5nBiMsoSHy9x6r8a2i6hA27zVuEZa5TfvBCbnum4yV5+CihTJtUIsOjFREahO1eGg8dDQLzTL4cwXdgTJsRcHaoO8WA0WL6m9T93gH9XtDin4wI/YGIsq5JKUqrZrPAk+Sm80EJF2DJjhi3rrq3PoybpDEJUmDYFf0mtALDrhwLgGCrLrAZb9ErMCJrow/BqMnrTcvZE5XbEAMwnkM2boHr4tamsindZmgCdU4jk4GFJlQ==;20:lqDSPZcgMTJSD4hX4ZlvSRVqkoWXJnWwqW7A0vnkj2UFUN4cZAwJGDLkBB3NUZEcW5dj96c7wm3waSw9EgPUYSNL4mQs2B5N5Kj62xjV6n9NJTs4ypRqgwtaX7rSBJzd9xw1cIs1rraiSgW13baAy9mCV9QhE6yjf3Bigk2J0vQ= X-Microsoft-Antispam-Untrusted: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1370; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:;UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(520078)(5005006)(3002001);SRVR:BY1PR03MB1370;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1370;BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(520078)(3002001);SRVR:BN3PR03MB1496;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1496; X-Microsoft-Exchange-Diagnostics-untrusted: 1;BY1PR03MB1370;4:MI6a9nIOAEUHXp1/lRyqYCMollNqthqB5eHlF0Y0GS/cxIaniaUP5RX6vNt4LwWjLLIjKtJIi408gEZVuwU8iwMUxE4Mz+8u8QWdXZ9FtS6aW6AtI5DgXzmazIgbSQmwVsrqYfZDPhsFtE16t2frETH/zWD6TLBMl7RPticHHGBW2FeaQcKM1igT6snpxoklHnxmOkHkFyIAtSjLB5el6pMh6G/mDOq3uKBOZjGWb5hWYKrR/FanxQjzqJ7ZRmF1vz7LTrLo9TAWJvIgQMMCDSn5F2XDyUseYMM0hIPN6se/A2gX37a/Z8wOQ1EFD8saMOqmPBjMPkRVx61ckpa7t56x125TC9t1J1qkbDVEu8s= X-Forefront-PRVS: 0731AA2DE6 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(6009001)(24454002)(479174004)(199003)(189002)(46102003)(23726002)(46406003)(47776003)(189998001)(5004730100002)(83506001)(42186005)(53416004)(2950100001)(97736004)(101416001)(5001960100002)(50466002)(54356999)(110136002)(76176999)(87976001)(86362001)(122386002)(69596002)(4001350100001)(5890100001)(33716001)(5001920100001)(40100003)(64706001)(77096005)(92566002)(50986999)(66066001)(106356001)(5008740100001)(5007970100001)(81156007)(105586002)(93886004);DIR:OUT;SFP:1101;SCL:1;SRVR:BY1PR03MB1370;H:linux-builds1.altera.com;FPR:;SPF:None;PTR:InfoNoRecords;A:0;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics-untrusted: =?us-ascii?Q?1;BY1PR03MB1370;23:VULYe0kNcLKK/unGyQXL5ZTE5W1HXJPjfTtxXXg/B?= =?us-ascii?Q?5vF3+pZlI4RxkFrXb7YXHW9NoPCSxS9pMsioV+792dNqqJY7dWjZ+v1owq3F?= =?us-ascii?Q?DjCJHgNp28XIdVFmOZ9w+NXPqiftRLa7DJu5ea9xk0Blh8pfPN3fDigLCgZH?= =?us-ascii?Q?uDDrxIrhbaQk1GanmTjd5SLp/7L3FaMOKG3ngerxkQLCwBWTF/ruJtIl7cV8?= =?us-ascii?Q?ywyh+u2XzN17rXT0PxdgGH1FzwU28eFmxzWUQOFkY3KSjnbhO/yG9+4mDdoO?= =?us-ascii?Q?Hscboi3dyWvEzYqTrL1p8O1TJiCwgUH6eJsV2UgqtX/HEzcw7PUMEiFQRNED?= =?us-ascii?Q?IU/3BKXd3YiiIXgav733/DlWJoYL4QGlC3YawiGwHGSkqHZYZ+dD5flkBiLZ?= =?us-ascii?Q?u3ysc7kYRw5AqIGhXpNbngaoefPAgh/KfRTb77Hthsu0XMnHO0Kd77BexSyR?= =?us-ascii?Q?wEJxrop+vU4NjGL6kOnduqZhHG7LJ3eKna+W4EElDYLIEIWZw4+JwIJfyDFm?= =?us-ascii?Q?F95IzxWcohm2tabWiFd1lcg5BuUhXWmZG4xVVXSuYHNl8zmljBbr3DwxGQtS?= =?us-ascii?Q?L97ExHUNeGc81pLUAUL7IGvubePXPrdIpCEKV78IWNqI8OBLjhXc96jtl9RT?= =?us-ascii?Q?Wm/HSJnSWlUxdoUSPe19Lx+lBwLV8cgEAILkCfngr5WFdsbOWw4YQEQ2Cukp?= =?us-ascii?Q?VTdPa/FXkvVxHSVImWRT+WYdm3XgBSHcLSZZ+knTAGu8OE3Rnx9efxgvpik4?= =?us-ascii?Q?g/dAKHlMmZL3ov9Cm9DtBgQLP+YQJJOVp6v1xVFNZi/FwEA47QkyWz7CBsHV?= =?us-ascii?Q?Rd6x+xzOzEJjILC7JMVN4b8zMucCs2pFEfo6PxSVOoIib2QRgpmfRYC8mPr5?= =?us-ascii?Q?NQoTUhhcKZqYsbnwu3KNwaaYknPp8wDS1rrWwMw0FL153kHMCQ2uorKvHxwE?= =?us-ascii?Q?wIMHMGCG2yuYT3ssLqOrz6U3n/oEnsBM9qXo4oMIseisLj4Hlu4ppvkXXx2A?= =?us-ascii?Q?vRUeYHKp96KoIleMcaY/iKJDKUwfPej4sdGblVLS70lZcGFjs8whX31cvFs1?= =?us-ascii?Q?KFOjgGFYAY1sOvYHrq83zNqse/K8beMHwBdu8mqcXviqlGtsaEcG6LJcYyxX?= =?us-ascii?Q?ETFu9qbTGQFkRcg43spxQ4bqOoxD6CO?= X-Microsoft-Exchange-Diagnostics-untrusted: 1;BY1PR03MB1370;5:pw+E52xU50NdNuE6utmJwMvGm3lork4rl4gfyxQ8SVhqDEXr1grFVEtzJq/5yO+bXmWVFIMkMCB9hDHgZmTFHZah/vdwTEymJ+oguLS7LReGOUfThl6E2gMKNn3maJKLNjFY7+Z7AwCxTEIB64DCHA==;24:mrSHKssyh3AkLDYGVBPcDb4J0l7macvUVpPpCxRqQbYwHhRc8o1F0wkKN3OpjbKVtMi9TO0ErNTFGviBcgT0qyvorXLA7UeNAr0gKA52Ibw=;20:6UNPSaRZmpScy77U2Xb5OjlHBsIdozat1b5O2eAz4VWl2ym0lxmNjyM0QVX8GncB0YMbtNb49IzEGuuE2zcTTXmCgqUl/GTr8dJtrByJbNrsOPS7YdKMe/Q0gD69VWJ+XgTko/l154EdXZJusZ1mKVC1D4TocxuyaQW3h9rnv1s= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB1370 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: BY2FFO11FD019.protection.gbl X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11FD019;1:qlRGaY0/kQN4n6/qIqYo4tGggDF8/otqIToQ4ZmXISOMYkgZUoNmfjeoqj6wKaDQOhx20qkX19lrtIW4uyvqWrWxPPLIkTw7XwVyth/n2sDLTviWh37mhT/woLJ7lYX1Etcie3BIFfyFIuCRpdOXRZqC9lEcb6MC0e/QLTgMzSsZGEgoenpl2mp+iqbDXUwNydS/KaKD6/1zR3hJyeOHqMYJ/ow95DDiV/9Xe2Qro+D5YitkgaJcsSzrz2C4A7lO2DXvt39XnT5EXrYv2S4EOX3xpi2I0jdN2ViStE+AbzKDpsWQ8xkNXHYMpE9lUFvKm1iUttka0LoGZXrP8Zad9L+LoKvp7j38YzwRCxQT/J6DJeObJjVc/EI6VywfXLu8xMCqtpA4ScDcX+B61l94sg== X-Forefront-Antispam-Report: CIP:66.35.236.236;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(1110001)(1109001)(339900001)(479174004)(189002)(199003)(24454002)(5890100001)(87936001)(85426001)(47776003)(77096005)(53416004)(46102003)(83506001)(64706001)(66066001)(40100003)(122386002)(92566002)(16796002)(5001960100002)(189998001)(4001350100001)(86362001)(97736004)(5007970100001)(81156007)(110136002)(11100500001)(5008740100001)(21840400001)(6070500001)(5004730100002)(76176999)(54356999)(6806005)(50986999)(50466002)(23726002)(106466001)(93886004)(105606002)(33716001)(2950100001)(5001920100001)(46406003)(7099028);DIR:OUT;SFP:1101;SCL:1;SRVR:BN3PR03MB1496;H:sj-itexedge04.altera.priv.altera.com;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;MX:1;A:0;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN3PR03MB1496;2:jFX3c2ngFttyHusr8kXdS2d/zqC3ud4tOojOmplj0sqIo8gwXr2mCBN1vJ/7gT8iRKx3/tjs1ydvUkFOQMqC1gtMioPVBSrRncURhDWqj8qLNL/dgo1t85eXKUlQz1vNHectq5Lch9QHNVe0MuTmF7MeAaScuNbQWbG4W0+Qu24=;3:l97WLaTte+cYIrKZdUxg8LEg2Km5IyVpdeJa8E24G1YNnPmnuI7EcqNkWezk4nHkXdurTKgyVeRPVmaDRfC4Wm6JGRTyrRonO0h2DJEwekavxc8/2sqZ322BY5aAN1DdpOJe04Q0Vu5+ZIGTJu7zaLQM2smZj9arGpNL1KlmiKDeCns9n4lyYgBTpgHYGCqjwMtnLr5/WiNt67ZqtE63+bdeHVLv4+mUX9RrZK0vaus=;25:RE9gjxu9TBu4heO/G0esYzGdLNzof9fsev29r4s/MvE2o1JLeRZAmTn/tZBHVk8anDzEs1Jfw74GInLcwxs9fPvs1Y4yuBnUlOig0cNp2o6FvOaMwPPXpbwnuKzguIENEBiVXomZZY6kPSRPWBccqHYyw9HyYrdNOudJyywq8IqcX2ouytOaNY/IZU7mKoAO8kIEqekglv1mQaYn/X00Q4SKwugzx/QjsDJ+/6JV/f0AvQvG7xSAuw5aDHXev5lDwGL4zoxdJJR24rVKAkvi7Q==;20:NikeqOB1K373hDtJgVbZaE5hgP78QGJXlr3W1EKF4D27bfoIEW8C2pAiinx8YQg83TB79sks2budkSqyumktVVqWgMtBCpaYQYM2GgBP73dNvz8ZRwq/7iruYzqnbaIxvrHKn5NdzBzE7f1g8YBAFo4sry+EIBaYCopccNyr/i4= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1496; X-Microsoft-Exchange-Diagnostics: 1;BN3PR03MB1496;4:Vfqgs7Jscrg6ynA71JMmHFSTwSY2INx5MfXccW3tPVS9AoT+EuHlfuZ9/7DtOA6neyye5nAr/HWwGD7s2iEPFWvvX68RzySmqyj53yGUrTdPW0DwYqO36PHqeD6Msjn6q+J6INxkmVzl4zXSPgyc9Lw1a0Ju9jV0xgYkt4dinP0ItDskDs9/Z/3dyzQZLJb9ppr9fA72yYRlsi89T549DleaLA3XPHnJTw1yJo43I9p36/Flyr1BawRW0VTQmzr3BpG3n839JyXsGz0O9V+Fve1bCl/x1GOJvDeZY/J5xRxLn0yHDN7cSXZh1sErR39P2lyOYiEs5EYgVev5AdSl8zdYC2se5sN2VUQee7up8FQ= X-Forefront-PRVS: 0731AA2DE6 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BN3PR03MB1496;23:6NJg1KU8aquO4vu0BGspSyM+GU14rSoYUUFZu/xb9?= =?us-ascii?Q?VsuLPyfapxhfjv3bfIURc+1d3EWBkhKWYOQa9TaIebREcUQb88mR4Js/2SJx?= =?us-ascii?Q?XTdZJ7Di5RfyMC6kLZkky0WOX7iUSEswMrQkG0xcr1XEFoDrW80b2cbKM1eT?= =?us-ascii?Q?6dizMGI01vs+LpZgoA/5u5roLC4irlfvXBErzk3+4uQZI7MACBsxEdrUGmXB?= =?us-ascii?Q?ox4dEWVRvLPkXdUB4ifniHE0Ka7WO6kmLltSCM9DFdao5VqY8g2rkVwCmlks?= =?us-ascii?Q?SVsRlGWoW/dG/5vFOctT8cCRFBr9gvjzQxc6hDnhekEdsO+r7s+Z+364wEB0?= =?us-ascii?Q?Js3Qs86lUkJnJQwKmakCyutYKHh6/TPhxCH00YP8HxeXeUtQel8V/YbaFmCz?= =?us-ascii?Q?W+PuWsFg0ncNh1pR69kzjKDPiI8+5SLvj6fmNilX78WdzQiztvbXcndzZgiM?= =?us-ascii?Q?Fu0305/lv4RNl1eifJ4LrGj02yPWRz0FL31fX8/QHDBIdzuJ8EE+GT4nfXi0?= =?us-ascii?Q?ZtTKuoHXmkuVm7HTR+UKKoS9/Azfb0g1PBR2/BLAjQf9ysulRMCZJ0NkQkh0?= =?us-ascii?Q?DLp6F5s6q5mFsSdNtEO02/A/NC3J3o/SGpgW5Wj7bHcSKAYUO1fCweZTL+fZ?= =?us-ascii?Q?wjLuMp5o+LMCC3Rx2C/SgxxVUmInpdtSbpi1KIPLJtVtEfudUbjuLRFCDXiG?= =?us-ascii?Q?IlPahOx7lFHqoDkcYVAN8ETiS6Ag4d20pwSZYPJIhNMYMCL5om57bRdUP/jE?= =?us-ascii?Q?kSzIIcIsIo0GSmgUDnoNgMVwoIyQUlG51UhMtixsxkcMSc7KHwgFMJuYjIWb?= =?us-ascii?Q?Wh+DHP6I3/eNWCtrtvB8tKSN6gMqnWj5+KEOZKaARj+3gXa/bLnphQSx67Ll?= =?us-ascii?Q?r05DHJKclXyCTcUpFIaffjqzoB+E0OJ5k7jNIoHV7949R74xEBuUsVsOmOYG?= =?us-ascii?Q?ftrlmYDqJiUf4I7NvBFVSRqa0ven3OkFgezs+s0fuvMJi3PaUOg9Dj6hdRnL?= =?us-ascii?Q?lSqjed0n6RrY3P8UgNwiOWTUufsTUOxuY4kCANfVyvt2O5TY6k5xP6E4X0Ty?= =?us-ascii?Q?TmJQq39kxmIVJVvqCMYlFzqHTmkEhZjXL5OYWQjx7oHzoFgiXr1iVTJ04YzK?= =?us-ascii?Q?bpEe09MOORFaPjWP308FT7IBGnNRnTZf+uhBg62FV5o0JMmt1dQxEn5lVre+?= =?us-ascii?Q?+QpyQGlg1+/BojvLZzpF4QdBx3CtwPQI7WSTD7QzULWnVsjorM4Rjm9EZhEv?= =?us-ascii?Q?qe/FdTSTL6ikFrEwmXFH3NFxYUA33ndVIn6wS8swPe8+MOFC806hfzjLmURj?= =?us-ascii?Q?ViFFCwnXRYYTn8VfyYGbZX8hsB91wmM3VyEygv0cDFV?= X-Microsoft-Exchange-Diagnostics: 1;BN3PR03MB1496;5:h1IQ7yHKHrVlZicYmNgRzxVkcrnry0/gjPLz663jtgvUljS2zNpIBQ+op5JeSIvE5eHht+rekJ4+RCjoGzIQio3tynspjlr6yUF3Mzn2neCU0hiOJdICelNia0yw2N34J+4NGvh9Tyk9rYhczfuuow==;24:fI1MuNIAYLzGl4GBTYJzgrTgYqebag1aOd5f1q5AqU+Hym+Eb1nFlQwUsFniL0aKIcY5aTN1y0rl5XXzvPg5fCDi8oQ0wEFwAG+oJX3Ops0=;20:G/BaF3rS4xfgG+oF4kyepOy45F/nwuY05od/VbVVEwgoNKevwR4V7aLP4B2mc376M95qSJESVZd2bNCOJAFfoK6yMJvR4x988IECbZT6bbFxRw1q4MNCvWBNsUSa77jvkHuDSbdYiZ3Douh70JAl4hP0k88r8XcalcGhga8ATok= X-OriginatorOrg: opensource.altera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2015 02:39:12.0718 (UTC) X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a;Ip=[66.35.236.236];Helo=[sj-itexedge04.altera.priv.altera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB1496 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 15 Oct 2015, Florian Fainelli wrote: > On 15/10/15 13:49, Dinh Nguyen wrote: > >> > >> Does this text change with and without the 8b63ec1837fa patch? > > > > No, this text does not change with/without the 8b63ec1837fa patch. > > Could you instrument mdiobus_scan(), get_phy_device() and > phy_device_create/register to see if the parent is NULL, non-NULL? > Yes, I can do that. > So far, I cannot see what is wrong with David's changes, quite the > contrary, and if there was something wrong with the PHY device creation, > it should not get you that far. > > You have not answered my previous question though, do you have PHY > fixups registered for that ID? By fixups, do you mean the skew values that are in the device tree? Those are the only fixups that I have the PHY. Another debugging point, the SoCFPGA board has a Micrel ksz9021 PHY attached to the ethernet port. What I'm seeing is that with 8b63ec1837fa patch, when the call to ksz9021_config_init() is made both of_node and dev->parent->of_node are NULL, without the patch the dev->parent->of_node is a valid pointer. Thus the skew values get programmed to the phy. BR, Dinh