From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754219AbbJPPAc (ORCPT ); Fri, 16 Oct 2015 11:00:32 -0400 Received: from mail-bn1bon0083.outbound.protection.outlook.com ([157.56.111.83]:43683 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753200AbbJPPA3 (ORCPT ); Fri, 16 Oct 2015 11:00:29 -0400 Authentication-Results: spf=fail (sender IP is 66.35.236.227) smtp.mailfrom=opensource.altera.com; cavium.com; dkim=none (message not signed) header.d=none;cavium.com; dmarc=none action=none header.from=opensource.altera.com; Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=dinguyen@opensource.altera.com; Date: Fri, 16 Oct 2015 09:38:37 -0500 From: Dinh Nguyen X-X-Sender: dinguyen@linux-builds1 To: Andrew Lunn CC: Florian Fainelli , David Daney , "David S. Miller" , , , "linux-kernel@vger.kernel.org" Subject: Re: SoCFPGA ethernet broken In-Reply-To: <20151016033143.GA28207@lunn.ch> Message-ID: References: <561FF9E2.30102@opensource.altera.com> <56200687.9040903@gmail.com> <562005AD.8020903@opensource.altera.com> <56200BD7.8020505@gmail.com> <56200E15.9080603@caviumnetworks.com> <56201158.8040806@opensource.altera.com> <56201AE7.2020103@gmail.com> <20151016033143.GA28207@lunn.ch> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [64.129.157.38] X-ClientProxiedBy: BY1PR15CA0038.namprd15.prod.outlook.com (25.162.17.176) To BLUPR03MB1362.namprd03.prod.outlook.com (25.163.80.28) X-Microsoft-Exchange-Diagnostics-untrusted: 1;BLUPR03MB1362;2:RYjPBYZzQoVM+HvN98MZsphRqWxj7rWNTsb6Y3zN7Xou76GzK7siEAhdW9d4UuVoVEu4sQZWAa2K9X74fYN1gxZsZPP9quFq2gQ14BNRjlQ3MsrrpGD28OikihJ5ofo6S3kvVYN11hcfm/O3o165wPeaO2v9JqkzepklJ1lytjc=;3:LOaTEZNXQ8o/iV6rvLubaQq1OtBoZl6lrmmyMBYrohWDwJsZyJAFtEhBp2VlRKrIvcCOU1hAQfx64TLZs/lklUc0X9++dM4wILA3joijVBbum7zmeE9d4jtcEQKz5Cra2hPZTZxIV8+FQW7YMSBtKA==;25:AhGOjtXmISfJV3WfQjjWT+Fi1oOAjxDJFLI1UIW5Ok2VTO6zrhsyUudHBmFIBvASpBlaxhrLSNNcLeWRANWMoBJ+WIdmE7iOxrqgHFwJIaETssABA4h+NbjQCxGRr2Sft+GHr/YO9LjpPIX7xDVZOXrzkdDl4qWYqLYqzQN1CWdlRbLgFqrcnncMyxdNA+PLZDmr1zAs/xLGMmrfgCumHuIgeU3RFI89iVRS1/mZW17+dqtEsi9Z3Ync4hqA3aijuKsf7kxMKBGUV7g5wtJpNg==;20:cOKbNdPCJTzq7KjDuRq3pjw38AVlxvUiwgDC7XDlz2/5E71v1WKB9ByFUMyVhRjpURh0ahZLFZ4+cbfUiQQ4VKgVkaS8N0b0mKbKnNVnJSwSa3jWQrEaiRuwm8xMWWCU87kJP7vN0+pg9XK8q3Lh8sMK0UVWLjqhbNs2vLaPaDU= X-Microsoft-Antispam-Untrusted: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB1362; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:;UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(520078)(3002001);SRVR:BLUPR03MB1362;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB1362;BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(8121501046)(5005006)(3002001);SRVR:SN2PR03MB046;BCL:0;PCL:0;RULEID:;SRVR:SN2PR03MB046; X-Microsoft-Exchange-Diagnostics-untrusted: 1;BLUPR03MB1362;4:pHzMpoBP77ZvpmR+Jf2ItBrlwL16aW0qDNLBv1IJFwRE3/8sC3xG/xHeTSbY35adr1PiSjiOu3kIpFGmpWEJTKoAZrYrcf7PTmUbpVuEdDaXgE3t4HNjIqkFJPeZZFT8gJVXB1GtTNQtSBiLdGkTk8KjFt+F9jpAgWRUojzYjs5l2OAlhES3H7Vjr9FHoQhM0B7SVGueMkh9Z6FmTl77BKJIu+wvlo2zTJM+IxorVnotypMsPTfRYBrhIT4XhghKHR2dWf8lPLni+FH2HG1gT4BC8SSigocLPFAv5qmd+9oocyZlj3DvBAA1zMRuIbXZ09s5iBIEy0H1uTpnKkuy8kc7SO+p+bP4T6Mm2bkFioA= X-Forefront-PRVS: 0731AA2DE6 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(6009001)(24454002)(199003)(189002)(106356001)(50466002)(110136002)(69596002)(86362001)(97736004)(33716001)(101416001)(83506001)(189998001)(87976001)(4001350100001)(50986999)(93886004)(81156007)(19580395003)(54356999)(76176999)(77096005)(122386002)(40100003)(47776003)(23726002)(46102003)(5007970100001)(5001960100002)(105586002)(46406003)(2950100001)(53416004)(64706001)(66066001)(42186005)(5004730100002)(92566002)(5890100001)(5008740100001);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR03MB1362;H:linux-builds1.altera.com;FPR:;SPF:None;PTR:InfoNoRecords;A:0;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics-untrusted: =?us-ascii?Q?1;BLUPR03MB1362;23:dpa5xP03A1f0GEMvs6Ietye0xsr9yZoorsqdl1OIt?= =?us-ascii?Q?MPozYD2ddy15rlsLwJ6gWxcN0v7UrdSiiixTCk/N2ErQXC3GVjVJiBn7EhpA?= =?us-ascii?Q?XORsqhMRUcH1M/nLNN8NSlij89Nl6/ry/4jXC5luFMDqP+6zS1k5Bpf3TDMi?= =?us-ascii?Q?kaGlu/zG3y2bzAoGl711jxJ56DAKyt3LrXBzC8Ua+AgQutd0i8x64cN856yp?= =?us-ascii?Q?CDbRwNMGWzJa06u8ZVj17sj/TwDvNmmkv25ts0D86GSPRTn40xtmSY39EWHD?= =?us-ascii?Q?FLdhaz57yzB0smGrBLGUUt98UwFuENXP12tu5jA1TNqyh8z99jTLyKelIpY3?= =?us-ascii?Q?aZ08v1jXtbzy9I7p1eHeC5UyJahB/s+RDROZn6o4eEBKsyePVEeSvqD6HF5K?= =?us-ascii?Q?gj67sPIlLzs2rAHo6nCp1phdQadV0QhZ37W57BeHj6ASHcjSaFSmw5LpEcIc?= =?us-ascii?Q?z9jOG0awm1wmIwrgdQhafqeiJtpuNFXOKOW1xpn6zEakS0gJ6+d+i+uaIIcF?= =?us-ascii?Q?LfXnYwC3ZJpu2YU4/lZtnVxnj+tYQNn5PJ22996DnyBMMlDxWOLmILV9Ij1S?= =?us-ascii?Q?H+N4k5dq6ym9FHqWcpdhhmuI8Yrm73Ta93zSjorNNtYFblrxknKEK7T3/5xT?= =?us-ascii?Q?9m5f5HhkVZXpTvQsr71xdHNo5gOsgC4n41ErK89HFBSRPrGWC/c4lnNr+vNC?= =?us-ascii?Q?k3d7EExSUEJm2o/GynQsx0OmMIHAGMj+FOCPd/tyVhesc5AcN86iS6cGzP80?= =?us-ascii?Q?VEzWfz4EpthfdXYro9h6HHroZ7c/HRO+QhVgCwLOjRCs/55UJIutaq++o4kj?= =?us-ascii?Q?oSndyVhD6Mgx6y0R0N3BcnSLDFCIF0fAibSJG95BLta65EnzW3vXuP62sM0I?= =?us-ascii?Q?k+l4u12RGF5cVuieHkphNgo8k7ChIp6/Lt6u9YZmi1YlX34qgV//2Dig6SaH?= =?us-ascii?Q?Y6+35OyzKOP3XW22ZstSBj4vRb7lnCOQL1nohtkSX/zhDUqndnJkpAoF86Cw?= =?us-ascii?Q?9ZJgLcfTbjpNOjFhy2lBUFFvwspExod9uu38Kr7grFX5PbtDXDNackDjdOc1?= =?us-ascii?Q?waDzmkayYL/G33aA5dahqlQlD3qT6hd3Q/o4dR+Xk+ubMLoJ9JPveIoG+5lj?= =?us-ascii?Q?VOMMymWeAo=3D?= X-Microsoft-Exchange-Diagnostics-untrusted: 1;BLUPR03MB1362;5:yjcrL07aC2YNIpE2zq78RkaSZtXf6fdAPOCR3sjFZKOh3QgbC3YqcRx2HQBFiswRJF7zT68B9sV/KxLW5LWrZbvdrXxiosnfiJjuNvanHp6ang/sIkhAgLi2e7k6Nl40nFzBle+9pLz1AwJF+iznFg==;24:sOXY9qc4nAj9Ve6PkbDY5SVZwrrEW1xFdOiMB8Gm31li7XfLlY/T1p4NwPqFHtdCiFhXhDZswvRbJCGgpYh3JW+uEEZTpwrby3wu2WsVduU=;20:YpP/Owf1QTzr14fjA/MvmsQiB/NVkWVht07Hf902czETfqcDLvB33ShCaFRliqC2OHWMSAwvLZabx9oiagvzQvqI+Ds1mhSq2V1OIbKAZL+QrfdXglHsIdvRijpTo0w7zdf94noHXH9vOlLv8X+kmdHskXD1HPSpV3KQXaJh86U= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB1362 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: BN1AFFO11FD009.protection.gbl X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11FD009;1:ciwyjWCkhYNPqzekjXb2/n4WkvK4JjabgVdQYO7CMwVbzoGAPD7RZ6jmaDq9wX25WxqJ9JeGdqJzGUiZVOTqfvUmxToe7sfAINM1NZ4wLTW4lOUBEduM9VOz+CmIA+Z9DRdNA5OzWcRIxqYATM3+0Rx1wv32TfgVONw5qfywckLgbxTmn4sWhbWS+L3FZuPs2t6m/6JzbPztCPLg+XZoIwTB4J57NSXdprveG/gYSSh0Fh6Oem7tPg8HIYoDl8PBAVgoepEXaCvdY03+kMHMswyTi08WCpjTz1JItW6HveEwcLUtzGRDkegb7eU/3ltGZJoVdp5Frf2YbWD6q4B8ZeDS+F9Yi+g454OLgRrN+L6TKc2o9bw+f8pMaKhHIEtZnuqR1o0Q7UJi9Wl2eqY2kA== X-Forefront-Antispam-Report: CIP:66.35.236.227;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(1110001)(1109001)(339900001)(199003)(189002)(24454002)(105606002)(85426001)(40100003)(83506001)(87936001)(5004730100002)(54356999)(93886004)(92566002)(5007970100001)(86362001)(47776003)(53416004)(76176999)(2950100001)(50466002)(77096005)(23726002)(106466001)(5001920100001)(21840400001)(110136002)(50986999)(11100500001)(16796002)(46102003)(5001960100002)(122386002)(19580395003)(33716001)(81156007)(189998001)(5008740100001)(64706001)(4001350100001)(66066001)(97736004)(6070500001)(5890100001)(6806005)(46406003)(7099028);DIR:OUT;SFP:1101;SCL:1;SRVR:SN2PR03MB046;H:sj-itexedge03.altera.priv.altera.com;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;A:0;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;SN2PR03MB046;2:UDWncsBxBBgGaeMCs+8MMd18o9WzlVuitXHgvZpRC93yVAPon2h1mUxLN8vVqqymbGWkC0rRZ8PhDUAtat4Vgt1XbCWyNo4WKG0qqkxMaGQqG16yw+fW6SCcPnU7ykSW6ZYk+Zdi3pI6u+nUsEIXD46DFXhox6bLJQO10hm4HG0=;3:K6ERtd2X7yGwdlu3FmCqnvW13OE807RWn08P1UCMUz8O2yiqkmz3hPAvzWV9n7/kNBs6fDwhT/Bxleb2ASWwYD0sANTw3y2fdO4SMhrEIDbHWlLyMXMo9JUU7mXKKrpD7r2oe6aUbc1VI1SEBD3EGqG4Y/WvAUEvEBQd0x45LrVc49nYer0XeUJ8e/2aWDHVltzpzOHbmGtBMTrBp6/wWRIWDIe4qf87Hj05KYUh2jk=;25:xWvNHBQvMHoajmPu3zGaqbwmjK4vWrKDd9j2NleiSSHSuBcvHiQEkAG/hwOHu3D/PI8Tb2TxKe7emPmHjUsHvED8L9J1yM5RtTTxxuDs/Ajd2NX/mqksUwGkGJgpnaL/NpS26/uAS2OlBD0CNjOMsW0v2QaAj9w2auv9BduTkCbMbtUaA0fmwvm01hdJaryAlgXeY6ul2ELIOxqpTWafBySSDSri7jcv+vSZQdIw/t1YIOrGlrjuofHgpqJ+D+jQqCXcHO9oVeDAE6EpZsNcUQ==;20:Hj7V8ljPCyO0lZHJFErqL7/BD+6s9j1EHT9kV/PurbgK3Y4iqez6rvZgJeD3iQjALLUppsgaTreWpWenlO9Poj/UKXW1eqgdeu/EvAiTg7xUjFJCG0iHPRRLRhBMMC21diTy1yaHx8rb0y+7jez6ujUIMX8wTHre/JAVeAIcHjc= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN2PR03MB046; X-Microsoft-Exchange-Diagnostics: 1;SN2PR03MB046;4:vpWDjn8ISkPs62B4K73CPq/47DQz3KnoFi8cFUARRPCMblAXT6ji/YL8EGzghXUzmCYRkxiIWUy+hiPpIV5ryQ8a0MHAf3zIXu8Qa0T/vINnZysnZ5vFwL+BW5omuyR4Z3y7J1+a8L9aMHr381RSLuvcq5eUOmogrUlR+VWnoLK5qUpNAef/kUbXoo8idpOGGYINMiu/XgGyRas3CgkbQjSUr2nupe0HHEejyo99EAWTyZ570CWnGU8SYpxqitceWzDVN3GoX5LgBERoFCh2QsnJgVZD7kX2yC8Hz5D2qT2at71ZOyNCUNgmRDN4Q4oOfH97jnmxs7KytavrmM4uu+TrNNZg32XQqbDUqMvDl0A= X-Forefront-PRVS: 0731AA2DE6 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;SN2PR03MB046;23:a1THdGvA78/HVCe8UwJdCQ/aQNNGoa4truWXblSH+q?= =?us-ascii?Q?St+wIBMYn+SPT8Rvq3xD85NW0T9/T3xW0b5SgK8lPHa0q1j8Y4P2jg2Hleap?= =?us-ascii?Q?b2hq4/S3FnrtDsjuzzLzBh/XK7NS+G+Vku6/jIN+Y9SPf+QUlX8XZV9ep9Vx?= =?us-ascii?Q?krMBqW24M0FxI/p+hG5UggAhS+8GWtjsnyp4Ng9+KPx1Leq5MaG76NGqk9Tr?= =?us-ascii?Q?tRnZ6DpA/wm7O+tRHGTCikNKbsGzpTqdP74FSsAerC/KRMSpmfNbwcDR2njy?= =?us-ascii?Q?RVQ0FBQ8BGxIDHnpKImmPbdGpNkSYjp0BHOGNdvF3IVir68dtpIWZUv+g6Za?= =?us-ascii?Q?FBIHXlw/fThkcLthF5uxZFMgJi2Iv32GT8esxv+iGh9/4DdGFUeLE28eQlm2?= =?us-ascii?Q?m+kCJLUq8vNG9pwazJJ0GqdLMY07xBcKSet4aQG79vQvopPnJOJt/cj6kR3h?= =?us-ascii?Q?OSjA1LXye/PaqitbDu30roLboldkg3bhJ72/5X+CdtJ+rVS47vKvHCm8C2jb?= =?us-ascii?Q?FX9MvE2JSVXAsJFPqoZOvbWcEQUMPLSVkkOtcCs/k5RN7W6w9VdR8LMNNlDe?= =?us-ascii?Q?W/QTisFOIVW4flXjeBpr66dasyaLLDauy/Dps5DRFgpOX5ccmKJgKbcVM6Yh?= =?us-ascii?Q?SdbWtNI1KaEuwiAXEWlsM64sRXVOtibEQyvXWFK4Lr42HS8C6LfKKnyCjdjh?= =?us-ascii?Q?2xWrOC9ZuCIrqWuOmBWqUzAGH4XtUqGd2m/sMiXprZWhMAmjXr2XzNPcWvWy?= =?us-ascii?Q?KXWplGv2QZUJ7895cfCyYaTU1kuPkiEexr/fyl1iaTAQpY4TQjIZiWtURFwx?= =?us-ascii?Q?2jJvyAJv52aC2j4DbKKVKnO1CBQu3/kQH7qKBMaCXaGCTnKBmTL0U4EhJZc0?= =?us-ascii?Q?TDQAic5L3ZOdiE2O8tgxK3gQb170W3fXbZrTK+1xvhbQ3QhAGEsqQuU80nyr?= =?us-ascii?Q?6v4FguF0Is79oy2CtHnNqMxTCnYgjoL6dM2H1KMIZyy3xpkE5CbKXVCzFDB+?= =?us-ascii?Q?tbCSttVww61rOnyywN5shSDtzYTIO0IB4cotmn2764k1pxqxACgUohHTGKdY?= =?us-ascii?Q?o6vFowmB4/dat4D5SQjRs1/+sQbQqLWrS3emmSDKP5GQVZ6Rkb2U2nMp0SV/?= =?us-ascii?Q?vltKenBss4D+n+Ua/9EaSmYvEJF0J0bPuX/ymCaQmQ6pflkLSA8D1j35tktd?= =?us-ascii?Q?dDn5pfKnni9YLE98bZgvyWoUscfJpLsQT9oDPzXK2tYNm9lx0P3qgYXgTW8x?= =?us-ascii?Q?rvWzqMSRmeWcb50BRV/gsYZU3hEkSYVUGE/YUJtCPTU0TINMSyuTQ6oAInef?= =?us-ascii?Q?lUtdUxCFb111fwcUP1MY0Imdp8lurCVnK89JcYvWEN?= X-Microsoft-Exchange-Diagnostics: 1;SN2PR03MB046;5:uRD2WWD13YDWhol1H9EQUyi6pgluLvXv4JLIygKrmZ437uW8C3W3MA7S9b6orIadwyJO+6vN7WTMm7osUYXxeYLj7hjOqcHHaHvJ7ZmaaRjttyQ9bb/NPY7udhdVISuXr7L/r/PTkXmDoKCwWU3D/w==;24:geDuxxpKAuKOeZXgr67NRgnpPBFjAAUZRcGj79d217Q9XUT+izZNJRZrXUbVFP4K/wn69MjY5VgC887ZnrOtv6UDJTmUNWrDZF6cU1kPT/I=;20:d8rm40juhedFF0shNMzmuPILUZZqYkpNNKmaD+VKbB9op/jJbf1DCtpbhzHix5Z4/mu/Ktr9Msb857WJmOvL2turrnnesixTJCMyt4LOaDDJiEe+2YH06/OJBoNiugEYE5cR+YtImxZod5aQeUNQJsnR+HdaLgKSBIp++glhdLk= X-OriginatorOrg: opensource.altera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2015 14:45:37.3567 (UTC) X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a;Ip=[66.35.236.227];Helo=[sj-itexedge03.altera.priv.altera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR03MB046 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 16 Oct 2015, Andrew Lunn wrote: > > Another debugging point, the SoCFPGA board has a Micrel ksz9021 PHY attached > > to the ethernet port. What I'm seeing is that with 8b63ec1837fa patch, when > > the call to ksz9021_config_init() is made both of_node and dev->parent->of_node > > are NULL, without the patch the dev->parent->of_node is a valid pointer. Thus > > the skew values get programmed to the phy. > > Ah! > > You have the phy device tree parameters in the wrong place. These are > phy paramters, so should really be in the phy node. But > socfpga_cyclone5_socdk.dts has them in the MAC node. > Alright, let me see if I can rework the DTS. > There is nothing in Documentation/devicetree/bindings/net/micrel.txt > which says you are allowed to place them in the MAC node. Obviously > the code did allow this, which is what has now broken. > I was following Documentation/devicetree/bindings/net/micrel-ksz90x1.txt and in this document I was following the autodetected PHY example. Did I mis-interpret the example? BR, Dinh