From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754242AbbJSPVj (ORCPT ); Mon, 19 Oct 2015 11:21:39 -0400 Received: from mail-bn1bon0058.outbound.protection.outlook.com ([157.56.111.58]:2608 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753717AbbJSPVf (ORCPT ); Mon, 19 Oct 2015 11:21:35 -0400 Authentication-Results: spf=fail (sender IP is 66.35.236.227) smtp.mailfrom=opensource.altera.com; st.com; dkim=none (message not signed) header.d=none;st.com; dmarc=none action=none header.from=opensource.altera.com; Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=dinguyen@opensource.altera.com; Date: Mon, 19 Oct 2015 10:14:21 -0500 From: Dinh Nguyen X-X-Sender: dinguyen@linux-builds1 To: Andrew Lunn CC: David Daney , Florian Fainelli , "David S. Miller" , , , , , , , , "linux-kernel@vger.kernel.org" Subject: Re: SoCFPGA ethernet broken In-Reply-To: <20151016193854.GC28207@lunn.ch> Message-ID: References: <56201158.8040806@opensource.altera.com> <56201AE7.2020103@gmail.com> <20151016033143.GA28207@lunn.ch> <20151016150345.GI10146@lunn.ch> <20151016155644.GJ10146@lunn.ch> <56212A09.5080206@caviumnetworks.com> <20151016193854.GC28207@lunn.ch> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [64.129.157.38] X-ClientProxiedBy: BY1PR15CA0004.namprd15.prod.outlook.com (25.162.17.142) To BLUPR03MB1362.namprd03.prod.outlook.com (25.163.80.28) X-Microsoft-Exchange-Diagnostics-untrusted: 1;BLUPR03MB1362;2:DjEsMrzRcVB577eG33jfQGHSMpJy6UqmlJ0jaVm53ThoDKitjGuikBQlImPKwcYumwI9cMK4G6Tism7DMilAR6EbfJ112NfCSekjfyAeBqz2v0sRf4/CR0hu8+ztTK8Fd/+5PS5Gag0RSQ6Qn4zBNM5oP8fkQCCt14wN8GhdXWU=;3:+ETC+Q9o60ho72oEY6GbtuTR8trA9NRvfIGdja/GIYKihg1O9Z7e4VfT61qv0zcGMgp4oF4gujTZL206NRm8IxJJh90mYRA1mHvX/5gVvsVSoSI/mAe11VL3RbD7yS4keOC2NStj0PXavx986x4mLQ==;25:Ybh4+8j0COF0Oq0ODk8pKlChsx5x+6gjrESBL9lVn8dILvxrcIk858VdkFG/Wy6hwi1NtMXNaVjSqfcqg+c5qBUg+iu2RbMLzr2kHdTJXSuck0gD52hrb0teydrh1/yQo9WNPte+aouTQr60vECGwX24d/wRq60uG/tBlo5vZnvm8R3k4/NZvRZp7FNrJnAqetfNuEUDX35/FBKmSxh7SAJ7xrUJqWXjX4Te3mbcQ8QQST0nROxoDZZsvdSaQQ1/k1fd/0E33RbAB7IM5YCHtg==;20:L95n812zshQ1ztUFddo6L0QjXDPcl02Dw0MKLuTCwd80RftnOHAzZmQW7duIRhekIvC8TUKv1OT97jrspHT2gxAzVCm2ae4nDehLgHiCZL+m85P/D2j1IwX05wUgMQv5+pRi02P0jhJHbscRHT6JrIWpvGvZpZO8ct07Mioym48= X-Microsoft-Antispam-Untrusted: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB1362; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:;UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(520078)(3002001);SRVR:BLUPR03MB1362;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB1362;BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(520078)(3002001);SRVR:BY1PR03MB1500;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1500; X-Microsoft-Exchange-Diagnostics-untrusted: 1;BLUPR03MB1362;4:QmuBVPBqbbBZy3KtTbNXdtQdoBUJMcxAm1+wIAYB0N51YQ5ODLw1rXlEZETfoS+Drg+0ZYG0CGg0b6W8tFmmimEcMn9TQ1zRVUpgzeZXkFr3Kmrocv2MglWpRcBMlENqGNvHodLJe1nmpY2KuPMixOJZ3zjsFgsgMLQTiX/DICY+iHT3s2OhV+K+Vxk0urKU1q3gHG0vkoA5GiTl3MovLYye/0WW/vTEBWtg6qr63ePCCQP1qZIYrH4Npuw2SdD4+uh7o9S67Q2zXA8hFikBq66A+0/nUGQ+4JVtwa6JyjxhdJwSFsPL0/AVf953ZwCvt5PhZmUvHpLWQIN/opzpNhP9YCr5zqFzGjxPRTzDhxY= X-Forefront-PRVS: 07349BFAD2 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(6009001)(189002)(24454002)(51694002)(199003)(4001350100001)(5001960100002)(189998001)(46102003)(110136002)(76176999)(54356999)(105586002)(33716001)(93886004)(50466002)(50986999)(106356001)(122386002)(77096005)(5007970100001)(40100003)(46406003)(5008740100001)(5004730100002)(2950100001)(53416004)(81156007)(83506001)(5001920100001)(23726002)(42186005)(87976001)(64706001)(47776003)(66066001)(97736004)(92566002)(86362001)(69596002)(101416001)(5890100001);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR03MB1362;H:linux-builds1.altera.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:0;LANG:en; X-Microsoft-Exchange-Diagnostics-untrusted: =?us-ascii?Q?1;BLUPR03MB1362;23:2K6jHOeQB065tb8PPWW6EcOwNbqXr0wJKqLh80xL9?= =?us-ascii?Q?l3ERsy9X9ZDCzlymCdlEsRcvoCOb23IKvskU4E/v4gR0dkEEQsRfi2IYCsNY?= =?us-ascii?Q?4vvgDUNEQ1dtAyoKCvVbaEZ7mXLS8CH1oF96kZwtG2SWrmWGPIya3xD79Q3y?= =?us-ascii?Q?vZnk6BaqdtgjsAG2RjvPR59Te6wiytiWJq9Fu5BTR/69SBMZE1PUb/5Lqiwk?= =?us-ascii?Q?X63zwPT5I7yHGle8bKk1+LSP5+0rsElUerXSGlmk6p8yd49JbY/PWo6gtx9X?= =?us-ascii?Q?44lmq+ffAPXm2cYle1gUy879NyrtjGTkV73q1jaiNbv4eFa5YNkEFDbkEeZO?= =?us-ascii?Q?L4fydU63T+36hdXAXD12Qwx5YaY5YNDYh4ByK+Sh896y9AfWYrBDLLCFHMwf?= =?us-ascii?Q?GEmETZ6AVNQpBkysQoBKXyuPKc0OU8C4wcghf4DLpjEcYcjmbrTq4qAL4qlf?= =?us-ascii?Q?jChXWWGHdNU3mpfllLFfWJbDMbSf5x9GCvMe47CU7bmKdzjw0F5AO6fCGObn?= =?us-ascii?Q?oHCDHp+de9gsNUjphtJFY9UxRPETG6U4X/FCwvuVJbfBBu9mVXhYWNbSpSBR?= =?us-ascii?Q?OEZyFfpaAfGlRD0oFi/sjFzfPCT9xZAVSZ/8daa2cPr1rV3rkFVAnfLizpO3?= =?us-ascii?Q?sqyWeR0cojuEOyGq7yXdz4Z9XVs90FEGusrW8VDqdSlfAO50J3tQqLQ0RSs/?= =?us-ascii?Q?i5q//UljijZigVlm9Fh0xlco7xY8iOL2AlOWsrNs3JnnmaCoYcV74BTrqMyT?= =?us-ascii?Q?GR6mSyNdROH18d2iLJ/JoxjLB+e+wWr9qK1l512omDllvEHLWH4RUa5sK5p0?= =?us-ascii?Q?gSVW7VC52xzcCoOuCuuYJrOelvoEyuVlI0CLWdYvpCgt0UQldZ7RLdm0zTFc?= =?us-ascii?Q?vB4e7dkUwadozLwFUo/KU0DKtGutKG/NTvx4TA8Qs6HdUphufTsEjMv358s+?= =?us-ascii?Q?SaevcA/bQAOfNHTNkfxoNWt+zItfaxTFmo9GPRGjWyJzLJOytf/E8bnWAA0V?= =?us-ascii?Q?BM/zwMavY/Ap9lVavr4nnMBoTFb4rFjAwfxlqg1pZZamG16U4a9o6ircBZee?= =?us-ascii?Q?5JHJeoEV5Bh4SpotBv6VNRkSGYAenB/w6v1mJMdyCYSysVLW5dOrOWZWVpMG?= =?us-ascii?Q?i1+ybUMJuslb12yVCWMQnFxDUMb/DZr?= X-Microsoft-Exchange-Diagnostics-untrusted: 1;BLUPR03MB1362;5:AIR9vMTtOXPRZxA6LN2BIIpJILoJvM0LNE6vB8TrbZ+kzWKdJOW0ws/rUQbz1l66e4Xc3wWu4JmALgpxDzJrRgs2s62q0THyQFCWBG42AEQHedgizbLxPT2UyPjBqdR1UAZqLGBVzNSRRuontUEqQg==;24:P7aNTSffClZ95iqkyNVS7E0UOMtQMicDAu+nAYKCD1U7pRWvUi6XjvYLR6qSb36QaoxJuk4sJ4M3p8rfuCXQjjrHZ9uFCve+a8MxXVYTvO0=;20:gFeruU4jON5mXFct/Gu2niLR2VmfwI+YB2xIiwXJnIkud/fXvmAsGTIEdCqetASJr5ImQYBLQPwqNSU4xwtcmloMoRVEEUHbXujvnTcUs7+qeRLU1Xdmmq2u8Y8x74o1L/ew6cSu64A+w71fBRlowNitWkqhcHk+ZbznF9wQ0lM= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB1362 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: BN1AFFO11FD032.protection.gbl X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11FD032;1:+wCLcSMUMCQStJ6te2Dd1J+3omFWZycvc4q5fby6gR2T1Ni6135VzOSmLasPNSSiBBd7WFjJc4Jlpou8iETGn78KASleD1ifvn4DWoxplgiic4hDDsAuZwa7s9zSYuHW1GQ+s6DG7jHT7Xw4K2b0GtngkjBeRjOSL6nMZxmX+yd3BWGYQEVs0N4eQiGgwiB8r8HICpboEpMi0JA8Fk0WzPbl8SftIq5Xx1tUwCHAbYcFWPBjRvJbJuWuClZ1niQBkdRFd+q6vhkg32gQoRPYm4CXSJHzzork2HZ3cui1seysHiMPVUkf1cxj+MezNS/oCRddZeW0qJHboppCc1dyq39tJIIxhdovGyNI2k3QP14R8CEtFqlRHW6L6ItBLg3tgV8+yuT8JiyyApfgweH0bQ== X-Forefront-Antispam-Report: CIP:66.35.236.227;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(1109001)(1110001)(339900001)(24454002)(51694002)(189002)(199003)(66066001)(93886004)(105606002)(53416004)(92566002)(46102003)(106466001)(47776003)(5008740100001)(54356999)(76176999)(50986999)(85426001)(86362001)(2950100001)(33716001)(81156007)(97736004)(87936001)(110136002)(5001920100001)(6070500001)(5004730100002)(5001960100002)(189998001)(4001350100001)(77096005)(5007970100001)(64706001)(6806005)(122386002)(21840400001)(50466002)(11100500001)(46406003)(23726002)(5890100001)(83506001)(40100003)(16796002)(7099028);DIR:OUT;SFP:1101;SCL:1;SRVR:BY1PR03MB1500;H:sj-itexedge03.altera.priv.altera.com;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;MX:1;A:0;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1500;2:xX+OQ8dKxMXIEulT5awj/dDqhe3jH/NDvAzJytV+w6IwDSoSVbBcVF4zIzOM5q+Q9EP9XHSSCTPIxxSQz4XFxazfA6Q2BGsA1x5WmuhvnLnWsAnrUmmruo11WGH0rYzqU5TOCDKkQQtxSy552ndLt/FOV710I2y/w3cpmylmwXM=;3:2CseUzSv4BxDd5/0GrOQNXkLDXfwzsOQAZCgDFB6tY7OUD9k1vsZCFIr3R5VvPopEvVj26HeZAeYe0nv8p1Ht+oq+WSd+Rye6rlq7otBa+sLe7GuRtHAxUY1/hrtubP0Zhah2TlXY3EyZtpM7HFsBG6KBnYLMcGUqe/5KhVRRlKaSiHMC6ADDDCRLqAuWhyrVfHnd9Z2Z7wvzgkiyauOqGVnIdgsFyupAJvIU8RRuBU=;25:fqiP9eoOzI7g1OA9xPjYbWwUU3mESTx8lIsGtB58/jkaigDxEjQi2eIfdN+IiJGSAcDzdsA0KvcC5q18SpsQ3jxl9he+xJofmYwjChh0nK1rfwY3Z+2p5L/neb/B+o64f4BvZtzD8fzU0bRZCdYD7Vt5pavKzu4AJnadQEsCLiWOJp1mCeg78hJ2b282Yt+XluQP15Jqux2XU9ZelWWNFTOPaRaR4LKO2cpkemOR7JC+udMVpoFGOJCYMV7+AAw56dNxsAsLztJWwDQYQh/mMQ==;20:hOrMR/EvZP8eUeK/97o26wDT6hK9wFM49t9fcw1AQtU36+rZa2ebCew43vcsfVeYy0rbLC01jqcAaLOdic7noB5A5kF2ZUGf7pbKyVANmnPLaJOnuzuWUAlfwV9M/iaFIMHHD9ooSVGjvnpxMb5RMfwVN/JPrrI03rDG8te2q0c= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1500; X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1500;4:mPDU1gRMmLvUed5iQdNWQQa2+jwK+cSTh4U/mhhALuSxEkl0Jxx2/YnIiC40RRMnWPqG+CksqQ5HnwWGTajAy8BtiQPrBgtp32T6o95c9M2x+EOHwu2S5YZQvqSto/XlcQg0v6WcmxFM55uYseKxfKbiNbOvkVh45W83DZIy0Mx1wCVVEr052SFT24KjmsNittQfyYf/sS/RfoOiJUUbxBW0CIzYxd+/q4BN7aytTv/ybWa0HkFZRR2X5nJwYzzKx0E/y5CqmOxPnt5M4Kb4Zy1gn4NmOeb1DTA7dL7ZHYelDxftIIXq/gIMctUyBGah0mo9KEYnovpgHJ9HoVqREe9w7jA7/Frp7MrKib4eQdc= X-Forefront-PRVS: 07349BFAD2 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BY1PR03MB1500;23:Q8v5gPiRtEMeVsVANXyMsgCap2nMfMiXItUm7nfBs?= =?us-ascii?Q?VGRSWHWwsF/ZkJQOod9Nq47BG0kW/GAih5UDJGGr49o18VnGR/qYX2PYAA/3?= =?us-ascii?Q?qDPHOmQmUkf2wP3SfS8szjHlvLbilSYPQ3zVFMqx4nuetrklBdDbVJ71OaZd?= =?us-ascii?Q?VFjyG+EODyQPdPWtOpFWfR9UasOcnKs3JTD0RzjQ5TLFI1fV95JA8xWbsIMW?= =?us-ascii?Q?Gz4UyomKtllARiHLWtp3rvMy/jkjt4rTZXgWmUsOnAMel4cqFh7zufjUyO0U?= =?us-ascii?Q?NzrerQBbX4pSkkrm1T2cGYnWNbNK5tJDKNiA1B3PTPIQjPxwH7YEoP40xykx?= =?us-ascii?Q?pWu64YXX2ZdX1Bqe6vvAsPZ+LYmSveKthsa16tx9cd/HIXhIjoy3xeJhMuF2?= =?us-ascii?Q?tX8KbvXJd94lIaO628/mctgurM9bkeyolD6qqqYxqT+E/gtW2iESlz0OE8wN?= =?us-ascii?Q?O1H8xHxaof8ESgqMN0jgenRtaaV5NASc7MOil+04f4szgM7UdkVWavWLcx/1?= =?us-ascii?Q?anfm70+soj2LVkvU7y6bd10ZGyh9UB7NGFAhukQXbRKIWzMXz70TwG7CDgnB?= =?us-ascii?Q?wR59nnc7gXbLBRwzfzS/fHY4vRWZedNGDsic5FwKd8/zOvUPIG44345Ppclk?= =?us-ascii?Q?j8FS0zh6lC0JY2+mQ5UL22foQZlaobJ+k2zomMDqS3iUAm75QUPO6DlDpwYN?= =?us-ascii?Q?LBs8uZaZNLSL5wnr/mH3c72qk0uMhA2T6gjMeUg30Gc8B9sLlXy3qTmt2XQt?= =?us-ascii?Q?N8ODe2eHl7svIuOvokwcsba2+aHIifWdX3dBPriXnsCAzNErDj76yu0suJ3N?= =?us-ascii?Q?OPgYtjddbRAdbcyuvVBLxPWKxQKg+YWlADN3QrNlUfFTEmXzUzha7gdXC3Qy?= =?us-ascii?Q?+VZivfvC92o+NGC3Op17prig5LI/cNPnDul4K8oLRWZlhpYbmbYt2nU4QGxL?= =?us-ascii?Q?lvlVpAippmlntBBIFMsKCPmpFJK3Uax7RWxPdG2kEMKeuuZl9z7ZgLxgt/Ab?= =?us-ascii?Q?WZfWCXNZheRwn/xuav3a9VIEF4Z85fgLerCSvEoJxmTexZ73/9ESTFqWQtTM?= =?us-ascii?Q?NI3PODpnL0PzY+DQFq9tS0r8JgpqPZ71i4y4Q30+RR23HWKsDsytAvuQZnao?= =?us-ascii?Q?V1NKAowtJ+J0u+EUMg5+BYc0GFcrB0Feg0GhOdXGvQb4stzqy7vx6pAZXtMw?= =?us-ascii?Q?55Ovylza1wEVw3j2MR25VvWkKJMNKmPCmSR8gsoa96s7kJX8Z3AzVUUKs93u?= =?us-ascii?Q?N85boyDgov82t7xvC5UDEFOIM3Cf2ibZ9KaNuwNewNgZKwhIcK/ueIfEnJHj?= =?us-ascii?Q?DR5u+yS0zNe/dArlXZFs58=3D?= X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1500;5:EqEz6Yb13q6C2Azlx6YxdgOW0y+A+vsYBLiIQvUlN9v64dPPv2P+2pJs+vzprzzuXPSdPbCF8qkS3rxHSfPzdNXdAANSJKVv2hcVNV6WfllCBlKN7Md90YgdNo+uqGMHj7ErS9kBVQnNA9ak9y9yqg==;24:mzfUxCANM179K4uCmhsqrdMpOvfh73M0i2Fzp2B2aD381QKpsqYydrilAoFhjrNN/19bi2NJD2gomxhrfotjR82IBuk9g3o87QvoZM6SGmY=;20:0ewGCC4/hu12ezKfDoi0r03+jfpB0B9yE7x2ngsJr97XZQLE7zvESGStUBM7/1A963/eY8xGwzRG7zpw6DyIJZ9BxJJy6uslm0hQ2pu8Znug4qNdQmesMph7gHIkfbIZThrx0s6j6loObWcjU6sgU2+asxesk1NnkIjcCrbYQA8= X-OriginatorOrg: opensource.altera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2015 15:21:30.1495 (UTC) X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a;Ip=[66.35.236.227];Helo=[sj-itexedge03.altera.priv.altera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB1500 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org +CC Giuseppe Cavallaro +CC STi and Rockchip Maintainers This is approaching beyond my breadth of knowledge on this subject, so I just wanted to get some further insight. On Fri, 16 Oct 2015, Andrew Lunn wrote: > > > Maybe we need to walk up the hierarchy. > > > > > > Perhaps something like: > > > > > > const struct device *dev_walker; > > > > > > dev_walker = &phydev->dev; > > > do { > > > of_node = dev_walker->of_node; > > > dev_walker = dev_walker->parent; > > > } while (!of_node && dev_walker); > > > > > > > The above code seems to have fixed the issue. > > What i don't like about this is that it allows you to put these > properties in the mdio device node. These are phy properties, not mdio > properties.... > AFAICT, the stmmac driver is allowing for the phy node to be part of the mdio. In the function, stmmac_init_phy(), there is a separate check of a standalone phy_node, and the case where the phy is part of the mdio. commit "8b63ec1837fa phylib: Make PHYs children of their MDIO bus, not the bus' parent." is now placing a hard requirement to have a PHY as a separate node. For now this is only breaking SoCFPGA, but perhaps might have affected STi41x and RockChip, but maybe haven't been spotted because perhaps the testing has the bootloader setting up the PHYs? > If phydev->attached_dev->dev->of_node works, that would be my > preference. > BR, Dinh