From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753325AbbJSK57 (ORCPT ); Mon, 19 Oct 2015 06:57:59 -0400 Received: from mail-by2on0055.outbound.protection.outlook.com ([207.46.100.55]:61200 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751209AbbJSK54 (ORCPT ); Mon, 19 Oct 2015 06:57:56 -0400 Authentication-Results: spf=fail (sender IP is 66.35.236.227) smtp.mailfrom=opensource.altera.com; st.com; dkim=none (message not signed) header.d=none;st.com; dmarc=none action=none header.from=opensource.altera.com; Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=dinguyen@opensource.altera.com; Date: Mon, 19 Oct 2015 05:50:52 -0500 From: Dinh Nguyen X-X-Sender: dinguyen@linux-builds1 To: Andrew Lunn CC: David Daney , Florian Fainelli , "David S. Miller" , , , , , , , , "linux-kernel@vger.kernel.org" Subject: Re: SoCFPGA ethernet broken In-Reply-To: Message-ID: References: <56201158.8040806@opensource.altera.com> <56201AE7.2020103@gmail.com> <20151016033143.GA28207@lunn.ch> <20151016150345.GI10146@lunn.ch> <20151016155644.GJ10146@lunn.ch> <56212A09.5080206@caviumnetworks.com> <20151016193854.GC28207@lunn.ch> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [64.129.157.38] X-ClientProxiedBy: SN1PR07CA0033.namprd07.prod.outlook.com (25.162.170.171) To BY1PR03MB1370.namprd03.prod.outlook.com (25.162.109.28) X-Microsoft-Exchange-Diagnostics-untrusted: 1;BY1PR03MB1370;2:lAYorB6UR0qcskMBBAmqvwdIsswr30ELnGmz2+zU7s7NvaQqdgpVscoyY4pnMRd5rk16Bbw5JOnyEXra13Cfrax4+XsuFI2bSMaW8OPkTUwvwDiUuTb4uulshi9D+JMqYpDXtrvepyIWdrZDVAcqIJJw0rh4i2mhu6p9lXXCMCU=;3:pnEQru4orLotVADdpLRQ1+B54kyHyv8X1ngeoyMzQ04a8FcHy/SemFRgC0X86E2zUZrkjttLY8v4L1B4fXYMewLLPLede4M/BmupVgr7MbO/gr/zrFPlNPUi06Ad3P+q39NL4QyaYdqOKrc+KduPJw==;25:y8nppNuUQYywf64KZO82SNBUxyaHkF4RxKqe7eUZDIxcXnd5VCkLtzlyrnxCB1aN7np8sGDK9MxOtIpkpG5o+J5mEE/I8GRQMX2IMZR8yULzKQLHmNPQeXyTKQ8QCo8+gy3bIC9+4XQqPR6GKOOYLLZegdW7Vdl8ZlCGMPxr1SydqUTtJ44k8kGlIfCIRgl4wwXClvOa3end0Xpr3u6mnTStwClsCAkCkV2ESUB4Pu8sj6smBztMfJhPt384jpkwiUS0eXqCdyzQzJ9xswhv5w==;20:8GdUecIJcv0un1FhF850XKgfahLBrw6P+NIIo+WqdjmtMETeUdCrLf738Zi2XALi7TuDc8v3hIyC+V86kwk6KSrZ3XvZraPvTvpYBOjdoa1TSu9rr3gGxLLYTOjjeWJpXLcRW4Bi/2kL3so3iP97WF9NQpkJKwygl2MON/9SHIA= X-Microsoft-Antispam-Untrusted: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1370; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:;UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(520078)(3002001);SRVR:BY1PR03MB1370;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1370;BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(520078)(3002001);SRVR:BLUPR03MB312;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB312; X-Microsoft-Exchange-Diagnostics-untrusted: 1;BY1PR03MB1370;4:C6D3Tw+z0N6UnvsrKYmcuvWiZgv7JKWeSlfz5ZZEszRfugS0yo06qQ/oW/9OK7JkG01SluRCqA52O+6Mr+VOuBDIRVBGJV9ueY0DlWkmi4uakjmH++Hs20bq3HSK8XAu3P5HDby2bsX5gRkyescrgXM9oEbFJr8hvBw0MmzkAbAkiSOtX1XhfSaeQOwQriFzIldQJ335baHW7JOeTaY1BjfzNZGxuEse5CGqhpYhPX7r+M/NKFzGxEO5osiytY/UGhlA2Zd7gGtBf5o5nSbxIdxDxgMycqr+MDFKS5u9DZux1poWhGYBDw6IAW5slVueZkwqNSlYva805/b4F6EURWqfld2/6nJiShLuyO8En7E= X-Forefront-PRVS: 07349BFAD2 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(6009001)(51694002)(24454002)(199003)(189002)(97736004)(110136002)(64706001)(189998001)(46406003)(66066001)(47776003)(83506001)(33716001)(101416001)(40100003)(5004730100002)(50466002)(5008740100001)(81156007)(2950100001)(92566002)(87976001)(5007970100001)(5890100001)(76176999)(54356999)(106356001)(4001350100001)(23726002)(93886004)(69596002)(122386002)(50986999)(77096005)(5001960100002)(53416004)(42186005)(105586002)(86362001)(46102003);DIR:OUT;SFP:1101;SCL:1;SRVR:BY1PR03MB1370;H:linux-builds1.altera.com;FPR:;SPF:None;PTR:InfoNoRecords;A:0;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics-untrusted: =?us-ascii?Q?1;BY1PR03MB1370;23:FZk1LV8TBAWrE4OwmCvZnNNFKxz22dONkYwgfAruX?= =?us-ascii?Q?d57fBzEzQqFxI2koOBXuNPJB7MM0GJk2l0greMzeS7g6CrVa6c9bmwVBfr4L?= =?us-ascii?Q?+GWyU9ysMsfgLX6nCcLwJNR2pO3pU5JFVUiEdvjz4wdtvHyD7mFTDbwpH80O?= =?us-ascii?Q?0a4ic2qeex8/YAO8NYpamhHKc61tK4diyih0HI6xqPtFDhOcbb1jYdcW6QVS?= =?us-ascii?Q?59opor6Oes9sYY0PQEGNB1KWUJ6VL0kLYnKfYURQUaXUbJXVHQDFgFqwQbzA?= =?us-ascii?Q?FRZtWLDKUwQf4LcW30+OLro9zHmx0+B0xkfJ/ejtZM26i0CGh1HPRmn9DsEu?= =?us-ascii?Q?tUCBMogYXRgtDRS4DBLe/6NjOTuqbZU78wgj60tvWIeTqV2BvTBcHZrJ4nvi?= =?us-ascii?Q?nGmVWwzXBWxsiKZ6+O85/cqodZ6mJoYe91e8xWVRijleICwJF+5+vaGB0NQq?= =?us-ascii?Q?4G7cEZn8wtpj8nH67WB740o/dFsP3jNE7Uc8iAvLGm92WjiIh1o1C/aaC31P?= =?us-ascii?Q?CFcUqqwBhN8/A7JVpYb0onXCyfyNljE8UvBQh1rdIy3Cs1nbsbaZ/M7wzOon?= =?us-ascii?Q?5sXafqbAYS1nja0F3DFpi8mmHMOHrSQvLkj2o3dKGAOGqBjY+TXGBp9CujF4?= =?us-ascii?Q?fgxUA64s2Pq+7NLU4pGPR8x6uasnVz5lwv/NBGkodYbreqMaiHy/1FI3eqax?= =?us-ascii?Q?vhXXiDIxI8yTxFNJzLNgLMxDV35R3SLuuQpkIQMihBZ5HSi9OZLFGrmoADsy?= =?us-ascii?Q?EcAfQMaJkrDwLkjsU9SLUKG99W/STC5fWtlVODifgrRXXw4moNAnCH+dhJiy?= =?us-ascii?Q?65/Tch0suI9yWJpAiR7T3dbpxVdFFGZ/iCYzly/Vc9qMEeHpwaxIdRfRjHuy?= =?us-ascii?Q?J/m7hIWfbSEaxd8p6uMRLyNMglVbxe4rc9iFeOkKnj77PPogkaO1PN/oqUg/?= =?us-ascii?Q?h1FfDSmXs9Ktpx+pQasAgkoM8FObaBfOK6FVmorDsvyJ1ZXEk0UEUf7kU4KF?= =?us-ascii?Q?Mj/6elOi8JfHgJkiB+trNHSMAE4bEXGVzf39SWeZs2RRyNhWjOfHmSi8R548?= =?us-ascii?Q?EVeE6ZQCH+hDP/nfo49ULNsaRQwPkD7Kxu+IKrrfdMPQ7PSHw=3D=3D?= X-Microsoft-Exchange-Diagnostics-untrusted: 1;BY1PR03MB1370;5:TryUpsSBa9mUSWBGm24AzpyFnGYDDzHxCHT7ZaWMJDYDL4Kj9SIhJBta/PpPEqbVxAbF9rUQJdDiABn6Anu/JgP3RwqnQy3na8BqvdvAbVHyq+FnKzm2nKPLvZojOaYFkCIuq7Ecs7ev/YWZdJ67lw==;24:/AWe4VwA3KJj6JbOSKtsV5mnAg9+B86RHw1Clg1BgCKi2p7RphevwU0cu7ygO0Q6wmwEOlsL4oGo0rs4za5wO/XIZ3w9Y+42vmabDpDxWpc=;20:CSdRUuWuFAmJgCPrqJZBxufPo/Ho3ZVsey4nGPSlxZw4UgU6OF+BIAp7wiMpu9yafVaX6DSrbEKnrM0kR0tbbwMQgTlpKWDWeFnsuDEJso3i6U9mgSJhMGScbV0vfKJqVU3Ggs/Vat1qq7Y5pK6VB5czdkpCiE8ZadpY7E0+Txc= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB1370 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: BN1BFFO11FD051.protection.gbl X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11FD051;1:orPY6TFJpDazqQd9bgI6V23xcsD01JCja0EJCkJ+AEkudE/YP9TLThYIuZJjjPn93l9J1qoT8ndHuUNbEBrleLk1+9A8v0kRVVpWwdT/8T14+QYFHgt+Rv+Ia5Bb3jz3BqQePcNNydV2WLWHEWJgH0NTi58EJg01oKE4l66TRMfETVBczH2BdrSMvD4UrdOsmHWp0yF1m7M1Y/G25Mcp5RXY8yLEljpK1A166VM99LTTYCz6qCYcKlOfey6DoyLqohOA3jDBQkw3/vI37GmPC4SctboSabBUomh9YHT/9BrRJuKwn90eEpaoCIoc/xxklaqvxON71LWG09LVKJufRYLZTE1FfbkSv6bqPpJ9ZZUUEHPnJ08XPGD8S8qMoThEO8/SnVOxv2OTuGly+FwLRg== X-Forefront-Antispam-Report: CIP:66.35.236.227;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(1109001)(1110001)(339900001)(51694002)(199003)(24454002)(189002)(93886004)(122386002)(2950100001)(21840400001)(77096005)(64706001)(47776003)(5007970100001)(5004730100002)(66066001)(87936001)(11100500001)(189998001)(5008740100001)(86362001)(110136002)(6806005)(40100003)(5001960100002)(106466001)(83506001)(92566002)(105606002)(53416004)(33716001)(23726002)(5890100001)(46406003)(46102003)(50466002)(50986999)(85426001)(76176999)(81156007)(4001350100001)(16796002)(54356999)(6070500001)(97736004)(7099028);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR03MB312;H:sj-itexedge03.altera.priv.altera.com;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;A:0;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB312;2:pDs0nh5DnYqF1PUNHqkkDTKb89RJZTXbQtLMtR7Em9/cRsUu5mg2YBE9KLQQhDwlAqu6k0ulsTFkPHGE8XhEk1Ezxr1QgIk99htML0cEKPad6zzI1CjmAk2v7b65kJps0zAZ5crgzfz1Yj/c1+CSSrOEtMdX74XtUhxBf8RMwVk=;3:IJYD93urp1rYKbp9OIofgqZz/Qc6G/CcrCOWw1YZEC5cSimhAFtZjoUxjTr1N4HRvZNSLJ6tjoJD4AzJ+xBOfMbFhPB+2P0HbUrp77TPnF0sWgb+vpkO0QhmyLnAuTLeL6Yt+jqzcevH1a2jBJn5z8AtkVfFpv1WGLQeVuHrXmymtyXZOz60+YviF2VuMa26Rk/soZaFxUAKJ2aYvZ01jmtNQyFkHcq8PZXzO/JCFK0=;25:84FAGrEQhUy1NF56wJWJ9iISjN06VsMdovTPkbizKBVvq87UTmXLVQxqiBXHDnwxQOjEk3vHEcJbWgoSsCDxCGL7c6a2J2Rb81AZUxGcTAATIZI48HIdZOuG2IGnU1ZmCGPLp2K2HSvBFEwA2HKAqH2cb4m6oz8kbfoNeiHnMukIpBN6x6QTLxVCflCsiqlO32cGo0IZA7ZpWMyz7NcDjsvG8TKrlm1Nq6NCLxPJTOlFTsgfLtsitsEon3FpMIwNl2+AhpyoF9u6n5h2Izp0/Q==;20:vQvrclE/9B7Fia7rhSUT2qE3oebwP7AQLZ12t5Jl+pBP43IzjTOBze+cJ/XJ6q1046muQpVnPFhTdP8XWHQThx1xp4UQxcYw6Mqtix4vSvZpz3aVMO54KiWkWe9D6Vqyq/4THQj3+kUsk6G7Fam98zJ/lHyqmjTKidNOClD2C74= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB312; X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB312;4:mqteIwo/uKtQ00gTvaBql3tKLrQ73Mmk4em+PpXQbEZnyDyuHj5ozhKnFSqHJgcSWmCqJyTIfL0pDwAPU6hF/ebXvh4XUCc36/NrD4Az/koyS3daMGus59OmXsR/Odeqk71kITnK2IQ/cu9v/OAi6l+1qejv3y3lrSwTxcslW6L/AKt7wBUEsEQfhHYRpM81+Lq2QZeO7CTido/ictoD6Vr4L0xFPT2vzHMDbQEfTXwAxQZmYCRAq1Wh/kLXeOjdL2Yf0/rvavrtXnHIzqbaKYbkKnLf1Rmjnrnou453Pw+CXAE230AhEXWKokvIprcp/5I8zauF3sIWr+WFUd+w2dGvbX32NJx3FigGtZAFW5o= X-Forefront-PRVS: 07349BFAD2 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BLUPR03MB312;23:5glgCMNqri+ADchT6d4SrY8iG96BFGgZLmgazyKob+?= =?us-ascii?Q?dqgq8NgWyac2x62T0P06pORmmY/YXJJE5UDBXF3ywi5aDXRL7E+TEsJcvyX1?= =?us-ascii?Q?+qE1JbpEtkBAqDf3rY6r1FPYO0UsJ+gLyHi1yKSSOM7i+exUL3wxHtbuIdoB?= =?us-ascii?Q?aEnMDGlnFRXZ0pQPuCNrqqd5/aZfwHc+h+BGxpeZBMPj64mm1hcbpYv5nXkx?= =?us-ascii?Q?Xa6is5Sdi51vYP4iw0nmvMQDY+svIWC2o+KlnA/Rz0RG3Conaebe64EegnYZ?= =?us-ascii?Q?xeabtyVFx3VwM9TyGTMZM9l1xNPvhJ4h3wTMZCV9R/1vid3g1NwqHpvLVgZm?= =?us-ascii?Q?qdxcuc7iTF+B2VYyBHIG8C9mhhM3vTyjbAlCYkemNT1BiY6+fI9u5ejK+joC?= =?us-ascii?Q?lwDBLEhaqyOYCnVMefEm5WzV4Cz28fBRhRx1uoyVndkEUQdZTt8m04DJMU0Q?= =?us-ascii?Q?i7kOwKrcpjiyxYkfs4RDIjJp3yCtDxFYQtxR6We5Oe5HrKH5J0UAyhGSTEaq?= =?us-ascii?Q?ZRD6aRO9p24+5MINryu8hMPKKWBbv/IozdGnPGxpHIwGPORupS3v3SO6S9xB?= =?us-ascii?Q?cI0dhFy36qP0Wl2tEQIrqFZKObn+NPqR29eMddyjf8L7Q8lV7T+PzO1zt6uJ?= =?us-ascii?Q?m5hehrrQpzezwn9l0IHZBBFsPWhjEsdMSaBf6TfUubscdkFHR/HpXbGM0n/r?= =?us-ascii?Q?E3L/b29QFzofUsSViw/F9qHJSuaEVM4yFLd9FDBrPcdneCIXOabConodPXYy?= =?us-ascii?Q?+sMAd5VidG74qeKut3m0iFeIa5cqtja5Q/QG2rUG1Gf+gGYjUWwwsiTTWvSS?= =?us-ascii?Q?ssJLqzbOwaY8CworvUQM4l7dgXuQXZG8lq6wKN31d/oaszBLjbhFZlSwIJAr?= =?us-ascii?Q?pow2ZuPvtejCdMdgy7OUvXYF35CGqcjOtpTwJg9rFE0WXGiWDlrDE1OTbTiP?= =?us-ascii?Q?hbXur7XcejpZHO+vmVxIWPVT6LLvWhXF22NZUbmqSthVuCDNbfwYJTr3QJiG?= =?us-ascii?Q?+55JfT+jgOO29RO0qU+s4pQS/0m9OmkwUUgqY8Nb+wXaw2ViBj1yLVz+oOFB?= =?us-ascii?Q?UkbCAsTbXtdFioAwlQ3xm7zY4RK46jQ8KPGOGHxXedxWhJU5DRZLKyXjDYhP?= =?us-ascii?Q?ROqTLWS4tv0ojO1u0uDiMpsQjM5AqSn0NHQbHN4e9k40t8mMyhtTeMWlb9mo?= =?us-ascii?Q?5z/GfMjBL/VbdpD4qQzVs4N+aYzvev81lb10ssqVlBnzuFpaeeexh/xyL26D?= =?us-ascii?Q?gADLu8BPfpeZ47USxynwiItvm30NbqnB5PD3CXktVlxMgCtcArMAWjFbfNSw?= =?us-ascii?Q?=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB312;5:Zatmsl19u6FUrOs+TPvzuMSxriy4dF9qWAiH4TjwaI7pS0zvCNueB+Nf1/bhnuTpq+abu7TmgifeFuf9u/+vaUF/62RSujxFkgNyyslcE70hpn25hld/LmuA72nXVkuJFg8DToiXm2CDb+rCaNryJA==;24:VBBNC6KykpaVNqAC9KWJpWuqctCVoN3KgdX+AaOOsu0tJvV9VjDOYhd2wE+FKjDVN6IGX8Dd1WfMlfZkSf9vEHp2YF+AeGTlei6KAYTHgpk=;20:1EKJr15/lCFxr7ostyFCCXDisdGVUjakze/sNlhyWdIA55uLTC8CM6Kh3qjrALmtZv6WvG2crch3GGGmuKgDlicMHsC6T7GlWykBVj0x/ms6SFgxiqqIgdschFC/2Z/x32uzBK573DjoH1HBU2bkcKcz7G+imEDmdN4B2wJVdiM= X-OriginatorOrg: opensource.altera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2015 10:57:52.3758 (UTC) X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a;Ip=[66.35.236.227];Helo=[sj-itexedge03.altera.priv.altera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB312 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 19 Oct 2015, Dinh Nguyen wrote: +CC Giuseppe Cavallaro +CC STi and Rockchip Maintainers This is approaching beyond my breadth of knowledge on this subject, so I just wanted to get some further insight. > > On Fri, 16 Oct 2015, Andrew Lunn wrote: > > > > > Maybe we need to walk up the hierarchy. > > > > > > > > Perhaps something like: > > > > > > > > const struct device *dev_walker; > > > > > > > > dev_walker = &phydev->dev; > > > > do { > > > > of_node = dev_walker->of_node; > > > > dev_walker = dev_walker->parent; > > > > } while (!of_node && dev_walker); > > > > > > > > > > The above code seems to have fixed the issue. > > > > What i don't like about this is that it allows you to put these > > properties in the mdio device node. These are phy properties, not mdio > > properties.... > > > AFAICT, the stmmac driver is allowing for the phy node to be part of the mdio. In the function, stmmac_init_phy(), there is a separate check of a standalone phy_node, and the case where the phy is part of the mdio. commit "8b63ec1837fa phylib: Make PHYs children of their MDIO bus, not the bus' parent." is now now placing a hard requirement that the phy must be in a separate node. For now, this is breaking SoCFPGA, but I think it may also impact Rockchip and STi? > > If phydev->attached_dev->dev->of_node works, that would be my > > preference. > > BR, Dinh