From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757833AbbJVTa6 (ORCPT ); Thu, 22 Oct 2015 15:30:58 -0400 Received: from mail-bl2on0090.outbound.protection.outlook.com ([65.55.169.90]:32325 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757204AbbJVTa4 (ORCPT ); Thu, 22 Oct 2015 15:30:56 -0400 Authentication-Results: spf=fail (sender IP is 66.35.236.236) smtp.mailfrom=opensource.altera.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=opensource.altera.com; Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=atull@opensource.altera.com; Date: Thu, 22 Oct 2015 14:24:03 -0500 From: atull X-X-Sender: atull@linuxheads99 To: Moritz Fischer CC: Subject: Re: [RFC] fpga: socfpga: Fix check of return value of devm_request_irq In-Reply-To: <1445541167-7095-1-git-send-email-moritz.fischer@ettus.com> Message-ID: References: <1445541167-7095-1-git-send-email-moritz.fischer@ettus.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [64.129.157.38] X-ClientProxiedBy: BY2PR21CA0030.namprd21.prod.outlook.com (25.162.74.168) To BLUPR03MB1505.namprd03.prod.outlook.com (25.163.81.23) X-Microsoft-Exchange-Diagnostics-untrusted: 1;BLUPR03MB1505;2:GNXerHRlal2IFnjazNUp50843Z6qoKikB8hczHcRDK4tnya4pZLfRQpHEkf+dKBQG/SpcBJFqqAr7J/su4c1wMHKLeWNj9iSZIWc9IYjaiqZkQllCGNm05p9GVOnYmu5ToZBPkVWf3lBtJCroMOSLAgicUZ3HTO6Ae50+55IWZ8=;3:7GP3IFnK2mP9e7CH297dwHSIBpZtgyZEQw4udYq6amsnAffHfZIOfJn0oCF6gFCOaq2flpYe7OsMQ6joPMxJuN9ONSLef767Fi1+K4VXwEvy1IaQbDcGyahtIoTpknxaW6irjikhtiElDS9A7Fis2Q==;25:Z7gPtgX5WNglMk7AD9cbE9G0rlpkjO88Evl5c3Ggza+Jb6SylVBao1rKkb06xgsdalMsheyZmrJbiIc9j10hpZ9lauaMrz8qHBilz2L4DdsoiajXR+Ly3I39en8pNbl5e/1cqrk/XbfZ2bsH50DIQ+BwCg3nOs8S/cyyoZcJnj+LDVA33BCtmnxlyjdzhzxZAnrpy+1KHToozok4l4zobEXWXZAzEEi4KmBBv8cxEeriV/03xzqP9bWyv9rbOtPmvwIL7C54wciX9VgumhHsTQ==;20:skp/ONIx4IT9+ylnYZKWEvlfGLlh9uydQQ0evZauEx4Q19asJ/r5CZURMkEPd71mpEN2bDqpkOMhscU65Tt2FfeR4pEFC8LayZA1OkZhmBPtlJt9nBtSMPV8lOsvPLlu9zVo7XbJCsenIRuOtMHgkA2D0tgaYY1Kg06gP7WXkEE= X-Microsoft-Antispam-Untrusted: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB1505; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(80048183373757)(204874498639787);UriScan:(80048183373757)(204874498639787); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(520078)(8121501046)(3002001)(102215026);SRVR:BLUPR03MB1505;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB1505;BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(8121501046)(5005006)(3002001)(102215026);SRVR:CY1PR03MB1501;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1501; X-Microsoft-Exchange-Diagnostics-untrusted: 1;BLUPR03MB1505;4:KjSMIQRgSlfq4g+sPdLxF4peKqWq/12dkFRCIGRPD2U0z3IstWm39Xt/q/dPaerW1pz7tP94Gub9qXv301wuCAAV5JqvraFKW5zXaEnZP7I5rCPbQh+trtXMSKPHwbjHCTCM+GrGPMSCoe7G+tpo9g62ipAW37bWU8vm1vW29l7WkD9jL89WVl22B6zWq8z+iR56ZnJNSQL7bDXWPsMZVpZyUWP507+n7T5wUMvHG4pzwKT7if2kVQB+EfMDtGUmhc8JNiKKWIJl8h2nFOCGuPIyi/k0vOT/PcJCu2lblXsNfotWJavwFuc+cJvVoT2Sx+Gub4Ddd8fIpov7n5xgGbBdGcAkSc3W8IiFIQUOcaUTuLSKa8LLjZeHXp6WQiJF X-Forefront-PRVS: 0737B96801 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(6009001)(199003)(189002)(24454002)(50986999)(19580395003)(5004730100002)(101416001)(53416004)(46406003)(5007970100001)(47776003)(77096005)(54356999)(86152002)(86362001)(2950100001)(105586002)(106356001)(5008740100001)(42186005)(69596002)(19580405001)(110136002)(189998001)(5001960100002)(33716001)(4001350100001)(76176999)(83506001)(66066001)(5001920100001)(23726002)(97736004)(50466002)(122386002)(40100003)(81156007)(87976001)(92566002);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR03MB1505;H:linuxheads99.altera.com;FPR:;SPF:None;PTR:InfoNoRecords;A:0;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics-untrusted: =?us-ascii?Q?1;BLUPR03MB1505;23:WUFuC62RrHJGtL6vujdpVwpc2apanCv4fJaDmr5bs?= =?us-ascii?Q?KFiaEVTkiJranJQztiNeuUPtBr5mM4BFRjdQfijWpH+r5HyfH/esR9xcuBZ2?= =?us-ascii?Q?4tokuTWxs+3BA3gUNsfHlRU2mh0t4bNPyw9jKaXwY/uIltjtl9g+KcbdqQbu?= =?us-ascii?Q?OfwlpSL27AnMIjFfgRlgr+4JMxnPE8PQmmLmmwgNpXS0mQzAVM71Nv1tr8ys?= =?us-ascii?Q?Eg+lLTNW3sBNlOdYD2JuDk5xKXJ9SXyZrWmdsptNz/pbdJFojB0fc2t99c62?= =?us-ascii?Q?9GxbPAlDAHLYV0CawDcxgUUjOXF7GGO8PaKxx2HqMcoigPuK2kma9Ce91H3s?= =?us-ascii?Q?VLmCdt+9QIAJ6gTCOoShW4VKCTWmBegXnu74QKkn2FG01FY+kr3cnAZNkhWJ?= =?us-ascii?Q?TZVqJTBes3B+vQkjaRppioKYzyhlxwsP3L4uPkbL1gsVwEkljo1QuAXz1cS2?= =?us-ascii?Q?C74jM8abRs0P1U0ZNdB9RftAnIEOaeOL4i1KcqElbgIfVHwCndtDB0od3Fj0?= =?us-ascii?Q?+aw/QGArU2icHHMEh5ELOHormRNW6j3QnSuVVuj+IEWLXWeb6AsJPdNGnkNl?= =?us-ascii?Q?h/3DJs82RrJXgL3JHf6ab0g9TxGb+E5otW6MRyQywYMc4zbiUHydGum2CYQh?= =?us-ascii?Q?Cc7hIKdiljYE6/rAoJwZtwMFxIpYG++ukqZZEYilyNzt80vEzn6YKpg+3/vk?= =?us-ascii?Q?zk6SguZk8JymPEvYt7jhUdJm67um/iBkAw5UGDg0PLvh1p/v+uhN9NUbeAc3?= =?us-ascii?Q?kXeZejz37KtV1xeeTz+Zcmc+vNbuGggjz3fO3O7ER9FoZw6SiWgLeN+jRPPX?= =?us-ascii?Q?0gKC88joUYE5g9R0caSYhP4uKK4Pu4tfP0OKe3X8d0nKGf/pPEvFFiNtMiq1?= =?us-ascii?Q?QcGfiadvZc+mgXH0xesJAzgkOP4nTVWJ0PaG1FTOR/e7YIgWOX4EnkPCIQCO?= =?us-ascii?Q?R6FHninLM+J9UdcVnBzxwyvnidlshnWOrC85sNTsTwjWGUAqMZabez/mRm3M?= =?us-ascii?Q?W7mnmGbRTOkHO5jqzWMqQEz2qyGOik0LSRskQ6ZyQ8k04qNof9vECeoy7qfN?= =?us-ascii?Q?1bYJjhpYSfa/viudixuhhW97jEE9bXVOXfuyvnSPehd9RaVKw=3D=3D?= X-Microsoft-Exchange-Diagnostics-untrusted: 1;BLUPR03MB1505;5:9hkoI37i90wIHxgc5aa7o7YyEVaZIc/3Dwy3En9rKMvSy7nhG8pHXKVJCxcVb9+Ze3kmAIeuaMtJ69vXb6rlnQhQAisG9J9Ooqafd2G+9752Qr06hNYNh46uxrxhjLYrSG5TozbhrrX9QZBzUQEYzw==;24:2N/E9gDFhswvck6aQtLFudDOGZiBKl2wuznp89zFWm/bp9SqEIXFJxXIi77zyVas4Fy/ZEUqt60rfdqTb+bZF2UpjXpNEYaiC38/FRQujkM=;20:SWkhsbVd0lSx/5IBO2vyAzdXhfJtbZtFlr6BVIGN87oGILw9gnfLX4xn3lCg3uNE9BoYWOx6AtM+t4+CCMDKIktED5jqU0u51hPlxVhzKTfNa8BCrJyYEoPkkyV8jeMrAuV/F869r8523A67kHPA/VOPTsJSMMbTrJmz167Puh8= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB1505 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: BL2FFO11FD026.protection.gbl X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11FD026;1:qbT0Br+p2E1bDNkbWWq7OdbMMImyOteyx5/lus2PiH3F0sEX8xbjRcUQuRAPe7Zpnz0Km8oXXCQvnqFWNDGP1AQ2ou1uyfeSufkmzs6cn3WYe6TKNyNumDlF4EPt9fxsADqo75djiYdxd5EVu2emOoQdSh/eWrjAMB6jkJyqB5mesrthWRpy39Ru12N8nd1wGw4CGHYBS/Un+by4c67g9pE412lJolVUgnOZVh5PoiZd95im7zL2gpgvUIWsc9PTcci9ikHuf0zV8Gva9fCLKlnJxypRMxFAAbs6la2lm0B5K+cgabefxcBlbcUnzR+2dvgg1tPNqCHx788UaMHBVHo4Ack0/QNDGX4Tuzb6SWHB5uwjLXesYPJQu/q1IAbu X-Forefront-Antispam-Report: CIP:66.35.236.236;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(1109001)(1110001)(339900001)(189002)(24454002)(199003)(66066001)(92566002)(2950100001)(6070500001)(23726002)(81156007)(5004730100002)(46406003)(97736004)(5007970100001)(6806005)(4001350100001)(50466002)(77096005)(5008740100001)(21840400001)(47776003)(53416004)(87936001)(110136002)(5001960100002)(189998001)(83506001)(122386002)(40100003)(19580395003)(16796002)(5001920100001)(33716001)(19580405001)(50986999)(85426001)(86152002)(105606002)(86362001)(76176999)(54356999)(106466001)(7099028);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR03MB1501;H:sj-itexedge04.altera.priv.altera.com;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;MX:1;A:0;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1501;2:Pq3y9NnMtNLq/q0CmO8JSIrCzFLmlKFGkM4iOxhIsuni+5SBePT2Ugjp6hL6ROsgdKAUNXpMfSTMuGFk1WfJz/hOtuQhESnJApZs3WyJrECpLhfJuxOfZmqfDLUD4MYOwlXwmrjhV9Q66CtAEawKE43OtlX8w11pYYgVcymjGCA=;3:CpQeZRB3NzOfU/72l84SoZTBZAEbfVjvBebtvRl9LjawoYJWDSd8AJt1kSyLBnqe4FojEdg1iXc/dCiZ+JTRNrywCye5KvkVda2PH8RJfO93+Mh0/S+BHIHrW5cb08HhtBAUkugzPRGlENBMmZzzxbK/lgKitKh1S+9S6oM5oHVEXtdRd2P9pg/F0OsLHQTuXAYB7W3SsYHe7jULUFZrHU1d8rTje/qDLpfOJFqQN8s=;25:cgYd8w87YdPUC8Kn7xBKvAUbTy75+UafGNt3C8Bd9KRbRZCWSOLZIi9gnZuxXkdB3B7FxkAirL8EsjFVCSIcLcEC3x9/0r9aSzmopIwTGSliH5j7ahKn3LCQ4vNuZUku65LfmtPP/eIt8Ydr7OXvonhBKzQ7DpAceLSWa6nZhbTCAIzzs9g53MnGROW3o2xQgqVMWgbjPHX2cP9ACFMI7eS2f3IuGLAvKxKESSxRoFetHzlmMoLXltiAd0ITzOQWvfd1B/dAC5XGKXjDbqWaeg==;20:AmHZw7lsfyFd7LwljJpiv4lj5or2ct3he4VF5OBJaEyYr5r77crkt5+r46Ic0P98JIDe5cwOiTjapikdH+oqRhoO1eiZ24a3bBYPoTh8wTbY2Yqdz16djUs4ZCfgL0dIWoJ/UZA0zmqsPPwnkHqK7V3WEKKbJEsKixahHMSO+cY= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1501; X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1501;4:mcWAI8I8JAU1LgfD+rbJUXKM9nGoomNTYnjjnqjv9+mq0dKbUEAdWkE4zVeFQn3eWpbuMO06Ec0ZgGF6ZDo7JBV+WW+fbX4Hsy6gBuWNCkKiBQsqjmsUGfxxm/fuihiqumTXf5XeCqOFn16GRqNIz36raqGb5ar6tk+9UJto2bZuY7GdZcCPJKW71TEm364XCaejonMZ/NhbBjSC1nZAX4gzeZ4GoIuE1A5bp6vYuOMmLjMYKUcUiVWVyiSsxz3eUVSRoF/Q+V5OSLouLkPp/qfhBwV21XAKJDzjEBY3vqgjPIfW3XOZievWgAjFRzjRZjy2Kbn/foibgpRQkYtzOa270A9bji3Y2ZK29hIH+72G+0HndfcySaX6EUgKKPVJ X-Forefront-PRVS: 0737B96801 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CY1PR03MB1501;23:XhEgWYMeVaqdv7qV1LXUIm1gTlGM5SVYj3tDdZ7UT?= =?us-ascii?Q?6hfgTTstje3nSYQTolzblGGJ6ijtOq6R1L05CRPqs5T83QrHgr5gRQSXx1N3?= =?us-ascii?Q?5m7e8Thc5vH/jxIzvtN0A/qrYwr9yYmQdiPxW/xSvYmjITQo6hXYWLVhQGz2?= =?us-ascii?Q?1q09Gc3UlhqNdAiM5Ohxb/ZprZKDcu14PrfpcHEQuFuD1WH3gGrq7UkbqnXh?= =?us-ascii?Q?3oGkwRoMeJHaYNCuo2bYRwzIyhVJ4al51xn06Z0CSY96XCydIQJIjICs5+CA?= =?us-ascii?Q?Gd+z8WLfhOjsAkRxvLZiuCwLq8gpXdMBHY5GrqI38IxU+lxe60l5AXz9lbzp?= =?us-ascii?Q?wPVZCQKjbVFAnkdZpH5QMl25J6KUDKnxtaMa4DVh+MnZTvXyln4SEZ3aA0m1?= =?us-ascii?Q?iqtiTpD0Ml8LD5uYIELP+LKJlj7WVMZ4mpRYp1lJVEw84OQeFmCcCMZaIaeK?= =?us-ascii?Q?rqv13e7XWHWdU1ttzFLNQ0zswxWd2/IXIIvtYjPHms5gxlCtxcduf7fRgtQU?= =?us-ascii?Q?Qd4fyc8xz2Qrj3yyOurE2YYyJMV/KVq5sdIY/zK7MPG14z/ysaFftknqf1ds?= =?us-ascii?Q?zeAAfUiqgw9r/ozvrV6oWicjub67GE3MIwCNsUvrq7S0t6Vb5F+i8MAEKPO9?= =?us-ascii?Q?w50eWzK4tpW/A5us6wxHTRnhz1++LUaku3e1p9+eluyjlhehaAIef9askfYM?= =?us-ascii?Q?xN+ofUbDkyxaXljrWhQoOGK3R3stDr5Hj0zrAwVF1DtsAP8nJ/s5KO9JOUhY?= =?us-ascii?Q?Ys5ZIejm97iigPkY3B+uJcQxgfvLuZg3UHmiJHNca82SDDtRWegRF9XDXOVZ?= =?us-ascii?Q?2sfC67cSudyOlak1O1On5ZiHDkkO/KejUzuuVfVjVKkkKYePXUu0O1ojavzz?= =?us-ascii?Q?EDPfck1dJzLt42CiY1Mzo5elxcBhDV9o3bnnkgQLYFp23TbiNBZvNmzRUJyR?= =?us-ascii?Q?IsPEeEeVpR3xBMS6fDGThi5rOl/dC2TISV4BOjv/RIcSFqEqYVvIpbkXPn56?= =?us-ascii?Q?7fpLMnFRIZ/lvc4BDYBdz8b1ixBJfZ795GUSfxNbYSLzXj1nEyhp9pSNJGom?= =?us-ascii?Q?y6qUmyHvLSpA5WjIbRGeFcGeA0gTkuPcHoRrENAUsZUXwlD2n3vo6bQJcGHR?= =?us-ascii?Q?oxhNV+NSy8VLSNpmkSrDNYhQCp9osnVLSq022hrBzYQNF2J5ANBRvOk5QJG2?= =?us-ascii?Q?XpB6FEjz04xPJG4aR2MiSHLIgTWSjy3S5mvjplLRRIzuwugdWdiU6OS93M7y?= =?us-ascii?Q?tHNBTKVu/pQIIDNqwo=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1501;5:/myyrlSfjfGa2TMgdzDLxDXOTfQzM7BgTL1CURclV337Zt48Cd1MLuFyg2KhijHVUyTiR5jy7UIS1dItMot8abhThK343znp3hNkPslKryTq8bkfWWFQXTOZaO11tthcmWOL0phSOGmbIDeWthbU8Q==;24:aUul7PZR/14LV7pO5rGqU4rmp9fJmNzCfkzO/JSKjWxhMqJ8roU2sj5CpK7Emizz+lRrG1PZN4Wq4xgXELGmRLeeY1/doNISj0AIzpk2wKo=;20:WpiMGymw0U2gJIOw7DVK9MAxg14bSsx/7MeDD2KKp+AYjvVGcBYxmN4Elh4hW0f8jjwZ+hNbZurGUfbz6/sefl1uu4uw7C6gztjDfWZoNYRt88dhMlKFFyyawMuHeWkJPVESC5jHIGlFK6PZ0AhSKQCZq29YFK8C6Vi00nOyHHg= X-OriginatorOrg: opensource.altera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Oct 2015 19:30:52.8434 (UTC) X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a;Ip=[66.35.236.236];Helo=[sj-itexedge04.altera.priv.altera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB1501 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 22 Oct 2015, Moritz Fischer wrote: Hi Moritz, Thank you, yes this is better. I don't know if I need to ack everything, but here it is anyway: Acked-by: Alan Tull Alan > The return value should be checked for non-zero, instead > of checking it being IS_ERR_VALUE(). > > Signed-off-by: Moritz Fischer > --- > drivers/fpga/socfpga.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/fpga/socfpga.c b/drivers/fpga/socfpga.c > index 706b80d..27d2ff2 100644 > --- a/drivers/fpga/socfpga.c > +++ b/drivers/fpga/socfpga.c > @@ -577,7 +577,7 @@ static int socfpga_fpga_probe(struct platform_device *pdev) > > ret = devm_request_irq(dev, priv->irq, socfpga_fpga_isr, 0, > dev_name(dev), priv); > - if (IS_ERR_VALUE(ret)) > + if (ret) > return ret; > > return fpga_mgr_register(dev, "Altera SOCFPGA FPGA Manager", > -- > 2.4.3 > >