From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755946AbbJ1PGP (ORCPT ); Wed, 28 Oct 2015 11:06:15 -0400 Received: from mail-bn1bon0059.outbound.protection.outlook.com ([157.56.111.59]:9120 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750968AbbJ1PGM (ORCPT ); Wed, 28 Oct 2015 11:06:12 -0400 Authentication-Results: spf=fail (sender IP is 66.35.236.227) smtp.mailfrom=opensource.altera.com; lwn.net; dkim=none (message not signed) header.d=none;lwn.net; dmarc=none action=none header.from=opensource.altera.com; Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=atull@opensource.altera.com; Date: Wed, 28 Oct 2015 09:59:15 -0500 From: atull X-X-Sender: atull@linuxheads99 To: Moritz Fischer CC: Greg KH , Josh Cartwright , Michal Simek , Michal Simek , "Rob Herring" , Pawel Moll , Mark Rutland , Ian Campbell , "Kumar Gala" , Jonathan Corbet , , , , Pantelis Antoniou , Alan Tull , "dinguyen@opensource.altera.com" Subject: Re: [PATCH v12 1/6] fpga: add usage documentation for simple fpga bus In-Reply-To: Message-ID: References: <1445983755-24007-1-git-send-email-atull@opensource.altera.com> <1445983755-24007-2-git-send-email-atull@opensource.altera.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [64.129.157.38] X-ClientProxiedBy: BY1PR0201CA0036.namprd02.prod.outlook.com (25.160.191.174) To BY1PR03MB1515.namprd03.prod.outlook.com (25.162.210.149) X-Microsoft-Exchange-Diagnostics-untrusted: 1;BY1PR03MB1515;2:w3Pe+SbT8541fENSRoKROWGH346Zhmx9U30gsKUoAabFi5T/a1xYb2QmTpcyKx9ImuSR+zBsDBkcsf/ohGk2nFz15lOiWpCEcIJn0d75yVRFCnstLuTKgH9vBWu97kFm44jWH/RaUkQblPBSHI0MMkbt2jMIlGWnKZ5/TRUr4xk=;3:wF/qcIzuUkSh6t60M86j8ng8fqsNmKWAPcN4/VPPZQwE/oLb0vkf/YY+jp4nsQge79i3Qd046V65AaJ9SlU9n1oJ7RTOyIG2HWshlerWMvXJWtgfdARnXdxT1o4AVrJngCKmPfB4KQVwv/AKX9G+Gg==;25:+eykjobJQ9KVOt3u4/U64GIPOjHvE3ro/0ma6Mt+A9AV3VutkDhuTZz4PcVuWNUGPgm3pqPPy2scJ+LiMi1TX14ETYmUwf8IxlK3OPeGzqec6yolBjKlfewuySsdnPZxCOZX3X5fqdic6gVuy/CF4Ljg2aLz4sxXCx84Ub/iuEx4bXjL7q9Hyg0yp2tSc7jLQCG3y/rQpAlAzJhK+wM33U3nmrqbphPASUO72zcjUJTKPP+vx2wFRMZhFikcJVHafnZnJY593ZieMGs/y6w+KA==;20:6cBj+PQGMm2thnR3x0xlshaEVxDZU8+5koZSBGAb1FSl2a0kndKMzvSHPFvMoxuv3iCrGyrK7ZP7WosLEqvHjmLdKaTkq1DSW3rGEZmJCLnRoid4b6IiIhhKLFF97ye+HZwKF1iZHcz2Qm5F3VZaLBq8a5S7F0imM0SosX4qAEs= X-Microsoft-Antispam-Untrusted: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1515; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(80048183373757)(204874498639787);UriScan:(80048183373757)(204874498639787); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(520078)(3002001)(10201501046)(102215026);SRVR:BY1PR03MB1515;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1515;BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(520078)(10201501046)(3002001)(102215026);SRVR:BLUPR03MB309;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB309; X-Microsoft-Exchange-Diagnostics-untrusted: 1;BY1PR03MB1515;4:NyY/R273hZwLIVCFsaAxv/MX8VtkoovAcoVfKguEjtj8LJ1drUcKs/A6dy2w70SRyLAWLmbomG6gOG/M6Hv/06Ls9EGHkuk7ulOz9vDb4l4lHDAUhGTS765aCWap8bfcuQdMPgU4cuMRK4eJj/Iy5d7oLhqB0kjUTc6+Uv/Y8cJ6LJhy+yXR5+slDG0mP3UKLd6yVCiy3nz/BTiEQ+dUxYkL/XwrUIRIn18awCpDnFBAoDPyRH9Ocjb+6TJNkbAADIrroDqypBveP+1NSh66siSCdBkTas6b++qYsFGowV8jWdhPYHNC/ThmwOhpLKZIzIdJtGpdJe/Hpve1Z6d6gqr3aEX0Im3d85tP8FBOEnv1tuEkXuZEpsLDhyqaPpxxAAKbAod1aGKmM9LbwEB0nw== X-Forefront-PRVS: 0743E8D0A6 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(6009001)(199003)(51914003)(377454003)(24454002)(52044002)(189002)(2950100001)(86152002)(69596002)(86362001)(50466002)(92566002)(66066001)(87976001)(101416001)(77096005)(33716001)(4001430100002)(76176999)(50986999)(5008740100001)(40100003)(5004730100002)(46406003)(83506001)(54356999)(23726002)(189998001)(81156007)(5007970100001)(19580395003)(19580405001)(105586002)(110136002)(42186005)(122386002)(53416004)(4001350100001)(5001960100002)(47776003)(107886002)(97736004)(106356001)(7059030);DIR:OUT;SFP:1101;SCL:1;SRVR:BY1PR03MB1515;H:linuxheads99.altera.com;FPR:;SPF:None;PTR:InfoNoRecords;A:0;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics-untrusted: =?us-ascii?Q?1;BY1PR03MB1515;23:YcHKDy0WPT0qJ4uGQ4fCY8zY+6dvk+1bg38dgWYW6?= =?us-ascii?Q?+Vj1cEHxc8drKVjFAkXWHOOjX/G4CkmB67s8AfewdKbO/6OA7nKC3flRtFQ/?= =?us-ascii?Q?fRLg5inNzRTd5ZuQ4iQKmxJG0apJ9ExbRy6CqsNH3f+L7BoQvCjFw0Y1suCj?= =?us-ascii?Q?hcQQWsiYrQYopyaFYe9cf/JZioPav9a2qW48N0XwTZzXrLnRoNoeUmPJeMze?= =?us-ascii?Q?qupdvtiBmR8UEnPg9VUAsiYvEUWiFWvv3U/qHScG2+1GY9bMr9TelObShF2L?= =?us-ascii?Q?hFvYgzIT9AzkMYF0M/xUABhWtOdVeBVemdMoRjnzZPQSwuXQiOYJvngn3hVc?= =?us-ascii?Q?nOWjVqUJrNhPT1arBkGLuvi5rQl/0lWZf2ifMzmiXxevO3Ad0+Q0F3eMsxKX?= =?us-ascii?Q?cC8TZvkDSG4gOepAVirBYPoXLp++hLM9j0RYVO+lUbWKSoYW7p0xGeth1ALw?= =?us-ascii?Q?JH2w8VsLZYzhdu4caTVQSe2VBOq3qXnoq43TCESBV97pVYVvmBDuF37bH2EF?= =?us-ascii?Q?pFd8wNIHMGBwLcF6ZzV09dIjubhAn+P1ew81kRdL0czh2tApH0mG45ALCaLA?= =?us-ascii?Q?RiyGC/y3uHE6kAdAfouc5gDa42M3mRFDMvSo0zSyCVuIDKFabaLtO3A4XXF2?= =?us-ascii?Q?8yPutDZnTleXjI+oQuW2djYtl9DFyja9GyWTMYK7dfjE8rtTTCnL9L6Ec1UY?= =?us-ascii?Q?pnN4MrhO+xJmAF7WYtqRy0lLbwRVIKq57Sh0hoCbgnHkroy22t9iezCqfm8C?= =?us-ascii?Q?OnUwjh3mTrVwgMcMLkTFbaXdPcSSdbnfwZTD6S4bWtqH/pBQ1zho5JrbUiA2?= =?us-ascii?Q?jOGBFk8LmyTqDVlKMl9wCF2aHwcgYy6t2mmGx6aOTqXsM8vfuZu4WOx4Xaqu?= =?us-ascii?Q?YIEYxtgoLAcauH/62dAfBttp6tYv130kBCP2TgLG9Rjf438TbpEjq1upOkMu?= =?us-ascii?Q?TbhHikNTxETHQfVJJiMkoqJbFWNIrNt7eqmxQxzrb3Aq2jIW1lwItvtoov00?= =?us-ascii?Q?uhvi5+emBXcR0KeR0FJSC4aWA8jSx+IdYU7PDYXEL9HFLcAyIG8v5Tv38seo?= =?us-ascii?Q?lIG5tU5H5ou8CBShu8OFGHd7P3vBq43xMqG7UJRkFJMulYP9I6xMglqtKPx+?= =?us-ascii?Q?D8fOuaCo37LQr2VxLIcfR+nPFC96QKRC+w6b+2oZCZFiP7yuyXmBElZfM1AF?= =?us-ascii?Q?mBT5VR49MtMSOFuyzinq4UbEAQ0ZH97rQwE?= X-Microsoft-Exchange-Diagnostics-untrusted: 1;BY1PR03MB1515;5:NotLa10i+gcUrztOvZQNAgtlV57usVUwvuJEDAEREiieM/tMYeNLB7mGdbAQ0fyFVAIv4jOdmCXdWA7jF74q7CU0ZMHskmaO93Sk0X7oWh33C0dxl/g/tZOlTcok7OiEwHveRQtORFOgx159/Eb0Aw==;24:snaEy8oirOUBFdbm0axT8vaqr6CLXEXvssQrIrNTtucy8QMsClWl7xhysDBk5ssQ66joeZ8cLferB5GAHTaFJlTNHcFra5BB4DEF4Pbrgn8=;20:UohgNQl5+yA37UIbpliXOc0XwB6KnK2WrIs95LMrmuQ0TBUfo4rG5MZVXX2PGKSUlXjvPS2xHblIuUtvm9c8k23zkn2XDMV5Fka4v+L8NmBYonY2ZWnH78ToolNoIWjA10ehDcFEWAJQniTEUy+tl74NtZ4KeegIYma0SCgr3pI= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB1515 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: BN1BFFO11FD041.protection.gbl X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11FD041;1:wMLdngMlQUYRKO5SNQeklMR3FepNr5K5eKYfPc9QBEg3hZAN0+dtX7JjrCqcOUo29Ysmw0XMvaIHriWjd9HF/1CV+RzmAUgs7ef85Rd6pyq6MZzHyCT6SzC+RiAe9rCyMZsYQihILaAmFqmmN4RYFW6azQywJ6rMIfQxcY545IRy+AUY3AGEo1rG21/rjmzWLcjAHAABh/iC/dumGS0iY/kZU252hvkBPInCnVANl0vtzq383yAZsbcD8cqAHQxPW5dYdNC3tPojH6OTvTWqbarGgpPBxHKk6k4mcSBd7b9NZa0qiDlF3lrKrZ1G9FKC5TJZ9mPOejwqdwkb1f8/ScYgLhlsq5s0GULP+kvzLIyN05xAwOUm4IwAFBAh9oi0SO8DyBmJl/WBTYSbBgabqA== X-Forefront-Antispam-Report: CIP:66.35.236.227;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(1110001)(1109001)(339900001)(51914003)(199003)(24454002)(377454003)(52044002)(189002)(106466001)(33716001)(122386002)(85426001)(87936001)(5001960100002)(40100003)(110136002)(16796002)(105606002)(66066001)(189998001)(47776003)(81156007)(21840400001)(5004730100002)(46406003)(4001350100001)(50986999)(5007970100001)(2950100001)(5001920100001)(77096005)(54356999)(86152002)(76176999)(92566002)(19580405001)(6070500001)(97736004)(11100500001)(50466002)(23726002)(6806005)(19580395003)(5008740100001)(107886002)(53416004)(83506001)(4001430100002)(86362001)(7099028)(7059030);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR03MB309;H:sj-itexedge03.altera.priv.altera.com;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;A:0;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB309;2:w/V17HgINX0Ph15yUybrsJNR+Woa9N1RvHJNYWNfYXrHUNScI77bXRyaR7AyTBSZni3lbTpXojWF6DxzWb1RoIZiegcH8s7tZzToCGDEybMb0yEs2/I19nf8zgdkvqIEn22l7KwMuPtXuRr2KKRcyIJWznfDByMtCNa0IJutPYY=;3:OOBLy4+5T2LCFpg4+coNbNF/Qak6ym+sGrwcMavNHsCSOGblBJfOoPfQz5YWhfAAovaubzS7U0v120Ry8j5EBKOlvrXjJaExXvB3VjI7k4BHJc8Y5pMTwuO/oWExuSU0uDp7+YEFrxYp7XH+S4WDaT8EXk8y0CX/vln5S1lKSSrpSzRARGbacRdhCpOdWJbvs7Xup24nkKR1K7vQ+f3jFTEiWgOgzhNHmh2HRFf5KIc=;25:8oCCkZ08gQF4DcX0QfnzxOgATqSoAukujEzYowZ8BHRa8qL4h4uZyoNtnQ0I/vpjEzF8RLsZcCSSw0CBaElz/Z3Bzo/z+XON679pawtMOLLILI9UGFd1dFVkgiEVjSZ2dvjKO3HV3nAgQEbi99a0GXUZcvu3yjcQWfGmgW3py+yeHee9whnm5MW1gsyYLLytpaSIbzcLlG8Gp/SzGu1WCFj555W92Qne4Q1YmDN48q9la/g05rHS2NcgWsXZELAR71ZKY4mUeW81bEi3YgBKUA==;20:KUPFrHf/+eeI1W4olMJO5KB54JYDdZ5FCVT4eB7CnkGdt+A4BxssCv2R892m2oUUt3oUsxRucmMUsv9a8v4/zAYKrK0ResjguRE2Occjb4KnsT7SjxKLfyM1zhp9jdUSRH5KouKfdZ/2PH+JdHQo8up3qUomOJyC0cTk0GKZQHA= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB309; X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB309;4:LJ4MjA4HbPd4BfVbhVYwXKxfjaq2O4d+2xucQRd3RmdoYGCFbkyxcEKqfsEtAVn3X4rtM8EwSdHGF+rmXKzuxKUod3XK80mqsRBPalR/mao4U5MmzCkPzWKb8XR78L4qAdqpfhsHsmrBeIm9HB3L6PGfabaEHM8AJdBeX/h0vlt9QYYJox3blP2ddQ/yjmnQG2PD1kRoq/mKigdnGTJ8TKpK+i8ggCg+dDHD3oAs3ZUwjKzF+KnfQ6xUx0Ykls68cq+Nm0lKEzO+NppxCJp1f2QlRhXzqAH5zUMBTjf6qH/+aA4nDPZwvT7p4cUlQeF5aZY3+9Finw91vHFAUPY+y5ElFIo9J/vO5wNfuA6Iacm9fIrEhGdgMd9HaOqoG8J4qU7R7ZfmA3BIKnvyhkCGJw== X-Forefront-PRVS: 0743E8D0A6 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BLUPR03MB309;23:Caq4VHTtgJusb8CDSJ69X/BXyL25rJgMViK4Gh9NcT?= =?us-ascii?Q?eFca77ykFdyZllkjxRtCQQR1W46l7R3toKl7qPlJ9/sID2VKlqF0Baakcqqf?= =?us-ascii?Q?zq3fV9MvoGuPv5HI2ZgwUtXWUzRspn7GgW1ErfatjCOU08oVaPhLbVQz9d6+?= =?us-ascii?Q?zGY9ribstLCynDf3t9V7ISLQtzgy6LrC/1fhoFnDwuzRS7WZbYUFAG73bogG?= =?us-ascii?Q?nXPf5rGNqeRn3wULZHe4C+xsyXXw+okL2jVdlgFeouzCmxqtk5vkx6LFM31w?= =?us-ascii?Q?1UDYXYnLz1p2wuBKjK6L5nsNUe5kqu1lf5wWKNcXTuLP8NS9uSmM6Wf3zQ5e?= =?us-ascii?Q?l1KhqikBOV3QO3qYztl2bAfsim7XR4Fn5xpXSFgTRKMNUxpkcy3uYeCIa/zZ?= =?us-ascii?Q?KMOu62t0KH6d+frpUN3YeMGqTON21+LGXJeNBjVREsUDTxP19VflJUfjP0LJ?= =?us-ascii?Q?c9H3SIQ/N4BDBIFUKz3YT7j30KW5nZeJBQLpjaOEU0SwDvk43nzwn7oq+pQg?= =?us-ascii?Q?tN6d9rl9H9/26Ryfgamvf+qnypIGzAN+AJJ6NjI46Q+1GjxwlwXMTznbp0FG?= =?us-ascii?Q?76+4PA0EuBGXHawsM+CR44Rbb5mk7R2Kix0E34vNNs0H9yulIA/CWbt8ZhPy?= =?us-ascii?Q?q0F/phlfJWhz/TPcb02KNOnBUOJG08dq6jbdNTTq1bPrzOseU5V5qf0G80WM?= =?us-ascii?Q?grybidy/cjXYkQY0iQofUkBVeXvwEgjPDAdycQLRzN6B6UfXLV+MZxBfOCUs?= =?us-ascii?Q?MKFgRJQgusxenb5Be0m2VzRQ0tAD2+Un7SdHQtzTPL4KgEx6hhLGSGGUS6mI?= =?us-ascii?Q?5J0XI4X6Wz4Rb+O7gjKsjNyNIgfBNhT/23ND6aYTWGc+B7hsuC6VqUXxuDBP?= =?us-ascii?Q?GEu7lcGYytRr32Vsa3gYzaRvBLFwESdjrwU5Bf/DxybkLWRyy1lRYjONVlyx?= =?us-ascii?Q?VMqTX7GKhb0TcapUBsTPuPBXS3oAHYX2kCGKgO6efWesLyAmE1GuowXFPZs/?= =?us-ascii?Q?XTzVaKSFahzgn53ItlYgPZPQNuOftjOAiPjvbq4U6+OHR56nHP2N2C+S0w4b?= =?us-ascii?Q?AR/qaY0GMNCdcT9SN1jJPFDEGy0ZqMHr1BF6UFMJlUfxvUXPELd5YuCDe2Zf?= =?us-ascii?Q?aZ6LZCEhHlGBDYFN+2aZA5kalOESy13zRH0z+lDr56Hamur+HFziNGYRSLI8?= =?us-ascii?Q?PU1eIoEDm5rGTgprOTBZTk+6V7Zm+cSsEsquMo6XfMbOQySlwJl4BN2GOayi?= =?us-ascii?Q?b21yWxW4iU978D6sr0xv2myWB1ys0K/1VoNvRaTDrP6mkUWc9j9h8UmJTSDo?= =?us-ascii?Q?fcIPIiUcm+UewxczvH+uawUVYc0ULYX9N8pvkbqSNo5JJlDUtOpxq8V9yijk?= =?us-ascii?Q?SHnHsG9V4+a3mZL3+6LabSkAA1gYafnLZBjWQVlYY8CY0PXs4a2UqHJZr4Mv?= =?us-ascii?Q?zVOJALXA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB309;5:CwI/I3VbPPeKYJGjkHs5Q5QxZ+Tpp7UdgdkhGC55gBUATr0f0TEdL+IsdsJVloAbkMEGl1cfWWLNHm58s7L8ihkNgpyoLu9yT8j81DZ2B80j/Wc2dMikZxlK3loCdDQgqzbKK4Ig9QeuSYKCqbD+6w==;24:Q/vCJ7Gwj/MYYQf2eQB1rHAYSHR86MKOODCJTNIljbyB5foxqBKDcLf3sO9rINYi1bL5Kp7OacI4EGTAY/n5OBv/DnVLCzgt1SuG/H2m9+Q=;20:FJvVIk4vILlYIRKgypwntrtBR1TSSKjsXjGAqQyuFhqNq6JvJeGbn2MuX+ceEGyZqntv30Fds72PFulc3eDBsDnwrUlT/Z5W9v3+QwFztRXMGvNt+fWL0cQrI7Fs23u7e3OYVihRUijuZA0N9Rlgei7Nzmt5Tfr39a8JOWF2OwA= X-OriginatorOrg: opensource.altera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2015 15:06:09.0346 (UTC) X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a;Ip=[66.35.236.227];Helo=[sj-itexedge03.altera.priv.altera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB309 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 28 Oct 2015, Moritz Fischer wrote: Hi Moritz! > Hi Alan, > > great docs! Couple of nits inline below > > On Tue, Oct 27, 2015 at 3:09 PM, wrote: > > From: Alan Tull > > > > Add a document spelling out usage of the simple fpga bus. > > > > Signed-off-by: Alan Tull > > --- > > v9: Initial version of this patch in patchset > > v10: s/fpga/FPGA/g > > improve formatting > > some rewriting > > move to staging/simple-fpga-bus > > v11: No change in this patch for v11 of the patch set > > v12: Moved out of staging > > Small changes due to using FPGA bridge framework and not > > representing the bridges as resets. > > --- > > Documentation/fpga/simple-fpga-bus.txt | 58 ++++++++++++++++++++++++++++++++ > > 1 file changed, 58 insertions(+) > > create mode 100644 Documentation/fpga/simple-fpga-bus.txt > > > > diff --git a/Documentation/fpga/simple-fpga-bus.txt b/Documentation/fpga/simple-fpga-bus.txt > > new file mode 100644 > > index 0000000..bd43478 > > --- /dev/null > > +++ b/Documentation/fpga/simple-fpga-bus.txt > > @@ -0,0 +1,58 @@ > > +Simple FPGA Bus > > + > > +Alan Tull 2015 > > + > > +Overview > > +======== > > + > > +The simple FPGA bus adds device tree overlay support for FPGA's. Loading a > > FPGAs D'oh! > > +DT overlay will result in the FPGA getting an image loaded, its bridges will > > I'd prefer 'will result in the FPGA being programmed with an image' OK > > > +be released, and the DT populated for nodes below the simple-fpga-bus. This > > +results in drivers getting probed for the hardware that just got added. This > > +is intended to support the FPGA usage where the FPGA has hardware that > > +requires drivers. Removing the overlay will result in the drivers getting > > +removed and the bridges being disabled. > > + > > +The simple FPGA bus will need to disable and enable bridges that will only > > +affect the child devices that are below the bus. If partial reconfiguration > > +is to be done, then bridges will need to be added within the FPGA design to > > +protect the rest of the bus when one part of the FPGA design is being > > +reconfigured. > > + > > + > > +Sequence > > +======== > > + > > +Load the DT overlay. One way to do that from user space is to use Pantelis' > > +DT-Overlay configfs interface. > > + > > +This causes the simple FPGA bus go be probed and will do the following: > > I think you mean *to* be probed Yes > > + 1. Disable the FPGA bridges. > > + 2. Call the FPGA manager core to program the FPGA. > > + 3. Release the FPGA bridges. > > + 4. Call of_platform_populate resulting in device drivers getting probed. > > + > > + > > +Requirements > > +============ > > + > > + 1. An FPGA image that has a hardware block or blocks that use drivers that are > > + supported in the kernel. > > + 2. A device tree overlay (example is in the simple-fpga-bus bindings document). > > + 3. A FPGA manager driver supporting writing the FPGA. > > + 4. FPGA bridge drivers. > > + > > +The DT overlay includes bindings (documented in bindings/simple-fpga-bus.txt) > > +that specify: > > + * Which FPGA manager to use. > > + * Which image file to load. > > + * Flags indicating whether this this image is for full reconfiguration or > > + partial. > > + * A list of FPGA bridges. > > + * Child nodes specifying the devices that will be added with appropriate > > + compatible strings, etc. > > + > > +Since this code uses the firmware interface to get the image and DT overlay, > > +they currently have to be files on the file system. It doesn't have to be that > > +way forever as DT bindings could be added to point to other sources for the > > +image. > > Having this will be really useful, but I agree this can be a follow up patch. > > -- > > 1.7.9.5 > > > > I'll take a closer look but feel free to add a: > > Reviewed-by: Moritz Fischer > > Cheers, > > Moritz > Thanks for the review, I'll fix the nits. Alan