From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966057AbbJ1Pid (ORCPT ); Wed, 28 Oct 2015 11:38:33 -0400 Received: from mail-bl2on0086.outbound.protection.outlook.com ([65.55.169.86]:43073 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756081AbbJ1Pi0 (ORCPT ); Wed, 28 Oct 2015 11:38:26 -0400 Authentication-Results: spf=fail (sender IP is 66.35.236.236) smtp.mailfrom=opensource.altera.com; monstr.eu; dkim=none (message not signed) header.d=none;monstr.eu; dmarc=none action=none header.from=opensource.altera.com; Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=atull@opensource.altera.com; Date: Wed, 28 Oct 2015 10:31:32 -0500 From: atull X-X-Sender: atull@linuxheads99 To: Steffen Trumtrar CC: , Moritz Fischer , Josh Cartwright , , , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , "Jonathan Corbet" , , , , , , Subject: Re: [PATCH v12 4/6] fpga: add fpga bridge framework In-Reply-To: <20151028095027.GK1166@pengutronix.de> Message-ID: References: <1445983755-24007-1-git-send-email-atull@opensource.altera.com> <1445983755-24007-5-git-send-email-atull@opensource.altera.com> <20151028095027.GK1166@pengutronix.de> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [64.129.157.38] X-ClientProxiedBy: BLUPR01CA022.prod.exchangelabs.com (25.160.23.12) To BN3PR03MB1510.namprd03.prod.outlook.com (25.163.35.149) X-Microsoft-Exchange-Diagnostics-untrusted: 1;BN3PR03MB1510;2:LbdBvh8/QAg2156/PxDLp5se5MGFolJ7+PEXRALElB/t1yIV+ZNP5F+ga4wuWGcr8oJdnJ0q2RRXfIFAs714IX97kW0XKREwHNyhG/umVLeRTRzzcV39HUhIPiUX67vPzYSOPHMH5BiosqZw9N/QtyEKDYneO98Om44wP8RmvTU=;3:X7zPei4FnM3okEEJj+WJilaA5dTleVpia8Am5A2s0gWCp9Y2V7DK6w5H6na/R+7Jo51b02otYQ8Rh8n5TKntaH2abqdBndXyTgKUqFR81/nK5vM54w8g0eKJpOKZZYmQfwPdw3nzCPBREN+TLG0S0A==;25:DK2Jp2Gj78IvPprrf9lUD+tSiy4FVsnjwLGnteea/eI1xybv+UjdlMqc3qGuGIypLe4e5Aq6PwU2toETyJ6ahPP9GqwqMzm2NTJTHOxj+i/JqvUzUtjRFH82doYKxuI8E3gfRA52jy9Dx1Yt2LbLY2ehSj4KzPvBCBUcEK5QF+EFBas+QNSXRfkqH4h12zxKecyMmVQ+JtaQMu3XPj2xgrz1REGT5AUd6QJ6ci962PSQp6nDdvDFo2xuc2ESKzucl+H56XDLwhjGgxYh9Fk+zg==;20:fJ/24Y1RApIRMXnZmw8S0NqdQAJ/566uqHo8FCb2mdjzO3tWHWS3AfCTzO0336CIXa6oMUowPzc1QtZtU1x5zkpI3MrOLMFruSjoKldLYL2KackKM5JvULCkXJOdsW6jkxR2a03RkVCO0w1o3cL57zDCBGXLpHqnnk0oUcfndxc= X-Microsoft-Antispam-Untrusted: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1510; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:;UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(8121501046)(5005006)(3002001)(10201501046)(102215026);SRVR:BN3PR03MB1510;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1510;BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(520078)(8121501046)(3002001)(10201501046)(102215026);SRVR:BY1PR03MB1498;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1498; X-Microsoft-Exchange-Diagnostics-untrusted: 1;BN3PR03MB1510;4:KnJ9BcdvmtiHA44HqbT901ZdAMzX050pQoegiqEOhF/3CY5JNcHUXPEoNdm06zeV2R13VepxyagZRedvL4nkUmQ1J+8Ln43PH+Xt2JfFXUB4vaFkqqzCS/882ax/f1RSGgfTnYZHT3BlWdEC8L7afMXa+p75PT0hboX7PGN5B2fKTwZIHyP9ei3nDXZ7ByhwFUoJlgnPn3ldfST9hyK5ac1a2nmy69pYPs+8EzPYgNcld8eYZqw7I0ROm4+BWrHNaLCXYY72A9SQJkWCRuRMrZB2TC72ix5jv7e/gyIkKFWOQIUnc8DAIhYhO3NIAvfXiHg3SyUIJnbgvkplo9rpddmASSnrAPjNvjSnZMNYxrC/1eB3uKZ3oBjsJb1d9oBLT68DxUwslI9cLCT0uMdg1w== X-Forefront-PRVS: 0743E8D0A6 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(6009001)(199003)(51914003)(24454002)(189002)(66066001)(50466002)(5001960100002)(2950100001)(110136002)(5008740100001)(77096005)(47776003)(86152002)(107886002)(189998001)(106356001)(105586002)(40100003)(23726002)(53416004)(122386002)(33716001)(46406003)(42186005)(92566002)(5001920100001)(4001350100001)(81156007)(97736004)(86362001)(83506001)(76176999)(69596002)(50986999)(101416001)(5007970100001)(5004730100002)(54356999)(87976001)(4001430100002)(7059030);DIR:OUT;SFP:1101;SCL:1;SRVR:BN3PR03MB1510;H:linuxheads99.altera.com;FPR:;SPF:None;PTR:InfoNoRecords;A:0;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics-untrusted: =?us-ascii?Q?1;BN3PR03MB1510;23:KHrZZVqfcyj/gFpZfF83pgu16LWFW2Lmqgl2q/BMj?= =?us-ascii?Q?rGHAENAzkz18qgofD7mHfAZ41qfFhl0NPcrVpQZRxacDK/K6i7rI0ZGDkSFp?= =?us-ascii?Q?WD6Lnd3F8JrMnGBEArXh8TiBielcNEqSfysHyyGRi6W9+g+k+d2YW1AXZtFW?= =?us-ascii?Q?iuGWKK7DaAYywtjS0UU0jTBIrvGtizryk5ppA1l7ZAFfyWII5uBCZoDawp8r?= =?us-ascii?Q?WD+wLoO3COwW97SQgnOI76sg4niUM3hD48I99zIKo0YYLHTh2OnrHgvUuZ//?= =?us-ascii?Q?qUkaYBygMqcXDgWnD0A7DRRxQ0nV3bmSz8PTbSoZhvtORzLGIevbX9G7ssXA?= =?us-ascii?Q?b2jsI5qADEBlgttwpSMWAUv9wDL3dtJnq+e3UQA4AQOHoAehefLT/TvcM33P?= =?us-ascii?Q?GPF1nxVoNepe/FOGpFkgICOwPmlVpNgdTz6GOF6n32W4/cwLYn9dzUUUqxps?= =?us-ascii?Q?fC1wO0BKAZGEoBhlA+gKhh0naLewgcbs0Ezg7UCIyCWb9BuupeTH3gv3KxIa?= =?us-ascii?Q?zbkasjOP7PouSEBqhu9AMCrVIoRN+mG1ao3uITVxSPCPBmzc718k2YpI6BUt?= =?us-ascii?Q?kMKgNWcmQd4qAWPujRS3dWYr1up6Ecy7K7hvxsVVzFn0VnKzVW3QgGwVnKFT?= =?us-ascii?Q?4kxb9Gl9nKHzP9ihb9RGMV1puh/713hZNo0xyzi9MbisCeHFyDnBlhQQ/DxS?= =?us-ascii?Q?RIry3txUgJ15CIuAOqOoA6Rr8a4p0Ow82bu4FDDMUk4IBRVt1vq1R0mTZfcY?= =?us-ascii?Q?JPoql2GwLA4rj6SxYuxZTuZuHgqpGT+Gt+b9E1i2saz2MPDe3CTFBx93ux0N?= =?us-ascii?Q?sp6eIEg8uhmlk8WiXgR7anNhfFYnpAciGSQAO+ac1M/aiWry4s7dyEO0uv1/?= =?us-ascii?Q?7qMKSPxwrL6OKKq87fjHJwDR6q5Z2yJ5r97T22F/oqrA3MDkBVyqmdufpMZz?= =?us-ascii?Q?HdT9CA/7zfLImxW6yznz9h2HAw+E9+MgGnrQQ9MpYquP7JvZmUEuhGIVs34X?= =?us-ascii?Q?W6/GNyYwUgV4/P5Nix0+uU7taTMgj8XF1HopGSr/nmsPmKYfAGkyCth47VcW?= =?us-ascii?Q?c5pYiUFV3mJ3mj6C56QmZG+9TqkNbXhMvrIAlcySUpycF7Zy/J0YScyEsuNi?= =?us-ascii?Q?CyT77ZBrzzQabIGgdAXOnjjiHLeQeuL?= X-Microsoft-Exchange-Diagnostics-untrusted: 1;BN3PR03MB1510;5:jc/cm3RvHmqgZCuMD7klJh2YlRR/uIldB15PCT5xs5GOh/XKXNG9QGB+8qJtWikvZiBwUwPEGkHX+te+vNpUdNikJzSQ5I1H5bU9fAsFK/oUgnAOAz5dcBpuF1uPkkBpAeDSGwTJBCfLwuxnSS7SDA==;24:ncjJM3IVoqT0hxcj9GbFQl8qZ1PkNpgyZaJT+HSvejDCRw3rWmYujgq2FU57q6dtDWgwRg4t0W7+3JhaY1WENloRzuH+6laBLbh/UL0CN3Q=;20:SiAYYxBgBV9bFztZwArfKggiNo7qL5gCZ9+/nbfmMU7v5U+E0h+oyRT3WSjOEBUOdyNxK/jP+HsdLpjxrau+WkYg9u9wO+6fhlwSwVGzN2/e2TiSiCTTHXA1FCfJ8HrvrNZ6WuH8KFWw1fm9ZT7DjJj/53wssFseR7UtNqKq1RU= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB1510 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: BN1AFFO11FD022.protection.gbl X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11FD022;1:7c6gwr7jgrJDE5wMIkbUZvSSciXEIPkzO93NY5mj1yDEkE+aRmrHOFydJ3NVwdOYrLP/iCJg3uy0MILlUgQbZVfk+wwcE3ZpG7ythzCFF4u5YmCgFE/LwMon3wWC3wL2lT2g6Z57ExipHtr9mqqEbBq7b2AGbeqhrwosY9ZWK3R5fGZkE/p1Be7vS5L8jdPX7gLhBWXxoNO1FyQ0DEDOh3mpW9ZIWvGisbTDvVBGAXZg1dEZ1ALMzZ04Jf1yJqe1wttZCsWQnS9OA51v4KMuPPrj01i9hDkFqSQacCvtcNuMz1oFJJlfJi0ZKr11mItStzEnkSMtRWcAoCoBIGSH14ZBu/5Do7YJlBKNRVcb+QEhdDPdxGjivucNTBXvs8zrJImYnbIdNazwXYA61x3Egw== X-Forefront-Antispam-Report: CIP:66.35.236.236;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(1110001)(1109001)(339900001)(199003)(189002)(24454002)(51914003)(4001350100001)(5008740100001)(33716001)(46406003)(85426001)(97736004)(6070500001)(40100003)(21840400001)(2950100001)(87936001)(5001960100002)(107886002)(122386002)(81156007)(189998001)(92566002)(77096005)(16796002)(5007970100001)(86362001)(50466002)(105606002)(54356999)(47776003)(110136002)(23726002)(66066001)(76176999)(106466001)(50986999)(5004730100002)(86152002)(11100500001)(4001430100002)(6806005)(53416004)(83506001)(7099028)(7059030);DIR:OUT;SFP:1101;SCL:1;SRVR:BY1PR03MB1498;H:sj-itexedge04.altera.priv.altera.com;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;A:0;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1498;2:jRQEHQQWsRy1z/Y6j2fax5UCreA/76nv/a3V8xGrqmB0fBgC6NaeBy9yUp2cVO3evYVGmtr3UTaZAgCDzmfA+Lq0wXrdr8WNV6Dl1maHvKJKdF9HF2fhGB/A6Vft3cj8nelJlGY11BYSZ8s69bs8mOZ+NCU/I2LGklnddohKnFI=;3:NLJlH3/hFwn7TdUtx17HxOZ3XVhYHqBs4zg7lHxhYP8iVOnLRMZswDqRaNW6AXsJOEzY8Bav8lE2gA6C9mJUe/aA+DKXp39BblTQz8dyxTzOqnrrmtmLipLj0GNaLEgbqX0cjExEndjlrFvkkY9G5MmmLuIPUrZMRXvTg6K46qxGac4hvdLxUqf00jYjVL6M3E4rBbWf/eHBSQtRUtWAWt6IADvaZi+H3dnWHrWlefg=;25:3aUbFvhVWtp0Huil58i0H45aXFbfyCcAzQldBxvAAYQ+wkDe8z2v37mxMnWr3UfNNvojp19H8QVBqvcF1lHRrELE9mpHx5g1b40mKJeAfAqAZrUGcBGe4NGTTZwY9QEynrGaZ2yA0C2ehXLyarruAblbmTKZWB+okmneXJoS/r+YoBvXakLUur+tt5CKulLfeBOpz0l/heyCkELXkPuJleGru5/ZvWxN0nXQ6IKl9+Xj1btJcSWrqlEMVY4wVEw3EYu7mrckIylhqDgvRWX5cg==;20:KfH6Of+JBxBv6E57fK9swgBGtmcTglHnruNQ2I40dxp6NsGTyh5O9fwBRBK1NzVOMnLkK4eudOibi0ky4us1H6SznvniZjKCENXTn0qaAnRX+669p1TxanCNoLGSd6Guiufok/+eeOl5sTISawqN+iBzD5wNqfeRHHyFhgPmjZQ= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1498; X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1498;4:JPm+QMRJd4UotHaKv9aegQtLK1mb7jo6gu49ohPs3Sb4WNpwbbma3XS/oT3LNU1V5cHosnaSKAywv+ynUhwl16sf1C9ZahEQ8dZQa/A9aGtvl9rnFaDV1TAISA3dbuhwJbIZHpbxx8WHzvkJPXGL9xzw3ervEBBG7wGfVFmLWXhmh9AEsFmh7Jc0dOOMwS+aD61EM/SFc54jQVquaOEi1iEcoAL/lCdaT4CRkI8CIaopdPqX3UzypLmK2Z3PXaY4B288IMSArlEYzTjizuu0SvbbPETTN720sflihBx0cCBuT/oixsgo4xwROBmEf8dfRxFw9bTOrAcLbGSucaJT8P5g8U9RWX7XX0gexHb9T7Pw9nlsX7Jv/1hyupvdsihebQ3etgJp4Xx9bcr180uqTQ== X-Forefront-PRVS: 0743E8D0A6 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BY1PR03MB1498;23:EAOtNCyjC/ddGrkYcHqiIMj76jlhJR0VC4SOn9ziA?= =?us-ascii?Q?rbO0rbO2vcpeIHJwU8niWhTYKA7uVbNZ+6fhsYdgX3C1/DARwWgmkmacY2ha?= =?us-ascii?Q?2CpYHJmEiYMaZclk1ktdKBu2rCxmfVmcdYK/szEEICISX/CPHZZbFBO1wYSH?= =?us-ascii?Q?BUo5bhCO2jrQZ18ry0hm15v363RfBUht0FNRlAhU1po+lWCIeAQbLBLhwv/F?= =?us-ascii?Q?EiZtnwwxxi96z80Y5O9lsdbPl7fJgL8GgFXirYLCrDj2+uyZFUXhM1OYC0GK?= =?us-ascii?Q?boA+JZIYBSMSdWK8ZNk5hQBIhHvMZgdlQ3LzPkgyWiaC+ruJY40MO79lsMk0?= =?us-ascii?Q?mnFaTq53wuW65sXYJZxk88BHOucFV/Uvcfc+Vl2FNGNUVDY52YmVvgIOr1us?= =?us-ascii?Q?djwMS9ulDh9h9VmHZVc4DnIwMOjGwZgWwp7GDyyGniVKHLLhriBPsyA6P+LV?= =?us-ascii?Q?fj1+8La3Xj84znx6r3ajakjLVE4PNTrMsKEoDfflbztwE1Ku0QcdIV/ywC1x?= =?us-ascii?Q?1KhNycQjTr2uuHq1JxMLp0KhxNKTyG7rAEvsrPMEfHgmzXGVdqfzqLtvfNMI?= =?us-ascii?Q?pfvaO5CJHcQiGToD3dO7sAu94SGbJ7PHIrQGM5bCEKM7SD7Tma+au3JAMZRZ?= =?us-ascii?Q?LPIoZ6RA6gz9rMFYqO6WnaMSRKLwEjXGVC6A8lK4V11lk43irKQ+zB8iFHcA?= =?us-ascii?Q?u+NzxpVzx+TYKqWXsmVy5gnNgkguhao7PJPS7miMlAcvz8XKQupexSRzLckj?= =?us-ascii?Q?kKcMLf2HrYv0SCexbJZB/yMsZ4TjUSd9ElkUoW6/ZG2pFQwZjQvIJ3B7uFMd?= =?us-ascii?Q?uGuRmp/87E7fvti7DuNlwHz7XhvtkWqLc77Y33y6aMM87uSqpm0vcSLr9my5?= =?us-ascii?Q?Gk1QdUQIhGCGH2zqMI2aQnt1QvxYsAxhyWSoV2jF3fXbDehYa6y6x6v1v1/W?= =?us-ascii?Q?cnpXTvg8za7QGA3Woxqcj7pVKbeqoB03yogNXgKjwahunPq4pZm7+q6RVqSi?= =?us-ascii?Q?JZXB4CSE7qXH/EwjI5sBvEpKyY8SafZyaAma760evSXuoHwQ51E7QXo/mIMm?= =?us-ascii?Q?SicqcRJfp4vxOjJVrEwUQQ8wn4+rnyCRky+gIke8uqP/Jd6VEhay13JgPCfU?= =?us-ascii?Q?9tmBFm5uQQ3wk94eO4nrRF2nxdnikvdncgywd/+SS0Dow/9NDZHRQhzoPN1B?= =?us-ascii?Q?6aS8SQd5uNm7OHhrzDHkLHPLTazPaSYJEMoSCBwc9JamyKgp3RInq62bm8Hr?= =?us-ascii?Q?kHJjZfWkQJh9WyoT3gkujBEJf/J30vO3rK8bfyloQHzAVZl9JKAUrXTUr0gX?= =?us-ascii?B?dz09?= X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1498;5:oAtUjFh/XGC+jZQFRB3ZcYm+fYl2rRmYZn5GhUrNb4D5qHOOC/woaBFZJV60DWcg4oVTfc8z5334ObSI4s+hVBTJbf3t7Yz/VJhrVDo8zT6b2KwHZ1G0xuW3lIEnvx29ftPPE48G0YoJAfSQCIBivg==;24:OB7q2c0Dd+bpwAT4/lF1NJDfHhAKUSyGjRcqJyX5IHEjIx3iUB/+Ni+54XN+eMgQhYt4OB+q91Gip9fjucBebaNnfag6VrPyDEFBM1h+0c8=;20:SbZjV+E4WY9dnjeigu6Q0KTSvSjvGEPOP6OEOUkJfZ4NNpqXpe6Mh7H/RDKaVnLeEOxH4Y721nZFcaj4H/vUTZnhL10qQBsRHojBBHnNH9zBoRMH9z+b6QS62Skoo/8uR4apVApmys7BeKwo0tWDw1vIEsWyqM/1p2+4YEkanPU= X-OriginatorOrg: opensource.altera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2015 15:38:21.7771 (UTC) X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a;Ip=[66.35.236.236];Helo=[sj-itexedge04.altera.priv.altera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB1498 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 28 Oct 2015, Steffen Trumtrar wrote: > > +int fpga_bridge_enable(struct fpga_bridge *bridge) > > +{ > > + pr_err("%s %s\n", __func__, dev_name(&bridge->dev)); > > Please clean this... > > > + > > + return bridge->br_ops->enable_set(bridge, 1); > > +} > > +EXPORT_SYMBOL_GPL(fpga_bridge_enable); > > + > > +/** > > + * fpga_bridge_disable > > + * @bridge: fpga bridge > > + * > > + * Disable transactions on the bridge > > + * > > + * Return: 0 for success, error code otherwise. > > + */ > > +int fpga_bridge_disable(struct fpga_bridge *bridge) > > +{ > > + pr_err("%s %s\n", __func__, dev_name(&bridge->dev)); > > and this up. > OK > > +void fpga_bridge_unregister(struct device *dev) > > +{ > > + struct fpga_bridge *bridge = dev_get_drvdata(dev); > > + > > + dev_info(&bridge->dev, "%s : %s\n", __func__, bridge->name); > > Is this necessary information? I can remove it. > > +static int __init fpga_bridge_dev_init(void) > > +{ > > + pr_info("FPGA bridge framework driver\n"); > > Dito. > IMHO unnecessary log spam. Maybe change this to dbg? Sure. > > --- /dev/null > > +++ b/include/linux/fpga/fpga-bridge.h > > @@ -0,0 +1,49 @@ > > +#include > > You don't seem to use this. Correct. I'll take it out. Thanks for the review! Alan