From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757554AbbJ2PMA (ORCPT ); Thu, 29 Oct 2015 11:12:00 -0400 Received: from mail-by2on0056.outbound.protection.outlook.com ([207.46.100.56]:17081 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756814AbbJ2PL5 (ORCPT ); Thu, 29 Oct 2015 11:11:57 -0400 Authentication-Results: spf=fail (sender IP is 66.35.236.236) smtp.mailfrom=opensource.altera.com; lwn.net; dkim=none (message not signed) header.d=none;lwn.net; dmarc=none action=none header.from=opensource.altera.com; Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=atull@opensource.altera.com; Date: Thu, 29 Oct 2015 10:04:58 -0500 From: atull X-X-Sender: atull@linuxheads99 To: Rob Herring CC: Greg Kroah-Hartman , Moritz Fischer , Josh Cartwright , Michal Simek , Michal Simek , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , "Jonathan Corbet" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-doc@vger.kernel.org" , Pantelis Antoniou , , Dinh Nguyen , Matthew Gerlach Subject: Re: [PATCH v12 5/6] ARM: socfpga: add bindings document for fpga bridge drivers In-Reply-To: Message-ID: References: <1445983755-24007-1-git-send-email-atull@opensource.altera.com> <1445983755-24007-6-git-send-email-atull@opensource.altera.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [64.129.157.38] X-ClientProxiedBy: SN1PR0501CA0011.namprd05.prod.outlook.com (25.163.126.149) To BLUPR03MB1507.namprd03.prod.outlook.com (25.163.81.25) X-Microsoft-Exchange-Diagnostics-untrusted: 1;BLUPR03MB1507;2:4hCFeQMcYEszghX3fngr8YX3yS18R73t1DehFE+N85Hf7dcyi0U7pYhKcJLGghfWwiHlKGzQDA1OvkislXoOVVFbRyQwMIoLsCD55IVPH8w3x+VfaK40KDA8dB2JCLKeeeI3g53GlLEW9/Lj2OMRrv6RbtMfrRgr2S0q76KtC84=;3:IIQ/RiQEnJWrLi8k+InuYb+jZwUsrBy9pJ9zKuqBjDLZywUnrk8YfXtX9BzI9vNO8EwxUXbS8Lt0lPaRs0b4IEcLBuc+jk2+N9w5pQS/GIZwngCk6oUVth2sl70z53QYwhXVV5G0RYvcmRqhfX96cQ==;25:3eySjUhOCw2uK0gqYLqc9yXToE0Bhi5z3UAtGOKEwbhourSYcmKl3ReO6/bFFo//x6i9tQBLuMZ9b/hfciAljNHkxFCkxXIxpxdR+i157bWCYBqB7nd3jNxp0VEXgsQ0WSnHewhLptQlsEC21mlnFB1ICEAAQL21tGOrrNpqnv+j+HlWsFp1X6L72wlF28mXP1hX4kWlnOFiTR18Xpl2DPwhLvq5BxaMmyP87I49VCE/Ew9oE1hot1IDbgT0cOm7L1HMrqyCx+objdrYulNpRQ==;20:Q06eDZ8VADP+nc3wEOdk+7KFFN2j+xq3/Sz2Rf9e7n7q4CxQ4ZOG85wh9b9ar1FiGecmae1vi5GgF+fNe74MUJHsESJiMIRpyQGza8IFvff79e14bII+4hwKun2GeVeHTT+1pWO7/P4hIxWl3H748s+2vGwNXouHsm7AtMJs9uY= X-Microsoft-Antispam-Untrusted: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB1507; X-LD-Processed: fbd72e03-d4a5-4110-adce-614d51f2077a,ExtAddr X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(80048183373757)(204874498639787);UriScan:(80048183373757)(204874498639787); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(5005006)(8121501046)(3002001)(10201501046)(102215026);SRVR:BLUPR03MB1507;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB1507;BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(520078)(8121501046)(10201501046)(3002001)(102215026);SRVR:BLUPR03MB1492;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB1492; X-Microsoft-Exchange-Diagnostics-untrusted: 1;BLUPR03MB1507;4:BN7GBcjrdWaXn+KuzLNyg+TvNPLx5TQQ/LgqzZWaqgsLMQ+Syaqh/ND9l8KrmhkGtJwnItYzO35tmg8W0Ss8SQHy0o8K8ZlstJFuI2EZzW4oRWqLh0OYarnQunoCZ3ByARo2YleA8sfJ26cbR41gMGhZRDT8KdkjHeAWjV60HlAgLtR4FAJ3+J5ji6Ta43ccYLpGJw7xsnotIk8oSCSj8G0rNx0t9/dOgdkl6bqyjTjc3q4311ZZpRT5AALMXQQSsN/oZteEK1RnlFvgSNToBDk1AX98T7X4mcldIWPICq6N/AXI2Se1iOPapaEL8+X8iBnJ+E7HVDEyx9Wr4jDwwa2mxZg0Zy+0fSJusOb6z4/6iaOuGnuQdjfZ5r/n3lhozyOBL1gUH2eJMxuP4oNjxA== X-Forefront-PRVS: 0744CFB5E8 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(6009001)(199003)(377454003)(189002)(24454002)(5008740100001)(42186005)(4001350100001)(101416001)(77096005)(50986999)(2950100001)(40100003)(83506001)(106356001)(33716001)(122386002)(87976001)(46406003)(97736004)(86152002)(54356999)(47776003)(105586002)(50466002)(76176999)(19580395003)(81156007)(189998001)(4001430100002)(5004730100002)(19580405001)(66066001)(69596002)(86362001)(110136002)(5001960100002)(107886002)(5007970100001)(53416004)(23726002)(92566002)(7059030);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR03MB1507;H:linuxheads99.altera.com;FPR:;SPF:None;PTR:InfoNoRecords;A:0;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics-untrusted: =?us-ascii?Q?1;BLUPR03MB1507;23:poACFZpL5AhgzKNaguYApE5ANF0Sj80L6SJayy4k1?= =?us-ascii?Q?gYqmqa8SKWwLxeoNDbRrKRnaNS9IHyaFKD8/aw42y8Bo9KgX1APnfqec7SU+?= =?us-ascii?Q?1qNwiMPrlfvttnZg6wnSrdsvTuj7m6eD4GPNSa/i+z7+GIZwOqFqRexnYejb?= =?us-ascii?Q?ael7JE+fGDLnAHlFpqQ2Te9F+gASTOUgoqxEOcCLtV+IJUbDoVJ6QSi+cauL?= =?us-ascii?Q?uJPq4TAGaJGCXVEZQIBzEUtiFEbaCzz9mNG5rvXJRXzsKhvde6QwjgqB3wm/?= =?us-ascii?Q?KHpdxzV/PECmdHD66jrVjkKmhRz7UUixu4nvafz5DF59bfaU8ki//sRmSs9n?= =?us-ascii?Q?2VWj1QF7neT+ah/exvZ89HGzE6a4Ezu47hcXYt+kIpRmQXIcRf9dbKkqzh/W?= =?us-ascii?Q?9/+V57gsSrQxvhDjEzVrW/3TlydZkFjzAiUKQpN9TKZs47VUkBUedy6AHZJ7?= =?us-ascii?Q?heO2hQM+Dt/j1NCbLK6DVtJZ/z2B+deMA/klfZxYa8+0TSbMCaOtzdLrDe53?= =?us-ascii?Q?lTPCOfZQhPo4Mn8yBFllKoJr0bDKIM9VRWdJq0TN3AMLOxxJ2xVbbf557EVv?= =?us-ascii?Q?WXuMcCNDKk8hoVLenxAiiwESXW3DovUsMGghqhl8X+tEHXT7afnNru6rDSAO?= =?us-ascii?Q?Eg4ih/yCdE7onSMSDXLLMwddvPCW7saeoIVJnM9/PmRoLDbQ06T8UgujJGaU?= =?us-ascii?Q?UMS9knSzY4A9NLKgnECVvRUag7lDjXFCfQRC55C6Waf/hrOujtcR+oLQGkqH?= =?us-ascii?Q?n0KLnPRN2/gP4zqll4RK1jJbif+dYlMxXU3NwODdWDL83JreuBT19w3UleQ/?= =?us-ascii?Q?6Modb/BlUr0uh5P3atoyE5MQGD5zeRIncP4DoyYZ+5tY+4UvFFgco+B/Tzio?= =?us-ascii?Q?ZprvYuJxjMLcfG/P/VKZZTer7yNoVpbJMJGWyMVgtpCzHowawwJRr+rOAE6l?= =?us-ascii?Q?UlS0hqtFUKb8aH/P2vym5ej5o80ONixaSH+Z6kFiJnkO3FwnGqfu/CEjsg0J?= =?us-ascii?Q?pkaJKuyTnUIIO46B7kI7IB+MeOoNfDNEDQJKqxKrnB6RC+ofXktmYF0Ygd2H?= =?us-ascii?Q?wbnevoBbQmDw+QQvDJ/CcuEjV79rE4+R+UzyLL7sAdrBdTWtt308Qdd8L3hZ?= =?us-ascii?Q?I/DAxNtsemD5hTVWaAF+8iZr4DhGBS+s2QJkW+39Y1CyLfLrF0Hdg=3D=3D?= X-Microsoft-Exchange-Diagnostics-untrusted: 1;BLUPR03MB1507;5:go0gfkKSuxZ6OsbJwUks0F2V9nv7wUXHaUCwbgCgULoKXI9CDJuMkUju4LirIEVveVsRB0GoDlV8B3HQ1wzE1bvcQXyPdmolsIuxahvoJuefHEuVV2BwJLRt8Ssg04DmOz9oNp5X4rcNxHsX+w7qJQ==;24:3wwj1JdxJp1PF//7sykAF/l1Hu7NutxxHtNbso1iyZGncx1TTp+WNOgzmmcSOgRZRb3BXREe1+/aLkVKKX8DCwCajI719SGmc3+NoXlXhBQ=;20:ocvyli1KlO5soLlG7zIokIyevxjd/CLC/5hDJbfX+OAuFnNOJTUmyVsWd/IovY40yYvrCEpBhfFVM2/huowrCrm3AfHkHlbgQbC18AE94qjFwkA0fv5t+8fR+mqK6OoEvg+ZZyzG676+3+tLhSuOb2h0wBzdz+SyURUeCB8KOjY= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB1507 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: BN1BFFO11FD028.protection.gbl X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11FD028;1:HmTTkzJv0Qp87H8mjbTlxuQ8tWdNMMtQWQKpzONcqy+/r4RwcUMEiQFUMlhkJEpaZyM9imKL0Uwx9TCb70OeUt3X6mdzjbMwL3kfwzrrooi/vCyXcyi4M+RrjuzTRh/RscSyE70nHG/JOVGv7MmMohy3qxtAkLrG0QU1obAo9mTas8iEaOAkzoc3gMCe5g3HssZgsLOZ4agwiD564iqIbylT0QsWJ0M/ffBUdsYPYej50/v0QaNrH0MVgnVftFyzg9Nw9BthWbb3KlGBb4bqDnel6VYh5QpOiAruWoN+CIkvwszY7F1qBJsCne8VWKYavZkgiHWaQtd6nOeNHGwL1tZ08bjgOO109/byvJJoocCB+WQfBwLxpmNCg4Z4Hv4xZ/DNpiNGFYurg9v6Mcs+WQ== X-Forefront-Antispam-Report: CIP:66.35.236.236;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(1110001)(1109001)(339900001)(199003)(24454002)(377454003)(189002)(6070500001)(16796002)(66066001)(86152002)(85426001)(87936001)(110136002)(107886002)(40100003)(33716001)(122386002)(189998001)(105606002)(47776003)(4001350100001)(86362001)(46406003)(81156007)(5007970100001)(50986999)(21840400001)(5004730100002)(77096005)(76176999)(97736004)(23726002)(5001920100001)(6806005)(54356999)(11100500001)(5001960100002)(92566002)(2950100001)(50466002)(19580395003)(106466001)(5008740100001)(53416004)(83506001)(19580405001)(4001430100002)(7099028)(7059030);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR03MB1492;H:sj-itexedge04.altera.priv.altera.com;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;A:0;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB1492;2:WHIZX1+rCaTV42ZsQhVNB5Y4BIePEx9GHvy2ndG0Ng8W8f9w6eMu6kXjtZosEYPgvGVaq1up0kefTuHXY9jUw/gYiagV37aroGIocn99JcH3gEjzH547VjLPNwcLEAVU8T9KU9mkOX/Wr37shKPNE99Zs/7myY2a542c78X8jmo=;3:bEuokXUfz6DBpxUWfu8axeaKxdOcYRbdbr5DVOoDuasLuPwB9e4EosbOJevDXEi2x2hKWD29e5oKd/9FCaQlzSCmNkd8tvXpNokymhWE4U6Rs6q2HBPaSCxGO1SEkTt9I5YzZLJ/r4zS0DWTrFcsDRvSSNbgR8aTbaKQOABJmzHpT7ZB6H36nWgi3EsrE8vOZuv7Fv88NX4k3UeVM1I1itV8nsAwvHjUEcoSmfipOU4=;25:z60CbA/MpMDR1UI2FN5hA1pHU8u3V0GiKlqSspy5SYMPa5pSDwjcsxLrpFAO2I5OVIWbWvzCm5HfDy0heEMiNaJeE9tCmzfPc5VDRfCZvwFhEySIIMYIyNddmRCTwBKG3qljsVPs8SD2byu5e3E0n5J6sl4pUA3V5U5tvZfUvjCmR5y2BeVgtbFRe7o4Ohl8g7aMgedgN5/+ee+z4JnETjuVXx64gG+TOwSeGBLIkhkWnBv4b66tXvAy9eHTkdJcRkdVvg/sm3DsrzlbQ9DJtA==;20:FlVBefQnIm/qx7f52BKs1VfelMDqiHPrlT6cv7ls9l5AagAFg0Hid+dTl8dXkZo1ypz9xCuqXQkB3ozftqawukTurhJettDmX6Ia2p3MJNOcqSiAWw8LEe2WT2bmrTwg40HpmV7Or1jmgRyALhHrt3bocOoZ4+7hq+rNrPZObik= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB1492; X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB1492;4:Ru8//yL4joAd45cPhzfxBQ2pN4rigAgZi9MdBV3eJHEe4EwoFuBJnymRM18mThpJZXRXQ1duhMgJ+fbYpAvT7owaGo6w9fEqwOl8NBlVILCBCTDJiwV+cbs6brZ4T4n3mFP9gaJUxpDSUHlVD9YglFhvmAHnalMVXSP+kZY2VXoaPXGzPNjqSeDGBwE9eSH2kt7kNp0c9tKiZmLG05Wf/oH5n0ETnwnQBkYZ0SOK/0PtFpp3pqzquK3TrFmZuYP3pXUoILsywCxhRLH9xhjtbkuFIgG/Rqy4Z/j+0+yCqRp8utpN+t/jWDUFj9/B7WsHVfJlzWxncHdRjQb6gcloGUTlAnC72bzSUxUeLL0TOnrJOvgd6d3v0P7bOoytKm8UXGm6rKBfRaa6KJNaXYIgkw== X-Forefront-PRVS: 0744CFB5E8 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BLUPR03MB1492;23:zkFyppPXeRB7yoM8DZ5tArubZY5C3ugxea/kr+W+U?= =?us-ascii?Q?7RvbHT8Od41U4NoruHVMJEvYdH2r7+iAOgxP8OfLfDe6Lcc9sqht7hyQdVGH?= =?us-ascii?Q?uVbPIt4YfWhsPGI2yhxz69oVqOvlnZI0aO4pU4MrNKtIZT5CxnihCsftrbaP?= =?us-ascii?Q?BMaFQToZVvRPsjTcRmYiOJco7tH0kQnPlMdWPaVIuJOLypy8eCnps6LqXFe0?= =?us-ascii?Q?k6gScS0c+FpdjzA4XISwqSLsNrIKhnhEuMdtR3rG1ZbviRnCah9QizbhLZ3r?= =?us-ascii?Q?JGe17UNM7fHFEzWLuyDyXuEw5PJacV9fZOmgrp4HywMz9hQU+VEcHjurGAjr?= =?us-ascii?Q?MIZxMJ00f3/w6J1t/RW/Dk9d20QVdvhk/SPzPYcGrdNdjVgFUxDOZAcLU3Su?= =?us-ascii?Q?bTf0fDwMOqgprfBqWt4kKyUp0PVODMvckgfadjbk4QuA1ARIOL0Iv4aPnQ0m?= =?us-ascii?Q?pJoaOhJ5TBw0fMMOK7cVm6FejKxEwnCBWiZgP0KCkjEhJmo+ilpm8iBydFpq?= =?us-ascii?Q?3qOlG8bdjg402byfWpJyVKF6Syw+bIcgQQt2mnMbSsaRPV/ha4rSz72E3/MJ?= =?us-ascii?Q?1R1iUAklMxBmvtNu0XkbL5khRYcTd0vdcFtQo6V3sezVLKBr7EB1ernIVzfa?= =?us-ascii?Q?SK6SXy5oib2rUP//ILsn15S8xQRGkfTh/UoEeS4z4+KOoNoaKmLGthdNd+PD?= =?us-ascii?Q?Havji2/CXohAl1sQVU3eXdVYw5q+RzBwbJhs8KAdJSw5S022fI38sPeDv8Pd?= =?us-ascii?Q?5p/82LDBWP2BQps+q3Ish3+9AV02yjwy+EaRL/X8CMtwWcClA3F/pu9ruQFy?= =?us-ascii?Q?PRK8XdajD4tRAWsq9vHKYklaApAPwi1eTw7Boc5Wn/9GKDdubdUJLflNaeaG?= =?us-ascii?Q?T6dONOgHU/wLyXmyXqqPHEpSPCgED/pv7NxIFqJpApPOUmnxdG/TyVVusWkt?= =?us-ascii?Q?X5fsuVVXCIhBHwKvtutbYndvAauM1Oeqy764xe/wW7Nz4YePoiGEWzzS/qPR?= =?us-ascii?Q?ki8/sBSaw+ODFsR/yks8ugUx9Chq3jfdxKzXC6x3v1dHFpIT5zTOqyRbuEAM?= =?us-ascii?Q?ean7si5CrYEfDsrFHZviAxRxvcxemgvadFseCmUtAjs2fuIAEGQpeLIgiprB?= =?us-ascii?Q?anaSDj2VPwGQoF3YO7u0070hhztNNXdq4JW/xQTdE0P/q7fgXXNgLupPyAuC?= =?us-ascii?Q?UlQsYRbHbuJUcQjBuKnxJBV1Vhea4JsRpEtx0CuNghQgu1JL7czpRXh6XlxJ?= =?us-ascii?Q?Xqm8/0sm40RYBlxv8yBFD3rl+EgxaeJemGVm2ghPc1m1pmqwq8Z1kIqVZRN7?= =?us-ascii?Q?LqaMGO0PHSo3BGLd/yC5dB5zPLq5tn0fPfNTpHaFsaaXecE2VizLv2Wxs+88?= =?us-ascii?Q?ql1g15VpTbm1JGoQApJGfIU1Xo=3D?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB1492;5:jWhTzDgB4AqFieiSXajemiJPbwehEwtR4LgN0FvYNmiR9lnL5ayygc6mpL4e5ugZcjByyUDUQJHezuS+C7A86N8JsNkrtuW4WG08vLk60iDOuQb/PPWezSpszOvt5rg+VwVHbC1MPrEk6Mi8UzczmA==;24:x41jOw+E2ZmgYj9twzU04NafxUIFYN1tZfvSLDg9R2P9gD9c294N1huyexWK6ijCYHgqfyrwvyG/IL5iUUEri/mai7owapVlwSwQWd0a5x0=;20:reUHZFvxYjo0blptno1fGBlDSQggDKy0bvo5htjpyiY8+cZJL4xGwJnHLxAb+1REkBT3FSBZHCGxp/EhgfOIx2h9k5kEuJsTvSXBgeK4Am1tyY82Mc9HamZUMpZfKNaK1RINC8OZh4eVaFPD6OvvIa2wGJpl6SevMmUrgKj+zHI= X-OriginatorOrg: opensource.altera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2015 15:11:51.6188 (UTC) X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a;Ip=[66.35.236.236];Helo=[sj-itexedge04.altera.priv.altera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB1492 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 28 Oct 2015, Rob Herring wrote: > On Tue, Oct 27, 2015 at 5:09 PM, wrote: > > From: Alan Tull > > > > Add bindings documentation for Altera SOCFPGA bridges: > > * fpga2sdram > > * fpga2hps > > * hps2fpga > > * lwhps2fpga > > > > Signed-off-by: Alan Tull > > Oops... Wow. Ugh. > > > Signed-off-by: Dinh Nguyen > > Signed-off-by: Matthew Gerlach > > These should be roughly in order of who did modifications. I'd expect > you to be last. I wrote the driver, Matthew, Dinh, and I all made mods. > > > --- > > v2: separate into 2 documents for the 2 drivers > > v12: bump version to line up with simple-fpga-bus version > > remove Linux specific notes such as references to sysfs > > move non-DT specific documentation elsewhere > > remove bindings that would have been used to pass configuration > > clean up formatting > > --- > > .../bindings/fpga/altera-fpga2sdram-bridge.txt | 18 ++++++++++ > > .../bindings/fpga/altera-hps2fpga-bridge.txt | 36 ++++++++++++++++++++ > > 2 files changed, 54 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.txt > > create mode 100644 Documentation/devicetree/bindings/fpga/altera-hps2fpga-bridge.txt > > > > diff --git a/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.txt b/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.txt > > new file mode 100644 > > index 0000000..11eb5b7 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.txt > > @@ -0,0 +1,18 @@ > > +Altera FPGA To SDRAM Bridge Driver > > + > > +Required properties: > > +- compatible : Should contain "altr,socfpga-fpga2sdram-bridge" > > + > > +Optional properties: > > +- label : User-readable name for this bridge. > > + Default is br > > Why does the user need label? We generally use label to match physical > labels like "Rear USB port" or "disk LED" or something. > I'll remove it. > > +- init-val : 0 if driver should disable bridge at startup > > + 1 if driver should enable bridge at startup > > Perhaps "bridge-enable" would be a more descriptive name. > I could change it to bridge-enable. Alternatively I could have two booleans that are bridge-enable and bridge-disable as: bridge-enable : boolean property should be defined if driver should enable bridge at startup bridge-disable : boolean property should be defined if driver should disable bridge at startup Default if neither bridge-enable or bridge-disable are specified is driver will leave bridge in its current state. > And to comment on other replies, I have no problem with this type of > property in the DT. But yes, configuration type properties will get > more scrutiny. > > > + Default is to leave bridge in current state. > > + > > +Example: > > + fpga2sdram_br: fpgabridge@3 { > > + compatible = "altr,socfpga-fpga2sdram-bridge"; > > + label = "fpga2sdram"; > > + init-val = <0>; > > + }; > > diff --git a/Documentation/devicetree/bindings/fpga/altera-hps2fpga-bridge.txt b/Documentation/devicetree/bindings/fpga/altera-hps2fpga-bridge.txt > > new file mode 100644 > > index 0000000..eb52f3b > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/fpga/altera-hps2fpga-bridge.txt > > @@ -0,0 +1,36 @@ > > +Altera FPGA/HPS Bridge Driver > > + > > +Required properties: > > +- compatible : Should contain one of: > > + "altr,socfpga-hps2fpga-bridge", > > + "altr,socfpga-lwhps2fpga-bridge", or > > + "altr,socfpga-fpga2hps-bridge" > > +- clocks : Clocks used by this module. > > + > > +Optional properties: > > +- label : User-readable name for this bridge. > > + Default is br > > +- init-val : 0 if driver should disable bridge at startup. > > + 1 if driver should enable bridge at startup. > > + Default is to leave bridge in its current state. > > + > > +Example: > > + hps_fpgabridge0: fpgabridge@0 { > > + compatible = "altr,socfpga-hps2fpga-bridge"; > > + label = "hps2fpga"; > > + clocks = <&l4_main_clk>; > > + init-val = <1>; > > + }; > > + > > + hps_fpgabridge1: fpgabridge@1 { > > + compatible = "altr,socfpga-lwhps2fpga-bridge"; > > + label = "lwhps2fpga"; > > + clocks = <&l4_main_clk>; > > + init-val = <0>; > > + }; > > + > > + hps_fpgabridge2: fpgabridge@2 { > > + compatible = "altr,socfpga-fpga2hps-bridge"; > > + label = "fpga2hps"; > > + clocks = <&l4_main_clk>; > > + }; > > -- > > 1.7.9.5 > > >