From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752560AbbKBGzQ (ORCPT ); Mon, 2 Nov 2015 01:55:16 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:20254 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752478AbbKBGzG (ORCPT ); Mon, 2 Nov 2015 01:55:06 -0500 X-IronPort-AV: E=Sophos;i="5.20,233,1444687200"; d="scan'208";a="185520505" Date: Mon, 2 Nov 2015 07:55:03 +0100 (CET) From: Julia Lawall X-X-Sender: jll@localhost6.localdomain6 To: Takashi Sakamoto cc: kbuild-all@01.org, Takashi Iwai , Clemens Ladisch , Jaroslav Kysela , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: [PATCH] ALSA: firewire-lib: fix compare_const_fl.cocci warnings Message-ID: User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Move constant to the right of binary operators. Generated by: scripts/coccinelle/misc/compare_const_fl.cocci CC: Takashi Sakamoto Signed-off-by: Fengguang Wu Signed-off-by: Julia Lawall --- Depends on personal taste, but the modified version does look a little nicer to me, since one can better see the relationship between the fdf and sfc fields. amdtp-am824.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/sound/firewire/amdtp-am824.c +++ b/sound/firewire/amdtp-am824.c @@ -36,7 +36,7 @@ int amdtp_am824_set_parameters(struct am if (err < 0) return err; - s->fdf = AMDTP_FDF_AM824 | s->sfc; + s->fdf = s->sfc | AMDTP_FDF_AM824; /* * In IEC 61883-6, one data block represents one event. In ALSA, one