From: Julia Lawall <julia.lawall@lip6.fr>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: kbuild-all@01.org, Alessandro Zummo <a.zummo@towertech.it>,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2] rtc: Add a driver for Micro Crystal RV8803
Date: Tue, 3 Nov 2015 08:07:57 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.02.1511030806570.2043@localhost6.localdomain6> (raw)
In-Reply-To: <201511030710.GSjglrml%fengguang.wu@intel.com>
It looks like it is worth a check.
julia
On Tue, 3 Nov 2015, kbuild test robot wrote:
> CC: kbuild-all@01.org
> In-Reply-To: <1446504512-9079-1-git-send-email-alexandre.belloni@free-electrons.com>
> TO: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> CC: Alessandro Zummo <a.zummo@towertech.it>, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, Alexandre Belloni <alexandre.belloni@free-electrons.com>
> CC: rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, Alexandre Belloni <alexandre.belloni@free-electrons.com>
>
> Hi Alexandre,
>
> [auto build test WARNING on abelloni/rtc-next -- if it's inappropriate base, please suggest rules for selecting the more suitable base]
>
> url: https://github.com/0day-ci/linux/commits/Alexandre-Belloni/rtc-Add-a-driver-for-Micro-Crystal-RV8803/20151103-065235
> :::::: branch date: 51 minutes ago
> :::::: commit date: 51 minutes ago
>
> >> drivers/rtc/rtc-rv8803.c:244:2-8: preceding lock on line 240
>
> git remote add linux-review https://github.com/0day-ci/linux
> git remote update linux-review
> git checkout f8c59e6bf4a130cb2f46cad981771dddecc406ff
> vim +244 drivers/rtc/rtc-rv8803.c
>
> f8c59e6b Alexandre Belloni 2015-11-02 234 time64_t alarm_time = rtc_tm_to_time64(&alrm->time);
> f8c59e6b Alexandre Belloni 2015-11-02 235
> f8c59e6b Alexandre Belloni 2015-11-02 236 alarm_time += 60 - alrm->time.tm_sec;
> f8c59e6b Alexandre Belloni 2015-11-02 237 rtc_time64_to_tm(alarm_time, &alrm->time);
> f8c59e6b Alexandre Belloni 2015-11-02 238 }
> f8c59e6b Alexandre Belloni 2015-11-02 239
> f8c59e6b Alexandre Belloni 2015-11-02 @240 spin_lock_irqsave(&rv8803->flags_lock, irqflags);
> f8c59e6b Alexandre Belloni 2015-11-02 241
> f8c59e6b Alexandre Belloni 2015-11-02 242 ret = i2c_smbus_read_i2c_block_data(client, RV8803_FLAG, 2, ctrl);
> f8c59e6b Alexandre Belloni 2015-11-02 243 if (ret != 2)
> f8c59e6b Alexandre Belloni 2015-11-02 @244 return ret < 0 ? ret : -EIO;
> f8c59e6b Alexandre Belloni 2015-11-02 245
> f8c59e6b Alexandre Belloni 2015-11-02 246 alarmvals[0] = bin2bcd(alrm->time.tm_min);
> f8c59e6b Alexandre Belloni 2015-11-02 247 alarmvals[1] = bin2bcd(alrm->time.tm_hour);
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
>
next parent reply other threads:[~2015-11-03 7:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201511030710.GSjglrml%fengguang.wu@intel.com>
2015-11-03 7:07 ` Julia Lawall [this message]
2015-11-03 9:31 ` Alexandre Belloni
2015-11-03 9:34 ` Julia Lawall
2015-11-02 22:48 Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1511030806570.2043@localhost6.localdomain6 \
--to=julia.lawall@lip6.fr \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®