From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754081AbbKETjK (ORCPT ); Thu, 5 Nov 2015 14:39:10 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:62788 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750860AbbKETjI (ORCPT ); Thu, 5 Nov 2015 14:39:08 -0500 X-IronPort-AV: E=Sophos;i="5.20,248,1444687200"; d="scan'208";a="186282376" Date: Thu, 5 Nov 2015 20:38:59 +0100 (CET) From: Julia Lawall X-X-Sender: jll@localhost6.localdomain6 To: David Miller cc: Julia.Lawall@lip6.fr, kernel-janitors@vger.kernel.org, linux-decnet-user@lists.sourceforge.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, lkp@intel.com, roopa@cumulusnetworks.com, rshearma@brocade.com, ebiederm@xmission.com Subject: Re: [PATCH] decnet: remove macro-local declarations In-Reply-To: <20151105.142619.983467860147585345.davem@davemloft.net> Message-ID: References: <1446718696-32505-1-git-send-email-Julia.Lawall@lip6.fr> <20151105.142619.983467860147585345.davem@davemloft.net> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 5 Nov 2015, David Miller wrote: > From: Julia Lawall > Date: Thu, 5 Nov 2015 11:18:16 +0100 > > > Move the variable declarations from the for_nexthops macro to the > > surrounding context, so that it is clear where these variables are > > declared. This also makes it possible to remove the endfor_nexthops macro. > > > > This change adds new arguments to the macro for_nexthops. They are ordered > > such that a pointer to the referenced object comes first, the index in the > > list comes next, and the list itself comes last, roughly in analogy with > > the list_for_each macros. > > > > Signed-off-by: Julia Lawall > > > > --- > > > > This patch takes care of a single file, where the macros are defined > > locally. If the basic transformation looks OK, I will change the other > > files that either likewise define their own macros or use the macros in > > net/mpls/internal.h. The potentially affected files are: > ... > > This looks fine to me. > > Please resubmit this when net-next opens back up, which should be > shortly after -rc1. OK, I'll do the others then too. julia