From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754233AbbKGSVK (ORCPT ); Sat, 7 Nov 2015 13:21:10 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:52152 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753311AbbKGSVI (ORCPT ); Sat, 7 Nov 2015 13:21:08 -0500 X-IronPort-AV: E=Sophos;i="5.20,258,1444687200"; d="scan'208";a="186546336" Date: Sat, 7 Nov 2015 19:21:04 +0100 (CET) From: Julia Lawall X-X-Sender: jll@localhost6.localdomain6 To: David Miller cc: kernel-janitors@vger.kernel.org, linux-decnet-user@lists.sourceforge.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, lkp@intel.com, roopa@cumulusnetworks.com, rshearma@brocade.com, ebiederm@xmission.com Subject: Re: [PATCH] decnet: remove macro-local declarations In-Reply-To: <20151107.131834.2152455608881468661.davem@davemloft.net> Message-ID: References: <20151105.151320.1646543343654766675.davem@davemloft.net> <20151107.131834.2152455608881468661.davem@davemloft.net> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 7 Nov 2015, David Miller wrote: > From: Julia Lawall > Date: Fri, 6 Nov 2015 11:57:34 +0100 (CET) > > >> > Would it be preferable to remove the macro entirely and inline the for > >> > loop header? > >> > >> Could you show me an example of how this would look exactly? > > > > One possible solution is below. I moved the initialization of the nh > > pointer inside the loop to reduce the size of the loop header. One could > > also inline fi->fib_nh[nhsel] where it occurs, but it seemed that that > > would make quite long expressions. > > Personally I like the explicit named iterator. It is descriptive and > tells that we are walking over all of the nexthops for a route. OK, I'll follow that solution. julia