From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751971AbbKJUvW (ORCPT ); Tue, 10 Nov 2015 15:51:22 -0500 Received: from mail-bn1bon0076.outbound.protection.outlook.com ([157.56.111.76]:50898 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750749AbbKJUvU (ORCPT ); Tue, 10 Nov 2015 15:51:20 -0500 Authentication-Results: spf=fail (sender IP is 66.35.236.227) smtp.mailfrom=opensource.altera.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=opensource.altera.com; Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=atull@opensource.altera.com; Date: Tue, 10 Nov 2015 14:44:08 -0600 From: atull X-X-Sender: atull@linuxheads99 To: Moritz Fischer CC: Geert Uytterhoeven , Subject: Re: [PATCH] fpga: FPGA_MGR_ZYNQ_FPGA should depend on HAS_DMA In-Reply-To: Message-ID: References: <1447061851-19932-1-git-send-email-geert@linux-m68k.org> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [64.129.157.38] X-ClientProxiedBy: DM2PR10CA0003.namprd10.prod.outlook.com (25.160.213.13) To BN3PR03MB1509.namprd03.prod.outlook.com (25.163.35.148) X-Microsoft-Exchange-Diagnostics-untrusted: 1;BN3PR03MB1509;2:gny10tOwbRM+TZxEfh7dDvCBpeVYzihueobVIHsQA3ng8Bz9N7u0voXYBSkQMjVUeBXcrdgEAlPLrsR++N2byEJ0JvaBf8yVitAEwpX0VuAKjhGUWXa+Vd7am+ROtiagit6dR3iULDDa5LADocv2Jdbwx4y25vqimk6PfzRDOt8=;3:CbmjjPWbgpHD8lnlIn3srAUcjlsVixIDKzXUvP80jagRKbrPFUWR4Mied9Nb9MPFz1b9KXypVgpVac00gxgktnIS9rFjpRTZ7+q0kSnbUduRvQEKF8RWFbCHXNFIAqVIDRAYrXRGgM/aZJn6htVJbQ==;25:yQtKJWcVZkKzXSag2+hXvrWuSdQWn+kd7hmsTbcuSbsLn/jGWHP4VwWGbe1oYuGKu+SMCoYkiXqEssdPF02h8RvyGGY1YLEKPuBULsDGy4Kfyz0Vfm61DIVCSIelL/tzdOr2FlduIbZVeuKIeHWsUoRif5Bo4ET3CD8O7Nrs86DrV0nhMk5TeUKoIZqWJVYuGMKjf6rBQQ0l/euMEHsKPc4YUA2UNSKBYM5891bvG82AQHjyyLlU/w7/EMHgbcFbprYy6TDK11M73pRIxBNBug==;20:i7jVFDb3TVDbLd9k6o+1pSCa7XW3A01CXqfytCJTdBgF5mzCnZjlItiYWcMYY1l25y3zaoeGZV+tuaAS7keoFE2ij0wvkjb5YZVTc0WE8JbZwafQ30SgLbJzMMro41yL5MfDtGFdbp0aaZbjANcSSqMPK63Qh2es/pSGgnyRqRc= X-Microsoft-Antispam-Untrusted: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1509; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(80048183373757)(204874498639787);UriScan:(80048183373757)(204874498639787); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(520078)(3002001)(10201501046);SRVR:BN3PR03MB1509;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1509;BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(5005006)(8121501046)(3002001)(10201501046);SRVR:BN1PR03MB202;BCL:0;PCL:0;RULEID:;SRVR:BN1PR03MB202; X-Microsoft-Exchange-Diagnostics-untrusted: 1;BN3PR03MB1509;4:XurykO1h30hU1FdpM0fLGRKCD24xTAdWStOtjSOG8OsqMgOUxAkX5FVI6234tcb69aKoQjPMa8BjfjeeylsETq3isCBTJoMEfqgX7SXzfdzU/K0LUQd3mdY3fsb3SuCOdUrCbXnZeT/mp04rBHEu6RtF5yBbUIEQcCxHYI44hWIviEffJUTA0LZpG5E6wpWVc3wfRAGiYWs/fZVGVWpnbOdhRBJuignVTI22/AAvpoMQGF8d8xKLz+GwYp5SwpdyS6hav9n9fTe7KiMz2mj9JQZsYfAZqnl65RSpscStqBsj4gH5/feJd83Jt+YsMu5W3xohAg7qJFAz6AcjLkUJoJaIZgwszr0N99W7cWxVnxCa0vMWiZqOxUBh0BE04YdI X-Forefront-PRVS: 07562C22DA X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(6009001)(24454002)(189002)(199003)(31014005)(377454003)(92566002)(19580405001)(23726002)(189998001)(110136002)(5004730100002)(50466002)(4001350100001)(40100003)(54356999)(5001960100002)(19580395003)(2950100001)(77096005)(5008740100001)(81156007)(5007970100001)(122386002)(42186005)(101416001)(47776003)(66066001)(76176999)(83506001)(106356001)(87976001)(97736004)(105586002)(53416004)(33716001)(46406003)(50986999)(575784001)(86152002)(69596002)(86362001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN3PR03MB1509;H:linuxheads99.altera.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:0;LANG:en; X-Microsoft-Exchange-Diagnostics-untrusted: =?us-ascii?Q?1;BN3PR03MB1509;23:frAQWR7mT10I4CtWOOeybvjgZceSo8GDWy0uuaUGH?= =?us-ascii?Q?M12vXZkARJL0SvzCrMjTGIy/G9RAY10HDggaRt9+RiEb4t4b1iz24ah/k2Uu?= =?us-ascii?Q?zyV77KBkaSAxan/Sv9CqIrmwp1SwMnFtHTZaGw8K+A/zFd/dPMWRgNMfZNSW?= =?us-ascii?Q?aNYul/3JDCKZH2OFeQKUqFMNT0Qfyc9Af/TinFsd1S0mDZ2ujbZFYFTcoKIG?= =?us-ascii?Q?2M13hJXrXu6C4jRBH3Pd1SU8px+x8rOwgXlI5kNuGWbKVM0aT6HYzrfMkJSP?= =?us-ascii?Q?TMMjEh8F648JIBgels7NOtxcpZBO7yis2SB/ZsB378sxr/Joxs1QBRdrS5Rv?= =?us-ascii?Q?Efj4v0bqkZ+vta2R0aZIMNNJriN5WF8zJddjRSLmk9bKpbGRsRWfPk9aaMv6?= =?us-ascii?Q?qraeuqiIZ/qLAqyuEyiQU08K/wE1l88WEDiDRAKr2TcfhsJVNtBKKl+OqTUv?= =?us-ascii?Q?35PxXY1UKGscLMekvMCm0jXBTz1XKSu1lw7CrSJgtdVu94nczpqy0qjd5mWD?= =?us-ascii?Q?j2o23thRLd2pCm/bOGFfGGnFHsHWdj5xXFUUGNI/WDosd6dg/MzHaIeuITVm?= =?us-ascii?Q?O6siVVqYPfDJTz0Ni4L3a0ozwOgb7FdWDP5U8GuxoaubpuXtaYrzea5KRoc4?= =?us-ascii?Q?hS0xppkE7v1F8Tl6bb7e+wF2uA/0vMTHnctM3bNYQKAazmqziLPRVZe2REZb?= =?us-ascii?Q?eGAJEeU8kWI9R4dTuX7+u6tIn22YL0pkuW3NMs0iebUHqTZi0RzjkRREdaLp?= =?us-ascii?Q?K+PdYBpDkY/z3ZwvZv7T0joVhHJ9AwZvq33XtmmkS47XsyvDjHkG/DNNK9XN?= =?us-ascii?Q?KSnoOwH5JA3IBQ8EP4LilbLv16KlslntMPiiv2w6ZwkG2XL6MRy71oKidb2o?= =?us-ascii?Q?A/qpD64iqk7sKfDW9j7YD1IoakcxwRrbtjCbvmGFjCO6RMMIIEaiIjeopI8e?= =?us-ascii?Q?yQUFbtgOY4TCSk7WCkM2mjVGvUiw+vbF2CA/1wik+bWLmxIR+yR/SFG5+vlO?= =?us-ascii?Q?3lM42yrpNpPKJuxA2FCdwu/B2UttcerhgtSdqzPRbVJeOMVVq+HxMvjW5XRO?= =?us-ascii?Q?NvyhVnEMzyuzdzQtfAcOXPq3zSlt3opZhEyNZCCZRZdvtV7+uitjhXe2GQVi?= =?us-ascii?Q?m4eBovqXpcXsn0wyVzICtDP7Le+VkKn?= X-Microsoft-Exchange-Diagnostics-untrusted: 1;BN3PR03MB1509;5:hBOXyrx/ZciNyikzA+wvjfEDa8YKC4voAmKqYWOnVepGuAFs9FpLDwEMN/Y7T76vzgpJrKpu3B1WlaMOWXtGH+YbLUOG/g8OzaICwd75puenLjBL26JC0j2KeeKaqhxnbHuon4O0fVgHh0IC3GcP7w==;24:cVPpsnD+pW78gGeWA403ZFrUNHvnSJNKuuyYhfFvEwFF1cy+ZqoCLN4qMHePpiQY3/ZhKc0Jf774xKqVinYHIwWGynWY2MSzQ1nstAoRPiE=;20:wvf+pLsUTFcEJ6+czFOCT6mSRH2K/xC2qkF+zR4OWMKu0rKeH2hzr8IcC8G+8UU13NaXjRYRsANsnwoKzWxqDRlrJuhO+DlndW7Ehep1Wy5NU3+q82lvZ7HQSLhqi7f9VESi1MK51LBnBXsev8SqPpcpJ+sUJGMjCHvlGZhjaB4= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB1509 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: BN1BFFO11FD025.protection.gbl X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11FD025;1:9SIMGm2z+F22HLKWg7vnvZQKuM6L77JACKzMRPbSauaaTT4U7mmpVCrHOfCpG2Co2+x8VNydBRJNedFn24o4t8biapbmIQsSHo//6GlfvpEPQaDD4g7mECLtuTJn7sQvqpOcYslSZPnCkIv92e9Yi910CkP8IQ2Pw57UL2Ydnk8jpF/5hSYPWzBDotAZ9HpCmdbhXCcUYzefkcwNTztiBizT1G3C2pq21uo9lCg7f52kvmeKVca5Ov6WxKQqx4umHeuM2az93iA0ASgmz6hLLCTS9SPa1rnJ4+03OAuiwp0zaDyms31qbFsfDTRMf46FtKjwtBiGYKPpURLWxE1jiCh49Ta8VOWhKC3YUrYAjSl0F4H2TMuv5h1nVID8ujZA X-Forefront-Antispam-Report: CIP:66.35.236.227;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(1109001)(1110001)(339900001)(199003)(377454003)(31014005)(189002)(24454002)(122386002)(85426001)(575784001)(23726002)(86152002)(110136002)(66066001)(5007970100001)(86362001)(50466002)(77096005)(50986999)(54356999)(87936001)(76176999)(11100500001)(21840400001)(5001960100002)(40100003)(47776003)(189998001)(5004730100002)(83506001)(5008740100001)(97736004)(53416004)(33716001)(81156007)(4001350100001)(19580405001)(6806005)(106466001)(92566002)(105606002)(2950100001)(19580395003)(46406003)(16796002)(6070500001)(7099028);DIR:OUT;SFP:1101;SCL:1;SRVR:BN1PR03MB202;H:sj-itexedge03.altera.priv.altera.com;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;A:0;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN1PR03MB202;2:sRmFbgXt9mJHNho+VsD6N9xntatDXx0cgPnd74MfB25nAfs8818DGph+wECyc+87kKLSdLOS99N5MuKa1aSFjRX8Tk2T+Abc787sExGcZ5mfesdRQoZH6SmX2qPY1Mq7GiEmEHP9DmZt4tCyid4n6ffCz1C30E8EqOcjdSF1qlg=;3:3NPwvTsbQK0dwymw9Z44tt0igng9d2TMwLzWmJNTD/n/0oqinOYLYJto9InCoRVOctMS/YFs+9gdGw+ia4K3nHAi6XvWDisSDP+koQyxUvmFXaekTMEXuTyTeU+sb+cSbcABszbhXkCZa1j1M/tp/Bz2U7FFuiaZG5bCieVIW7/aCSUvNvQCO7umRGeJnmSoQ1i0ro5N7OYJchg9Le1B5jTMK56syDCIwB3pal8Oif0=;25:Ruepel8/uj/I7KzJiLW4fmr/fDzQDHAfXl/w9ZLjsEm72qBk/Z+ngvO/hkPC4nK/fcUQMeFFpFGP8pkg6PHiEYpyRM8J96nh5vd2iz2gNjdUwp7jmsl+742HUX7+8Yu6QHBNnNzkFTVYz2TfZr9Fsfs13Pcf5nYmWdzhjM2lyGAFxl+XXjmXLfcFZmW/qpEQxfp2ra8m6mibjqDRizvjIdKlbt3PtEEDxfrBNlszRSjiqyjpTAe3s+0FTPwGV6VRw1gphq/0i/JObzmfhNvf0g==;20:YHhvgNqgAlvv4oxEBnrv2hTh2XC0XK19T/9JGiX8qU7OBidvqjSbTCBKxst8AATUBBzy0Ua9ylqvwd6BfDQIWSq9edxROlJccBG0oclKjjsEdcgeckQp0M/Ux7ytR65R8dSf16hXtsCmFr3o6aP9v91ngn7DLwLAKJHuarSI92I= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN1PR03MB202; X-Microsoft-Exchange-Diagnostics: 1;BN1PR03MB202;4:lqykivHFftoRMLHcUc+nIWtBDmmvMFh2aDvkbiCpS1FHWLbIsdArEJqtEBXK8qhcxmu65YHAhlIk9Qx1sWENPTsBCy+haF1BvlUhXkUVp2EmZ6WPAiq60meWb7Jgftljwdcf4sVtt0Gqh6ylS8gFiEYpUaVY1zah090EaPc/1ohVYc8xLVmm1lB8aWbTHNfEcj90xQi7Rf9oME/3KfMObIsnFRbWuf2/xOT1okjnNWAzi/cbrPk7il9Z9NnxBR2tRnHxr1Wx7u7nL6mgwl1EFlKbWVwyOjIDCWVWukK9O2BO0ywczTEQ+cAkgbVXMLn4M4h0nabJEIIr6RR4rCeDgnJUMwPQ0ju17deCZMZgspf/h1omKBQ3i9biMCGa6BYD X-Forefront-PRVS: 07562C22DA X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BN1PR03MB202;23:9rr9cZFCdL1iDxzXANxCnIw8GP8FFb55Acps/tM1uR?= =?us-ascii?Q?gVOicWiHYx45fCwbzMaeK/rm5VMJ8BYVfgm6xvzlPa3MnE7zaScUwEihiv8H?= =?us-ascii?Q?GFI1AxnjLJoXbNIa3Cn4L8rUQOYsQH9+y6ZO/nFkGCOsyP3pIKHSifIdEqHb?= =?us-ascii?Q?EXcdfnrsbsliE4NYFqVEUNcdZQlSVsIKmjbvlFdN93Iqokkba+CKTrNBu4h0?= =?us-ascii?Q?17McAzs3TZW5KVg7mkBSUr7+sXZK4OI4MPKpGpyyasnhzHmyV5b8EL9kBO38?= =?us-ascii?Q?bmOWIb2bA5xMnWyVs8SKyyL/CxJhU+ZU2IML32LghWvIqYs12HQDxKVjjVLh?= =?us-ascii?Q?mjyEXnmagTvD7g4kC7DN5B+Ctu/2nLG2c1s2JPa2XMwS+KuIiGbzdvm/kiTV?= =?us-ascii?Q?qG0fPyqr8FdCqwJMCN3WLA88C6uSEgrANdkecNninUVsmxvjgbXVSoHKCZVs?= =?us-ascii?Q?TMkOhdwS8O5q4QlVoq1deaP+c502LxC4m/yA3mexIv/a7EEnDQ3p20KZmsH2?= =?us-ascii?Q?NGpNy0Bfwqz5ezVeh1xh5YGNMIpTkI7MqCCgi8GcXaRCmnDJekKOSMvImIzK?= =?us-ascii?Q?pDCD3Coy+gcbAC4Y7kdSqI7kOorOH4kpcgH33sXtGOQLi///IjmA0+K8lyqT?= =?us-ascii?Q?bc6dqbSzbSOmYHJD3j1CuxkVupfhXaJKj5tWVerSm7yHDYKmTo8sDevO8l+m?= =?us-ascii?Q?8Yssw4flww7KbyQIt75Th3abuL34mVduXiu8YDgKDjudAXZEpi6II2dN5GqJ?= =?us-ascii?Q?5w+7hymmZO+ekBnc9AOTUwdKchL0ZT7rW8sb0/OPugcNPmhiCaZepHGfWmZF?= =?us-ascii?Q?vIvX/puY4SZYzOf22LJ5bi4Ne6szS4BoLFWPWXCr8BdGtg8Gpu4aEmDol196?= =?us-ascii?Q?3TfW5RNwLRmgoTtdwT/roLLW+Y/ndpddT7cA0CenWeGJVxg0IynRgrhqR93h?= =?us-ascii?Q?xrAzxPZFT8bgfp0g6LDA7BOYdQRVfDq+G0ZDHZP0EQblxy+62T1zY/b0F0NQ?= =?us-ascii?Q?lGCtdE9rWcmg/IvME2rH5ILW36pcPRejHr3Q8wPJlNlClrx+7FbUp49Hlq2a?= =?us-ascii?Q?Lr3aR5LG8XgEhzWJTI8IEMPEpdDqaEFDRVGt2lL6cPfljHgPYdCFw9Zz48kb?= =?us-ascii?Q?aDb6SPl9VwQ0n8kKptIsGe1kP+aftYjzHcxQk67EYNtEyuVVQ7QKTKqiJ1zM?= =?us-ascii?Q?ylV6y7bWedN05HFROQHGjn7D5x4i7Vxzgksk13A66H4Gy/wtQjo2DcfdJB2r?= =?us-ascii?Q?K1P+v+D8J9QS3XWtiLh2DfLUpzVbgJpd7equ2DShx/r5j19eSN76Imw6EFe4?= =?us-ascii?Q?T8OetRYqc/kdUqs6aj5WE=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN1PR03MB202;5:GWPZdBHWtROok/n5ksYohLYvIRTSzeglOy1w1NoaD8JDSez7GWuh7I5+kfS5UwhskXGksARv51f+zdLz1G1Hw9zoPd4W3jokzk4cvDmAMIBeq761IcpPkr5vzVZC/JGg8zflqOqlcq3+i3En/91Dqw==;24:mj2/g1cmtFHfHAHGOXTGARbbibHNQrGoMDusOLGyIGxHqoit4kJLOn4PwKR053IGsrx2TZ9xXsSH7pFldSDG4amjXyPp1J5wrEEJ4vdRSjI=;20:XCDRKUhlA6FBlI8tElCP8zS0lGmckzUmoVe34y15BJLU3vJOQnzFZXFzJa93V+YBuY//yUeMeBCIIaY3zZayxjY2rbTX0OKqzbuUhhfuL4BfLJGafG5a39dX6D4cn4Ge8UwTNnTu+EM7OOiJQtU+OF54IldO3SxNCA86B2FXYhw= X-OriginatorOrg: opensource.altera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2015 20:51:17.2118 (UTC) X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a;Ip=[66.35.236.227];Helo=[sj-itexedge03.altera.priv.altera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1PR03MB202 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 10 Nov 2015, Moritz Fischer wrote: > Hi Alan, Geert > > On Tue, Nov 10, 2015 at 8:28 AM, atull wrote: > > On Mon, 9 Nov 2015, Geert Uytterhoeven wrote: > > > > +Moritz > > > >> If NO_DMA=y: > >> > >> ERROR: "dma_free_coherent" [drivers/fpga/zynq-fpga.ko] undefined! > >> ERROR: "dma_alloc_coherent" [drivers/fpga/zynq-fpga.ko] undefined! > >> > >> Add a dependency on HAS_DMA to fix this. > >> > >> Signed-off-by: Geert Uytterhoeven > >> --- > >> drivers/fpga/Kconfig | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig > >> index c9b9fdf6cfbbeb6d..d61410299ec0cf80 100644 > >> --- a/drivers/fpga/Kconfig > >> +++ b/drivers/fpga/Kconfig > >> @@ -21,6 +21,7 @@ config FPGA_MGR_SOCFPGA > >> > >> config FPGA_MGR_ZYNQ_FPGA > >> tristate "Xilinx Zynq FPGA" > >> + depends on HAS_DMA > >> help > >> FPGA manager driver support for Xilinx Zynq FPGAs. > >> > >> -- > >> 1.9.1 > >> > >> > > Good catch! > > Reviewed-by: Moritz Fischer > > Alan, > > if you don't mind I'll send you (or gregkh?) a patch with adding me as > (co) maintainer, or Reviewer to the MAINTAINERS file so you don't have > to forward manually next time > any more ;-) I doubt Geert's patch caught the last issue in zynq-fpga ;-) > > Cheers, > > Moritz > Hi Moritz, It would be great if you could be added as a Reviewer. Please submit the patch to Greg. Alan