mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: <konrad.wilk@oracle.com>, <david.vrabel@citrix.com>,
	<linux@arm.linux.org.uk>, <stefano.stabellini@citrix.com>,
	<jgross@suse.com>, <tglx@linutronix.de>, <vkuznets@redhat.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <xen-devel@lists.xen.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	"Will Deacon" <will.deacon@arm.com>
Subject: Re: [PATCH v2] xen/events: Always allocate legacy interrupts on PV guests
Date: Fri, 20 Nov 2015 11:24:02 +0000	[thread overview]
Message-ID: <alpine.DEB.2.02.1511201117120.1107@kaball.uk.xensource.com> (raw)
In-Reply-To: <1447870445-17199-1-git-send-email-boris.ostrovsky@oracle.com>

On Wed, 18 Nov 2015, Boris Ostrovsky wrote:
> After commit 8c058b0b9c34 ("x86/irq: Probe for PIC presence before
> allocating descs for legacy IRQs") early_irq_init() will no longer
> preallocate descriptors for legacy interrupts if PIC does not
> exist, which is the case for Xen PV guests.
> 
> Therefore we may need to allocate those descriptors ourselves.
> 
> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Suggested-by: Thomas Gleixner <tglx@linutronix.de>

You need to do this for arm64 too.

FYI you can download arm64 cross-compilers from
https://releases.linaro.org/14.04/components/toolchain/binaries/
then you can use them by exporting ARCH=arm64 and
CROSS_COMPILE=/path/to/gcc-linaro-aarch64-linux-gnu-version/bin/aarch64-linux-gnu-


> v2: Use nr_legacy_irqs() instead of NR_IRQS_LEGACY (needs definition for ARM)
> 
>  arch/arm/include/asm/irq.h       | 4 ++++
>  drivers/xen/events/events_base.c | 5 +++--
>  2 files changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/include/asm/irq.h b/arch/arm/include/asm/irq.h
> index be1d07d..b864f60 100644
> --- a/arch/arm/include/asm/irq.h
> +++ b/arch/arm/include/asm/irq.h
> @@ -2,6 +2,10 @@
>  #define __ASM_ARM_IRQ_H
>  
>  #define NR_IRQS_LEGACY	16
> +static inline int nr_legacy_irqs(void)
> +{
> +	return NR_IRQS_LEGACY;
> +}
>  
>  #ifndef CONFIG_SPARSE_IRQ
>  #include <mach/irqs.h>
> diff --git a/drivers/xen/events/events_base.c b/drivers/xen/events/events_base.c
> index 849500e..524c221 100644
> --- a/drivers/xen/events/events_base.c
> +++ b/drivers/xen/events/events_base.c
> @@ -39,6 +39,7 @@
>  #include <asm/irq.h>
>  #include <asm/idle.h>
>  #include <asm/io_apic.h>
> +#include <asm/i8259.h>
>  #include <asm/xen/pci.h>
>  #endif
>  #include <asm/sync_bitops.h>
> @@ -420,7 +421,7 @@ static int __must_check xen_allocate_irq_gsi(unsigned gsi)
>  		return xen_allocate_irq_dynamic();
>  
>  	/* Legacy IRQ descriptors are already allocated by the arch. */
> -	if (gsi < NR_IRQS_LEGACY)
> +	if (gsi < nr_legacy_irqs())
>  		irq = gsi;
>  	else
>  		irq = irq_alloc_desc_at(gsi, -1);
> @@ -446,7 +447,7 @@ static void xen_free_irq(unsigned irq)
>  	kfree(info);
>  
>  	/* Legacy IRQ descriptors are managed by the arch. */
> -	if (irq < NR_IRQS_LEGACY)
> +	if (irq < nr_legacy_irqs())
>  		return;
>  
>  	irq_free_desc(irq);
> -- 
> 2.1.0
> 

  parent reply	other threads:[~2015-11-20 11:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-18 18:14 Boris Ostrovsky
2015-11-19  9:10 ` Juergen Gross
2015-11-20 11:24 ` Stefano Stabellini [this message]
2015-11-20 15:17   ` Boris Ostrovsky
2015-11-20 15:36     ` Stefano Stabellini
2015-11-20 15:42       ` Boris Ostrovsky
2015-11-20 16:33         ` Stefano Stabellini
2015-11-20 16:49           ` Boris Ostrovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.02.1511201117120.1107@kaball.uk.xensource.com \
    --to=stefano.stabellini@eu.citrix.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=catalin.marinas@arm.com \
    --cc=david.vrabel@citrix.com \
    --cc=jgross@suse.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=stefano.stabellini@citrix.com \
    --cc=tglx@linutronix.de \
    --cc=vkuznets@redhat.com \
    --cc=will.deacon@arm.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®