From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933052AbbLTLJ5 (ORCPT ); Sun, 20 Dec 2015 06:09:57 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:4004 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932405AbbLTLJ4 (ORCPT ); Sun, 20 Dec 2015 06:09:56 -0500 X-IronPort-AV: E=Sophos;i="5.20,454,1444687200"; d="scan'208";a="193179564" Date: Sun, 20 Dec 2015 12:09:52 +0100 (CET) From: Julia Lawall X-X-Sender: jll@localhost6.localdomain6 To: SF Markus Elfring cc: LKML , Richard Cochran , kernel-janitors@vger.kernel.org Subject: Re: [PATCH] posix-clock: Use an unsigned data type for a variable In-Reply-To: <56766488.9050402@users.sourceforge.net> Message-ID: References: <56766488.9050402@users.sourceforge.net> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 20 Dec 2015, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 20 Dec 2015 09:09:34 +0100 > > The data type "int" was used by the variable "result" in the > function "posix_clock_poll" even though the type "uint" will usually > be needed for the return value from a call of the function which was > assigned to the pointer "poll" of the variable "clk". > Reuse the type from this poll call instead. Why use uint when the function return type it unsigned int? On the other hand, why is the function return type unsigned int when there is a return of a negative constant? julia > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > kernel/time/posix-clock.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/time/posix-clock.c b/kernel/time/posix-clock.c > index ce033c7..ac0b733 100644 > --- a/kernel/time/posix-clock.c > +++ b/kernel/time/posix-clock.c > @@ -69,7 +69,7 @@ static ssize_t posix_clock_read(struct file *fp, char __user *buf, > static unsigned int posix_clock_poll(struct file *fp, poll_table *wait) > { > struct posix_clock *clk = get_posix_clock(fp); > - int result = 0; > + uint result = 0; > > if (!clk) > return -ENODEV; > -- > 2.6.3 > > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >