From: Julia Lawall <julia.lawall@lip6.fr>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: kbuild-all@01.org, Dmitry Vyukov <dvyukov@google.com>,
"David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
syzkaller <syzkaller@googlegroups.com>,
Kostya Serebryany <kcc@google.com>,
Alexander Potapenko <glider@google.com>,
Eric Dumazet <edumazet@google.com>,
Sasha Levin <sasha.levin@oracle.com>,
Kees Cook <keescook@google.com>
Subject: Re: crypto: algif_skcipher - Require setkey before accept(2)
Date: Fri, 25 Dec 2015 07:54:48 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.02.1512250753010.2084@localhost6.localdomain6> (raw)
In-Reply-To: <201512241831.VN3LufSe%fengguang.wu@intel.com>
Lines 766, 767 don't look correct at all.
julia
On Thu, 24 Dec 2015, kbuild test robot wrote:
> In-Reply-To: <20151224093902.GA8235@gondor.apana.org.au>
>
> [if your patch is applied to the wrong git tree, please drop us a note to help improving the system]
> Hi Herbert,
>
> [auto build test WARNING on crypto/master]
> [also build test WARNING on next-20151223]
> [cannot apply to v4.4-rc6]
>
> url: https://github.com/0day-ci/linux/commits/Herbert-Xu/crypto-algif_skcipher-Require-setkey-before-accept-2/20151224-174142
> base: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git master
> :::::: branch date: 63 minutes ago
> :::::: commit date: 63 minutes ago
>
> >> crypto/algif_skcipher.c:767:18-21: ERROR: reference preceded by free on line 766
>
> git remote add linux-review https://github.com/0day-ci/linux
> git remote update linux-review
> git checkout 7f3e28b295bcfeb7fba928af15780f1bb3051430
> vim +767 crypto/algif_skcipher.c
>
> 7f3e28b2 Herbert Xu 2015-12-24 760 tfm = kzalloc(sizeof(*tfm), GFP_KERNEL);
> 7f3e28b2 Herbert Xu 2015-12-24 761 if (!tfm)
> 7f3e28b2 Herbert Xu 2015-12-24 762 return ERR_PTR(-ENOMEM);
> 7f3e28b2 Herbert Xu 2015-12-24 763
> 7f3e28b2 Herbert Xu 2015-12-24 764 tfm->skcipher = crypto_alloc_skcipher(name, type, mask);
> 7f3e28b2 Herbert Xu 2015-12-24 765 if (IS_ERR(tfm->skcipher)) {
> 7f3e28b2 Herbert Xu 2015-12-24 @766 kfree(tfm);
> 7f3e28b2 Herbert Xu 2015-12-24 @767 return ERR_CAST(tfm->skcipher);
> 7f3e28b2 Herbert Xu 2015-12-24 768 }
> 7f3e28b2 Herbert Xu 2015-12-24 769
> 7f3e28b2 Herbert Xu 2015-12-24 770 return tfm;
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
>
next parent reply other threads:[~2015-12-25 6:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201512241831.VN3LufSe%fengguang.wu@intel.com>
2015-12-25 6:54 ` Julia Lawall [this message]
2015-12-25 7:41 ` Herbert Xu
2015-12-25 8:38 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1512250753010.2084@localhost6.localdomain6 \
--to=julia.lawall@lip6.fr \
--cc=davem@davemloft.net \
--cc=dvyukov@google.com \
--cc=edumazet@google.com \
--cc=glider@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=kbuild-all@01.org \
--cc=kcc@google.com \
--cc=keescook@google.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sasha.levin@oracle.com \
--cc=syzkaller@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®