From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752796AbbLZUIj (ORCPT ); Sat, 26 Dec 2015 15:08:39 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:33632 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751237AbbLZUI3 (ORCPT ); Sat, 26 Dec 2015 15:08:29 -0500 X-IronPort-AV: E=Sophos;i="5.20,483,1444687200"; d="scan'208";a="194454676" Date: Sat, 26 Dec 2015 21:08:27 +0100 (CET) From: Julia Lawall X-X-Sender: jll@localhost6.localdomain6 To: Sergei Shtylyov cc: Julia Lawall , Gilles Muller , Nicolas Palix , Michal Marek , cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] coccinelle: api: check for propagation of error from platform_get_irq In-Reply-To: <567EF188.7020203@cogentembedded.com> Message-ID: References: <1451157891-24881-1-git-send-email-Julia.Lawall@lip6.fr> <567EF188.7020203@cogentembedded.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 26 Dec 2015, Sergei Shtylyov wrote: > On 12/26/2015 10:24 PM, Julia Lawall wrote: > > > The error return value of platform_get_irq seems to often get dropped. > > Maybe it was intentional (see my recent follow-up to your netdev patch). > But if an error gets unconditionally overriden, deferred probing can't work. > So your patches seem good things in the end. Thank you! Actually, this semantic patch overloos the case where a constant is returned directly, which is apparently also popular. I can update this if the whole concept is useful, but that's not clear at the moment... julia