From: Julia Lawall <julia.lawall@lip6.fr>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: Julia Lawall <julia.lawall@lip6.fr>,
Coccinelle <cocci@systeme.lip6.fr>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org, linux-media@vger.kernel.org,
netdev@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-spi@vger.kernel.org, dri-devel@lists.freedesktop.org,
Gilles Muller <Gilles.Muller@lip6.fr>,
Michal Marek <mmarek@suse.com>,
Nicolas Palix <nicolas.palix@imag.fr>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Subject: Re: [Cocci] [PATCH v2] coccinelle: api: check for propagation of error from platform_get_irq
Date: Sun, 27 Dec 2015 12:41:30 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.02.1512271239460.2038@localhost6.localdomain6> (raw)
In-Reply-To: <567F9A29.50202@users.sourceforge.net>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 833 bytes --]
On Sun, 27 Dec 2015, SF Markus Elfring wrote:
> > The error return value of platform_get_irq seems to often get dropped.
>
> How do you think about any more fine-tuning here?
>
> Commit message:
> * … of the platform_get_irq() function seems to get dropped too often.
>
> * Why do you concentrate on a single function name?
> Do you plan to extend this source code analysis approach?
>
>
> > +@script:python r_report depends on report@
> > +j0 << r.j0;
> > +j1 << r.j1;
> > +@@
> > +
> > +msg = "Propagate return value of platform_get_irq around line %s." % (j1[0].line)
>
> Are there more unchecked return values which are interesting
> for further considerations?
> https://cwe.mitre.org/data/definitions/252.html
The value is not unchecked. I made a specific rule because the specific
problem is quite common.
julia
next prev parent reply other threads:[~2015-12-27 11:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-26 19:24 [PATCH] " Julia Lawall
2015-12-26 19:59 ` Sergei Shtylyov
2015-12-26 20:08 ` Julia Lawall
2015-12-26 20:24 ` Julia Lawall
2015-12-26 20:29 ` Sergei Shtylyov
2015-12-26 20:38 ` Julia Lawall
2015-12-26 20:58 ` [PATCH v2] " Julia Lawall
2015-12-26 22:26 ` Sergei Shtylyov
2015-12-26 22:32 ` Julia Lawall
2015-12-26 22:36 ` Sergei Shtylyov
2015-12-27 6:13 ` Julia Lawall
2015-12-27 11:18 ` Sergei Shtylyov
2015-12-27 7:58 ` [Cocci] " SF Markus Elfring
2015-12-27 11:41 ` Julia Lawall [this message]
2015-12-27 16:24 ` SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1512271239460.2038@localhost6.localdomain6 \
--to=julia.lawall@lip6.fr \
--cc=Gilles.Muller@lip6.fr \
--cc=cocci@systeme.lip6.fr \
--cc=dri-devel@lists.freedesktop.org \
--cc=elfring@users.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mmarek@suse.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.palix@imag.fr \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®