From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754569AbbL0VLI (ORCPT ); Sun, 27 Dec 2015 16:11:08 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:8464 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752514AbbL0VLA (ORCPT ); Sun, 27 Dec 2015 16:11:00 -0500 X-IronPort-AV: E=Sophos;i="5.20,487,1444687200"; d="scan'208";a="194664358" Date: Sun, 27 Dec 2015 22:10:58 +0100 (CET) From: Julia Lawall X-X-Sender: jll@localhost6.localdomain6 To: Weng Xuetian cc: Chen Yu , Darren Hart , linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, Weng Xuetian , kbuild-all@01.org Subject: [PATCH] surface pro 4: fix compare_const_fl.cocci warnings Message-ID: User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Move constants to the right of binary operators. Generated by: scripts/coccinelle/misc/compare_const_fl.cocci CC: Weng Xuetian Signed-off-by: Fengguang Wu Signed-off-by: Julia Lawall --- It's not a big deal, but the constant on the right looks nicer to me. key_code seems like the more important information, so it is nice to see it first. surfacepro_button.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/platform/x86/surfacepro_button.c +++ b/drivers/platform/x86/surfacepro_button.c @@ -111,7 +111,7 @@ static void surface_button_notify(struct break; } input = button->input; - if (KEY_RESERVED == key_code) + if (key_code == KEY_RESERVED) return; if (pressed) pm_wakeup_event(&device->dev, 0);