From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Shannon Zhao <zhaoshenglong@huawei.com>,
<ard.biesheuvel@linaro.org>, <leif.lindholm@linaro.org>,
<linux-arm-kernel@lists.infradead.org>,
<stefano.stabellini@citrix.com>, <david.vrabel@citrix.com>,
<catalin.marinas@arm.com>, <will.deacon@arm.com>,
<julien.grall@citrix.com>, <xen-devel@lists.xen.org>,
<devicetree@vger.kernel.org>, <linux-efi@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <shannon.zhao@linaro.org>,
<peter.huangpeng@huawei.com>, Jan Beulich <JBeulich@novell.com>,
Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH v2 12/16] ARM: Xen: Document UEFI support on Xen ARM virtual platforms
Date: Mon, 18 Jan 2016 17:34:38 +0000 [thread overview]
Message-ID: <alpine.DEB.2.02.1601181710270.9400@kaball.uk.xensource.com> (raw)
In-Reply-To: <20160118105115.GD21067@leverpostej>
On Mon, 18 Jan 2016, Mark Rutland wrote:
> On Fri, Jan 15, 2016 at 02:55:25PM +0800, Shannon Zhao wrote:
> > From: Shannon Zhao <shannon.zhao@linaro.org>
> >
> > Add a "uefi" node under /hypervisor node in FDT, then Linux kernel could
> > scan this to get the UEFI information.
> >
> > Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
> > ---
> > Documentation/devicetree/bindings/arm/xen.txt | 42 +++++++++++++++++++++++++++
> > 1 file changed, 42 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/xen.txt b/Documentation/devicetree/bindings/arm/xen.txt
> > index 0f7b9c2..fbc17ae 100644
> > --- a/Documentation/devicetree/bindings/arm/xen.txt
> > +++ b/Documentation/devicetree/bindings/arm/xen.txt
> > @@ -15,6 +15,36 @@ the following properties:
> > - interrupts: the interrupt used by Xen to inject event notifications.
> > A GIC node is also required.
> >
> > +To support UEFI on Xen ARM virtual platforms, Xen pupulates the FDT "uefi" node
> > +under /hypervisor with following parameters:
>
> s/pupulates/populates/
>
> > +
> > +________________________________________________________________________________
> > +Name | Size | Description
> > +================================================================================
> > +xen,uefi-system-table | 64-bit | Guest physical address of the UEFI System
> > + | | Table.
> > +--------------------------------------------------------------------------------
> > +xen,uefi-mmap-start | 64-bit | Guest physical address of the UEFI memory
> > + | | map.
> > +--------------------------------------------------------------------------------
> > +xen,uefi-mmap-size | 32-bit | Size in bytes of the UEFI memory map
> > + | | pointed to in previous entry.
> > +--------------------------------------------------------------------------------
> > +xen,uefi-mmap-desc-size | 32-bit | Size in bytes of each entry in the UEFI
> > + | | memory map.
> > +--------------------------------------------------------------------------------
> > +xen,uefi-mmap-desc-ver | 32-bit | Version of the mmap descriptor format.
> > +--------------------------------------------------------------------------------
> > +
> > +Below is the format of the mmap descriptor.
> > +typedef struct {
> > + u32 type;
> > + u32 pad;
> > + u64 phys_addr;
> > + u64 virt_addr;
> > + u64 num_pages;
> > + u64 attribute;
> > +} efi_memory_desc_t;
>
> I don't think we should describe this here, as it duplicates the UEFI
> spec, and is techincally incorrect the above is only guaranteed to be
> the prefix of each memory descriptor -- that's why the
> uefi-mmap-desc-size property exists.
>
> We don't do this in Documentation/arm/uefi.txt, and I don't see why we
> should do so here.
>
> Does Xen handle arbitrary size memory map descriptors? I'm not sure what
> new information might be passed in future additions to the descriptor
> format, and I'm not sure what should happen in the Dom0 case.
Xen passes to Dom0 the memory map in the same format as the native
memory map.
> > Example (assuming #address-cells = <2> and #size-cells = <2>):
> >
> > @@ -22,4 +52,16 @@ hypervisor {
> > compatible = "xen,xen-4.3", "xen,xen";
> > reg = <0 0xb0000000 0 0x20000>;
> > interrupts = <1 15 0xf08>;
> > + uefi {
> > + xen,uefi-system-table = <0xXXXXXXXX>;
> > + xen,uefi-mmap-start = <0xXXXXXXXX>;
> > + xen,uefi-mmap-size = <0xXXXXXXXX>;
> > + xen,uefi-mmap-desc-size = <0xXXXXXXXX>;
> > + xen,uefi-mmap-desc-ver = <0xXXXXXXXX>;
> > + };
> > };
> > +
> > +These "xen,uefi-*" parameters are similar to those in Documentation/arm/uefi.txt
> > +which are used by normal UEFI. But to Xen ARM virtual platforms, it needs to
> > +introduce a Xen specific UEFI and it doesn't want to mix with normal UEFI.
> > +Therefore, it defines these parameters under /hypervisor node.
>
> Could we please describe what that actual difference is?
>
> I know that the OS must handle a system table differently under Xen, but
> this doesn't describe what it should do.
For a reference, the hypercall interface is described in not so many words here:
include/xen/interface/platform.h
http://xenbits.xen.org/gitweb/?p=xen.git;a=blob_plain;f=xen/include/public/platform.h;hb=HEAD
However it is clear that platform.h also contains some x86 specific
calls, for example xenpf_set_processor_pminfo. It might be a good idea
to list the calls that are available on ARM64.
> I assume that the OS can handle the memory map in an identical fashion
> to when it is native. Is that true?
Yes, I think that's true.
next prev parent reply other threads:[~2016-01-18 17:35 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 6:55 [PATCH v2 00/16] Add ACPI support for Xen Dom0 on ARM64 Shannon Zhao
2016-01-15 6:55 ` [PATCH v2 01/16] Xen: ACPI: Hide UART used by Xen Shannon Zhao
2016-01-15 15:39 ` Stefano Stabellini
2016-01-18 10:32 ` Mark Rutland
2016-01-18 11:38 ` Stefano Stabellini
2016-01-15 6:55 ` [PATCH v2 02/16] xen/grant-table: Move xlated_setup_gnttab_pages to common place Shannon Zhao
2016-01-15 15:53 ` [Xen-devel] " Stefano Stabellini
2016-01-15 6:55 ` [PATCH v2 03/16] Xen: xlate: Use page_to_xen_pfn instead of page_to_pfn Shannon Zhao
2016-01-15 17:08 ` [Xen-devel] " Stefano Stabellini
2016-01-18 5:08 ` Shannon Zhao
2016-01-19 14:59 ` Stefano Stabellini
2016-01-19 15:10 ` Shannon Zhao
2016-01-15 6:55 ` [PATCH v2 04/16] arm/xen: Use xen_xlate_map_ballooned_pages to setup grant table Shannon Zhao
2016-01-15 17:21 ` Stefano Stabellini
2016-01-15 6:55 ` [PATCH v2 05/16] xen: memory : Add new XENMAPSPACE type XENMAPSPACE_dev_mmio Shannon Zhao
2016-01-15 6:55 ` [PATCH v2 06/16] Xen: ARM: Add support for mapping platform device mmio Shannon Zhao
2016-01-15 17:39 ` [Xen-devel] " Stefano Stabellini
2016-01-15 6:55 ` [PATCH v2 07/16] Xen: ARM: Add support for mapping AMBA " Shannon Zhao
2016-01-18 11:58 ` [Xen-devel] " Stefano Stabellini
2016-01-15 6:55 ` [PATCH v2 08/16] xen/hvm/params: Add a new delivery type for event-channel in HVM_PARAM_CALLBACK_IRQ Shannon Zhao
2016-01-18 12:38 ` [Xen-devel] " Stefano Stabellini
2016-01-18 12:42 ` Andrew Cooper
2016-01-18 12:46 ` Stefano Stabellini
2016-01-18 12:52 ` Andrew Cooper
2016-01-20 6:33 ` Shannon Zhao
2016-01-20 8:39 ` Andrew Cooper
2016-01-20 8:45 ` Shannon Zhao
2016-01-15 6:55 ` [PATCH v2 09/16] arm/xen: Get event-channel irq through HVM_PARAM when booting with ACPI Shannon Zhao
2016-01-18 14:38 ` [Xen-devel] " Stefano Stabellini
2016-01-19 8:21 ` Shannon Zhao
2016-01-15 6:55 ` [PATCH v2 10/16] ARM: XEN: Move xen_early_init() before efi_init() Shannon Zhao
2016-01-18 14:59 ` [Xen-devel] " Stefano Stabellini
2016-01-19 8:36 ` Shannon Zhao
2016-01-19 12:14 ` Stefano Stabellini
2016-01-15 6:55 ` [PATCH v2 11/16] ARM64: ACPI: Check if it runs on Xen to enable or disable ACPI Shannon Zhao
2016-01-18 10:41 ` Mark Rutland
2016-01-18 15:07 ` Stefano Stabellini
2016-01-19 8:41 ` Shannon Zhao
2016-01-15 6:55 ` [PATCH v2 12/16] ARM: Xen: Document UEFI support on Xen ARM virtual platforms Shannon Zhao
2016-01-17 3:43 ` Rob Herring
2016-01-18 10:51 ` Mark Rutland
2016-01-18 17:34 ` Stefano Stabellini [this message]
2016-01-19 10:25 ` Shannon Zhao
2016-01-19 10:47 ` Mark Rutland
2016-01-19 12:23 ` Stefano Stabellini
2016-01-19 13:13 ` Mark Rutland
2016-01-19 13:18 ` Ard Biesheuvel
2016-01-19 13:43 ` Shannon Zhao
2016-01-19 14:11 ` Stefano Stabellini
2016-01-21 11:50 ` Mark Rutland
2016-01-15 6:55 ` [PATCH v2 13/16] ARM: XEN: Set EFI_PARAVIRT if Xen supports EFI Shannon Zhao
2016-01-18 10:57 ` Mark Rutland
2016-01-15 6:55 ` [PATCH v2 14/16] Xen: EFI: Parse DT parameters for Xen specific UEFI Shannon Zhao
2016-01-18 11:03 ` Mark Rutland
2016-01-18 15:41 ` [Xen-devel] " Stefano Stabellini
2016-01-19 13:19 ` Shannon Zhao
2016-01-19 13:43 ` Mark Rutland
2016-01-19 13:46 ` Shannon Zhao
2016-01-15 6:55 ` [PATCH v2 15/16] XEN: EFI: Move x86 specific codes to architecture directory Shannon Zhao
2016-01-15 6:55 ` [PATCH v2 16/16] ARM64: XEN: Initialize Xen specific UEFI runtime services Shannon Zhao
2016-01-18 11:08 ` Mark Rutland
2016-01-18 17:45 ` Stefano Stabellini
2016-01-18 18:27 ` Mark Rutland
2016-01-19 12:03 ` Stefano Stabellini
2016-01-19 13:03 ` Mark Rutland
2016-01-19 13:31 ` Shannon Zhao
2016-01-19 14:20 ` Stefano Stabellini
2016-01-18 17:03 ` [Xen-devel] " Stefano Stabellini
2016-01-19 13:12 ` Shannon Zhao
2016-01-19 14:24 ` Stefano Stabellini
2016-01-22 3:58 ` Shannon Zhao
2016-01-22 10:57 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1601181710270.9400@kaball.uk.xensource.com \
--to=stefano.stabellini@eu.citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=JBeulich@novell.com \
--cc=ard.biesheuvel@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=david.vrabel@citrix.com \
--cc=devicetree@vger.kernel.org \
--cc=julien.grall@citrix.com \
--cc=leif.lindholm@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=peter.huangpeng@huawei.com \
--cc=shannon.zhao@linaro.org \
--cc=stefano.stabellini@citrix.com \
--cc=will.deacon@arm.com \
--cc=xen-devel@lists.xen.org \
--cc=zhaoshenglong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®