From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756587AbcARUU4 (ORCPT ); Mon, 18 Jan 2016 15:20:56 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:51778 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755979AbcARUUw (ORCPT ); Mon, 18 Jan 2016 15:20:52 -0500 X-IronPort-AV: E=Sophos;i="5.22,313,1449529200"; d="scan'208";a="197990090" Date: Mon, 18 Jan 2016 21:20:50 +0100 (CET) From: Julia Lawall X-X-Sender: jll@localhost6.localdomain6 To: Daniel Vetter cc: Julia Lawall , Maarten Lankhorst , David Airlie , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, kbuild-all@01.org, Daniel Vetter Subject: Re: [Intel-gfx] [PATCH] drm/i915: fix itnull.cocci warnings (fwd) In-Reply-To: <20160118172025.GM19130@phenom.ffwll.local> Message-ID: References: <20160118172025.GM19130@phenom.ffwll.local> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 18 Jan 2016, Daniel Vetter wrote: > On Mon, Jan 18, 2016 at 04:49:06PM +0100, Julia Lawall wrote: > > List_for_each entry binds its first argument to an offset from the list > > pointer, so this should not be NULL. > > > > Generated by: scripts/coccinelle/iterators/itnull.cocci > > > > Signed-off-by: Fengguang Wu > > --- > > > > Please take the patch only if it's a positive warning. Thanks! > > Against which tree is this? I can't find this anywhere like that ... I don't know. It may be against a submitted patch. In case it turns out to be useful, I forgot: Signed-off-by: Julia Lawall > -Daniel > > > > > intel_display.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > --- a/drivers/gpu/drm/i915/intel_display.c > > +++ b/drivers/gpu/drm/i915/intel_display.c > > @@ -16498,7 +16498,7 @@ void intel_modeset_preclose(struct drm_d > > struct intel_flip_work *work; > > > > list_for_each_entry(work, &crtc->flip_work, head) { > > - if (work && work->event && > > + if (work->event && > > work->event->base.file_priv == file) { > > kfree(work->event); > > work->event = NULL; > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > http://lists.freedesktop.org/mailman/listinfo/intel-gfx > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch >