From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932516AbcAYPUZ (ORCPT <rfc822;w@1wt.eu>);
	Mon, 25 Jan 2016 10:20:25 -0500
Received: from smtp02.citrix.com ([66.165.176.63]:34546 "EHLO
	SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932120AbcAYPUW (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 25 Jan 2016 10:20:22 -0500
X-IronPort-AV: E=Sophos;i="5.22,345,1449532800"; 
   d="scan'208";a="333781462"
Date: Mon, 25 Jan 2016 15:19:37 +0000
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
X-X-Sender: sstabellini@kaball.uk.xensource.com
To: Shannon Zhao <zhaoshenglong@huawei.com>
CC: <linux-arm-kernel@lists.infradead.org>, <ard.biesheuvel@linaro.org>,
        <mark.rutland@arm.com>, <stefano.stabellini@citrix.com>,
        <david.vrabel@citrix.com>, <catalin.marinas@arm.com>,
        <will.deacon@arm.com>, <julien.grall@citrix.com>,
        <xen-devel@lists.xen.org>, <devicetree@vger.kernel.org>,
        <linux-efi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <ian.campbell@citrix.com>, <shannon.zhao@linaro.org>,
        <peter.huangpeng@huawei.com>
Subject: Re: [PATCH v3 10/17] arm/xen: Get event-channel irq through HVM_PARAM
 when booting with ACPI
In-Reply-To: <1453519184-11908-11-git-send-email-zhaoshenglong@huawei.com>
Message-ID: <alpine.DEB.2.02.1601251512580.9687@kaball.uk.xensource.com>
References: <1453519184-11908-1-git-send-email-zhaoshenglong@huawei.com>
 <1453519184-11908-11-git-send-email-zhaoshenglong@huawei.com>
User-Agent: Alpine 2.02 (DEB 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
X-DLP: MIA1
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, 23 Jan 2016, Shannon Zhao wrote:
> From: Shannon Zhao <shannon.zhao@linaro.org>
> 
> When booting with ACPI, it could get the event-channel irq through
> HVM_PARAM_CALLBACK_IRQ.
> 
> Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
> ---
>  arch/arm/xen/enlighten.c | 36 +++++++++++++++++++++++++++++++++++-
>  1 file changed, 35 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c
> index 6d90a62..0e010bb 100644
> --- a/arch/arm/xen/enlighten.c
> +++ b/arch/arm/xen/enlighten.c
> @@ -29,6 +29,7 @@
>  #include <linux/time64.h>
>  #include <linux/timekeeping.h>
>  #include <linux/timekeeper_internal.h>
> +#include <linux/acpi.h>
>  
>  #include <linux/mm.h>
>  
> @@ -262,6 +263,35 @@ void __init xen_early_init(void)
>  		add_preferred_console("hvc", 0, NULL);
>  }
>  
> +static void __init xen_acpi_guest_init_events_irq(void)

please rename it to "xen_acpi_guest_init"


> +{
> +#ifdef CONFIG_ACPI
> +	struct xen_hvm_param a;
> +	int interrupt, trigger, polarity;
> +
> +	a.domid = DOMID_SELF;
> +	a.index = HVM_PARAM_CALLBACK_IRQ;
> +	xen_events_irq = 0;
> +
> +	if (!HYPERVISOR_hvm_op(HVMOP_get_param, &a)) {
> +		if ((a.value >> 56) == HVM_PARAM_CALLBACK_TYPE_EVENT) {
> +			interrupt = a.value & 0xff;
> +			trigger = ((a.value >> 8) & 0x1) ? ACPI_EDGE_SENSITIVE
> +							 : ACPI_LEVEL_SENSITIVE;
> +			polarity = ((a.value >> 8) & 0x2) ? ACPI_ACTIVE_LOW
> +							  : ACPI_ACTIVE_HIGH;
> +			xen_events_irq = acpi_register_gsi(NULL, interrupt,
> +							   trigger, polarity);
> +		}
> +	}
> +#endif
> +}
> +
> +static void __init xen_dt_guest_init_events_irq(void)

"xen_dt_guest_init"

Provided that you make these two changes:

Reviewed-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>



> +{
> +	xen_events_irq = irq_of_parse_and_map(xen_node, 0);
> +}
> +
>  static int __init xen_guest_init(void)
>  {
>  	struct xen_add_to_physmap xatp;
> @@ -270,7 +300,11 @@ static int __init xen_guest_init(void)
>  	if (!xen_domain())
>  		return 0;
>  
> -	xen_events_irq = irq_of_parse_and_map(xen_node, 0);
> +	if (!acpi_disabled)
> +		xen_acpi_guest_init_events_irq();
> +	else
> +		xen_dt_guest_init_events_irq();
> +
>  	if (!xen_events_irq) {
>  		pr_err("Xen event channel interrupt not found\n");
>  		return -ENODEV;
> -- 
> 2.0.4
> 
>