From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934107AbcAZLbg (ORCPT ); Tue, 26 Jan 2016 06:31:36 -0500 Received: from smtp02.citrix.com ([66.165.176.63]:45239 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756382AbcAZLba (ORCPT ); Tue, 26 Jan 2016 06:31:30 -0500 X-IronPort-AV: E=Sophos;i="5.22,350,1449532800"; d="scan'208";a="333986145" Date: Tue, 26 Jan 2016 11:31:19 +0000 From: Stefano Stabellini X-X-Sender: sstabellini@kaball.uk.xensource.com To: Shannon Zhao CC: Stefano Stabellini , , , , , , , , , , , , , , , Subject: Re: [PATCH v3 14/17] XEN: EFI: Move x86 specific codes to architecture directory In-Reply-To: <56A72B4F.2040909@huawei.com> Message-ID: References: <1453519184-11908-1-git-send-email-zhaoshenglong@huawei.com> <1453519184-11908-15-git-send-email-zhaoshenglong@huawei.com> <56A72B4F.2040909@huawei.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="1342847746-1876608270-1453807887=:3619" X-DLP: MIA2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --1342847746-1876608270-1453807887=:3619 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT On Tue, 26 Jan 2016, Shannon Zhao wrote: > On 2016/1/26 0:44, Stefano Stabellini wrote: > > On Sat, 23 Jan 2016, Shannon Zhao wrote: > >> > From: Shannon Zhao > >> > > >> > Move x86 specific codes to architecture directory and export those EFI > >> > runtime service functions. This will be useful for initializing runtime > >> > service on ARM later. > >> > > >> > Signed-off-by: Shannon Zhao > > This patch causes a build breakage on x86: > > > > arch/x86/xen/efi.c: In function ‘xen_efi_probe’: > > arch/x86/xen/efi.c:101:2: error: implicit declaration of function ‘HYPERVISOR_platform_op’ [-Werror=implicit-function-declaration] > > > This patch is based on following patch [1]. Maybe you need to update > your branch. :) > > [1] xen: rename dom0_op to platform_op > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=cfafae940381207d48b11a73a211142dba5947d3 Sorry, I made a mistake rebasing the series. It doesn't help that I couldn't find any Linux RCs on top of which it applies cleanly. As Linus tags RCs often enough, it is usually helpful to base one's work on a tag so that it is easier for other people to work on it. Please add my Reviewed-by to this patch. --1342847746-1876608270-1453807887=:3619--