From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751058AbcBAHfI (ORCPT ); Mon, 1 Feb 2016 02:35:08 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:33749 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750722AbcBAHfG (ORCPT ); Mon, 1 Feb 2016 02:35:06 -0500 X-IronPort-AV: E=Sophos;i="5.22,379,1449529200"; d="scan'208";a="200360499" Date: Mon, 1 Feb 2016 08:35:03 +0100 (CET) From: Julia Lawall X-X-Sender: jll@localhost6.localdomain6 To: ByeoungWook Kim cc: Julia Lawall , gregkh@linuxfoundation.org, ksenija.stanojevic@gmail.com, luisbg@osg.samsung.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] staging: rtl8192u: Fix block comments use * on subsequent lines in r8192U_wx.c In-Reply-To: Message-ID: References: <20160201051647.GA5001@gmail.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 1 Feb 2016, ByeoungWook Kim wrote: > The current realtek driver was written like my patch comments. but > Documentation/CodingStyle isn't before. > So I wrote patch like current realtek driver. That is probably fine, then. Sorry for the noise. I looked at some other code in the kernel, and it didn't have it. julia > > How should i do it? > > Regards, > Byeoungwook. > > 2016-02-01 16:01 GMT+09:00 Julia Lawall : > > > > > > On Mon, 1 Feb 2016, Byeoungwook Kim wrote: > > > >> clean up checkpatch warning: > >> WARNING: Block comments use * on subsequent lines > >> > >> Signed-off-by: Byeoungwook Kim > >> --- > >> drivers/staging/rtl8192u/r8192U_wx.c | 38 +++++++++++++++++++----------------- > >> 1 file changed, 20 insertions(+), 18 deletions(-) > >> > >> diff --git a/drivers/staging/rtl8192u/r8192U_wx.c b/drivers/staging/rtl8192u/r8192U_wx.c > >> index 4911fef..f828e64 100644 > >> --- a/drivers/staging/rtl8192u/r8192U_wx.c > >> +++ b/drivers/staging/rtl8192u/r8192U_wx.c > >> @@ -1,21 +1,23 @@ > >> -/* > >> - This file contains wireless extension handlers. > >> - > >> - This is part of rtl8180 OpenSource driver. > >> - Copyright (C) Andrea Merello 2004-2005 > >> - Released under the terms of GPL (General Public Licence) > >> - > >> - Parts of this driver are based on the GPL part > >> - of the official realtek driver. > >> - > >> - Parts of this driver are based on the rtl8180 driver skeleton > >> - from Patric Schenke & Andres Salomon. > >> - > >> - Parts of this driver are based on the Intel Pro Wireless 2100 GPL driver. > >> - > >> - We want to thank the Authors of those projects and the Ndiswrapper > >> - project Authors. > >> -*/ > >> +/****************************************************************************** > > > > Is the row of *s needed? > > > > julia > > > >> + * > >> + * This file contains wireless extension handlers. > >> + * > >> + * This is part of rtl8180 OpenSource driver. > >> + * Copyright (C) Andrea Merello 2004-2005 > >> + * Released under the terms of GPL (General Public Licence) > >> + * > >> + * Parts of this driver are based on the GPL part > >> + * of the official realtek driver. > >> + * > >> + * Parts of this driver are based on the rtl8180 driver skeleton > >> + * from Patric Schenke & Andres Salomon. > >> + * > >> + * Parts of this driver are based on the Intel Pro Wireless 2100 GPL driver. > >> + * > >> + * We want to thank the Authors of those projects and the Ndiswrapper > >> + * project Authors. > >> + * > >> + *****************************************************************************/ > >> > >> #include > >> #include "r8192U.h" > >> -- > >> 2.5.0 > >> > >> -- > >> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > >> the body of a message to majordomo@vger.kernel.org > >> More majordomo info at http://vger.kernel.org/majordomo-info.html > >> >