From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753150AbcBXPsk (ORCPT <rfc822;w@1wt.eu>);
	Wed, 24 Feb 2016 10:48:40 -0500
Received: from smtp.citrix.com ([66.165.176.89]:37135 "EHLO SMTP.CITRIX.COM"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750914AbcBXPsi (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 24 Feb 2016 10:48:38 -0500
X-IronPort-AV: E=Sophos;i="5.22,494,1449532800"; 
   d="scan'208";a="334190354"
Date: Wed, 24 Feb 2016 15:48:01 +0000
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
X-X-Sender: sstabellini@kaball.uk.xensource.com
To: kbuild test robot <lkp@intel.com>
CC: Stefano Stabellini <stefano.stabellini@eu.citrix.com>, <kbuild-all@01.org>,
        <xen-devel@lists.xensource.com>, <linux-kernel@vger.kernel.org>,
        <david.vrabel@citrix.com>, <konrad.wilk@oracle.com>,
        <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH 2/2] hvc_xen: fix xenboot for DomUs
In-Reply-To: <201602242008.Td9zQF7s%fengguang.wu@intel.com>
Message-ID: <alpine.DEB.2.02.1602241547080.17248@kaball.uk.xensource.com>
References: <201602242008.Td9zQF7s%fengguang.wu@intel.com>
User-Agent: Alpine 2.02 (DEB 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
X-DLP: MIA2
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi kbuild test robot,

you are awesome as always. I'll fix it in the next version.

Thanks,

Stefano

On Wed, 24 Feb 2016, kbuild test robot wrote:
> Hi Stefano,
> 
> [auto build test WARNING on tty/tty-testing]
> [also build test WARNING on v4.5-rc5 next-20160223]
> [if your patch is applied to the wrong git tree, please drop us a note to help improving the system]
> 
> url:    https://github.com/0day-ci/linux/commits/Stefano-Stabellini/hvc_xen-add-earlycon-support/20160224-203006
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
> config: x86_64-randconfig-x009-201608 (attached as .config)
> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=x86_64 
> 
> All warnings (new ones prefixed by >>):
> 
>    drivers/tty/hvc/hvc_xen.c: In function 'xenboot_setup_console':
> >> drivers/tty/hvc/hvc_xen.c:637:1: warning: control reaches end of non-void function [-Wreturn-type]
>     }
>     ^
> 
> vim +637 drivers/tty/hvc/hvc_xen.c
> 
>    621		}
>    622		if (off < len)
>    623			domU_write_console(0, string+off, len-off);
>    624	}
>    625	
>    626	#ifdef CONFIG_EARLY_PRINTK
>    627	static int xenboot_setup_console(struct console *console, char *string)
>    628	{
>    629		static struct xencons_info xenboot;
>    630	
>    631		if (xen_initial_domain())
>    632			return 0;
>    633		if (!xen_pv_domain())
>    634			return -ENODEV;
>    635	
>    636		xen_early_pv_console_init(&xenboot, 0);
>  > 637	}
>    638	
>    639	static void xenboot_write_console(struct console *console, const char *string,
>    640					  unsigned len)
>    641	{
>    642		if (!xen_pv_domain())
>    643			return;
>    644	
>    645		dom0_write_console(0, string, len);
> 
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
>