From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757869AbcCCPNw (ORCPT ); Thu, 3 Mar 2016 10:13:52 -0500 Received: from mail-by2on0068.outbound.protection.outlook.com ([207.46.100.68]:48341 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752152AbcCCPNu (ORCPT ); Thu, 3 Mar 2016 10:13:50 -0500 Authentication-Results: spf=fail (sender IP is 66.35.236.227) smtp.mailfrom=opensource.altera.com; ettus.com; dkim=pass (signature was verified) header.d=altera.onmicrosoft.com;ettus.com; dmarc=none action=none header.from=opensource.altera.com; Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=opensource.altera.com; Date: Thu, 3 Mar 2016 09:11:26 -0600 From: atull X-X-Sender: atull@linuxheads99 To: Rob Herring CC: Pantelis Antoniou , Frank Rowand , Grant Likely , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Moritz Fischer , Pantelis Antoniou , Alan Tull , Dinh Nguyen Subject: Re: [PATCH] of/overlay: add of overlay notifications In-Reply-To: Message-ID: References: <1456523056-15352-1-git-send-email-atull@opensource.altera.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [64.129.157.38] X-ClientProxiedBy: SN1PR0701CA0015.namprd07.prod.outlook.com (25.162.96.25) To BLUPR03MB1505.namprd03.prod.outlook.com (25.163.81.23) X-MS-Office365-Filtering-Correlation-Id: fa71ed42-548b-4a08-f23a-08d343766a91 X-Microsoft-Exchange-Diagnostics-untrusted: 1;BLUPR03MB1505;2:i87MJ1aUjhr5jMM6etB+NWbwx4K7z0nuobObe6umYXO1JKjNQ8oQsgE1jabJ0NGgDhmhia5g3XNnwtqHNv44LeEna9tMOhab65HVEHELS+TYTlzOmNlTdirP6nfXe0szcwohyODxhRTGqrNDvuzvuOlKttvac7Zr1VgYwunVddyVlbCpb+pR398XwBrOzNXW;3:dssmuWeuH4RmPU9IroRGR1d/Y8jzpGbR85iSufL8ANL5qOWbUVXUvjfltgAr478e/gKRwMkf2JyGbOSuRuNB0TWxW7xYhvpc7xEWlhPkpZcjoYK30mjGVVlh7f4EnSyt;25:H5lIF9ZCXlhnHKFaxet9AGX6azy3YHrDJv4qRcLETK9zVYC1piB+WflzdrTkbsslMohJD5l0sDtLnUW1Juiev2rYU22c8TJPm7/w3k80e5uLkaovNWUB7C1qlorP4uPauw5mAO9fiqs5iWf/MO0DZsDF4v33zjGqGDKUtxyBfjTff2UMYYbvD6EQbZsWosGI0u5pqTTz1BZ3c3mJzUvaqGXHfnv8aGDtgbIs5pYe4UQc0ylmSpNk5kvq780yycBd8Z7PxOxKdEpa7h8NrWr4ctpHcDpdHSNnioM9i5uXr7FpyZFxqIrFLUNCYbnZJDv9gwoY032WdXQmpjYQGQ0qTQ==;20:AKmHqha7b2bVNrCOB+ddWL9K1au7URwV8uubTlskFCGv6zbIV64gCc8qLdXIiFRlyJI89gXMUaZ0443F3PiZJuZEMDBd6zRPmejjGp7lruKbo5rrDJP9i9zHPgJklXhxEajbb/uRQ2QsH/LDg9VO/DLsPw+shrG4qBEAqUbTDNI= X-Microsoft-Antispam-Untrusted: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB1505; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:;UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:BLUPR03MB1505;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB1505;BCL:0;PCL:0;RULEID:(601004)(2401047)(13015025)(13017025)(13023025)(13024025)(5005006)(8121501046)(13018025)(3002001)(10201501046);SRVR:BLUPR0301MB2019;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0301MB2019; X-Microsoft-Exchange-Diagnostics-untrusted: 1;BLUPR03MB1505;4:Vr724BWbp+rCQnOQK+xBLiDROoML1DtvXLQJOvcSC0cLjNihoDIwvwdQrxv2mk2eSDcVJqnJGaePLhdBBN9ycuDbq89m+qUJtaYCtjaI07UpuczS5y0xcn7FR9L6tsH/L/03F8jTezBV4i1W+sec/HD3bC3KmKOfZwcDKaMOgSsbVBxun+PY/20Sz8TeeNRknAT+4qMSpUCGCF1iRHYy54oZ8kh68C43hfBdop0LiWJpXu6rHtII9faGfHvY98qrrsxiop/Lei1HBAULI7YmABmRoZXSsDOMnk/71I/NwW++9RhB3WezXx0FsJG/cVgWjUcHAzBCsZYml1kWWpfbiP1zmSysAUGeDrBkyfGunK4K6qOoiCmMLvvcEZinu7fJ X-Forefront-PRVS: 0870212862 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(377454003)(24454002)(4001430100002)(189998001)(53416004)(5008740100001)(66066001)(50986999)(4001350100001)(107886002)(110136002)(5004730100002)(4326007)(23726003)(6116002)(2906002)(42186005)(47776003)(1096002)(76176999)(92566002)(586003)(50466002)(15650500001)(54356999)(5001960100004)(46406003)(19580405001)(40100003)(86152002)(87976001)(19580395003)(122386002)(33716001)(86362001)(2950100001)(77096005);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR03MB1505;H:linuxheads99.altera.com;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics-untrusted: =?us-ascii?Q?1;BLUPR03MB1505;23:gFlR8rNzxfA6X/eEA6ke70kUyaeOBWlQJ01RMPcYf?= =?us-ascii?Q?bW3bylpXKr0jCBYvlcuCX6PU7wN3CH06KEbw+wooR7ChK13lnC7pyICL8uae?= =?us-ascii?Q?bDrYhLWQ+wR1xboA1dN4T4EhdaTjL3gSvEGwHYzmok6pORuBJrvJlE+2gTUj?= =?us-ascii?Q?B/0KKoE0o4RHfVQKghJRgxXKdCMuRWlLvuAZAutkd0D+5vp89UG+4IjbsxY+?= =?us-ascii?Q?rtF+sfI7nFRa1yk8eG4QsdxLGcXrTvBEBB19jLGFKlE+mfz8WpP/685wDVol?= =?us-ascii?Q?9s36lflOPwOxSajKnB9IYvjLDMnCn1BeECKgrOrAoPcNZHCPdy2WA8pxxcAB?= =?us-ascii?Q?fQbNgCHdigluyq0DbDiWATimohQaQhQ1qPR5RSDLKk+pscUzR8af7uVtROUn?= =?us-ascii?Q?zovpn/S3stQopFqGEn6tEr/LkDg6zEIYlx/oo5cQORdCPi/2IqcWdWBJ8mJZ?= =?us-ascii?Q?/kpUKveqi1l3ySCIeyvzvq9qghLWwU7JnQUfMW6MGD+lcXWE7OmhR5rxOgb+?= =?us-ascii?Q?sSv2glRxCHn6ZoPK2NXC1SMgzopNukXAdRIRuXVyafexSS5kifN2IDaVWVDV?= =?us-ascii?Q?lYdFEuyGNlJffF5gS6xJtQeupVZ73xKnaqvPZljCsckMfQsOEe251XUFD3HI?= =?us-ascii?Q?49DkenTeG/vZVu/2dkkPzr52s+KQQqZgXeiHa8PsChJYjI799RMziIIGA3+y?= =?us-ascii?Q?0j/OtSaAacx7DF5WJ06eQjoPVMOYVjMO0F9NMWzPrmv97Uyh+Tz+s3JH4vSY?= =?us-ascii?Q?TxbyVM6skaHwseomvk+x3s/hS/Jd71stjCZtx+Oo+Etlc+7hr65bCTXklBcH?= =?us-ascii?Q?XDNTy2VsIWkNWhy9vBVtJipVlR9asBUlCqb1KaWqP08uycOzZK2maa5PLPSL?= =?us-ascii?Q?MR+WJDdXHvZmjOUcvgkaUitsthSUCY7iMb4mOrpv15k7ScMZKxyr/xXPB3zh?= =?us-ascii?Q?QYJVFWCjbnuD4Okv9L7ZAad3UIhMAyHdwgmsvI1/KnhB5W8tzJC1uYo97+EH?= =?us-ascii?Q?upW5PLSV1UkAogvZnnv/UO8mU5nhIY+7qHx1hJCMIdrAdpPbTsjPyR/M4T+H?= =?us-ascii?Q?wd+Qe+9wgZyirzsNoQDBdkfixsV?= X-Microsoft-Exchange-Diagnostics-untrusted: 1;BLUPR03MB1505;5:3dTnAQnQ+jNRWPoWy4HvF1CozbBoE2MZ5k8an+Upo6bjY6e8O4/DSegFOkm2kt/NvsgkGnUK9Rd0PXcz4vcShHTQD2/7G1WVGWAOfCdUrANmIxurofUokp3r2ZVwWP0gwgKpMRbpXv9KfrN70G1KZg==;24:gUgFLZjmT5UR5F+R59a8OfYN2iw7zbtpqcxJwiVTi/UjI0yaZzcaXNl/EOsRcuCTjXFn83CFNw7HHFMreCySA9Nyo53n40Fr1SNfqXMT+Ds=;20:fYcI7egThaO8cIsJx2jlDd4oE7WToKkVeIAPTLNcWB0ye24S3eGG0ensrkhheqtnQrQ3tesRshu/PcrHLrBeETHM5DlghEuGj74uSROi+pkHcRv7Ep0GWD6ZTSkOPoMMHJLb1rw0N3+2gWkYGR7sPehgNTgWsdQxEWL0LJJ6LNw= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB1505 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: BN1BFFO11FD042.protection.gbl X-Forefront-Antispam-Report: CIP:66.35.236.227;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(1110001)(1109001)(339900001)(377454003)(189002)(24454002)(199003)(122386002)(54356999)(21840400001)(105606002)(5008740100001)(19580405001)(76176999)(2950100001)(19580395003)(50986999)(5004730100002)(11100500001)(15650500001)(85426001)(6806005)(40100003)(46406003)(106466001)(50466002)(86362001)(47776003)(77096005)(189998001)(66066001)(86152002)(53416004)(4326007)(4001430100002)(110136002)(2906002)(33716001)(4001350100001)(107886002)(1220700001)(6116002)(586003)(1096002)(92566002)(5001960100004)(956001)(23726003)(3720700001)(7099028);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR0301MB2019;H:sj-itexedge03.altera.priv.altera.com;FPR:;SPF:Fail;MLV:sfv;MX:1;A:0;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11FD042;1:FeGg/6vQ6jIbgPDE31WNd3srrsgPepXQ+lDQ5rgZ9jAghAGoBLdKxDH6hPtqQnf009Hi8bghzhqvVvH/9wxpboQXyrR5qXQyBFZdWr2KgC0t68C7qPI8hQt+/ibPWb3Cj8ckRXFNOmYfrkorr4Wn+N8btFCC85ABIR7zB6ikrscnRdXHbmFb3AqW4aCCBCxUpEZBMhE/NsYjnuEFpt4VCUb8oSInoQpHoUTfWoB8CSU4ImwZPlCOHhc77mvuBMlaM7ijjLVnr/Ku7cRvSd4I6ZxS0W7MaLTkduUhDwmuVAGlhY0bd3jRSqpWw3EQp9d0HyHps38p8toyKlsMwSWXNzfi+ti5br/bS0r7js+LDepVdYgrl55qIV6wisyeJIDaHFYFp0CXMxgF21R0vFPjUWGtexyRMk214867Rbo2RcTWnu06iG/QGMA6OGhY8Io30BHYTBI64lSUdQinoMjmyQ== X-Microsoft-Exchange-Diagnostics: 1;BLUPR0301MB2019;2:5LpgrpNglkDTMydvwk76yzImho4R8+tkmaQkFDjtgKLNRlSNd1wsf/8NPqY6Uf+DbUpl3cfPUzWX4R5KQAGejNMNfH3fCPX12AlufJSUP5P6DPGNYh4bpK7m84+yXxtYV1ptRj1EKfbkHm4SUvv6m5s8X7W7XnVdUvaDo3gjCMFFzPsMRqBrKwN8Q+9nldTh;3:hdYnZX9pJGD5v1mqxoLShwlejpBU59AeoS2TZRN2ctPEf1U2Bc2j0pTDOkrbn1pKFD1ulnC4JUlehEexlFdN7byvnJXcT0xJlVQlO2OOBmtLyMA5bXTs5Dgg5IBGb6v8wGHP9PpYi6mTckx1fBgBq+QMQxqfd6GdSLF4qauukTvjX/j7YGNCo0Cri2UNxleniolXGBqXegMqu4QPIXJaWJwXVh1C49CwX6hvOoNerDHmwZq60jdwf1nBlkRAfE57;25:4O5AJ0eZ9YkeRx4Wz0i65oq7HO+Zvyz2Tv+Y0//n9kBRfOdAOqGPSE4P0lyUNIbAlPlK8HS0YnJw2NvjYBgPLywn9GtDRlHVwaZ7Q9ROoUR8ithv1OsklpC0My+l+zF8Pp/zS/cgcRT9/nCaiiN7ZW+RnHGgV5aOYd+qYvz4LwW6liS6FbVsrYym/f58s9vpFpsEsDIuwO5ePpc/jBa3gi24ePC5IG+cxulZSBysuAN0UK3NjDeR899g4w6Zv93N+hzKqemh4t6lNr681dMO7IhUQ66s3B2aJ+F5iddYfXnTg0kRiKyP9zfOTbulAU1XIPrXeEFeihQLVFKxnc/SLA== X-DkimResult-Test: Passed X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(3001016);SRVR:BLUPR0301MB2019; X-Microsoft-Exchange-Diagnostics: 1;BLUPR0301MB2019;20:3t9sTW+1EJ6B3jIiBsYDNuQVhEO1NoL4kkh1qo4FsSqQ0/ikDfZwpVOcGQfXj05YQIglmgBabtMWoUvibGJCVq45upLd4vS4TNQ2tv3sYFW3BKiuT0YiVxG7tzmkAe2fuDFanV41c2gFt0Fs+xpXp6TkcLDChd1pSrvWQiblCB4=;4:9909enGc3OjYO1VuPrx5cgiUZW3E+aR2CmT+hq2EKDrYzfojtJqHLXOe56CNDDM8DuT9JWAEZ2T6eWkyFE6qhs3gNB9V/aBFlIkc2KFxp7lytpJfcDXmtSOO00ddmAa4ThmNQ9Yw07uIdoJBq9e6Ea3HH8HT2lrFikse9mREJsTSBamzRaTzXM+vJVuiFfspiemYsfJ0sE5aWCn+juZ1iSF4DM0z6noqem+xHwU0OcGdpS1/1ckdowkfCrb2HBTjnQouup5OZgyHydCMJozSQvrr8vKGdT0qAujN/hZm9IACD1lGaVanTZmOWMW2UxnBTqtPtbU+W+izD+hFSqhBRj36jxRHiZr4GKcKaeMbCZJafBVWW+ls8msrDq+FMk1Kxb+6V+BwUMv423n+NPNUtHaR0fzvlrUVWVfeBn2vRF9Hp0WkrXBmtfMjw2m91BFUI55Y6Al3JIZPLP1CzHnhPA== X-Forefront-PRVS: 0870212862 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BLUPR0301MB2019;23:+ho/NNbbF+b3MJMbloELE02u1qxR/cseTVPN4S5?= =?us-ascii?Q?5OTtbuTBgFeS6v9C9steQljaxVMUJtR5kra6N/wBToe1JGw+ubf7Q7rKvo52?= =?us-ascii?Q?ENaHw9Fpat2HzJOa6/IucOPkbC4gWeIBSmT7ccM5guVrhC9wjAEblTwwpj4x?= =?us-ascii?Q?dzOivJ0AWAzwmrJlE8Ah2UKfdY0ciyrBdDGdO0DThdRmfQyu+mr94ylO6bvP?= =?us-ascii?Q?5MJkgbFzdsUCmN0ZAhoVVweQ4203m5YCYgo8xj8PusVuh8/4qjzqMEUS3ZKq?= =?us-ascii?Q?AJTjM8vK/pjcxiz9HETRcUnXX6RGMVdZzvrxAjmsQuvz+7V2boEOPUMtV9lV?= =?us-ascii?Q?Eyvstdo+yxAZNRbUFRuS74gzmevfcwrfBcPwjbSF+sYQreFzNgCqWKG2iiIV?= =?us-ascii?Q?p3UPmF9RwWWmCqvVKD9T8Id++fKnXoBnf9Fpy83H+snFvzuJVZXViiECxeHo?= =?us-ascii?Q?4vemf7X3yTTxFO9iGiyHo0aqOtCu0o261n+aO5Vc6eoRpcCHgn8ThX+ljW/T?= =?us-ascii?Q?yqr1g0D25M2VaKzlNaseLF4Cn1EMvS+Qeu2i0UQfXoeRVRrQNtfrcPnLdU/K?= =?us-ascii?Q?to6XNa+gKp4r3GSy0Ba3isjj5USTuvn+yTq8HHcHHT7lDeSTH1T8oqHW2xtT?= =?us-ascii?Q?Fnv5MwSS6oI21dTuPar/Yu63TdMqdk0yekPsJLs35wy8oDfq41jX4ngAW5NB?= =?us-ascii?Q?QJHImcJqhS8GjIOJT2ibKzfmr4KpRgI9gEO6hVqFvBI7Q9Xftara1nOwnObX?= =?us-ascii?Q?GWq5jbQ7FWvtpya4QCcsuyLXvoJASfpN2XVXyAVF1zszc1EVxK9qhH32/Xtp?= =?us-ascii?Q?sh3qdsh1Ad6fMmdZo6oQkHHDMEcUPWzlAXXaijkx5wQgh93Pe+sR0KygfcBe?= =?us-ascii?Q?ccXGR5VVOCFWN1/iwK2qRlxPzBr/iNBWauXhVVIOg2CKCUcXWATBuuDcIhUS?= =?us-ascii?Q?rptIBThNEYP+2dRtKpCOcO9a/irdg+laOomCkABu5rlD12Wh5+Er+hdIhFWC?= =?us-ascii?Q?vjEvvXK0LNqyGp7e7SwLpJNYGX2QBXEIY7PPhE0RdEI/Ex2wPwHdBgIkAugM?= =?us-ascii?Q?/V+2uDWkvep8RHIHyGwNOPhmk8e92sCmV3uN4PPXoRqBhcPT4DjF8rjbcg8x?= =?us-ascii?Q?BmW38Ec3RtzLZwZfCmcKHlqm8wUi2gwlUuKmALXxYV9wU97piLjRQBh+ssT2?= =?us-ascii?Q?SVCj1qRW3AP6dGhkNmeV5dhVoSx1JDBWX5PezTUGrifIIjBFEaswBXSqAxHL?= =?us-ascii?Q?yEXSl9+z7ftY6y0oq5HBxfSwyw7kph7CYknutYuTJ5dGmvqpntIv/vtL7KzG?= =?us-ascii?Q?oQZJ56DNPCq11g86frS/1AeRsHSS10M0C7QsaVgCIezqV?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR0301MB2019;5:9K42v9cH0i+VwNC7Yk3AJD7uGt8st2JMlU7/niQtfgO0t1okU8JpQYYWl5oX/BoFEVMMA7IBn7ENZ6gWLTio7LkiD/zKQyPogfqkv9Yvoea80WFcGYUgRuEhKJdP+a3Xn9CozrWNcoEx3zs55aWdJg==;24:Fbvb0Q1NGrESOmzYWCysg29+hUVP17HjvD0yXLHBMqVcgnsq6vQYX7vW2mAW4A6PghW4xK1mCATAhbtJNcL8Cm8EG3TTyu1Ncu+ZhKNNQKI=;20:XrQfw+au9ZPdFRmpUsCzmZQK3UVx8O6Ao309Q3goOLxWTI/kAd2re3kyUBvyZNkqf5x3F5Rx5ClP1+SFHQU4PJKw8T0tSx39E/eUI21AZeOr4HayNiuR7JHfJLhnBK5jagEbwWJyQ5R9aKg1x5IrkRw2tDJK8EdTa3TeFPuxVqI= X-OriginatorOrg: opensource.altera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2016 15:13:45.8155 (UTC) X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a;Ip=[66.35.236.227];Helo=[sj-itexedge03.altera.priv.altera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0301MB2019 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 3 Mar 2016, Rob Herring wrote: > On Wed, Mar 2, 2016 at 12:49 PM, atull wrote: > > On Wed, 2 Mar 2016, Rob Herring wrote: > > > >> On Fri, Feb 26, 2016 at 3:44 PM, Alan Tull wrote: > >> > This patch add of overlay notifications. > >> > > >> > When DT overlays are being added, some drivers/subsystems > >> > need to see device tree overlays before the changes go into > >> > the live tree. > > [...] > > >> > @@ -389,6 +431,8 @@ int of_overlay_create(struct device_node *tree) > >> > /* add to the tail of the overlay list */ > >> > list_add_tail(&ov->node, &ov_list); > >> > > >> > + of_overlay_notify(ov, OF_OVERLAY_POST_APPLY); > >> > + > >> > mutex_unlock(&of_mutex); > >> > >> This means that any post-apply handlers can't make any calls that take > >> the mutex. Maybe that is fine? On the flip side, maybe we want to > >> prevent any changes while the notifiers are called. > >> > >> The other calls could have similar issues. We should make sure we are > >> consistent. > >> > > > > Currently it's consistent - all 4 notifiers hold the mutex, > > so all 4 prevent dt changes. That's not super bad, but it's > > different from the reconfig notifiers and I could see some > > possible usefulness in allowing changes. > > > > I don't see any harm in unlocking for pre-apply, post-apply, > > or post-remove. But for pre-remove, unlocking would allow > > notifier code to make changes to the overlay's changeset > > that is about to be removed. Is that something we need to > > be super worried about preventing? > > > > For pre-apply, unlocking would allow changes to either the > > live tree or the overlay. That's ok since the next thing > > that will happen after the notifier is that the changeset > > will be built from the overlay, so any changes made to the > > overlay would make it into the changeset before it is > > applied. Post-apply and post-remove are also ok to > > be unlocked. > > > > So if the pre-remove case is ok, I could release the mutex > > for all 4 cases in v3. > > The only one I can see it being useful to make changes would be > pre-apply. The complication there is you would have to move the mutex. > I don't think the mutex really needs to be held until before > of_overlay_apply, but I'm not completely sure. For now, I think just > leave things as they are now. > > Rob > OK Alan