From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753865AbcCWHUT (ORCPT ); Wed, 23 Mar 2016 03:20:19 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:32655 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752174AbcCWHUS (ORCPT ); Wed, 23 Mar 2016 03:20:18 -0400 X-IronPort-AV: E=Sophos;i="5.24,381,1454972400"; d="scan'208";a="209634851" Date: Wed, 23 Mar 2016 08:20:14 +0100 (CET) From: Julia Lawall X-X-Sender: jll@localhost6.localdomain6 To: Daniel Rosenberg cc: kbuild-all@01.org, Daniel Campello , linux-kernel@vger.kernel.org Subject: [PATCH] sdcardfs: fix itnull.cocci warnings Message-ID: User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Remove NULL tests, as the index variable of list_for_each_entry cannot be NULL. Signed-off-by: Fengguang Wu Signed-off-by: Julia Lawall --- The code seems to have a lot of unnecessary braces as well. tree: https://android.googlesource.com/kernel/common android-4.4 head: f06e869f936e548fd3fd78ddcbebe171f0defadb commit: 1e2d3bbcf3f5a603e62dfa0514a43e13ee679d4f [4/6] sdcardfs: Bring up to date with Android M permissions: packagelist.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/fs/sdcardfs/packagelist.c +++ b/fs/sdcardfs/packagelist.c @@ -160,7 +160,7 @@ static int insert_str_to_int(struct pack mutex_unlock(&pkgl_dat->hashtable_lock); list_for_each_entry(sbinfo, &sdcardfs_super_list, list) { - if (sbinfo) { + { fixup_perms(sbinfo->sb); } } @@ -189,7 +189,7 @@ static void remove_str_to_int(struct pac } mutex_unlock(&pkgl_dat->hashtable_lock); list_for_each_entry(sbinfo, &sdcardfs_super_list, list) { - if (sbinfo) { + { fixup_perms(sbinfo->sb); } }